March 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] dmusic: Enumerate ports for midi out and midi in devices in EnumPort.

by Christian Costa

2012/3/29 Andrew Eikum <aeikum(a)codeweavers.com> > On Thu, Mar 29, 2012 at 08:52:45AM +0200, Christian Costa wrote: > > + midiOutGetDevCapsW(index - 1, &caps, sizeof(caps)); > > ... > > + CoCreateInstance(&CLSID_DirectMusicSynth, NULL, > CLSCTX_INPROC_SERVER, &IID_IDirectMusicSynth8, (void**)&synth); > > + IDirectMusicSynth8_GetPortCaps(synth, port_caps); > > Maybe I'm pickier than most people, but I like error checking on these > sorts of calls. They make it easier to find what is happening when > something goes terribly and unexpectedly wrong. > It's the original code. I decided to keep it in this patch and add error checking in the patch that comes just after. I can merge them but I prefer to do things incrementally as much as possible.

March 29, 2012

Re: [PATCH 3/3] dmsynth: Put port caps that match native ones.

by Andrew Eikum

Just to be clear, which "native" do you mean? Does this match Windows 7's dmusic behavior, or something else? I've been trying to target Windows 7's behavior in the new audio design. Also... On Thu, Mar 29, 2012 at 08:53:52AM +0200, Christian Costa wrote: > - obj->pCaps.dwEffectFlags = DMUS_EFFECT_REVERB | DMUS_EFFECT_CHORUS | DMUS_EFFECT_DELAY; > + obj->pCaps.dwEffectFlags = DMUS_EFFECT_REVERB; /* DMUS_EFFECT_CHORUS | DMUS_EFFECT_DELAY */ I'd just remove the unused flags. No need for crufty comments.

March 29, 2012

Re: [PATCH 2/5] dmusic: Enumerate ports for midi out and midi in devices in EnumPort.

by Andrew Eikum

On Thu, Mar 29, 2012 at 08:52:45AM +0200, Christian Costa wrote: > + midiOutGetDevCapsW(index - 1, &caps, sizeof(caps)); > ... > + CoCreateInstance(&CLSID_DirectMusicSynth, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectMusicSynth8, (void**)&synth); > + IDirectMusicSynth8_GetPortCaps(synth, port_caps); Maybe I'm pickier than most people, but I like error checking on these sorts of calls. They make it easier to find what is happening when something goes terribly and unexpectedly wrong.

March 29, 2012

Re: [PATCH 5/5] dmusic: Implement partially SetDirectSound.

by Andrew Eikum

It would be nice to see some tests for this. For example, how does this IDirectSound reference relate to the one created by IDirectMusicPerformance::InitAudio()? On Thu, Mar 29, 2012 at 08:53:10AM +0200, Christian Costa wrote: > > --- > dlls/dmusic/dmusic.c | 27 +++++++++++++++++++++------ > dlls/dmusic/dmusic_private.h | 2 ++ > 2 files changed, 23 insertions(+), 6 deletions(-) > > diff --git a/dlls/dmusic/dmusic.c b/dlls/dmusic/dmusic.c > index 8f2edea..60d6b8a 100644 > --- a/dlls/dmusic/dmusic.c > +++ b/dlls/dmusic/dmusic.c > @@ -52,19 +52,22 @@ static ULONG WINAPI IDirectMusic8Impl_AddRef (LPDIRECTMUSIC8 iface) { > return refCount; > } > > -static ULONG WINAPI IDirectMusic8Impl_Release (LPDIRECTMUSIC8 iface) { > +static ULONG WINAPI IDirectMusic8Impl_Release(LPDIRECTMUSIC8 iface) > +{ > IDirectMusic8Impl *This = (IDirectMusic8Impl *)iface; > ULONG refCount = InterlockedDecrement(&This->ref); > > TRACE("(%p)->(ref before=%u)\n", This, refCount + 1); > > if (!refCount) { > + if (This->dsound) > + IDirectSound_Release(This->dsound); > HeapFree(GetProcessHeap(), 0, This->ppPorts); > HeapFree(GetProcessHeap(), 0, This); > } > > DMUSIC_UnlockModule(); > - > + > return refCount; > } > > @@ -257,10 +260,22 @@ static HRESULT WINAPI IDirectMusic8Impl_GetDefaultPort (LPDIRECTMUSIC8 iface, LP > return S_OK; > } > > -static HRESULT WINAPI IDirectMusic8Impl_SetDirectSound (LPDIRECTMUSIC8 iface, LPDIRECTSOUND pDirectSound, HWND hWnd) { > - IDirectMusic8Impl *This = (IDirectMusic8Impl *)iface; > - FIXME("(%p, %p, %p): stub\n", This, pDirectSound, hWnd); > - return S_OK; > +static HRESULT WINAPI IDirectMusic8Impl_SetDirectSound(LPDIRECTMUSIC8 iface, LPDIRECTSOUND dsound, HWND wnd) > +{ > + IDirectMusic8Impl *This = (IDirectMusic8Impl *)iface; > + > + FIXME("(%p, %p, %p): partial implementation\n", This, dsound, wnd); > + > + if (dsound) > + { > + This->dsound = dsound; > + IDirectSound_AddRef(dsound); > + } > + > + /* If no direct sound object is given, native does not create one yet */ > + This->dsound_inited = TRUE; > + > + return S_OK; > } > > static HRESULT WINAPI IDirectMusic8Impl_SetExternalMasterClock (LPDIRECTMUSIC8 iface, IReferenceClock* pClock) { > diff --git a/dlls/dmusic/dmusic_private.h b/dlls/dmusic/dmusic_private.h > index c05adf0..b0655d6 100644 > --- a/dlls/dmusic/dmusic_private.h > +++ b/dlls/dmusic/dmusic_private.h > @@ -96,6 +96,8 @@ struct IDirectMusic8Impl { > IReferenceClockImpl* pMasterClock; > IDirectMusicPort** ppPorts; > int nrofports; > + BOOL dsound_inited; > + IDirectSound* dsound; > }; > > /***************************************************************************** > > >

March 29, 2012

Re: po: Update German translation

by Julian Rüger

Hi André, Am Mittwoch, den 28.03.2012, 20:37 +0200 schrieb André Hentschel: > Thx missed that, next time it's all up to you. Giving the translation stuff completely in your hands now. :) OK, umm, thanks I guess ;) I might still bug you for approval though. Best, Julian PS: That mail was supposed to be private, since I used German, but it was late and I screwed up :)

March 29, 2012

Re: [PATCH 1/2] vbscript: Added Mid function implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17548 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

March 29, 2012

Re: [PATCH 1/2] vbscript: Added Mid function implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17548 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

March 29, 2012

Re: SoC 2012 Ideas

by Alex Bradbury

On 29 March 2012 10:01, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > BTW, I once defined a set of iptable rules to prevent networking for Wine (or was it for a whole user?) > based on the consideration that the apps I use have nothing to do with networking. > Here too, nothing need be changed in Wine. You can also add a 'nonet' group, configure an iptables rule to drop all packets from that gid and then use sg to execute wine using that nonet group. Of course this assumes the apps you run don't or can't switch from nonet to another group. Alex

March 29, 2012

SoC 2012 Ideas

by Joerg-Cyril.Hoehle＠t-systems.com

Charles Davis wrote: >1) Make Wine use App Sandbox on Mac OS X. >At the very least, I would like to be able to limit Wine's file-system activity to the prefix. I'm not familiar with Mac OS X' particular security features, but I wonder why limiting FS activity needs changes in wine? With AppArmor or the like on Linux, you'd define a set of rules living outside of the app. Limiting to the prefix won't work, because /dev/tty and /tmp/X11.socket etc. need be used. All my apps are installed in a directory outside any .wine prefix. There's a symlink from within C:\Programs. How would you take that into account? BTW, I once defined a set of iptable rules to prevent networking for Wine (or was it for a whole user?) based on the consideration that the apps I use have nothing to do with networking. Here too, nothing need be changed in Wine. Regards, Jörg Höhle

March 29, 2012

Re: RFC: KUSER_SHARED_DATA update patch to fix bug 29168

by Johan Gill

On Thu, Mar 22, 2012 at 5:19 AM, Joey Yandle <dragon(a)dancingdragon.be>wrote: > > > > It's been explained several times already that any approach to share data > > between wineserver and clients is going to be rejected. > > > > Can you point me to such an explanation? I joined wine-devel just > before posting my RFC. If this has been discussed previously, I'd > prefer to get the context before wasting my and others' time. > > I know they declined an in-process wineserver due to difficulties blaming the right component on a crash: is it the app or wine that's faulty? I found no other relevant discussion on wine-devel since January 2010, when searching for first 'share' and then 'server'. Too bad if a fork is needed, couldn't the sharing be configurable?

March 29, 2012