April 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] wined3d: Enable "AlwaysOffscreen" by default.

by Alexandre Julliard

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > --- > dlls/wined3d/wined3d_main.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) It doesn't work here (GeForce 8500, driver 295.20): ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so visual.c && touch visual.ok visual.c:1385: Tests skipped: D3DFMT_P8 textures not supported visual.c:2011: Test failed: Expected color 0x000000ff at 80,60, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x000000ff at 240,60, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x0000ff00 at 400,60, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x000000ff at 80,180, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x000000ff at 240,180, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x0000ff00 at 400,180, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x0000ff00 at 80,300, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x0000ff00 at 240,300, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x0000ff00 at 400,300, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 80,60, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 240,60, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 400,60, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 560,60, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 80,180, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 240,180, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 400,180, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 560,180, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 80,300, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 240,300, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 400,300, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 560,300, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 80,420, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 240,420, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 400,420, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 560,420, got 0x00ff0000. visual.c:2824: Tests skipped: No RESZ support, skipping RESZ test. make: *** [visual.ok] Error 25 -- Alexandre Julliard julliard(a)winehq.org

April 5, 2012

Re: (try 2)quartz: add control.idl as a typelib resource

by Huw Davies

On Thu, Apr 05, 2012 at 07:51:13AM -0500, Aric Stewart wrote: > > revised based on comments from Jacek Caban > --- > dlls/quartz/Makefile.in | 1 + > dlls/quartz/control_v2.idl | 17 +++++++++++++++++ > 2 files changed, 18 insertions(+), 0 deletions(-) > create mode 100644 dlls/quartz/control_v2.idl Calling this control_v2.idl seems a little odd. control_tlb.idl may be better. Huw.

April 5, 2012

Re: gdi32: Constification.

by Henri Verbeet

On 5 April 2012 14:37, Kusanagi Kouichi <slash(a)ac.auone-net.jp> wrote: > FT_Face is a typedef for struct FT_FaceRec_*, so it would be worth > adding const. > Except that "const FT_Face" doesn't do what you think it does.

April 5, 2012

Re: gdi32: Constification.

by Kusanagi Kouichi

On 2012-04-04 17:35:58 +0200, Alexandre Julliard wrote: > Kusanagi Kouichi <slash(a)ac.auone-net.jp> writes: > > > @@ -6407,7 +6409,7 @@ static BOOL get_text_metrics(GdiFont *font, LPTEXTMETRICW ptm) > > return TRUE; > > } > > > > -static BOOL face_has_symbol_charmap(FT_Face ft_face) > > +static BOOL face_has_symbol_charmap(const FT_Face ft_face) > > { > > int i; > > > > @@ -6729,7 +6731,7 @@ end: > > static DWORD freetype_GetGlyphOutline( PHYSDEV dev, UINT glyph, UINT format, > > LPGLYPHMETRICS lpgm, DWORD buflen, LPVOID buf, const MAT2 *lpmat ) > > { > > - struct freetype_physdev *physdev = get_freetype_dev( dev ); > > + const struct freetype_physdev * const physdev = get_freetype_dev( dev ); > > DWORD ret; > > > > if (!physdev->font) > > You are overdoing it. There's no reason to change per-value parameters > or local variables like the physdev. FT_Face is a typedef for struct FT_FaceRec_*, so it would be worth adding const.

April 5, 2012

Re: [PATCH 1/1] ntdll: Fix section header heap deadlock (try 2).

by Alexandre Julliard

"Erich E. Hoover" <ehoover(a)mines.edu> writes: > Description: > Free the section header memory outside of the uninterrupted > section lock. Changing the order here stops the process heap from > potentially deadlocking (Bug #30356). The allocation will still be an issue. I think a better approach would be to avoid any memory allocation in there. -- Alexandre Julliard julliard(a)winehq.org

April 5, 2012

Re: [PATCH 3/3] wininet/tests: Added checks for bad return values and stop tests when it happens.

by Alexandre Julliard

Morten Rønne <morten.roenne(a)tdcadsl.dk> writes: > @@ -29,6 +29,8 @@ > > #include "wine/test.h" > > +#define bail_out { ok(0, "Bailing out\n"); return; } Please avoid that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

April 5, 2012

[GSoC] Control panel proposal

by Magdalena Nowak

Hi, my name is Magdalena Nowak and I'd like to apply for this year's Summer of Code with Wine. My proposal is to merge the two control panel suggestions (Tools - Merge winecfg and control panel and Tools - Implement new control panel applets) into one project. I would start off with splitting winecfg into several applets. Roughly, each tab would become a new applet. The Applications applet would only be used to register applications with the control panel to allow the user to specify custom settings for that application. I would like to merge the Graphics tab with the Appearance section of Desktop Integration (and this applet would be the place where the 3D settings would go later) and merge the Folders section with the Drives tab into one applet. Later on, I will start implementing new applets. For example, create a Networking applet for the network-related settings, maybe a simple diagnostics tool (a read-only applet with information regarding build options and system resources), Fonts (both list of fonts available to Wine as well as hinting and DPI settings), a System applet for settings like owner name, Windows version, libraries etc. There is a problem with per-application settings. I have three possible solutions to this problem. I have made pictures to illustrate what I mean. One would be to simply add a drop-down list to each applet that contains settings that can be per-application settings. The drop-down list would contain a "global" entry, as well as entries for each application registered through the Applications applet. Upon selecting an entry, the applet would load the settings for this program. The second solution would be to have a separate applet for per-application settings. The screens would be stored in a DLL, for example, as to avoid duplication. The third, and my favourite, solution, is to create a virtual control panel for each registered application. The user would be able to select the application or global settings from some kind of list, and the applets would be passed an argument to indicate the selected application. If a specific setting was global-only, it would be highlighted appropriately. Here are the promised images: http://imgur.com/T4pUV - Showing the drop-down menu at the top of the applet window. http://imgur.com/vA1Vq - Showing the per-application settings applet. http://imgur.com/is63I - Showing the control panel with an application selected, and a Graphics applet showing a global-only setting. Of course these are only examples, I welcome any comments. I will post a proposal on Melange soon. Yours, 'Lena.

April 5, 2012

Re: Web based translation tool

by Michal Čihař

Hi Dne Thu, 5 Apr 2012 11:20:12 +0300 Yaron Shahrabani <sh.yaron(a)gmail.com> napsal(a): > On Wed, Apr 4, 2012 at 5:05 PM, Michal Čihař <michal(a)cihar.com> wrote: > > To help you with deciding, I've set up test installation with Wine > > sources. For now I've only imported master branch: > > > > http://wine.weblate.org/projects/wine/master/ > Hi Michal! > This is so wonderful! I'm glad you did that! > I can't register, can you please check why? Err, sorry. I somehow messed up email setup after testing out registration. Should be fixed now. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

April 5, 2012

Re: quartz: add control.idl as a typelib resource

by Jacek Caban

Hi Aric, On 04/04/12 20:38, Aric Stewart wrote: > --- a/dlls/quartz/Makefile.in > +++ b/dlls/quartz/Makefile.in > @@ -32,6 +32,7 @@ RC_SRCS = version.rc > IDL_H_SRCS = fil_data.idl > IDL_P_SRCS = quartz_strmif.idl > IDL_R_SRCS = quartz_strmif.idl > +IDL_TLB_SRCS = ../../include/control.idl This is not the right way. A simple IDL file in DLL directory that does nothing but #include will do the trick. See dlls/stdole2 for example. Jacek

April 5, 2012

Re: Web based translation tool

by Yaron Shahrabani

On Wed, Apr 4, 2012 at 5:05 PM, Michal Čihař <michal(a)cihar.com> wrote: > To help you with deciding, I've set up test installation with Wine > sources. For now I've only imported master branch: > > http://wine.weblate.org/projects/wine/master/ Hi Michal! This is so wonderful! I'm glad you did that! I can't register, can you please check why? Kind regards, Yaron Shahrabani.

April 5, 2012