April 2012 - Wine-Devel - list.winehq.org

My GSoC proposition: Raw Input

by Eryk Wieliczko

I've been thinking about joining GSoC as a student this year. As an idea I propose Raw Input, and I seek your advise. Is this topic good, what are possible catches, etc. I think that it might be possible to finally do a decent implementation, that would (besides mouse and keyboard) also support joysticks and possibly some other input devices - tablets and multiple mice and keyboards. What do you think about this topic? Links: http://msdn.microsoft.com/en-us/library/windows/desktop/ms645536(v=vs.85).a… http://appdb.winehq.org/viewbugs.php?bug_id=20395 http://bugs.winehq.org/show_bug.cgi?id=20395

April 4, 2012

Re: user32/tests: Add DlgDirList tests

by Alexandre Julliard

Bruno Jesus <00cpxxx(a)gmail.com> writes: > Based on original patch from Christian Lupien from bug 8226. > > Tests required to later fix http://bugs.winehq.org/show_bug.cgi?id=8226 This should be added to the existing DlgDirList tests, making sure that these things are not already being tested. -- Alexandre Julliard julliard(a)winehq.org

April 4, 2012

Re: [2/2] advapi32: Do not terminate a regular program if it calls StartServiceCtrlDispatcher.

by Alexandre Julliard

Alexander Morozov <amorozov(a)etersoft.ru> writes: > This patch partially fixes #30290. > > Pipe is renamed to spipe (service pipe) to prevent compilation error: > service.c:88:15: error: ‘pipe’ redeclared as different kind of symbol > /usr/include/unistd.h:414:12: note: previous declaration of ‘pipe’ was > here You shouldn't need to add global variables, just pass the handle to the thread. -- Alexandre Julliard julliard(a)winehq.org

April 4, 2012

Re: msi: fixed MsiGetFileHashW for empty files (try 2)

by Alexandre Julliard

Robert van Herk <mijnspamboxje(a)hotmail.com> writes: > @@ -493,6 +493,45 @@ static void test_MsiGetFileHash(void) > } > } > > +static void test_MsiGetFileHashForEmptyFile(void) { > + char path[MAX_PATH]; > + MSIFILEHASHINFO hi; > + char file[MAX_PATH]; > + UINT res; > + > + /* Create empty temp file */ > + GetTempPath( > + MAX_PATH, > + path > + ); You should add that to the existing MsiGetFileHash tests, there's no need for a separate function. -- Alexandre Julliard julliard(a)winehq.org

April 4, 2012

Re: [PATCH 2/2] ntdll: Fix section header heap deadlock.

by Alexandre Julliard

"Erich E. Hoover" <ehoover(a)mines.edu> writes: > Real Name: > Erich Hoover > > Description: > Using the process heap for the section headers can cause a > deadlock (Bug #30356), this patch uses the virtual heap instead. I don't think we want to use the virtual heap for that sort of thing, it should be used only for memory views. -- Alexandre Julliard julliard(a)winehq.org

April 4, 2012

Re: [PATCH 2/3] wininet: Don't delete locked entry in DeleteUrlCacheEntry

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/wininet/urlcache.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so urlcache.c && touch urlcache.ok urlcache.c:557: Test succeeded inside todo block: Expected failure urlcache.c:559: Test succeeded inside todo block: Expected ERROR_SHARING_VIOLATION, got 32 urlcache.c:568: Test succeeded inside todo block: UnlockUrlCacheEntryFileA failed: 0 urlcache.c:581: Test failed: Expected failure urlcache.c:582: Test failed: expected ERROR_FILE_NOT_FOUND, got 0 make: *** [urlcache.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

April 4, 2012

Re: gdi32: Constification.

by Alexandre Julliard

Kusanagi Kouichi <slash(a)ac.auone-net.jp> writes: > @@ -6407,7 +6409,7 @@ static BOOL get_text_metrics(GdiFont *font, LPTEXTMETRICW ptm) > return TRUE; > } > > -static BOOL face_has_symbol_charmap(FT_Face ft_face) > +static BOOL face_has_symbol_charmap(const FT_Face ft_face) > { > int i; > > @@ -6729,7 +6731,7 @@ end: > static DWORD freetype_GetGlyphOutline( PHYSDEV dev, UINT glyph, UINT format, > LPGLYPHMETRICS lpgm, DWORD buflen, LPVOID buf, const MAT2 *lpmat ) > { > - struct freetype_physdev *physdev = get_freetype_dev( dev ); > + const struct freetype_physdev * const physdev = get_freetype_dev( dev ); > DWORD ret; > > if (!physdev->font) You are overdoing it. There's no reason to change per-value parameters or local variables like the physdev. -- Alexandre Julliard julliard(a)winehq.org

April 4, 2012

Re: Web based translation tool

by Michal Čihař

Hi Dne Thu, 15 Mar 2012 10:12:14 -0500 Aric Stewart <aric(a)codeweavers.com> napsal(a): > I do not know if Weblate will work or not. > > Basically we have 3 big requirements that have been sticking points for > various solutions. > > 1) Real Names and e-mails for all contributors > > 2) Individual attribution for all translations. So we know exactly who > changed what string. > > 3) Generate incremental diffs/patches/change sets divided based on > translator. > > Generally it is #2 that has been the hardest for projects to cope with. I think Weblate now does all you request here. The software still has some rough edges, but I want to polish them on way to 1.0 release in upcoming weeks. To help you with deciding, I've set up test installation with Wine sources. For now I've only imported master branch: http://wine.weblate.org/projects/wine/master/ Changes in Git repository are exported as: git://git.weblate.org/wine-master.git Please note that due to enabled lazy commits, the repository will not get changes made in web interface until it is needed or explicitly requested. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

April 4, 2012

Re: Tools under the <>tools/winapi directory

by GOUJON Alexandre

On 04/03/2012 07:34 PM, Roger Cruz wrote: > How are the tools under the winapi directory used? I've tried running > them but they all complain about the same error. > ~/sandbox/wine/sources/wine-1.3.36/dlls/kernel32$ > ~/sandbox/wine/sources/wine-1.3.36/tools/winapi/winapi_extract > winapi_extract: You must run this tool in the main Wine directory or a > sub directory The error is rather explicit. I tried alex(a)leon:~/Projects/wine/winegit$ ./tools/winapi/winapi_extract --help and it worked for me

April 3, 2012

Tools under the <>tools/winapi directory

by Roger Cruz

How are the tools under the winapi directory used? I've tried running them but they all complain about the same error. ~/sandbox/wine/sources/wine-1.3.36/dlls/kernel32$ ~/sandbox/wine/sources/wine-1.3.36/tools/winapi/winapi_extract winapi_extract: You must run this tool in the main Wine directory or a sub directory

April 3, 2012