April 2012 - Wine-Devel - list.winehq.org

Re: jscript: Emit undefined statement return for switch without default clausule

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17636 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

April 2, 2012

Re: jscript: Emit undefined statement return for switch without default clausule

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17636 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

April 2, 2012

Re: wined3d: Added PCI device IDs for AMD Radeon 6750M & 6770M

by Henri Verbeet

On 2 April 2012 01:15, Gaurav Jain <gaurav(a)gauravjain.org> wrote: > Sounds good, so then are you okay with the patch with only the 6770M, since that has a different device ID? > The first step should really be getting the description string right. After that you should verify that that PCI ID is really unique for the 6770M, as opposed to having e.g. 4 or 5 different IDs that are used by all the 6600M/6700M cards. > Fair enough, the comment in the code states that wine estimates the *minimum* video memory. Is there any issues with wine reporting more? If so, then there are cases where certain models within a series may have less memory than others. Thus wine could improve it's guess by having a different entry for each card (if necessary). That way the guess would never over-estimate the memory (assuming that's an issue). > The comment is probably wrong, it's generally better to err on the side of reporting too much memory than too little. > Are there any problem with wine using the value from here instead of hard coding the video memory? Can bogus values show up? Can wine use GL_ATI_meminfo as well? The issue with GL_NVX_gpu_memory_info is that because it's experimental it can change (and if you look at the spec revision history, it has), so we can't really rely on it to do anything at all. The problem with ATI_meminfo is that it doesn't allow you to query the total amount of video memory. There's an undocumented hack to do this anyway, but since that's not in the spec we can't use it either.

April 2, 2012

Re: [PATCH 1/4] d3drm: Implement IDirect3DRMFrameX_AddChild.

by Jacek Caban

Hi Christian, On 04/02/12 08:54, Christian Costa wrote: > { > IDirect3DRMFrameImpl *This = impl_from_IDirect3DRMFrame2(iface); > + LPDIRECT3DRMFRAME3 frame; > > - FIXME("(%p/%p)->(%p): stub\n", iface, This, child); > + TRACE("(%p/%p)->(%p)\n", iface, This, child); > > - return E_NOTIMPL; > + if (!child) > + return D3DRMERR_BADOBJECT; > + > + frame = &impl_from_IDirect3DRMFrame2((LPDIRECT3DRMFRAME2)child)->IDirect3DRMFrame3_iface; This should be avoided. See unsafe_impl_from_* at http://wiki.winehq.org/COMGuideline for an example. Jacek

April 2, 2012

Re: [PATCH 1/4] dmime: COM cleanup for IDirectMusicPerformance8.

by Michael Stefaniuc

Hello Christian, On 04/02/2012 09:05 AM, Christian Costa wrote: > While you're at it, could you put a 4 spaces indentation to whole method. I thought about that but that would make the patch huge and it is already big. The re-indentation can be done when the functions get implemented. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Consulting Communications Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Werner-von-Siemens-Ring 14, 85630 Grasbrunn Handelsregister: Amtsgericht Muenchen HRB 153243 Geschäftsführer: Mark Hegarty, Charlie Peters, Michael Cunningham, Charles Cachera

April 2, 2012

Re: [PATCH 4/4] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17632 Your paranoid android. === WNT4WSSP6 (32 bit d3drm) === d3drm.c:467: Test failed: Invalid refcount. Expected 3 got 2 d3drm.c:475: Test failed: Invalid refcount. Expected 4 got 3 d3drm.c:477: Test failed: Invalid refcount. Expected 3 got 2

April 2, 2012

Re: [PATCH 1/4] dmime: COM cleanup for IDirectMusicPerformance8.

by Christian Costa

Le 02/04/2012 00:03, Michael Stefaniuc a écrit : > --- > > -static HRESULT WINAPI IDirectMusicPerformance8Impl_MusicToReferenceTime (LPDIRECTMUSICPERFORMANCE8 iface, MUSIC_TIME mtTime, REFERENCE_TIME* prtTime) { > - IDirectMusicPerformance8Impl *This = (IDirectMusicPerformance8Impl *)iface; > +static HRESULT WINAPI IDirectMusicPerformance8Impl_MusicToReferenceTime(IDirectMusicPerformance8 *iface, > + MUSIC_TIME mtTime, REFERENCE_TIME *prtTime) > +{ > + IDirectMusicPerformance8Impl *This = impl_from_IDirectMusicPerformance8(iface); > + > FIXME("(%p, %d, %p): stub\n", This, mtTime, prtTime); > return S_OK; > } > > -static HRESULT WINAPI IDirectMusicPerformance8Impl_ReferenceToMusicTime (LPDIRECTMUSICPERFORMANCE8 iface, REFERENCE_TIME rtTime, MUSIC_TIME* pmtTime) { > - IDirectMusicPerformance8Impl *This = (IDirectMusicPerformance8Impl *)iface; > +static HRESULT WINAPI IDirectMusicPerformance8Impl_ReferenceToMusicTime(IDirectMusicPerformance8 *iface, > + REFERENCE_TIME rtTime, MUSIC_TIME *pmtTime) > +{ > + IDirectMusicPerformance8Impl *This = impl_from_IDirectMusicPerformance8(iface); > + > FIXME("(%p, 0x%s, %p): stub\n", This, wine_dbgstr_longlong(rtTime), pmtTime); > return S_OK; > } > > -static HRESULT WINAPI IDirectMusicPerformance8Impl_IsPlaying (LPDIRECTMUSICPERFORMANCE8 iface, IDirectMusicSegment* pSegment, IDirectMusicSegmentState* pSegState) { > - IDirectMusicPerformance8Impl *This = (IDirectMusicPerformance8Impl *)iface; > +static HRESULT WINAPI IDirectMusicPerformance8Impl_IsPlaying(IDirectMusicPerformance8 *iface, > + IDirectMusicSegment *pSegment, IDirectMusicSegmentState *pSegState) > +{ > + IDirectMusicPerformance8Impl *This = impl_from_IDirectMusicPerformance8(iface); > + > FIXME("(%p, %p, %p): stub\n", This, pSegment, pSegState); > return S_FALSE; > } > > Hi Michael, While you're at it, could you put a 4 spaces indentation to whole method. Christian

April 2, 2012

Re: [PATCH] wined3d: When releasing resources, don't perform any other operations on device if it has been released.

by Christian Costa

Le 01/04/2012 01:49, Henri Verbeet a écrit : > My first guess would be to check if vertex buffers are perhaps > supposed to take a reference to the D3D interface. > Ok. I will write a test to check that.

April 2, 2012

Re: gdi32: Refuse to load a large .fot file earlier.

by Kristoffer Eklund

Stop e-mail me! 2 apr 2012 kl. 07.40 skrev Dmitry Timoshkov: > --- > dlls/gdi32/font.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c > index 230d421..f5c44d8 100644 > --- a/dlls/gdi32/font.c > +++ b/dlls/gdi32/font.c > @@ -3454,10 +3454,15 @@ static void *map_file( const WCHAR *filename, LARGE_INTEGER *size ) > file = CreateFileW( filename, GENERIC_READ, 0, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL ); > if (file == INVALID_HANDLE_VALUE) return NULL; > > - GetFileSizeEx( file, size ); > + if (!GetFileSizeEx( file, size ) || size->u.HighPart) > + { > + CloseHandle( file ); > + return NULL; > + } > + > mapping = CreateFileMappingW( file, NULL, PAGE_READONLY, 0, 0, NULL ); > CloseHandle( file ); > - if (mapping == NULL) return NULL; > + if (!mapping) return NULL; > > ptr = MapViewOfFile( mapping, FILE_MAP_READ, 0, 0, 0 ); > CloseHandle( mapping ); > @@ -3478,7 +3483,6 @@ static WCHAR *get_scalable_filename( const WCHAR *res ) > > if (!ptr) return NULL; > > - if (size.u.HighPart) goto fail; > if (size.u.LowPart < sizeof( *dos )) goto fail; > dos = (const IMAGE_DOS_HEADER *)ptr; > if (dos->e_magic != IMAGE_DOS_SIGNATURE) goto fail; > -- > 1.7.9.4 > > >

April 2, 2012

Re: wined3d: Added PCI device IDs for AMD Radeon 6750M & 6770M

by Gaurav Jain

On 2012-04-01, at 6:06 PM, Henri Verbeet wrote: > Ideally applications wouldn't care at all about this and use the caps instead, though in practice applications might use the PCI IDs for workarounds for driver bugs or for capability detection. Sounds good, so then are you okay with the patch with only the 6770M, since that has a different device ID? > The video memory is even more of a guess than everything else, in particular because you can have the same model with different amounts of video memory. Fair enough, the comment in the code states that wine estimates the *minimum* video memory. Is there any issues with wine reporting more? If so, then there are cases where certain models within a series may have less memory than others. Thus wine could improve it's guess by having a different entry for each card (if necessary). That way the guess would never over-estimate the memory (assuming that's an issue). > The GL_NVX_gpu_memory_info extension would be very useful for this if it wasn't experimental. Are there any problem with wine using the value from here instead of hard coding the video memory? Can bogus values show up? Can wine use GL_ATI_meminfo as well?

April 1, 2012