May 2012 - Wine-Devel - list.winehq.org

stub for SetThreadStackGuarantee

by Daniel Jelinski

Hello, SQL Server Management Studio 2005 needs SetThreadStackGuarantee to either be absent or return TRUE - otherwise it refuses to run at all. Is there a reason for this stub to return FALSE? Regards, Daniel

May 29, 2012

Re: [PATCH 2/3] jscript: Get rid of ret_nan hack

by Ruslan Kabatsayev

Hello, This patch (committed as d0a719a79dae001df341db907fcae54118691d35) leads to compilation error: make[1]: Entering directory `/fastdocs/programmer/wine-git/dlls/msadp32.acm' make[1]: Nothing to be done for `all'. make[1]: Leaving directory `/fastdocs/programmer/wine-git/dlls/msadp32.acm' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -I/opt/Xorg-7.5/include -L/opt/Xorg-7.5/lib -o string.o string.c lex.c: In function ‘cc_token’: lex.c:936:71: error: ‘NAN’ undeclared (first use in this function) lex.c:936:71: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [lex.o] Error 1 I've tried doing git clean -xdf, but this still doesn't compile. Regards, Ruslan On Tue, May 29, 2012 at 2:53 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/jscript/date.c | 28 ++++++++++++++-------------- > dlls/jscript/error.c | 3 ++- > dlls/jscript/global.c | 2 +- > dlls/jscript/jscript.h | 7 ------- > dlls/jscript/jsutils.c | 6 +++--- > dlls/jscript/lex.c | 2 +- > 6 files changed, 21 insertions(+), 27 deletions(-) > > > > >

May 29, 2012

ru.po: improved an Russian translation

by Oleg Yarigin

There are some improvements of a style (now it is more official) and non-translated empty lines. To avoid an character encoding interruption, I send the diff file as a packed text file attachment (ru_diff.txt.bz2, 22.3 KB).

May 29, 2012

Re: kernel32/volume: Don't modify the last error in GetVolumeInformation

by Alexandre Goujon

On Tue, May 29, 2012 at 7:07 PM, Alexandre Julliard <julliard(a)winehq.org>wrote: > Alexandre Goujon <ale.goujon(a)gmail.com> writes: > > > @@ -729,6 +731,8 @@ BOOL WINAPI GetVolumeInformationW( LPCWSTR root, > LPWSTR label, DWORD label_len, > > } > > else > > { > > + /* At this point, last error is ERROR_NOT_SUPPORTED. > Restoring the previous one */ > > + SetLastError(lastError); > > You should never need to do that sort of thing, there are no guarantees > about last error on success. > > -- > Alexandre Julliard > julliard(a)winehq.org > I know but The Sims 3 calls GetLastError very often (in the top 10), nearly between each call, maybe to check if a specific error does (or doesn't) occur. It troubled me when I investigated a bug and I thought the cost was so low that we could do it anyway. But I know you are right, so just forget about it. PS: FYI I tested it on WIndows and the last error is not changed (but it doesn't matter as you said)

May 29, 2012

Re: kernel32/volume: Don't modify the last error in GetVolumeInformation

by Alexandre Julliard

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -729,6 +731,8 @@ BOOL WINAPI GetVolumeInformationW( LPCWSTR root, LPWSTR label, DWORD label_len, > } > else > { > + /* At this point, last error is ERROR_NOT_SUPPORTED. Restoring the previous one */ > + SetLastError(lastError); You should never need to do that sort of thing, there are no guarantees about last error on success. -- Alexandre Julliard julliard(a)winehq.org

May 29, 2012

Re: Implementing joystick ids in DirectInput

by Lucas Zawacki

Ok, I sent patches doing this for linux and linuxinput drivers and a test. The joystick_osx.c version of this could be done but I dont have the means to test so if anyone wants to do it, you're welcome.

May 29, 2012

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream. (try 2)

by Vincent Povirk

>> + offset.QuadPart = 0; >> + size.u.LowPart = 0xffffffff; >> + size.u.HighPart = 0xffffffff; >> + return IWICStream_InitializeFromIStreamRegion(iface, pIStream, offset, size); > > What prevents you from discovering correct stream size? The size passed to InitializeFromIStreamRegion is an upper limit. If the underlying stream is smaller, the appropriate size will still be reported from Read, Stat, and Seek.

May 29, 2012

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream. (try 2)

by Józef Kucia

On Tue, May 29, 2012 at 12:29 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Józef Kucia <joseph.kucia(a)gmail.com> wrote: >> A stream can grow its memory. For example, IStream returned by >> CreateStreamOnHGlobal do this. > > I don't think you need to worry about that unless you have a test case > or an app that depends on this. That's what native does. See the attached unit tests.

May 29, 2012

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream. (try 2)

by Dmitry Timoshkov

Józef Kucia <joseph.kucia(a)gmail.com> wrote: > > What prevents you from discovering correct stream size? > > A stream can grow its memory. For example, IStream returned by > CreateStreamOnHGlobal do this. I don't think you need to worry about that unless you have a test case or an app that depends on this. -- Dmitry.

May 29, 2012

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream. (try 2)

by Józef Kucia

On Tue, May 29, 2012 at 12:07 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > What prevents you from discovering correct stream size? A stream can grow its memory. For example, IStream returned by CreateStreamOnHGlobal do this.

May 29, 2012