May 2012 - Wine-Devel - list.winehq.org

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream. (try 2)

by Dmitry Timoshkov

Józef Kucia <joseph.kucia(a)gmail.com> wrote: > + offset.QuadPart = 0; > + size.u.LowPart = 0xffffffff; > + size.u.HighPart = 0xffffffff; > + return IWICStream_InitializeFromIStreamRegion(iface, pIStream, offset, size); What prevents you from discovering correct stream size? -- Dmitry.

May 29, 2012

Re: [PATCH 1/3] ntdll: Implement RtlGetProductInfo and use it for GetProductInfo

by Alexandre Julliard

Detlef Riekenberg <wine.dev(a)web.de> writes: > The wrapper in kernel32 is not needed. > RtlGetProductInfo and GetProductInfo have the same signature and > tests show the same results. No they don't have the same signature, look closer. -- Alexandre Julliard julliard(a)winehq.org

May 29, 2012

Re: Implementing joystick ids in DirectInput

by Vitaliy Margolen

On 05/28/2012 12:53 PM, Lucas Zawacki wrote: > The solution I came up is in the attached patch, it's a little weird It's not just weird it's incorrect. You shouldn't use that list or rely on order of devices in that list. Instead you should use get_joystick_index() to get the index. It's not exactly clear where this ID is used so I doubt returning the same ID for different drivers will change anything Vitaliy.

May 29, 2012

Re: [1/3] user32/tests: Comment-out PostQuitMessage (causes tests skip)

by Alexey Slepov

I figured out now. As described in wine sources, PostQuitMessage() sets a flag in the thread's message queue that signals it to generate a WM_QUIT message when there are no other pending sent or posted messages in the queue. The tests with skipped testcases are those which use WM_TIMER messages - test_timer_message() and my test. In DIALOG_DoDialogBox() there is clearly defined that on receiving WM_QUIT message the window is destroyed. So timer messages just do not reach queue. I thought about solution again and now I think that it would be better to remove at all lines about WM_DESTROY handling, such as we don't handle this message. And let it be handled by default. That code does nothing except posting WM_QUIT messages leading to test skipping. (test passed on WineBot) What do you think? 28.05.2012, 10:32, "Dmitry Timoshkov" <dmitry(a)baikal.ru>: > sir-lexa <sir-lexa(a)yandex.ru> wrote: > >> case WM_DESTROY: >> - PostQuitMessage(0); >> + /* PostQuitMessage(0); It lets some tests to be skipped */ >> return TRUE; > > This is not acceptable, there is much more behind the scene. You need > to figure out the real reason of skipping the tests. > > -- > Dmitry.

May 28, 2012

Implementing joystick ids in DirectInput

by Lucas Zawacki

Hey guys, asking for a little code review here... I was looking at the solution for this bug http://bugs.winehq.org/show_bug.cgi?id=30705 and it comes down to implementing the DIPROP_JOYSTICKSID property for joystick devices. After some research on what this is I know it's always a number between (0,n), where n is the number of joysticks connected, and is analogous to the winmm driver joystick id. The solution I came up is in the attached patch, it's a little weird but I found it hard to give a unique ID to each joystick on Linux when they can come from different drivers. This solution uses the order which dinput puts the joysticks on it's device list and will work regardless. If someone has a better way to do it I'd like to know. Cheers,

May 28, 2012

Re: 1.4 has dropped off the list for AppDB submissions

by André Hentschel

Am 28.05.2012 15:26, schrieb Rosanne DiMesio: > As of the release of 1.5.5, 1.4 has dropped off the list of Wine versions for which AppDB test reports can be submitted. > > Can someone please add it to the list of stable releases that are always available in the dropdown list? Until it's put back, users will not be able to submit new test reports for 1.4. > > We could avoid having this problem every time there's a new stable release if users were allowed to submit test reports for any version. Bugzilla lists every version, I don't see why the AppDB doesn't. > I already sent a patch in March for this: http://www.winehq.org/pipermail/wine-patches/2012-March/112149.html -- Best Regards, André Hentschel

May 28, 2012

1.4 has dropped off the list for AppDB submissions

by Rosanne DiMesio

As of the release of 1.5.5, 1.4 has dropped off the list of Wine versions for which AppDB test reports can be submitted. Can someone please add it to the list of stable releases that are always available in the dropdown list? Until it's put back, users will not be able to submit new test reports for 1.4. We could avoid having this problem every time there's a new stable release if users were allowed to submit test reports for any version. Bugzilla lists every version, I don't see why the AppDB doesn't. -- Rosanne DiMesio <dimesio(a)earthlink.net>

May 28, 2012

Re: [2/5] d3dx9: Implement D3DXSaveSurfaceToFileInMemory.

by Vincent Povirk

> - hr = IWICImagingFactory_CreateStream(factory, &stream); > + hr = IWICImagingFactory_CreateStream(factory, &wic_stream); > IWICImagingFactory_Release(factory); > if (FAILED(hr)) goto cleanup_err; > > - hr = IWICStream_InitializeFromFilename(stream, dst_filename, GENERIC_WRITE); > + hr = CreateStreamOnHGlobal(NULL, TRUE, &stream); > if (FAILED(hr)) goto cleanup_err; > > + hr = IWICStream_InitializeFromIStream(wic_stream, stream); Why bother creating an IWICStream here? Just use your HGLOBAL stream to initialize the encoder.

May 28, 2012

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream.

by Vincent Povirk

> +static HRESULT WINAPI StreamOnStream_Seek(IStream *iface, > + LARGE_INTEGER dlibMove, DWORD dwOrigin, ULARGE_INTEGER *plibNewPosition) > +{ > + StreamOnStream *This = StreamOnStream_from_IStream(iface); > + HRESULT hr=S_OK; > + TRACE("(%p)\n", This); > + > + EnterCriticalSection(&This->lock); > + hr = IStream_Seek(This->stream, dlibMove, dwOrigin, plibNewPosition); > + LeaveCriticalSection(&This->lock); > + > + return hr; > +} The IWICStream needs to have an independent position from the underlying stream. Also, why not just forward to InitializeFromIStreamRegion?

May 28, 2012

Re: [1/3] user32/tests: Comment-out PostQuitMessage (causes tests skip)

by Dmitry Timoshkov

sir-lexa <sir-lexa(a)yandex.ru> wrote: > case WM_DESTROY: > - PostQuitMessage(0); > + /* PostQuitMessage(0); It lets some tests to be skipped */ > return TRUE; This is not acceptable, there is much more behind the scene. You need to figure out the real reason of skipping the tests. -- Dmitry.

May 28, 2012