June 2012 - Wine-Devel - list.winehq.org

Re: d3dx9_36 [patch 1 of 4, try 2]: Implemetation of D3DXSHScale

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19428 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

June 22, 2012

Re: wintrust/tests: Fix build with MSVC.

by David Laight

On Thu, Jun 21, 2012 at 12:56:43PM +0200, Thomas Faber wrote: > On 2012-06-21 12:34, Dmitry Timoshkov wrote: > > > Thomas Faber <thfabba(a)gmx.de> wrote: > > > >> FIELD_OFFSET isn't constant "enough". > > > > The problem is not with FIELD_OFFSET, but with applying shift and mask > > operations to a constant. > > > You're right, it's actually a combination of multiple factors. I'm not sure > what exactly its problem is - the gist is, FIELD_OFFSET cannot reliably be > assumed constant. > > E.g. the following code only complains about c4: > > struct a { > char a; > int b[5]; > int c; > }; > int c1 = (int)&(((struct a *)0)->a) << 8; > int c2 = (int)&(((struct a *)0)->b[0]); > int c3 = (int)&(((struct a *)0)->b[0]) + 1; > int c4 = (int)&(((struct a *)0)->b[0]) << 8; This is a bug in the microsoft C compiler. It won't let you do multiply or divide offsetof(struct, array_member[index]) by anything and still get a compile-time constant. The C language requires offsetof() be a compile-time constant, so this ought to be allowed. I couldn't find anything that looked like 'offsetof' that would generate a real compile-time constant. I can't remember whether it is 'constant enough' to let you do: static char fubar[offsetof(struct a, b[3])]; David -- David Laight: david(a)l8s.co.uk

June 21, 2012

re: [PATCH 2/5] ddraw: Use wined3d_get_adapter_display_mode() in CreateSurface().

by Dan Kegel

Henri wrote: - hr = wined3d_device_get_display_mode(ddraw->wined3d_device, 0, &mode); - if (FAILED(hr)) + if (FAILED(hr = wined3d_get_adapter_display_mode(ddraw->wined3d, WINED3DADAPTER_DEFAULT, &mode))) Seems like a step back in readability to combine setting and testing hr. - Dan

June 21, 2012

Re: Wine automated testing update

by André Hentschel

Am 21.06.2012 16:21, schrieb Francois Gouget: > On Wed, 1 Feb 2012, Jeremy White wrote: > [...] >> However, Alexandre has persuaded me that we should first explore >> integrating the dotest.sh functionality into the existing WineTestBot, >> as that would allow us to have a very simple clean web page, and would >> also allow us to integrate most cleanly with Alexandre's back end tools. >> >> Of course, WineTestBot is Perl code, and my Perl fu is low. So I have >> recently asked Francois to help with that effort as well. >> >> So the basic plan is as follows: > [...] >> 2. If so, modify WineTestBot to use qemu instead of vmware. >> (This is 'easy' because the WineTestBot code nicely isolates >> the VM functions, but 'hard', because VMWare provides some >> APIs that may have to be replicated). > > So I have finally found the time to get started on this. Yay! > It's not done yet but I figure it's time for me to give a status report > and ask some questions. > ... > --- Patches > > My code is far from ready for commits but I stumbled upon a few fixes. > Where should I send those? > I'd suggest to move the code at some point over to source.winehq.org with Francois as committer, so everybody can work on it in the normal ways. Testbot became a must-have very quickly and needs improvements now, so having at in a central place just makes sense. -- Best Regards, André Hentschel

June 21, 2012

Re: Examples of AJ silently improving patches?

by Stefan Dösinger

Hi, Here's another one where AJ implemented a suggestion I sent 3 days later: http://source.winehq.org/git/wine.git/commitdiff/5523820b810d16fd17da86fcf7… http://www.winehq.org/pipermail/wine-patches/2012-June/115180.html Am Mittwoch, 20. Juni 2012, 17:52:31 schrieb Daniel Lehman: > Another example: > http://www.winehq.org/pipermail/wine-patches/2012-January/110398.html > http://source.winehq.org/git/wine.git/commit/b1f04e23bf361e06d239e03693c904a > 597b9a32d > > I had added a redundant null check in both A and W paths. he simplified it > by making just the W path handle the null

June 21, 2012

Re: [PATCH 1/7] ntdll: Add support for junction point creation.

by Hans Leidekker

On Thu, 2012-06-21 at 09:57 -0600, Erich E. Hoover wrote: > On Thu, Jun 21, 2012 at 4:28 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > > ... > > > > This is not an atomic operation since you need two Unix calls. So you would > > need locking or rollback to deal with possible races. > > It is my understanding that directories only support advisory locks, > are you aware of a way to lock a directory? No, I don't see a way to fix this other than adding a new primitive to the kernel.

June 21, 2012

Re: [PATCH 1/7] ntdll: Add support for junction point creation.

by Erich E. Hoover

On Thu, Jun 21, 2012 at 4:28 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > ... > > This is not an atomic operation since you need two Unix calls. So you would > need locking or rollback to deal with possible races. It is my understanding that directories only support advisory locks, are you aware of a way to lock a directory? Erich

June 21, 2012

Re: Wine automated testing update

by Michael Stefaniuc

Francois, On 06/21/2012 04:21 PM, Francois Gouget wrote: > --- Network trouble > > I'm having trouble getting the network to work fine in the QEmu VMs. > > Eventually I discovered that if I bridged to eth0 then it's just the > communication between the host and the VM that does not work. > Communication with other machines on the LAN or with the Internet works. > However that's going to be a big problem to send the jobs to the VMs > (see previous section, plus the dhcp and dns is also running on the host > in my case). > > Now, rather than bridge to eth0 what I'd want on my machine is to bridge > to tap0, a local network where I have all my VMware VMs. can you please send me the network details of the host? Normally you don't bridge to eth0 but create a bridge interface and eth0 is a member of that bridge aka eth0 won't have an IP associated with it as the host IP would be on virtbr0. > What I typically see if I ping the host from the VM is that the echo > requests go out and the echo replies are sent. But ping on the VM sees > nothing. It could be a firewalling issue though my VMware VMs on the > same network work fine. bye michael

June 21, 2012

[1/5] windowscodecs: Implement PixelFormatInfo_GetBitsPerPixel.

by Vincent Povirk

June 21, 2012

Re: Wine automated testing update

by Julius Schwartzenberg

Francois Gouget wrote: > All replacements involve installing some application in the Windows VM. > So given that we want to run Winetest too I have the following > requirements: > * The application should run on everything from Windows 8 down to NT4. > * It should not bring in dependencies that would modify the behavior of > Windows. So anything that depends on installing .Net or upgrading > standard dlls located in c:\windows\system32 is out. > * Ideally it should also have a 64bit version so we can have > 64bit-only Windows VMs. > So I looked for a replacement but came away not entirely satisfied: Maybe freeSSHd and/or freeFTPd are useful: http://www.freesshd.com/ At least the webpage claims it runs on Windows NT4 and higher. Logging in over SSH just gives a cmd.com command shell as far as I remember, so this should allow for some interaction with the system running on the VM. Best regards, Julius

June 21, 2012