June 2012 - Wine-Devel - list.winehq.org

Re: Incompatibility in Kernel32

by Dmitry Timoshkov

"robert.van.herk(a)serioustoys.com" <robert.van.herk(a)serioustoys.com> wrote: > I feel hesitation towards starting to hack in kernel32 myself. Though this > bug seems to be blocking me to implement msi.dll completely compatible with > the MS implementation... You shouldn't look how native msi.dll behaves internally. > Shall I file a bug report? Try to add a test case to dlls/kenel32/tests/file.c,test_file_sharing(). > HANDLE h2 = CreateFileA(filename, GENERIC_READ, FILE_SHARE_DELETE | FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); > assert (h2 != 0); > > if (!DeleteFile(filename)) { > r = GetLastError(); > fprintf(stderr, "This only happens in Wine. I got error: %d\n", r); > assert(0); > } Is there any reason that you call DeleteFile() on a still being opened file? -- Dmitry.

June 21, 2012

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 3.

by Dmitry Timoshkov

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/windowscodecs/tiffformat.c | 75 +++++++++++++++++++++++++++++++++++++---- > 1 file changed, 69 insertions(+), 6 deletions(-) Just a note, that once this patch is committed plus today's IFD metadata reader improvements the infrastructure for metadata handling in TIFF files should be all done. WICExplorer is able to recognize and show complete metadata listings for every frame in a multiframe TIFF file (native riched20 is needed for nicer visualization). -- Dmitry.

June 21, 2012

RE: Examples of AJ silently improving patches?

by Daniel Lehman

Another example: http://www.winehq.org/pipermail/wine-patches/2012-January/110398.html http://source.winehq.org/git/wine.git/commit/b1f04e23bf361e06d239e03693c904… I had added a redundant null check in both A and W paths. he simplified it by making just the W path handle the null

June 21, 2012

Re: Examples of AJ silently improving patches?

by Alex Henrie

Here is an example: http://www.winehq.org/pipermail/wine-patches/2011-December/109805.html http://www.winehq.org/pipermail/wine-devel/2011-December/093517.html http://source.winehq.org/git/wine.git/commitdiff/6e5bba1b60f97fce34415ea30e… -Alex

June 21, 2012

Examples of AJ silently improving patches?

by Dan Kegel

AJ sometimes kindly fixes problems in patches while committing them (I guess it's easier than rejecting the patch for small issues). I wonder if these silent improvements would be worth collecting as a sort of style-guide-by-example. Anyone remember any good examples? I've started a list at http://wiki.winehq.org/StyleExamples

June 20, 2012

Re: [PATCH] winspool/tests: Fix failures, when the spooler service is not running

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19360 Your paranoid android. === WINEBUILD (build) === Can't determine base name

June 20, 2012

Incompatibility in Kernel32

by robert.van.herk＠serioustoys.com

Hi group, As I was trying write a fix for msi.dll, I stumbled upon an incompatibility in the kernel. If you open an existing file, FILE_SHARE_DELETE doesn't seem to work in Wine. In Windows, it does. Attached is a minimal test case. I feel hesitation towards starting to hack in kernel32 myself. Though this bug seems to be blocking me to implement msi.dll completely compatible with the MS implementation... Shall I file a bug report? Regards, Robert

June 20, 2012

Re: gdiplus: Implement GdipImageSelectActiveFrame. Take 2.

by Vincent Povirk

Looks good to me.

June 20, 2012

RE: msi:RECORD_StreamFromFile bug, help needed

by Hans Leidekker

On Wed, 2012-06-20 at 12:13 +0200, robert.van.herk(a)serioustoys.com wrote: > IStream is not exposed to the user, but an internal interface would > probably end up looking a lot like IStream because we need read/write/seek > operations, reference counting and the ability to create clones. So we > might as well use IStream. > > Hmmm... Then I want exactly the same as SHCreateStreamOnFileEx, but the > only difference is that the file should be opened with FILE_SHARE_DELETE. > (I think). You will also need IStream_Clone, which shlwapi doesn't implement. > What is that policy on this? It seems overkill to copy istream.c from > shlwapi, just because I want to change 1 flag. On the other hand, I don't > want to expose more functions in the shlwapi header, as that would make > it different from the Windows implementation... You can look at istream.c for inspiration, but please avoid copying it verbatim with its 2-space indentation and CamelCaseNotation. Try following the coding style of surrounding code in msi. You can probably also simplify the code a bit. E.g. you can leave out parameter validation and code/structure fields that will not be used by msi.

June 20, 2012

Re: mmcndmgr: Implement IMMCVersionInfo (try 5)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19325 Your paranoid android. === WNT4WSSP6 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000 === W2KPROSP4 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000

June 20, 2012