June 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines. (try 2)

by Akihiro Sagawa

On Tue, 19 Jun 2012 23:40:33 +0900, Dmitry Timoshkov wrote: > Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > > > Please ignore these patches. They were sent over 48 hours ago. It seems > > there is a huge delay between Gmail and wine-patches. > > If you are not subscribed to wine-patches the e-mails you send get stuck > in the moderation queue. Hi Dmitry, Thank you for your advice. I'm not subscribed to wine-patches up to now, so it must be the reason of the delay. I'll subscribe to the list. Akihiro Sagawa

June 19, 2012

Re: [website] Portuguese translation for release 1.4.1

by Lucas Zawacki

Disregard this patch. I added the wrong file to the commit and will resend. On Tue, Jun 19, 2012 at 12:01 PM, Jeremy Newman <jnewman(a)codeweavers.com> wrote: > This is just english. Did you mean for that to happen? > > No need to send the english, as if the xml does not exist, the site will > always fall back to the english version already. > > -N > > > On 06/19/2012 09:49 AM, Lucas Zawacki wrote: >> >> From: Lucas Zawacki<lfzawacki(a)gmail.com> >> >> --- >> news/pt/2012061501.xml | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> create mode 100644 news/pt/2012061501.xml >> >> diff --git a/news/pt/2012061501.xml b/news/pt/2012061501.xml >> new file mode 100644 >> index 0000000..7c0ff9f >> --- /dev/null >> +++ b/news/pt/2012061501.xml >> @@ -0,0 +1,13 @@ >> +<news> >> +<date>June 15, 2012</date> >> +<title>Wine 1.4.1 Released</title> >> +<body> >> + The Wine maintenance release 1.4.1 is now available. >> + <a href="{$root}/announce/1.4.1">What's new</a> in this release: >> +<ul> >> +<li>Translation updates.</li> >> +<li>Various bug fixes.</li> >> +</ul> >> +The source is<a >> href="http://prdownloads.sourceforge.net/wine/wine-1.4.1.tar.bz2">available >> now</a>. >> +Binary packages are in the process of being built, and will appear soon >> at their respective<a href="{$root}/download">download locations</a>. >> +</body></news>

June 19, 2012

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines. (try 2)

by Dmitry Timoshkov

Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > Please ignore these patches. They were sent over 48 hours ago. It seems > there is a huge delay between Gmail and wine-patches. If you are not subscribed to wine-patches the e-mails you send get stuck in the moderation queue. -- Dmitry.

June 19, 2012

Re: [5/5] gdiplus: Implement GdipImageSelectActiveFrame.

by Dmitry Timoshkov

Vincent Povirk <madewokherd(a)gmail.com> wrote: > > + if (stat == Ok) > > + { > > + memcpy(&new_image->format, &codec->info.FormatID, sizeof(GUID)); > > + free_image_data(image); > > + if (image->type == ImageTypeBitmap) > > + *(GpBitmap *)image = *(GpBitmap *)new_image; > > + else if (image->type == ImageTypeMetafile) > > + *(GpMetafile *)image = *(GpMetafile *)new_image; > > + return Ok; > > + } > > You appear to be leaking new_image. Thanks. I hope that won't prevent accepting other patches in the series. -- Dmitry.

June 19, 2012

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines. (try 2)

by Akihiro Sagawa

On Tue, 19 Jun 2012 03:39:18 -0300, Bruno Jesus wrote: > Hi, judging by the subjects I'd say the patches were commited already, > you're trying to send them again or are they different patches? > > http://source.winehq.org/git/wine.git/commitdiff/afdc84cf0366c8e161004bf1e7… > http://source.winehq.org/git/wine.git/commitdiff/2bb416baa88c28f57bb0f65aa9… > http://source.winehq.org/git/wine.git/commitdiff/f503afd86ff9df9467eb1351cf… Hi Bruno, Please ignore these patches. They were sent over 48 hours ago. It seems there is a huge delay between Gmail and wine-patches. Actually, one of my original patches are missed `static' keyword as Dmitry spotted(*). Therefore, I added the keyword and sent series of patches again. But, during transfer (>48 hours), the original patch was updated by Alexandre, then committed. After a while, my modified version was delivered and tested although they have already been applied. * ... http://www.winehq.org/pipermail/wine-devel/2012-June/095956.html Akihiro Sagawa

June 19, 2012

Re: [5/5] gdiplus: Implement GdipImageSelectActiveFrame.

by Vincent Povirk

>> Yes, but a non-bitmap (metafile) cannot have multiple frames. > > It actually can have records which represent embedded EMFs. Really? Well, OK then. > + if (stat == Ok) > + { > + memcpy(&new_image->format, &codec->info.FormatID, sizeof(GUID)); > + free_image_data(image); > + if (image->type == ImageTypeBitmap) > + *(GpBitmap *)image = *(GpBitmap *)new_image; > + else if (image->type == ImageTypeMetafile) > + *(GpMetafile *)image = *(GpMetafile *)new_image; > + return Ok; > + } You appear to be leaking new_image.

June 19, 2012

Re: [5/5] gdiplus: Implement GdipImageSelectActiveFrame.

by Dmitry Timoshkov

Vincent Povirk <madewokherd(a)gmail.com> wrote: > >> Why did you re-implement move_bitmap() ? > > > > An image can be not a bitmap. > > Yes, but a non-bitmap (metafile) cannot have multiple frames. It actually can have records which represent embedded EMFs. -- Dmitry.

June 19, 2012

Re: [5/5] gdiplus: Implement GdipImageSelectActiveFrame.

by Vincent Povirk

>> > + if (stat == Ok) >> > + { >> > + memcpy(&new_image->format, &codec->info.FormatID, sizeof(GUID)); >> > + free_image_data(image); >> > + if (image->type == ImageTypeBitmap) >> > + *(GpBitmap *)image = *(GpBitmap *)new_image; >> > + else if (image->type == ImageTypeMetafile) >> > + *(GpMetafile *)image = *(GpMetafile *)new_image; >> > + return Ok; >> > + } >> >> Why did you re-implement move_bitmap() ? > > An image can be not a bitmap. Yes, but a non-bitmap (metafile) cannot have multiple frames.

June 19, 2012

Re: [5/5] gdiplus: Implement GdipImageSelectActiveFrame.

by Dmitry Timoshkov

Vincent Povirk <madewokherd(a)gmail.com> wrote: > > + hr = IStream_Clone(image->stream, &stream); > > + if (FAILED(hr)) > > That's odd. When does that happen? IStream returned by SHCreateStreamOnFile (wrapped by GdipCreateStreamOnFile) intentionally doesn't implement Clone, there are even tests for that in shlwapi. > > + if (stat == Ok) > > + { > > + memcpy(&new_image->format, &codec->info.FormatID, sizeof(GUID)); > > + free_image_data(image); > > + if (image->type == ImageTypeBitmap) > > + *(GpBitmap *)image = *(GpBitmap *)new_image; > > + else if (image->type == ImageTypeMetafile) > > + *(GpMetafile *)image = *(GpMetafile *)new_image; > > + return Ok; > > + } > > Why did you re-implement move_bitmap() ? An image can be not a bitmap. -- Dmitry.

June 19, 2012

Re: [5/5] gdiplus: Implement GdipImageSelectActiveFrame.

by Vincent Povirk

> + hr = IStream_Clone(image->stream, &stream); > + if (FAILED(hr)) That's odd. When does that happen? > + if (stat == Ok) > + { > + memcpy(&new_image->format, &codec->info.FormatID, sizeof(GUID)); > + free_image_data(image); > + if (image->type == ImageTypeBitmap) > + *(GpBitmap *)image = *(GpBitmap *)new_image; > + else if (image->type == ImageTypeMetafile) > + *(GpMetafile *)image = *(GpMetafile *)new_image; > + return Ok; > + } Why did you re-implement move_bitmap() ?

June 19, 2012