June 2012 - Wine-Devel - list.winehq.org

Re: atl80: prefer native, if present

by Alexandre Julliard

Daniel Jelinski <djelinski1(a)gmail.com> writes: > From 7243b3594c9c0b13770ede1ab32d4dd1329b1dd4 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Sun, 17 Jun 2012 17:37:15 +0200 > Subject: atl80: prefer native, if present > > --- > dlls/atl80/atl80.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) There's no reason to do that, most of the dll is already implemented. -- Alexandre Julliard julliard(a)winehq.org

June 18, 2012

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)

by Alexandre Julliard

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -113,7 +113,16 @@ typedef struct DVD_READ_STRUCTURE { > > /* From 0 to 4 */ > UCHAR LayerNumber; > -}DVD_READ_STRUCTURE, * PDVD_READ_STRUCTURE; > +} DVD_READ_STRUCTURE, *PDVD_READ_STRUCTURE; > + > +typedef struct _DVD_DESCRIPTOR_HEADER { > + USHORT Length; > + UCHAR Reserved[2]; > +#if !defined(_midl) > + UCHAR Data[0]; > +#endif > +} DVD_DESCRIPTOR_HEADER, *PDVD_DESCRIPTOR_HEADER; > +C_ASSERT(sizeof(DVD_DESCRIPTOR_HEADER) == 4); Zero-size arrays are not portable and should be avoided. -- Alexandre Julliard julliard(a)winehq.org

June 18, 2012

Re: [6/6] wbemprox: Add tests for IWbemServices.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19208 Your paranoid android. === WNT4WSSP6 (32 bit services) === services.c:38: Test failed: failed to create IWbemLocator interface 80040154 services: unhandled exception c0000005 at 004019EE

June 18, 2012

Re: [2/2] comdlg32/tests: Test file name selection on init

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19196 Your paranoid android. === WNT4WSSP6 (32 bit filedlg) === Timeout === W2KPROSP4 (32 bit filedlg) === Timeout === WXPPROSP3 (32 bit filedlg) === filedlg: unhandled exception c0000005 at 7C809E32 === W2K3R2SESP2 (32 bit filedlg) === filedlg: unhandled exception c0000005 at 77E63110 === WVISTAADM (32 bit filedlg) === filedlg: unhandled exception c0000005 at 76A75031 === W2K8SE (32 bit filedlg) === filedlg: unhandled exception c0000005 at 76285DBE === W7PRO (32 bit filedlg) === filedlg.c:1158: Test failed: The EM_GETSEL message returned with no selection

June 17, 2012

Re: [PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test

by Nikolay Sivov

On 6/17/2012 13:11, Alexandre Goujon wrote: > > case DvdManufacturerDescriptor: > + nt_desc.manf->Header.Length = 0x0802; > + nt_desc.manf->Header.Reserved[0] = 0; > + nt_desc.manf->Header.Reserved[1] = 0; Does this length mean something? Looks a bit dirty to leave hardcoded things like that, but maybe I don't know details.

June 17, 2012

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)

by Nikolay Sivov

On 6/17/2012 13:11, Alexandre Goujon wrote: > Superseeds the patch of the same name (#87003) > Definition and assert taken from Windows Driver Kit (WDK) 8 Consumer Preview > --- > include/ddk/ntddcdvd.h | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/include/ddk/ntddcdvd.h b/include/ddk/ntddcdvd.h > index 5313496..d0178c7 100644 > --- a/include/ddk/ntddcdvd.h > +++ b/include/ddk/ntddcdvd.h > @@ -113,7 +113,16 @@ typedef struct DVD_READ_STRUCTURE { > > /* From 0 to 4 */ > UCHAR LayerNumber; > -}DVD_READ_STRUCTURE, * PDVD_READ_STRUCTURE; > +} DVD_READ_STRUCTURE, *PDVD_READ_STRUCTURE; > + > +typedef struct _DVD_DESCRIPTOR_HEADER { > + USHORT Length; > + UCHAR Reserved[2]; > +#if !defined(_midl) > + UCHAR Data[0]; > +#endif > +} DVD_DESCRIPTOR_HEADER, *PDVD_DESCRIPTOR_HEADER; > +C_ASSERT(sizeof(DVD_DESCRIPTOR_HEADER) == 4); This looks wrong, correct name for it __midl, and this also needs a check for __WIDL__ probably.

June 17, 2012

Re: [PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test

by GOUJON Alexandre

On 06/17/2012 01:19 PM, Nikolay Sivov wrote: > On 6/17/2012 13:11, Alexandre Goujon wrote: >> case DvdManufacturerDescriptor: >> + nt_desc.manf->Header.Length = 0x0802; >> + nt_desc.manf->Header.Reserved[0] = 0; >> + nt_desc.manf->Header.Reserved[1] = 0; > Does this length mean something? Looks a bit dirty to leave hardcoded > things like that, but maybe I don't know details. This was hard-coded for the physical descriptor. I tested it with the (few) DVD's I have at home. But that's what tests are for : let (more) people check the behaviour with more hardware/software/CDs/DVDs (than the developer has) Anyway, thanks for the review (especially a Sunday)

June 17, 2012

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)

by GOUJON Alexandre

On 06/17/2012 01:16 PM, Nikolay Sivov wrote: > This looks wrong, correct name for it __midl, and this also needs a > check for __WIDL__ probably. This is exactly what's present in the header file but if you want, I can resubmit with #if !(defined __midl || defined __WIDL__)

June 17, 2012

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines.

by Dmitry Timoshkov

Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > - static const struct test_data > + const int font[] = > { > - int id, weight, height, dpi; > + ANSI_FIXED_FONT, ANSI_VAR_FONT, SYSTEM_FONT, DEVICE_DEFAULT_FONT, DEFAULT_GUI_FONT > + /* SYSTEM_FIXED_FONT, OEM_FIXED_FONT */ > + }; > + const struct test_data > + { Please add back 'static' to test_data and add it to font. -- Dmitry.

June 17, 2012

Re: [PATCH] winepulse.drv: Add PulseAudio driver

by Maarten Lankhorst

What happened to the stamped capture buffers? Why is held_frames added? This doesn't look like an attempt to get my driver in, it looks like a rewrite by someone who doesn't understand why I made the design decisions I made for correctness. If you don't paste all the mmdevapi tests with the fix in my git tree, it's a regression. I don't want to see held_Frames because it's a shadow buffer. If winmm and dsound don't work without it, they're wrong, fix those. The logic I kept for timestamping audio buffers was removed which just makes timestamping less accurate on capture buffers. Was this driver even tested on low latency? There was a reason I kept track of all packets in a linked list, no need to do held_frames logic. I genuinely do want a good driver to go in, but this just isn't it. There is also no reason to have an INCREASED period size for exclusive compared to shared. I'm currently not handling exclusive because there are no good tests for it. and "hooray_cb" ? If this is going to be accepted (likely, sadly) I want to have this added to the commit: Rejected-by: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> ~Maarten PS: Still sad that you chose to reject my original driver not based on any merits.

June 16, 2012