June 2012 - Wine-Devel - list.winehq.org

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver

by Andrew Eikum

On Thu, Jun 14, 2012 at 02:46:37PM -0500, Rosanne DiMesio wrote: > A forum user reported this behavior with the Ubuntu 12.04 wine1.5 packages, which are apparently only available with the winepulse patch. > > http://forum.winehq.org/viewtopic.php?t=15747 > Thanks. I was able to reproduce it on a Debian 6 VM, as well. Now I just need to find a better way to check if PA is running. Andrew

June 15, 2012

Re: [PATCH 1/4] DSS Test Suite: CryptAcquireContext tests for base DSS

by Alexandre Julliard

Marek Chmiel <kcmark(a)gmail.com> writes: > From 748332765355ae099ab24cf1402bed86610984e7 Mon Sep 17 00:00:00 2001 > From: Marek Chmiel <kcmark(a)gmail.com> > Date: Fri, 1 Jun 2012 22:38:03 -0500 > Subject: [PATCH 1/4] Add CryptAcquireContext tests for base DSS CSP. > > --- > configure | 1 + > configure.ac | 1 + > dlls/dssenh/tests/Makefile.in | 7 +++ > dlls/dssenh/tests/dssenh.c | 119 +++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 128 insertions(+) > create mode 100644 dlls/dssenh/tests/Makefile.in > create mode 100644 dlls/dssenh/tests/dssenh.c You are adding 4 almost identical copies of that code. Try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

June 15, 2012

Re: [PATCH 2/2 resend] advapi32: Pass service name as argv[0] to ServiceMain

by Jacek Caban

On 06/15/12 16:17, Alexandre Julliard wrote: > Jacek Caban <jacek(a)codeweavers.com> writes: > >> Resend with tests. >> >> --- >> dlls/advapi32/service.c | 3 +-- >> programs/services/tests/service.c | 4 ++++ >> 2 files changed, 5 insertions(+), 2 deletions(-) > You will now get the name twice for autostart services. > I missed it, sorry about that. I will send a fixed version. Thanks, Jacek

June 15, 2012

Re: [PATCH 2/2 resend] advapi32: Pass service name as argv[0] to ServiceMain

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > Resend with tests. > > --- > dlls/advapi32/service.c | 3 +-- > programs/services/tests/service.c | 4 ++++ > 2 files changed, 5 insertions(+), 2 deletions(-) You will now get the name twice for autostart services. -- Alexandre Julliard julliard(a)winehq.org

June 15, 2012

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).

by Alexandre Julliard

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > + while(min <= max) > + { > + const char *encoded_symbol; > + > + pos = (min+max)/2; > + encoded_symbol = html_encoded_symbols[pos].html_code; > + dir = strncmp(encoded_symbol, amp, len); You need to check the length, strncmp is not enough. -- Alexandre Julliard julliard(a)winehq.org

June 15, 2012

Re: mmcndmgr: Implement IMMCVersionInfo (try 3)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19090 Your paranoid android. === WNT4WSSP6 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000 === W2KPROSP4 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000

June 15, 2012

Re: MSVCP60.dll

by Michael Stefaniuc

Hello John! On 06/15/2012 06:22 AM, John Emmas wrote: > Firstly, I'm not a Linux user. I'm a Windows programmer but I have a > passing knowledge of Linux (and several friends who are Linux > programmers). I write a Windows application which gets launched as a > child process by a popular Linux DAW. My program was first written many > years ago when the (then) current version of Wine was about v0.9.58. > Over a hundred people are using my program with old versions of Wine and > I've had no complaints so far. > > Recently however, two customers tried to use it with Wine v1.5.35. In > both cases the program crashed - apparently because some particular > function wasn't found in MSVCP60.dll (at the moment, we don't know which > function). Both customers went to a web site called WineTricks from That is fairly trivial to figure out. Start your app with Wine on the command line and it will crash with an exception: Call from <address> to unimplemented function MSVCP60.<function> Once you have those please open a bug on http://bugs.winehq.org/ for them. > where they were able to install an alternative version of MSVCP60.dll. > My app now gets past the place where it previously crashed although it > now crashes further on... :-( > > It looks as if the MSVC6 runtime module(s) that now come with Wine > aren't the same as the ones from v0.9.58. Either they're different MSVCP60.dll wasn't available in wine-0.9.58. It was introduced in wine-1.3.19. They were probably using the dll that came with your app or installed it from somewhere else. > versions of the Microsoft DLLs or maybe they're now being implemented by > somebody else, perhaps as part of Wine development? Either way, they > don't work with my particular app any more. Please open a bug for those issues too. > I still have Visual C++6 installed on an old computer, together with > both the source code and the (InstallShield) packager for my original > app. So is there anything I can do to make this work? For example, do Open the bug reports :) If there is a free downloadable version/demo that exhibits the same issues please add it to the "URL" field. bye michael

June 15, 2012

Re: [PATCH] sfnt2fnt: Fix broken .fon files on !x86 architectures

by Alexandre Julliard

Hilko Bengen <bengen(a)hilluzination.de> writes: > * Alexandre Julliard: > >> endian.h is not portable, you should use the endianness defines from >> the Wine headers instead. > > So, do I need to define my own htobe16 and htobe32 functions or macros > based on whether WORDS_BIGENDIAN is defined or not? Yes. -- Alexandre Julliard julliard(a)winehq.org

June 15, 2012

MSVCP60.dll

by John Emmas

Firstly, I'm not a Linux user. I'm a Windows programmer but I have a passing knowledge of Linux (and several friends who are Linux programmers). I write a Windows application which gets launched as a child process by a popular Linux DAW. My program was first written many years ago when the (then) current version of Wine was about v0.9.58. Over a hundred people are using my program with old versions of Wine and I've had no complaints so far. Recently however, two customers tried to use it with Wine v1.5.35. In both cases the program crashed - apparently because some particular function wasn't found in MSVCP60.dll (at the moment, we don't know which function). Both customers went to a web site called WineTricks from where they were able to install an alternative version of MSVCP60.dll. My app now gets past the place where it previously crashed although it now crashes further on... :-( It looks as if the MSVC6 runtime module(s) that now come with Wine aren't the same as the ones from v0.9.58. Either they're different versions of the Microsoft DLLs or maybe they're now being implemented by somebody else, perhaps as part of Wine development? Either way, they don't work with my particular app any more. I still have Visual C++6 installed on an old computer, together with both the source code and the (InstallShield) packager for my original app. So is there anything I can do to make this work? For example, do I need to link against a particular version of the MSVC6 runtime? Or do I need to configure my packager so that it specifically distributes the runtime modules that my app linked to? I never did that in the past - because whichever runtime came with Wine seemed to work. Any advice? John

June 15, 2012

Re: ru.po: improved an Russian translation

by Oleg Yarigin

Hi, Julian! > 1. Patches should be sent to wine-patches(a)winehq.org, not wine-devel. Thank you a lot, I didn't know these address! > I don't think that's a good idea... Afaik, the general guideline is to > not change formatting and punctuation (from the English original), > unless there's a rule in the Russian language that specifically > dictates it. In Russian there is different from English punctuation. We create a tool for humans, not machines, don't we? So, we must improve a punctuation according to a language's rules. Instead, I send my improves to Nikolay, as you recommended. > A normal, UTF-8 formatted textfile as an attachment ... should suffice, > you shouldn't need to pack it. > I guess an archive could also confuse the automated scripts I packed it to decrease a size. But if it isn't good for merging, I willn't do it. > Please understand this as constructive criticism, it will help getting > your patch accepted and not cause extra work for the maintainer > (Alexandre). It looks like you invested a lot of effort, thanks for > that. No, that's OK. There isn't something bad in constructive criticism, I think. --- Best regards, Oleg. P. S. I didn't know how to post messages into pipemail, so I replied privetly. There is a copy of my answer.

June 15, 2012