June 2012 - Wine-Devel - list.winehq.org

Re: msvcrt: Fix the name of the Portuguese locale alias.

by Bruno Jesus

On Wed, Jun 13, 2012 at 2:47 PM, Francois Gouget <fgouget(a)free.fr> wrote: > ... > dlls/msvcrt/locale.c | 2 +- > dlls/msvcrt/tests/locale.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > ... > - "portugese", "ptb", > + "portuguese", "ptb", Just a side note. Although I'm not sure I think portuguese is "ptg", brazilian portuguese is "ptb". So the correct may be: > + "portuguese", "ptg", A Portugal user would be able to check that, or maybe it's easier to write a testcase. If I'm wrong I ask apologies in advance, Bruno

June 13, 2012

Re: [2/2] msxml3: Support xmlns[:*] attribute nodes intelligently.

by Ulrik Dickow

I'll return to this patch -- merge, apply requested changes, test again -- a week from now. I'm unfortunately occupied elsewhere in the mean time. Thank you for your patience and quick & useful replies. - Ulrik

June 13, 2012

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver

by Alexandre Julliard

Andrew Eikum <aeikum(a)codeweavers.com> writes: > The configure.ac changes and parts of the driver itself were written by > Maarten Lankhorst. It doesn't work here, it's apparently using the driver even though PulseAudio is not running on this box: ../../../tools/runtest -q -P wine -M amstream.dll -T ../../.. -p amstream_test.exe.so amstream.c && touch amstream.ok err:pulse:AudioClient_Initialize PulseAudio no longer running? err:quartz:DSoundRender_create Cannot create Direct Sound object (88890010) fixme:ole:CoCreateInstance no instance created for interface {56a86895-0ad4-11ce-b03a-0020af0ba770} of class {79376820-07d0-11cf-a24d-0020afd79767}, hres is 0x88890010 amstream.c:274: Test failed: IAMMultiMediaStream_AddMediaStream returned: 88890010 -- Alexandre Julliard julliard(a)winehq.org

June 13, 2012

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19010 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

June 13, 2012

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19009 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

June 13, 2012

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19007 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

June 13, 2012

Re: [2/5] windowscodecs: Add stub IWICMetadataBlockReader to PNG decoder.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19006 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

June 13, 2012

DllMain() seems unused in ntoskrnl.exe

by Francois Gouget

The DllMain() function in ntoskrnl.exe appears to be unused: making it static causes a compiler warning to that effect and removing it entirely does not cause a compilation failure. Should it be removed or is there a build issue with ntoskrnl.exe? diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c index 2b84297..ffeb2f8 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/ntoskrnl.c @@ -1711,30 +1711,6 @@ VOID WINAPI IoInitializeRemoveLockEx(PIO_REMOVE_LOCK lock, ULONG tag, } /***************************************************** - * DllMain - */ -BOOL WINAPI DllMain( HINSTANCE inst, DWORD reason, LPVOID reserved ) -{ - static void *handler; - LARGE_INTEGER count; - - switch(reason) - { - case DLL_PROCESS_ATTACH: - DisableThreadLibraryCalls( inst ); -#ifdef __i386__ - handler = RtlAddVectoredExceptionHandler( TRUE, vectored_handler ); -#endif - KeQueryTickCount( &count ); /* initialize the global KeTickCount */ - break; - case DLL_PROCESS_DETACH: - RtlRemoveVectoredExceptionHandler( handler ); - break; - } - return TRUE; -} - -/***************************************************** * Ke386IoSetAccessProcess (NTOSKRNL.EXE.@) */ BOOLEAN WINAPI Ke386IoSetAccessProcess(PEPROCESS *process, ULONG flag) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Be careful of reading health books, you might die of a misprint. -- Mark Twain

June 13, 2012

Re: xbox 360 emulation with logitech cordless and dinput joy disable

by Stefan Dösinger

Hi, The patch needs a few improvements before it can be accepted into Wine. I can't comment on the dinput / xinput specifics of the patch, so this is a non- exhaustive list of general suggestions. Concerning the big picture, this patch needs a few discussions about xinput.dll design. There have been some discussions about that in the past, and I hope that some dinput devs can help out. Am Dienstag, 12. Juni 2012, 23:48:53 schrieb Giovanni Ongaro: > From: root <root(a)joe.(none)> Please configure git correctly, see http://wiki.winehq.org/GitWine section 3.3. Also consider using a non-root user, but that's your personal setup, so not really my business. > + if (getenv("LINIXFORCENOJOY") != NULL) return FALSE; /*JoeFix disable joystick*/ The problem with dinput vs xinput conflicts should probably be solved in a different manner. That aside, such configurations are usually done via registry keys. Also comments like /* I changed this here */ are useless, the git history stores this information anyway. > + <...> //JoeFix DEAD ZONE This is a C++ comment and not allowed in Wine. See http://wiki.winehq.org/SubmittingPatches > + fdJoy=open("/dev/input/js0",O_RDONLY | O_NONBLOCK); Xinput.dll should not open joystick devices directy, and definitely not a hardcoded one. I don't know if there's consensus about how xinput should be implemented, but basing it on top of dinput might be a start. A good start would be to write a few tests to test how Windows announces(or doesn't announce) Xbox gamepads and other gamepads/joysticks to games. My understanding is that xinput.dll only works for Xbox gamepads. Do those show up in dinput on Windows? > +#define DEAD_ZONE 4096 > ... > + if (e.number == 4) { > + if (e.value == 1) { > + FIXME("TRIGGER LEFT PRESSED\n"); > + pState->Gamepad.bLeftTrigger=32767; > + } > + else { > + pState->Gamepad.bLeftTrigger=0; > + } > ... > +#define JOYMAX 30000 > +#define JOYMIN -30000 The hardcoded numbers look questionable. The 4 and 1 are probably specific to the joystick, the 32767 might have a symbolic name like XINPUT_MAX or something. A part of this seems to be needed due to the attempt to emulate an xbox gamepad with a different device. Personally I'm not opposed to doing that, and you might need some device specific tricks to pull this off. However, this needs a more structured approach than hardcoding the values needed for one specific Logitech device in the code. Best regards, Stefan

June 13, 2012

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.

by Nikolay Sivov

On 6/13/2012 17:42, Ulrik Dickow wrote: > Here's a new version of the patch that follows all of your 3 requests: > > Den 12-06-2012 13:11, Nikolay Sivov skrev: >> [...] >> Please use something like CLSID array with every available Document >> CLSID, instead of only testing 2 of them. There's a lot of examples for >> that in saxreader.c. >> [...] >> It's better to avoid nested test calls like that imho, you could just >> add another call in main test list. >> [...] >> When this is running on all CLSIDs please add free_bstrs() here. > Is it ok now? Yes, that's what I meant. Thanks. > > Since it contains new functionality, namely test of more document > versions (CLSIDs) than before, it was necessary to change the Subject of > the patch. How do I make sure that the old patch changes status to > Superseded on http://source.winehq.org/patches/ ? E.g. use the old > subject with "(try 2)" added in the E-mail header, but the new Subject > inside the attachment? Don't worry too much about that, just send it with correct subject and mention in mail body which patch is obsolete. Correct subject is more important obviously. > > Regards, Ulrik Dickow > >

June 13, 2012