June 2012 - Wine-Devel - list.winehq.org

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.

by Ulrik Dickow

Here's a new version of the patch that follows all of your 3 requests: Den 12-06-2012 13:11, Nikolay Sivov skrev: > [...] > Please use something like CLSID array with every available Document > CLSID, instead of only testing 2 of them. There's a lot of examples for > that in saxreader.c. > [...] > It's better to avoid nested test calls like that imho, you could just > add another call in main test list. > [...] > When this is running on all CLSIDs please add free_bstrs() here. Is it ok now? Since it contains new functionality, namely test of more document versions (CLSIDs) than before, it was necessary to change the Subject of the patch. How do I make sure that the old patch changes status to Superseded on http://source.winehq.org/patches/ ? E.g. use the old subject with "(try 2)" added in the E-mail header, but the new Subject inside the attachment? Regards, Ulrik Dickow

June 13, 2012

Re: Re : d3dx9_36: D3DXQuaternionLn computes as if the norm of the input is 1

by Matteo Bruni

2012/6/13 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: >>>2012/6/12 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: >>> >>> + if ( (pq->w >= 1.0f) || (pq->w == -1.0f) ) >> >>I think the second comparison should be '<=', if you want to avoid getting >> NaNs. > > I checked in Vista. D3DX accepts -1.0f as input and returns what the patch > does. > > However, any value < -1.0f is a unacceptable value for D3DX ( D3DX returns > (-1#IND00,-1#IND00,-1#IND00,-1#IND00) ). > > > Best regards > Nozomi Oh, so it actually returns NaNs. Interesting... So the patch is fine as it is. Maybe you could try to add such a case to the tests, if it doesn't get too tricky. You could check for something like gotquat.x != gotquat.x, which should return true only if gotquat.x is NaN.

June 13, 2012

Re: wined3d: Avoid sizeof on structs with variable length arrays.

by Henri Verbeet

On 13 June 2012 13:27, Michael Stefaniuc <mstefani(a)redhat.com> wrote: > Uh... Any reason that field cannot be just > struct wined3d_adapter adapter; > ? > Not really, but if we actually supported multihead we'd have multiple adapters and would need to change it back again.

June 13, 2012

Re: wined3d: Avoid sizeof on structs with variable length arrays.

by Michael Stefaniuc

On 06/13/2012 12:56 PM, Henri Verbeet wrote: > On 13 June 2012 10:41, Michael Stefaniuc <mstefani(a)redhat.de> wrote: >> - object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); >> + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, FIELD_OFFSET(struct wined3d, adapters[1])); > > That's not really a VLA, just a somewhat stupid array of size 1. Uh... Any reason that field cannot be just struct wined3d_adapter adapter; ? bye michael

June 13, 2012

Re: wined3d: Avoid sizeof on structs with variable length arrays.

by Henri Verbeet

On 13 June 2012 10:41, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > - object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); > + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, FIELD_OFFSET(struct wined3d, adapters[1])); That's not really a VLA, just a somewhat stupid array of size 1.

June 13, 2012

Re: Misspelt Portuguese in msvcrt

by Piotr Caban

On 06/13/12 05:19, Francois Gouget wrote: > Is there a reason why Portuguese is misspelt in these two places? It's a typo. Thanks for spotting it.

June 13, 2012

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 3).

by Jacek Caban

Hi Erich, On 06/12/12 19:03, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control, the search is a > now a binary search, and some additional cleanup. It is important to > note that HTML Help only supports characters within the ANSI code > pages, so support for multi-byte characters is not necessary. Many > apologizes to Jacek Caban for missing some of his comments in his > original reply. > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. The patch looks much better. There is one remaining problem: + int pos = sizeof(html_encoded_symbols)/sizeof(html_encoded_symbols[0]); + float step = pos/2; + int dir = +1; + + do + { + const char *encoded_symbol; + + pos += -dir*ceil(step); Using float here is definitely not needed, esp. that you always use ceil() on it. You've made it more complicated than it really is. See [1] for an example. Also feel free to send linear search with FIXME comment. That's fine for the first iteration patch. Jacek [1] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/mshtml/dispex.c#l709

June 13, 2012

Re: [11/11] windowscodecs: Implement GetMetadataFormat.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18989 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd

June 13, 2012

Re: [10/11] windowscodecs: Handle IFD fields with count 0 same way as with count 1.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18988 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd

June 13, 2012

Re: [09/11] windowscodecs: Add support for IFD_UNDEFINED field type.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18987 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd

June 13, 2012