June 2012 - Wine-Devel - list.winehq.org

Re: [PATCH] loader: On Mac OS, don't use external symbols for the DOS and shared heap segments.

by Alexandre Julliard

Charles Davis <cdavis(a)mymail.mines.edu> writes: > My first idea was to just add some '.globl' directives in the code. But > then I asked myself: why are we using an indirect symbol at all? Why are > we treating this like an external symbol when it clearly isn't? So now, > the arrays are declared static, and their owning section is explicitly > declared to the C compiler. While compile times have gone up, at least > the compiled loader executable actually works. This core dumps instantly when build with gcc on Mac OS 10.5, and doesn't even compile on 10.6. -- Alexandre Julliard julliard(a)winehq.org

June 11, 2012

Re: [PATCH 1/3] winspool: Install the ppd files into the driver directory.

by Alexandre Julliard

Huw Davies <huw(a)codeweavers.com> writes: > @@ -488,18 +638,70 @@ static void *cupshandle; > DO_FUNC(cupsGetPPD); \ > DO_FUNC(cupsParseOptions); \ > DO_FUNC(cupsPrintFile); > +#define CUPS_OPT_FUNCS \ > + DO_FUNC(cupsGetPPD3); > > #define DO_FUNC(f) static typeof(f) *p##f > CUPS_FUNCS; > +CUPS_OPT_FUNCS; > #undef DO_FUNC This still requires the function to be defined: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_SPOOL32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/usr/local/include/freetype2 -I/usr/local/include -g -O2 -o info.o info.c info.c:732: error: 'cupsGetPPD3' undeclared here (not in a function) info.c:732: warning: type defaults to 'int' in declaration of 'pcupsGetPPD3' info.c: In function 'cupsGetPPD3_wrapper': info.c:741: error: called object 'pcupsGetPPD3' is not a function info.c: In function 'get_cups_ppd': info.c:771: error: 'CUPS_HTTP_DEFAULT' undeclared (first use in this function) info.c:771: error: (Each undeclared identifier is reported only once info.c:771: error: for each function it appears in.) make[1]: *** [info.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

June 11, 2012

Re: po: Update Russian translation (try 3) (resend)

by Nikolay Sivov

On 6/9/2012 07:43, Oleg Yarigin wrote: > To avoid encode breaks I send a patch as an attachment. > > I packed it into *.GZ archive, becouse (I suppose so) some > intermediate servers can block messages with big attachments. > > Please split it to several patches with changes grouped by some criteria, it's really hard to review when it's that long.

June 11, 2012

Re: po: Update Italian translation

by Matteo Bruni

Hi Luca, just a couple of nitpicks: -"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi <a href=" -"\"http://wiki.winehq.org/Gecko\">http://wiki.winehq.org/Gecko</a> per i " -"dettagli." +"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi <a " +"href=\"http://wiki.winehq.org/Mono\">http://wiki.winehq.org/Mono</a> " +"per i dettagli." This sounds a bit awkward, I'd go for something like "Nota: si raccomanda di usare i pacchetti forniti dalla tua distribuzione." #: cryptui.rc:413 -#, fuzzy -#| msgid "&Personal Information Exchange/PKCS #12 (.pfx)" msgid "&Personal Information Exchange/PKCS #12 (*.pfx)" -msgstr "Scambia di Informazioni &Personali/PKCS #12 (.pfx)" +msgstr "Scambia di Informazioni &Personali/PKCS #12 (*.pfx)" "Scambio". #: joy.rc:33 msgid "Joysticks" -msgstr "" +msgstr "Joysticks" I'm quite sure foreign words are always wrote in singular form in Italian language, so this would be "Joystick".

June 11, 2012

Re: A copyright question to wine developpers

by Christophe-Marie Duquesne

On Mon, Jun 11, 2012 at 5:33 PM, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > Have a look at what Google does for the Linux headers in Android. They > essentially process them with a script and remove comments, inline > functions and other stuff. There have been various articles about it. > Look at the argumentation. This really helpful. Thank you very much.

June 11, 2012

Re: A copyright question to wine developpers

by Roderick Colenbrander

On Mon, Jun 11, 2012 at 6:50 AM, Christophe-Marie Duquesne <chmd(a)chmd.fr> wrote: > On Mon, Jun 11, 2012 at 3:09 PM, Ricardo Filipe > <ricardojdfilipe(a)gmail.com> wrote: >> yeah, what happens is the header is reimplemented, not simply >> copy-pasted from Windows. >> Even if the API is not copyrighted, the header contents still are. >> > > Well if you rewrite a header such that it is 100% compatible with an > API (which means: 0 change in client code), it has to be very similar > to the one the API came from. > - The macros have to be the same, in order to expand the same way in client code > - The function names have to be the same as well > - Same goes for the typedefs > - The header name also has to remain the same. > > What can be different: > - function argument names > - indentation > - comments > > In the end, it seemed pretty silly to me to do that. But, if that is > the solution to my copyright problem, I am doing it! > > Have a look at what Google does for the Linux headers in Android. They essentially process them with a script and remove comments, inline functions and other stuff. There have been various articles about it. Look at the argumentation. Years ago a lot of video games used 3dfx their 'glide' APIs. A number of people made re-implementations of glide by using the 3dfx glide SDK. All implementations which used the official headers were taken down. Again there may be more information about this. Roderick

June 11, 2012

Re: A copyright question to wine developpers

by Christophe-Marie Duquesne

On Mon, Jun 11, 2012 at 3:09 PM, Ricardo Filipe <ricardojdfilipe(a)gmail.com> wrote: > yeah, what happens is the header is reimplemented, not simply > copy-pasted from Windows. > Even if the API is not copyrighted, the header contents still are. > Well if you rewrite a header such that it is 100% compatible with an API (which means: 0 change in client code), it has to be very similar to the one the API came from. - The macros have to be the same, in order to expand the same way in client code - The function names have to be the same as well - Same goes for the typedefs - The header name also has to remain the same. What can be different: - function argument names - indentation - comments In the end, it seemed pretty silly to me to do that. But, if that is the solution to my copyright problem, I am doing it!

June 11, 2012

Re: [1/4] msi: Add support for 64-bit registry components. (resend)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18942 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

June 11, 2012

Re: A copyright question to wine developpers

by Ricardo Filipe

2012/6/11 Michael Stefaniuc <mstefani(a)redhat.com>: > Hello! > > On 06/11/2012 10:54 AM, Christophe-Marie Duquesne wrote: >> To my understanding, wine is a reimplementation of the MS system. As >> far as I understand, you take MS public headers and reimplement their >> functions. If that is how it works, then how do you deal with >> copyright? The MS headers certainly come with a copyright clause: how >> is it possible to redistribute these headers with wine? > The Windows headers are copyrighted and Wine cannot redistribute those. > Wine provides its own headers. > > bye > michael > > yeah, what happens is the header is reimplemented, not simply copy-pasted from Windows. Even if the API is not copyrighted, the header contents still are.

June 11, 2012

Re: [PATCH 1/4] kernel32/tests: Move a cdrom test to its own file

by Alexandre Julliard

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > The cdrom test file will be used to test ioctl (results, structure size...) > Each drive is tested and skipped gracefully if ioctl not supported or not a CDROM drive. I don't see a need for a new file, particularly since disk extents are not CDROM-specific. But even DVD ioctls can be tested in volume.c. -- Alexandre Julliard julliard(a)winehq.org

June 11, 2012