June 2012 - Wine-Devel - list.winehq.org

Re: [PATCH] winepulse.drv: Add PulseAudio driver

by Alexandre Julliard

Andrew Eikum <aeikum(a)codeweavers.com> writes: > There's a lengthy comment in ready_pulse() describing why we're using > pthreads syncro primitives instead of Win32 primitives. I was under > the impression (thanks to the CoreAudio driver, mostly) that threads > not created through CreateThread() cannot use CRITICAL_SECTION, ERR, > WARN, TRACE, and so on. However, when I was testing, I noticed that > debug printing _does_ work in callbacks from the pthread thread. You can't do that, you need to create a proper Win32 thread, and solve the loader lock issue some other way. -- Alexandre Julliard julliard(a)winehq.org

June 11, 2012

Re: [PATCH] loader: On Mac OS, don't emit a __PAGEZERO segment.

by Alexandre Julliard

Charles Davis <cdavis(a)mymail.mines.edu> writes: > This is the reason we couldn't put the WINE_DOS segment at address 0. We don't need page zero, we don't run DOS apps on the Mac. -- Alexandre Julliard julliard(a)winehq.org

June 11, 2012

Re: A copyright question to wine developpers

by Michael Stefaniuc

Hello! On 06/11/2012 10:54 AM, Christophe-Marie Duquesne wrote: > To my understanding, wine is a reimplementation of the MS system. As > far as I understand, you take MS public headers and reimplement their > functions. If that is how it works, then how do you deal with > copyright? The MS headers certainly come with a copyright clause: how > is it possible to redistribute these headers with wine? The Windows headers are copyrighted and Wine cannot redistribute those. Wine provides its own headers. bye michael

June 11, 2012

Re: A copyright question to wine developpers

by Edward Savage

On Mon, Jun 11, 2012 at 6:54 PM, Christophe-Marie Duquesne <chmd(a)chmd.fr> wrote: > Hi, > > To my understanding, wine is a reimplementation of the MS system. As > far as I understand, you take MS public headers and reimplement their > functions. If that is how it works, then how do you deal with > copyright? The MS headers certainly come with a copyright clause: how > is it possible to redistribute these headers with wine? > > The reason why I ask this: I just rewrote an opensource implementation > of a closed-source library. This opensource implementation is meant to > be fully compatible with the closed source one: I reimplemented all > the functions provided by their header, and anyone using the closed > source one should be able to use my library as a replacement. My > problem, though, is with the distribution of the header: Since I want > to be fully compatible with the closed-source implementation, I have > to, somehow, use the same header. I could probably modify it so that > is *looks* different, but for the compiler, the API *needs* to be the > same. > > Since you seem to have the same problem with wine (and you probably > dealt with it succesfully), I wanted to ask you how you are solving > this problem. Do you "rewrite" the headers? Do you copy them "raw"? > > Thank you, > Christophe-Marie Duquesne > I wouldn't have a clue about France or my own country however it now appears rather clear cut to developers in the United States. You'd assume this is the common sense ruling that should follow any action of this type in other countries though. http://tech.slashdot.org/story/12/05/31/237208/judge-rules-apis-can-not-be-… Have you considered talking to your local version of the EFF? Edward

June 11, 2012

A copyright question to wine developpers

by Christophe-Marie Duquesne

Hi, To my understanding, wine is a reimplementation of the MS system. As far as I understand, you take MS public headers and reimplement their functions. If that is how it works, then how do you deal with copyright? The MS headers certainly come with a copyright clause: how is it possible to redistribute these headers with wine? The reason why I ask this: I just rewrote an opensource implementation of a closed-source library. This opensource implementation is meant to be fully compatible with the closed source one: I reimplemented all the functions provided by their header, and anyone using the closed source one should be able to use my library as a replacement. My problem, though, is with the distribution of the header: Since I want to be fully compatible with the closed-source implementation, I have to, somehow, use the same header. I could probably modify it so that is *looks* different, but for the compiler, the API *needs* to be the same. Since you seem to have the same problem with wine (and you probably dealt with it succesfully), I wanted to ask you how you are solving this problem. Do you "rewrite" the headers? Do you copy them "raw"? Thank you, Christophe-Marie Duquesne

June 11, 2012

Re: [PATCH 2/2 resend] wininet: Added InternetGetSecurityInfoByURL tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18940 Your paranoid android. === W2K8SE (32 bit http) === http.c:533: Test failed: req_error = 12007 http.c:544: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:557: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:558: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:559: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:560: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:569: Test failed: flags = 8, expected 0 http.c:657: Test failed: Returned zero size in response to request complete http.c:269: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:533: Test failed: req_error = 12007 http.c:557: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:558: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:559: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:560: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:562: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:569: Test failed: flags = 8, expected 0 http.c:583: Test failed: Wrong URL http://test.winehq.org/tests/redirect http.c:657: Test failed: Returned zero size in response to request complete http.c:269: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:269: Test failed: unexpected status 11 (INTERNET_STATUS_NAME_RESOLVED)

June 11, 2012

Re: [PATCH] winepulse.drv: Add PulseAudio driver

by Dmitry Timoshkov

Andrew Eikum <aeikum(a)codeweavers.com> wrote: > configure.ac | 31 +- > dlls/mmdevapi/main.c | 4 +- > dlls/winepulse.drv/Makefile.in | 9 + > dlls/winepulse.drv/mmdevdrv.c | 3216 +++++++++++++++++++++++++++++++++ > dlls/winepulse.drv/winepulse.drv.spec | 5 + > 5 files changed, 3261 insertions(+), 4 deletions(-) > create mode 100644 dlls/winepulse.drv/Makefile.in > create mode 100644 dlls/winepulse.drv/mmdevdrv.c > create mode 100644 dlls/winepulse.drv/winepulse.drv.spec How does it follow the Alexandre's requirement to split the patch into smaller pieces before submitting? -- Dmitry.

June 11, 2012

Re: [PATCH] kernel32: Don't use putenv(3) on temporary strings.

by Ken Thomases

The putenv() calls occur in a forked grandchild process just before an exec(). The strings are sure to survive the current process image. After that, it's the kernel's problem. Regards, Ken On Jun 10, 2012, at 11:47 AM, Charles Davis wrote: > The Darwin manpage for putenv() warns that it no longer makes a copy of > its input, but directly stores the pointer in environ. Wine was passing > stack- and heap-allocated strings to putenv(), which could have caused a > crash. We were very lucky it didn't. Instead, use setenv(3), which still > copies its inputs. > > Found while tracking down an insidious bug in Clang-built optimized > (-O2) Wine. > --- > dlls/kernel32/process.c | 24 +++++++++++------------- > 1 files changed, 11 insertions(+), 13 deletions(-) > > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index 42716c2..1ec3e3d 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -1741,17 +1741,14 @@ static const char *get_alternate_loader( char **ret_env ) > int len = strlen( loader_env ); > if (!is_win64) > { > - if (!(env = HeapAlloc( GetProcessHeap(), 0, sizeof("WINELOADER=") + len + 2 ))) return NULL; > - strcpy( env, "WINELOADER=" ); > - strcat( env, loader_env ); > + if (!(env = HeapAlloc( GetProcessHeap(), 0, len + 2 ))) return NULL; > + strcpy( env, loader_env ); > strcat( env, "64" ); > } > else > { > - if (!(env = HeapAlloc( GetProcessHeap(), 0, sizeof("WINELOADER=") + len ))) return NULL; > - strcpy( env, "WINELOADER=" ); > - strcat( env, loader_env ); > - len += sizeof("WINELOADER=") - 1; > + if (!(env = HeapAlloc( GetProcessHeap(), 0, len ))) return NULL; > + strcpy( env, loader_env ); > if (!strcmp( env + len - 2, "64" )) env[len - 2] = 0; > } > if (!loader) > @@ -1860,14 +1857,14 @@ static pid_t exec_loader( LPCWSTR cmd_line, unsigned int flags, int socketfd, > /* Reset signals that we previously set to SIG_IGN */ > signal( SIGPIPE, SIG_DFL ); > > - sprintf( socket_env, "WINESERVERSOCKET=%u", socketfd ); > - sprintf( preloader_reserve, "WINEPRELOADRESERVE=%lx-%lx", > + sprintf( socket_env, "%u", socketfd ); > + sprintf( preloader_reserve, "%lx-%lx", > (unsigned long)binary_info->res_start, (unsigned long)binary_info->res_end ); > > - putenv( preloader_reserve ); > - putenv( socket_env ); > - if (winedebug) putenv( winedebug ); > - if (wineloader) putenv( wineloader ); > + setenv( "WINESERVERSOCKET", socket_env, 1 ); > + setenv( "WINEPRELOADRESERVE", preloader_reserve, 1 ); > + if (winedebug) setenv( "WINEDEBUG", winedebug, 1 ); > + if (wineloader) setenv( "WINELOADER", wineloader, 1 ); > if (unixdir) chdir(unixdir); > > if (argv) > @@ -1976,6 +1973,7 @@ static BOOL create_process( HANDLE hFile, LPCWSTR filename, LPWSTR cmd_line, LPW > static const WCHAR WINEDEBUG[] = {'W','I','N','E','D','E','B','U','G','=',0}; > if (!winedebug && !strncmpW( env_end, WINEDEBUG, sizeof(WINEDEBUG)/sizeof(WCHAR) - 1 )) > { > + env_end += sizeof(WINEDEBUG)/sizeof(WCHAR) - 1; > DWORD len = WideCharToMultiByte( CP_UNIXCP, 0, env_end, -1, NULL, 0, NULL, NULL ); > if ((winedebug = HeapAlloc( GetProcessHeap(), 0, len ))) > WideCharToMultiByte( CP_UNIXCP, 0, env_end, -1, winedebug, len, NULL, NULL ); > -- > 1.7.5.4 > > >

June 10, 2012

Re: [PATCH 4/4] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdCopyrightDescriptor) test

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18927 Your paranoid android. === W2KPROSP4 (32 bit cdrom) === cdrom.c:85: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87

June 10, 2012

Re: [PATCH 3/4] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) test

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18926 Your paranoid android. === W2KPROSP4 (32 bit cdrom) === cdrom.c:84: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87

June 10, 2012