June 2012 - Wine-Devel - list.winehq.org

Re: Patch 1/2 - [scrrun] - Add initial support for Dictionary - try 2

by Vijay Kiran Kamuju

On Fri, Jun 8, 2012 at 11:00 AM, Jacek Caban <jacek(a)codeweavers.com> wrote: > Hi Vijay, > > On 06/08/12 03:15, Vijay Kiran Kamuju wrote: >> + *ppvObject = NULL; >> + if ( IsEqualGUID( riid, &IID_IDictionary ) || >> + IsEqualGUID( riid, &IID_IPersist ) || >> + IsEqualGUID( riid, &IID_IDispatch ) || >> + IsEqualGUID( riid, &IID_IUnknown ) ) >> + { >> + *ppvObject = This; >> + } Attaching the new dictionary.c with a bit more functionality, please review > > That's not the right way to cast object to interface. See > http://wiki.winehq.org/COMGuideline > > Cheers, > Jacek

June 8, 2012

re: iphlpapi: Don't rely on the HAVE_XXX macros having a numeric values.

by Dan Kegel

-#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (HAVE_STRUCT_IPSTAT_IPS_TOTAL || HAVE_STRUCT_IP_STATS_IPS_TOTAL) +#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (defined(HAVE_STRUCT_IPSTAT_IPS_TOTAL) || defined(HAVE_STRUCT_IP_STATS_IPS_TOTAL)) Isn't this a no-op? I thought that an undefined symbol was treated as false by the preprocessor. When I compile #if defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (HAVE_STRUCT_IPSTAT_IPS_TOTAL || HAVE_STRUCT_IP_STATS_IPS_TOTAL) defined #else not defined #endif with gcc -E or cl /E, I get not defined

June 8, 2012

Re: [PATCH 1/5] hhctrl.ocx: Add HTML to Unicode parsing capability.

by Jacek Caban

On 06/08/12 16:10, Erich E. Hoover wrote: > On Fri, Jun 8, 2012 at 2:58 AM, Jacek Caban <jacek(a)codeweavers.com> wrote: >> ... >> Did you test indexes like '<script>alert("really!?")</script>' ? :) >> Seriously, HTMLDocument is not the right tool for the job. > I can. Do you have a suggestion for an alternative? I don't know any helper API for that. Writing decoder for HTML-encoded characters sounds like a good solution. Cheers, Jacek

June 8, 2012

Re: [PATCH 1/5] hhctrl.ocx: Add HTML to Unicode parsing capability.

by Erich E. Hoover

On Fri, Jun 8, 2012 at 2:58 AM, Jacek Caban <jacek(a)codeweavers.com> wrote: > ... > Did you test indexes like '<script>alert("really!?")</script>' ? :) > Seriously, HTMLDocument is not the right tool for the job. I can. Do you have a suggestion for an alternative? Erich

June 8, 2012

Re: [PATCH 3/3] wininet: Added InternetGetSecurityInfoByURL tests

by Jacek Caban

On 06/08/12 15:13, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=18903 > > Your paranoid android. > > > === W7PROX64 (32 bit http) === > http.c:3293: Test failed: HttpSendRequest failed: 12002 This doesn't seem related to the patch. Jacek

June 8, 2012

Re: [PATCH 3/3] wininet: Added InternetGetSecurityInfoByURL tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18903 Your paranoid android. === W7PROX64 (32 bit http) === http.c:3293: Test failed: HttpSendRequest failed: 12002

June 8, 2012

Re: msxml3: Implement IXMLParser Get/Set Flags

by Alistair Leslie-Hughes

On 8/06/2012 7:15 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=18891 > > Your paranoid android. > > > === WINEBUILD (build) === > Make failed > > > This appears to be caused by the bot not building xmlparser.idl -> xmlparser.h. Best Regards Alistair Leslie-Hughes

June 8, 2012

Re: msxml3: Implement IXMLParser Get/Set Flags

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18891 Your paranoid android. === WINEBUILD (build) === Make failed

June 8, 2012

Re: Patch 1/2 - [scrrun] - Add initial support for Dictionary - try 2

by Jacek Caban

Hi Vijay, On 06/08/12 03:15, Vijay Kiran Kamuju wrote: > + *ppvObject = NULL; > + if ( IsEqualGUID( riid, &IID_IDictionary ) || > + IsEqualGUID( riid, &IID_IPersist ) || > + IsEqualGUID( riid, &IID_IDispatch ) || > + IsEqualGUID( riid, &IID_IUnknown ) ) > + { > + *ppvObject = This; > + } That's not the right way to cast object to interface. See http://wiki.winehq.org/COMGuideline Cheers, Jacek

June 8, 2012

Re: [PATCH 1/5] hhctrl.ocx: Add HTML to Unicode parsing capability.

by Jacek Caban

Hi Erich, On 06/07/12 23:09, Erich E. Hoover wrote: > + /* Post the HTML text to the document */ > + array = SafeArrayCreateVector(VT_VARIANT, 0, 1); > + if(!array) > + goto cleanup; > + hr = SafeArrayAccessData(array, (LPVOID*)&array_param); > + if (FAILED(hr)) > + goto cleanup; > + V_VT(array_param) = VT_BSTR; > + V_BSTR(array_param) = SysAllocString(html_fragment); > + hr = SafeArrayUnaccessData(array); > + if (FAILED(hr)) > + goto cleanup; > + hr = IHTMLDocument2_write(html_parsing_doc, array); Did you test indexes like '<script>alert("really!?")</script>' ? :) Seriously, HTMLDocument is not the right tool for the job. Cheers, Jacek

June 8, 2012