June 2012 - Wine-Devel - list.winehq.org

Re: Wine in Humble Indie Bundle

by James Eder

On Sun, Jun 3, 2012 at 6:16 PM, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > This comes up in one form or the other very often, though, doesn't it? > Company x releases software y with a Wine wrapper advertising "native linux > support" and users get upset. Personally, I'm glad they're thinking about > Linux and I think Wine fills a great role as a "transitional" step between > Windows and Linux, but I don't think it's any good to encourage using Wine > over making the game more portable. Besides, doesn't HIB have some rule > about requiring all games to support Linux natively? > > J. Leclanche More often than not it's the case that no amount of encouragement will lead to a native port. If it were a simple matter of encouragement, I doubt there'd be a point in Wine. Often it's the case that a company produces software with the intent to do very little after release day. By very little I mean that it *might* get one or two patches after release and then it's done. The patches address usually a handful of bugs. It isn't continuation of development really. Porting software is generally a lot more involved than fixing a few bugs. Porting is more like a continuation of development that often involves nontrivial effort. For companies that take a "fire and forget" approach to software development, Wine provides an option where there wouldn't be one otherwise. Of course everyone would love to see real maintenance and continuation of development but a realist will point out that is not what's happening. Nor would it in many cases even if Wine didn't exist. Those that object to Wine being used to port software should ask the real question: Would the software be ported otherwise? It is not even clear that it still would have been ported. For some, you might only get a port if it's a trivial thing to do. I'd like to point out that despite the increasing quality of Wine, it's becoming increasingly likely that software is designed to be portable and made available cross platform. It's also becoming more likely that a user can find high quality alternatives to platform locked applications. If Wine's existence is in fact discouraging native ports in a significant way then you would expect the trend to be in the other direction. The mere existence of edge cases where Wine may have discouraged a native port does not negate the larger trend. It seems a bit silly to fuss over a small skirmish when the war is being won on a much larger, more significant, turf. The availability of high quality cross platform development tools has done more to win the battle than Wine's absence ever could hope to do. Further the push for native ports is something that happens _after_ the application was developed using MS APIs and _after_ it was ported via Wine. (Ironically, there'd be much less fuss if the developers just kept it as a Windows only program.) If the original developer cared about being portable they would have used portable libraries from the start. As far as I can tell, there's no indication that Wine was a part of the original development decision to use non portable APIs. There's only the fears of some that it might have or will someday. http://en.wikipedia.org/wiki/Make_a_mountain_out_of_a_molehill -- Jim

June 4, 2012

Re: [PATCH 1/2] joystick.cpl: First version of the joystick configuration applet

by Alexandre Julliard

Lucas Zawacki <lfzawacki(a)gmail.com> writes: >> It's called joy.cpl on Windows. Please also use compatible exports, and >> avoid creating a lot of empty source files. I'd expect that a single >> source file is sufficient for this. > > Will do. I removed the uneeded shlwapi and advapi32 from the exports > is that enough or am I missing something? I mean the functions you export in the spec file. -- Alexandre Julliard julliard(a)winehq.org

June 4, 2012

Re: [PATCH 1/2] joystick.cpl: First version of the joystick configuration applet

by Lucas Zawacki

> It's called joy.cpl on Windows. Please also use compatible exports, and > avoid creating a lot of empty source files. I'd expect that a single > source file is sufficient for this. Will do. I removed the uneeded shlwapi and advapi32 from the exports is that enough or am I missing something?

June 4, 2012

Re: [PATCH 1/4] server: Move completion from async object to async queue.

by Alexandre Julliard

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > Well, maybe I screwed something up - but when I tried to access the > descriptor like that it caused segfaults in some of the tests. What I > found was that neither create_async_queue or create_async increment > the refcount on the file descriptor, but create_async does increment > the refcount on the async queue so that the async queue will live > throughout the life of the async. So, what appeared to happen is > this: > 1) A file descriptor is created. > 2) An async operation is queued on the file descriptor. > 3) The file descriptor is closed (queuing the async to wake up and > contact user space). > 4) The file descriptor is destroyed because its refcount reaches zero. > 5) The async operation returns from user space with completion > information for the operation. > 6) Accessing the completion from the no-longer existing file > descriptor causes a crash. > > I tried having the async and/or the async queue increment the refcount > for the file descriptor, but that caused a host of other problems > (mainly file descriptors never closing). So, I'm pretty sure that the > completion information needs to be held separately in the async queue > - but I can go back and double check that this is the case if you'd > like. It may have to be moved to the queue upon shutdown when the file descriptor is released, but I don't see any reason to maintain two copies of the same information. -- Alexandre Julliard julliard(a)winehq.org

June 4, 2012

Re: [PATCH 1/4] server: Move completion from async object to async queue.

by Erich E. Hoover

On Mon, Jun 4, 2012 at 2:53 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > ... > I don't think that you can have an async queue that outlives its file > descriptor. Well, maybe I screwed something up - but when I tried to access the descriptor like that it caused segfaults in some of the tests. What I found was that neither create_async_queue or create_async increment the refcount on the file descriptor, but create_async does increment the refcount on the async queue so that the async queue will live throughout the life of the async. So, what appeared to happen is this: 1) A file descriptor is created. 2) An async operation is queued on the file descriptor. 3) The file descriptor is closed (queuing the async to wake up and contact user space). 4) The file descriptor is destroyed because its refcount reaches zero. 5) The async operation returns from user space with completion information for the operation. 6) Accessing the completion from the no-longer existing file descriptor causes a crash. I tried having the async and/or the async queue increment the refcount for the file descriptor, but that caused a host of other problems (mainly file descriptors never closing). So, I'm pretty sure that the completion information needs to be held separately in the async queue - but I can go back and double check that this is the case if you'd like. Erich Hoover ehoover(a)mines.edu

June 4, 2012

Re: [website] Publish a sign button for the Wine in Humble Indie Bundle petition

by Jeremy Newman

I'm not sure this belongs in the news section on WineHQ. I need some further convincing. -Newman On 06/04/2012 01:11 PM, André Hentschel wrote: > http://www.winehq.org/pipermail/wine-devel/2012-June/095722.html needs more cow bell > > --- > news/en/2012060401.xml | 23 +++++++++++++++++++++++ > 1 files changed, 23 insertions(+), 0 deletions(-) > create mode 100644 news/en/2012060401.xml > > diff --git a/news/en/2012060401.xml b/news/en/2012060401.xml > new file mode 100644 > index 0000000..1bcd3d5 > --- /dev/null > +++ b/news/en/2012060401.xml > @@ -0,0 +1,23 @@ > +<news> > +<date>June 4, 2012</date> > +<title>Wine in Humble Indie Bundle</title> > +<body> > +<div style="float: left; margin: 0 20px 20px 0; display:block; clear:both; text-align: left; background: #000 url(http://www.ipetitions.com/assets/images/widgets/black.png) no-repeat top left; width: 200px;"> > +<iframe src="http://www.ipetitions.com/widget/view/black/437775" marginheight="0" marginwidth="0" style="width: 200px; height:150px; border:0;" scrolling="no"></iframe> > +<div style="text-align:center; font-family:Arial;font-size: 9px; width: 196px; margin-top: -3px; padding: 1px 2px 2px; color: #8a8a8a; font-style: italic;"> > +<a style="color: #8a8a8a; text-decoration:none;" href="http://www.ipetitions.com/">Petitions</a> by<a style="color: #8a8a8a; text-decoration:none;" href="http://www.ipetitions.com">iPetitions.com</a> > +</div> > +</div> > +<p> > + The Humble Indie Bundle includes a game (Limbo) > +<a href="http://zcint.co.uk/article/limbo-on-linux-incites-humble-bundle-petition">ported via wine</a>. > +</p> > +<p> > + That's pretty cool, but not everyone agrees, and somebody has started circulating an anti-wine petition. > +</p> > +<p> > + So Dan Kegel put together a pro-wine petition: > +<a href="http://www.ipetitions.com/petition/use-wine-as-needed-in-future-humble-indi…">Use Wine as needed in future Humble Indie Bundles</a> > +</p> > +</body> > +</news> > > > >

June 4, 2012

Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono

by Vincent Povirk

On Mon, Jun 4, 2012 at 12:23 PM, Max TenEyck Woodbury <max(a)mtew.isa-geek.net> wrote: > <mono hate> Let's not hijack Dan's thread for this.

June 4, 2012

Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono

by Max TenEyck Woodbury

On 06/04/2012 03:05 AM, Frédéric Delanoy wrote: > On Mon, Jun 4, 2012 at 8:35 AM, Dan Kegel<dank(a)kegel.com> wrote: >> On Sun, Jun 3, 2012 at 11:20 PM, Frédéric Delanoy >> <frederic.delanoy(a)gmail.com> wrote: >>> On Sun, Jun 3, 2012 at 7:02 PM, Dan Kegel<daniel.r.kegel(a)gmail.com> wrote: >>>> http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh now >>>> also installs mono. ... >>> >>> Wouldn't it be better (and more acceptable for people >>> disliking/wanting to avoid mono) to >>> - keep install-gecko.sh as is >>> - create install-mono.sh >>> - create wine-install-addons.sh calling the former >>> ? >> >> The point of this script is to make life easier for me and >> for the average user. It's not to make life easier for >> people who don't like mono, mostly because I doubt >> there are many of them. > > My comment was not only meant for "mono-haters", but it can also be > useful IMHO to split e.g. to limit download size.when one doesn't even > need mono, and it maybe clearer as well ("addons" is pretty generic). > > Frédéric > > Actually, it really is the name that matters. 'mono' is a lightning rod for a lot of political history. If you were to integrate the same functions into Wine itself, and hopefully avoid tripping over the stinking Microsoft patents, that set of problems can be avoided, A native MSWindows application that wants .net support would either connect to the installed dll that provides the required services or install such a dll. It would know nothing about 'mono'. It is only non-MSWindows platform programs that will try to link to the non-MSWinows libraries in 'mono'. So an MSWindows executable looking for .net support needs .net support, NOT mono. We can and should provide such executables the services they need. However we should NOT make it easy for programs from other platforms to fall into the stinking Microsoft Patent trap. That gateway to hell is called 'mono' and we should NOT open it.

June 4, 2012

Re: [PATCH 1/5] wined3d: Use NAN.

by Ruslan Kabatsayev

Hello, This patch stops wine from building on my system with following errors: In file included from arb_program_shader.c:35:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from device.c:32:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from ati_fragment_shader.c:26:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from context.c:27:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from directx.c:26:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from gl_compat.c:26:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) make[1]: *** [ati_fragment_shader.o] Error 1 Regards, Ruslan On Wed, May 30, 2012 at 6:14 PM, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > --- > dlls/wined3d/drawprim.c | 2 ++ > dlls/wined3d/utils.c | 2 ++ > dlls/wined3d/wined3d_private.h | 4 ++-- > 3 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/dlls/wined3d/drawprim.c b/dlls/wined3d/drawprim.c > index 2e30175..c8944e5 100644 > --- a/dlls/wined3d/drawprim.c > +++ b/dlls/wined3d/drawprim.c > @@ -25,6 +25,8 @@ > */ > > #include "config.h" > +#include "wine/port.h" > + > #include "wined3d_private.h" > > WINE_DEFAULT_DEBUG_CHANNEL(d3d_draw); > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index dc63d8b..f8f301a 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -25,6 +25,8 @@ > */ > > #include "config.h" > +#include "wine/port.h" > + > #include "wined3d_private.h" > > WINE_DEFAULT_DEBUG_CHANNEL(d3d); > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 096fe60..6632f6e 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -200,7 +200,7 @@ static inline float float_16_to_32(const unsigned short *in) { > return sgn * powf(2, (float)e - 15.0f) * (1.0f + ((float)m / 1024.0f)); > } else { > if(m == 0) return sgn / 0.0f; /* +INF / -INF */ > - else return 0.0f / 0.0f; /* NAN */ > + else return NAN; > } > } > > @@ -222,7 +222,7 @@ static inline float float_24_to_32(DWORD in) > else > { > if (m == 0) return sgn / 0.0f; /* +INF / -INF */ > - else return 0.0f / 0.0f; /* NAN */ > + else return NAN; > } > } > > -- > 1.7.3.4 > > >

June 4, 2012

Re: wininet: Added support for undocumented InternetQueryOption(98)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18739 Your paranoid android. === W7PROX64 (32 bit http) === http.c:3203: Test failed: HttpSendRequest failed: 12007 http.c:3208: Test failed: expected secure flag to be set http.c:3220: Test failed: expected a non-empty subject name http.c:3223: Test failed: expected a non-empty issuer name http.c:3232: Test failed: expected a non-zero key size http.c:3252: Test failed: expected a non-empty subject name http.c:3255: Test failed: expected a non-empty issuer name http.c:3264: Test failed: expected a non-zero key size

June 4, 2012