June 2012 - Wine-Devel - list.winehq.org

Re: kernel32: Change LCMapStringW to LCMapStringEx and call it from LCMapStringW (try 2)

by Alexandre Julliard

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -2625,6 +2641,28 @@ INT WINAPI LCMapStringW(LCID lcid, DWORD flags, LPCWSTR src, INT srclen, > } > > /************************************************************************* > + * LCMapStringW (KERNEL32.@) > + * > + * See LCMapStringA. > + */ > +INT WINAPI LCMapStringW(LCID lcid, DWORD flags, LPCWSTR src, INT srclen, > + LPWSTR dst, INT dstlen) > +{ > + WCHAR locale[LOCALE_NAME_MAX_LENGTH]; > + > + TRACE("(0x%04x,0x%08x,%s,%d,%p,%d)\n", > + lcid, flags, debugstr_wn(src, srclen), srclen, dst, dstlen); > + > + if (!LCIDToLocaleName(lcid, locale, LOCALE_NAME_MAX_LENGTH, 0)) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return 0; > + } I don't think it makes sense to do name conversion for a parameter that isn't used. If we use it someday it will most likely be to look up a conversion table directly from the lcid. -- Alexandre Julliard julliard(a)winehq.org

June 26, 2012

Re: configure: Add -linotify when present, for non-Linux platforms.

by Alexandre Julliard

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

June 26, 2012

Re: windowscodecs: Implement MetadataHandler_GetValue.

by Dmitry Timoshkov

Vincent Povirk <madewokherd(a)gmail.com> wrote: > > + case VT_I8: > > + case VT_UI8: > > + case VT_R8: > > + return v1->u.uhVal.QuadPart - v2->u.uhVal.QuadPart; > > Won't this only compare the low part on x86? In reality the only possible variant type supposed to be seen by this helper is VT_UI2, everything else is just for the sake of completeness. -- Dmitry.

June 26, 2012

Re: windowscodecs: Implement MetadataHandler_GetValue.

by Vincent Povirk

> + case VT_I8: > + case VT_UI8: > + case VT_R8: > + return v1->u.uhVal.QuadPart - v2->u.uhVal.QuadPart; Won't this only compare the low part on x86?

June 26, 2012

Re: [PATCH 3/5] secur32: Handle incomplete messages in schan_InitializeSecurityContextW().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19560 Your paranoid android. === WNT4WSSP6 (32 bit schannel) === schannel.c:702: Test failed: Got unexpected status 0x80090308.

June 26, 2012

[PATCH] winepulse.drv: Add PulseAudio driver

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, >If you don't paste all the mmdevapi tests with the fix in my git tree, it's a >regression. I don't want to see held_Frames because it's a shadow buffer. >If winmm and dsound don't work without it, they're wrong, fix those. I won't comment on the two individual pulseaudio drivers. Unfortunately, none of the two authors bothered to point me to a verbose log of the mmdevapi tests for my scrutiny. The tests should pass like they do on native. Regarding latency, I'm not aware of a flaw in Wine's winmm. HOWEVER, Wine's DSound needs a patch. Here the reason. To recap, latency is somehow related to the "distance" between what one hears and the PCM frames sent to the device. GetPosition is the only API call in that area in both winmm and mmdevapi. Buffer size is a completely different thing. I find it useful to have in mind a cascade of audio filters performing some buffering each. Then it's obvious that an app only sees the frontmost buffer size and knows nothing about the others. High latencies imply that there must be some large buffer space(s), somewhere. Period is an artificial entity related to how often the frontmost buffer is drained to feed the next buffer in the chain, in case that happens regularly. This is not guaranteed nor necessarily documented. You get the idea: regardless of arbitrary (front) buffer sizes and periods not worth this name, try and send a stable flow of data to play music without glitches and let explosions be heard ASAP. So far the situation, now the issue. It appears easier to write code that provides (frontmost) buffer space behaviour similar to native than one that provides similar latency. Alas, behaviour observable on MS-Windows differs from what we get with PulseAudio and some ALSA devices. Tests seem to indicate a latency of around 30-70ms from mmdevapi with MS-Windows. That good enough for games. OTOH if ALSA or PA gives us 2 seconds on Linux, that's a big cause of trouble. The authors of MS apps could never test them in an environment with such high latency. What happens with software not tested? It happens not to work. Two solutions: - Reduce actual latency or - lie about latency. Lying about latency causes apps to loose the ability to sync audio and video. However, given a choice between loss of lip sync and possible crashes or other weird behaviour because an app is executed in a environment that its developers never experienced, I consider the loss of lip sync to be less worrying. We designed the winealsa driver to accomodate an arbitrary latency and accept a large variation of periods. (Some bug report from Jack users seem to imply that it should accept even larger periods, e.g. 150ms, yet still pretend to use 10ms on the mmdevapi side). We choose to have the winealsa driver not lie about latency. That should be left to high level APIs. DirectSound is built around the "Direct" HW (lack of) abstraction: a circular buffer of samples is played by a DAC. The converted signal is immediately sent to the speaker. Hence: 1. GetPosition information in the DSound abstraction translates to a "playpos" -- well known. 2. No provision is made for additional buffering. The playpos must lie within the circular buffer. The reported free (writable) space shall never cross the playpos -- with subtle consequences. Wine's DSound needs a patch to ensure this second property. Given a 80ms primary buffer, Wine's DSound must not pretend its playpos is 2 seconds late! I think Wine should try and reduce latency but lie if that does not suffice. What's needed? 1. Have DSound always use a buffer large enough for typical situations (I believe 100-200ms). 2. Clamp the reported position such that it won't leave the (virtual) primary buffer. As a result, DSound must pretend to play even when Wine is solely pumping the huge 2s of cascading SW audio buffers. 3. Work on reducing the latency of the cascading audio filters. That device-level work is independent on the DSound one. Native's 30-70ms has the benefit that it nicely fits within typical DSound primary buffer sizes. PulseAudio's 2s does not (yet). I believe a total 80ms latency would be acceptable with games. Further areas of investigation and effort: - Maybe clamp latency in the mmdevapi drivers after all? After all, huge latencies are known to cause dead-locks in apps and we don't know what all apps or libraries built atop mmdevapi or winmm expect. (If yes, to what value? 150% buffer size?) - Try and find MS setups with huge latencies. USB headphones are said to be candidates, but I've yet to see an excellent and trustworthy report about what happens in that case. - Work on reducing the cascades of audio buffers - Work on further decoupling mmdevapi periods from UNIX audio API ones - Research the trade-off between glitch free playback and buffering in UNIX. The current settings in Wine's audio are IMHO not good enough yet. Regards, Jörg Höhle

June 26, 2012

Re: urlmon: Do not stop binding when OnDataAvailable() returns E_PENDING

by Jacek Caban

On 06/26/12 00:02, Andrew Talbot wrote: > Changelog: > urlmon: Do not stop binding when OnDataAvailable() returns E_PENDING. > > diff --git a/dlls/urlmon/binding.c b/dlls/urlmon/binding.c > index 58aed20..42eca4b 100644 > --- a/dlls/urlmon/binding.c > +++ b/dlls/urlmon/binding.c > @@ -1097,7 +1097,7 @@ static void report_data(Binding *This, DWORD bscf, ULONG progress, ULONG progres > > hres = IBindStatusCallback_OnDataAvailable(This->callback, bscf, progress, > &formatetc, &stgmed); > - if(hres != S_OK) { > + if(FAILED(hres) && hres != E_PENDING) { > if(This->download_state != END_DOWNLOAD) { > This->download_state = END_DOWNLOAD; > IBindStatusCallback_OnProgress(This->callback, progress, progress_max, Please add a test case. You may modify one of existing binding tests to use E_PENDING. Jacek

June 26, 2012

Re: Is it safe yet for developers to upgrade to Ubuntu 12.04?

by Daniel Jelinski

I don't know about compiling, but there are several other reasons to keep waiting, listed here: http://forum.winehq.org/viewtopic.php?t=15802 Regards, Daniel 2012/6/25, Erich E. Hoover <ehoover(a)mymail.mines.edu>: > I know that for a while there were some packaging problems that meant that > upgrading to 12.04 made compiling 32-bit Wine on a 64-bit PC extremely > difficult. Is this still the case? I'd like to upgrade to the new OS > version, but I'm not willing to sacrifice the ability to build Wine in > order to do so. Thanks in advance! > > Erich Hoover > ehoover(a)mines.edu >

June 26, 2012

Re: [PATCH] opengl32: Disable wglGetProcAddress for core GL 1.0/1.1 functions

by Roderick Colenbrander

On Mon, Jun 25, 2012 at 10:40 PM, Marvin <testbot(a)testbot.winehq.org> wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=19550 > > Your paranoid android. > > > === WINEBUILD (build) === > Patch failed to apply I don't think the test-bot didn't picked up the patch since the file it links to on the page is empty. Roderick

June 26, 2012

Re: [PATCH] opengl32: Disable wglGetProcAddress for core GL 1.0/1.1 functions

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19550 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

June 26, 2012