June 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] qedit/tests: Add COM aggregation test for MediaDet.

by Michael Stefaniuc

On 07/01/2012 12:12 AM, Marvin wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=19677 > > Your paranoid android. > > > === WNT4WSSP6 (32 bit mediadet) === > mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 > mediadet: unhandled exception c0000005 at 00401587 > > === W2KPROSP4 (32 bit mediadet) === > mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 > mediadet: unhandled exception c0000005 at 00401587 Both hosts miss qedit.dll. bye michael

June 30, 2012

Re: [PATCH 2/2] qedit/tests: Add COM aggregation test for MediaDet.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19677 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401587 === W2KPROSP4 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401587

June 30, 2012

Release schedule

by Alexandre Julliard

Folks, Because of various travels and vacations (and just to keep you on your toes ;-), during the month of July I'm planning to make releases on Tuesdays instead of Fridays. So 1.5.8 will be on July 3rd, and then I'll be out for the rest of that week. Subsequent releases should happen on July 17th and 31st, and I'll also be out the first 10 days of August. And if you find this confusing, just take some vacations too ;-) -- Alexandre Julliard julliard(a)winehq.org

June 30, 2012

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.

by Stefan Dösinger

Am Donnerstag, 28. Juni 2012, 20:50:15 schrieb Dmitry Timoshkov: > Obviosuly I'm not planning to add the casts everywhere, but the inline > constructs which specifically targeting the pointer to integer conversions > that imply truncation should compile without warnings IMHO. Fwiw, I fixed a number of double-to-float conversion warnings in MSVC in wined3d, d3d8 and d3d9 a while ago, as well as some similar integer issues. I fixed most of those warnings by using the proper data types and explicitly using float literals. I added a handful of casts in places where the API differences forced me to(d3d vs GL clipplanes if I remember correctly). >From my experience with wined3d the majority warnings(~90 %) from msvc made sense and pointed out potential bugs in the code. The rest were cases like the one Dmitry wants to patch where the API definitions force a conversion with potential data loss.

June 30, 2012

Re: windowscodecs: test for TIFFSetWarningHandlerExt

by Alexandre Julliard

Daniel Lehman <dlehman(a)esri.com> writes: > Fails to build on RHEL4 with libtiff 3.6.1 > > Alternative to this is a configure test for libtiff 3.8.0, which is when the function first appears I don't think this needs a configure test. Just define the prototype explicitly instead of using typeof. -- Alexandre Julliard julliard(a)winehq.org

June 29, 2012

Re: msvcp90: Fix __cdecl functions definitions that returns structures

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > In code produced by gcc callee removes hidden return argument. In code > produced by MS Visual Studio caller is responsible for removing the > hidden argument. That's only for structures larger than 8 bytes, which isn't the case at least for _Getcoll. Some tests would probably be a good idea. -- Alexandre Julliard julliard(a)winehq.org

June 29, 2012

Re: [1/5] d3dx9: Implement D3DXLoadVolumeFromMemory.

by Józef Kucia

On Thu, Jun 28, 2012 at 2:27 PM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > I'm not quite sure of the right and bottom misalignment checks. If the > tests confirm that, of course that's okay. > Native accepts misaligned boxes, but in order to implement it S3TC decompressor and compressor is needed. I'll make it a FIXME.

June 29, 2012

user32: Add test for ComboBox repositioning behavior (try 2).

by Sergey Guralnik

Marvin wrote 29.06.2012 10:14: > Hi, > > While running your changed tests on Windows, I think I found new > failures. > Being a bot and all I'm not very good at pattern recognition, so I > might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=19658 > > Your paranoid android. > > > === W7PRO (32 bit msg) === > msg.c:8219: Test failed: did not get zero count as expected (1). This is unrelated to my patch. -- Sergey

June 29, 2012

Re: user32: Add test for ComboBox repositioning behavior (try 2).

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19658 Your paranoid android. === W7PRO (32 bit msg) === msg.c:8219: Test failed: did not get zero count as expected (1).

June 29, 2012

Re: gdiplus: Add a test to show that GdipCloneImage is not supposed to increase refcount of the source image stream, but clone it instead.

by Dmitry Timoshkov

Vincent Povirk <madewokherd(a)gmail.com> wrote: > I think it's most likely not keeping the input stream in the new image at all. > > It's probably also worth testing SelectActiveFrame, GetPropertyItem, > and GetImageRawFormat with clones of images. Maybe they don't work. A quick test shows that SelectActiveFrame called on a clone of a multiframe gif image succeeds under nt4 and win2k, but fails under all later gdiplus implementations. Looks like a clone does not really clone anything. -- Dmitry.

June 29, 2012

Re: gdiplus: Add a test to show that GdipCloneImage is not supposed to increase refcount of the source image stream, but clone it instead.

by Vincent Povirk

I think it's most likely not keeping the input stream in the new image at all. It's probably also worth testing SelectActiveFrame, GetPropertyItem, and GetImageRawFormat with clones of images. Maybe they don't work.

June 29, 2012

Re: include: fix mingw64 build

by Nicolas Le Cam

2012/6/29 Austin English <austinenglish(a)gmail.com>: > On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: >> 2012/6/29 Austin English <austinenglish(a)gmail.com>: >>> Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 >>> >>> -- >>> -Austin >>> >>> >>> >> Hi Austin, >> >> I already tried to fix it on Wine side, see [1], >> but Alexandre told me on IRC that the bug needs to be fixed in mingw-w64, >> as it shouldn't include crtdefs.h by default. >> >> BTW, won't that break mingw32 build ? >> >> [1] http://source.winehq.org/patches/data/84070 >> >> -- >> Nicolas Le Cam > > Thanks for the info. Have you or anyone else discussed this with > mingw64? I did a quick search on their bugtracker, but don't see > anything.. > http://sourceforge.net/search/?group_artifact_id=983354&type_of_search=arti… > > -- > -Austin No I didn't take the time to report the issue. I cloned their repo and wanted to send a patch, unfortunately I didn't have the time to work on that actually. -- Nicolas Le Cam

June 29, 2012

Re: include: fix mingw64 build

by Austin English

On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > 2012/6/29 Austin English <austinenglish(a)gmail.com>: >> Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 >> >> -- >> -Austin >> >> >> > Hi Austin, > > I already tried to fix it on Wine side, see [1], > but Alexandre told me on IRC that the bug needs to be fixed in mingw-w64, > as it shouldn't include crtdefs.h by default. > > BTW, won't that break mingw32 build ? > > [1] http://source.winehq.org/patches/data/84070 > > -- > Nicolas Le Cam Thanks for the info. Have you or anyone else discussed this with mingw64? I did a quick search on their bugtracker, but don't see anything.. http://sourceforge.net/search/?group_artifact_id=983354&type_of_search=arti… -- -Austin

June 29, 2012

Re: include: fix mingw64 build

by Nicolas Le Cam

2012/6/29 Austin English <austinenglish(a)gmail.com>: > Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 > > -- > -Austin > > > Hi Austin, I already tried to fix it on Wine side, see [1], but Alexandre told me on IRC that the bug needs to be fixed in mingw-w64, as it shouldn't include crtdefs.h by default. BTW, won't that break mingw32 build ? [1] http://source.winehq.org/patches/data/84070 -- Nicolas Le Cam

June 29, 2012

Re: wbemprox: Add a Win32_LogicalDisk class stub.

by John Yani

NFS requests "Size" and "FreeSpace" fields. Not sure if it require them to be set.

June 28, 2012

Re: wbemprox: Add a Win32_LogicalDisk class stub.

by John Yani

So, is this patch good?

June 28, 2012

Re: wbemprox: Add a Win32_LogicalDisk class stub.

by Hans Leidekker

On Thu, 2012-06-28 at 22:22 +0300, John Yani wrote: > On 28 June 2012 22:17, Hans Leidekker <hans(a)codeweavers.com> wrote: > > On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote: > > That's better. Does NFS actually query the Caption and Description properties? > > > > > Well, no. I just thought the output should be similar to the one on > winetestbot: https://testbot.winehq.org/JobDetails.pl?Key=19642&log_201=1#k201 No, that's just a test I wrote to investigate this stuff.

June 28, 2012

Re: wbemprox: Add a Win32_LogicalDisk class stub.

by John Yani

On 28 June 2012 22:17, Hans Leidekker <hans(a)codeweavers.com> wrote: > On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote: >> +static void fill_logicaldisk( struct table *table ) >> +{ >> + static const WCHAR caption[] = >> + {'C',':',0}; >> + static const WCHAR description[] = >> + {'L','o','c','a','l',' ','F','i','x','e','d',' ','D','i','s','k',0}; >> + static const WCHAR device_id[] = >> + {'C',':',0}; >> + struct record_logicaldisk *rec; >> + FIXME("returns a fake logical disks table\n"); >> + if (!(table->data = heap_alloc( sizeof(*rec) ))) >> + { >> + return; >> + } >> + rec = (struct record_logicaldisk *)(table->data); >> + rec->caption = caption; >> + rec->description = description; >> + rec->device_id = device_id; >> + table->num_rows = 1; >> + TRACE("created %u row(s)\n", table->num_rows); > > That's better. Does NFS actually query the Caption and Description properties? > > Well, no. I just thought the output should be similar to the one on winetestbot: https://testbot.winehq.org/JobDetails.pl?Key=19642&log_201=1#k201

June 28, 2012

Re: wbemprox: Add a Win32_LogicalDisk class stub.

by Hans Leidekker

On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote: > +static void fill_logicaldisk( struct table *table ) > +{ > + static const WCHAR caption[] = > + {'C',':',0}; > + static const WCHAR description[] = > + {'L','o','c','a','l',' ','F','i','x','e','d',' ','D','i','s','k',0}; > + static const WCHAR device_id[] = > + {'C',':',0}; > + struct record_logicaldisk *rec; > + FIXME("returns a fake logical disks table\n"); > + if (!(table->data = heap_alloc( sizeof(*rec) ))) > + { > + return; > + } > + rec = (struct record_logicaldisk *)(table->data); > + rec->caption = caption; > + rec->description = description; > + rec->device_id = device_id; > + table->num_rows = 1; > + TRACE("created %u row(s)\n", table->num_rows); That's better. Does NFS actually query the Caption and Description properties?

June 28, 2012

Re: user32: Add a test for ComboBox WM_WINDOWPOSCHANGED handling.

by Alexandre Julliard

Sergey Guralnik <serhio(a)etersoft.ru> writes: > @@ -5807,6 +5830,25 @@ static void test_combobox_messages(void) > log_all_parent_messages--; > ok_sequence(WmKeyDownComboSeq, "WM_KEYDOWN/VK_DOWN on a ComboBox", FALSE); > > + wp.hwnd = combo; > + wp.hwndInsertAfter = HWND_TOP; > + wp.cx = wp.cy = wp.x = wp.y = 50; > + wp.flags = 0; > + flush_sequence(); > + SendMessage(combo, WM_WINDOWPOSCHANGED, 0, (LPARAM)&wp); It doesn't make much sense to send this message directly. What are you trying to test? -- Alexandre Julliard julliard(a)winehq.org

June 28, 2012

Re: [2/2] gdiplus: Increase refcount of the source stream when loading a bitmap instead of cloning it.

by Vincent Povirk

This looks good to me. (I didn't think it was necessary to comment, but this is an important fix and I was surprised it was still New.)

June 28, 2012

Re: Unused msvcp60 functions

by Piotr Caban

On 06/28/12 16:33, Francois Gouget wrote: > Actually there are some implementation differences between msvcp60's and > msvcp90's misc.c code. In particular for the init_lockit(), > free_lockit() and various _Lockit_ctor_*() functions. Are the two > implementations supposed to be identical? I forgot that functions in this file were changed. This implementations are not supposed to be identical. > There's no indication that the > two misc.c files are supposed to remain synchronized but if that's the > goal, one option would be to move the msvcp90-specific functions to > another file so that it remains easy to copy and/or diff these two > misc.c files. All files in msvcp60 and msvcp90 will be quite similar. So it's useful if diff is minimal/readable. But I don't think that splitting most of the files (so some files may be copied) is useful. > Also a lot of functions actually rely on forwarding to msvcp90. Should > this be used for the misc.c functions too? Only if functions are operating on identical object in msvcp60 and msvcp90. I was trying to forward functions when it was possible.

June 28, 2012

Re: Unused msvcp60 functions

by Francois Gouget

On Thu, 28 Jun 2012, Piotr Caban wrote: [...] > The function were not removed to make msvcp60 and msvcp90 more similar > (and probably because I didn't use -Wunused-function option). Thanks to > it one can copy misc.c file between the dlls when it's modified. Actually there are some implementation differences between msvcp60's and msvcp90's misc.c code. In particular for the init_lockit(), free_lockit() and various _Lockit_ctor_*() functions. Are the two implementations supposed to be identical? There's no indication that the two misc.c files are supposed to remain synchronized but if that's the goal, one option would be to move the msvcp90-specific functions to another file so that it remains easy to copy and/or diff these two misc.c files. Also a lot of functions actually rely on forwarding to msvcp90. Should this be used for the misc.c functions too? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ There are 10 types of people in the world... those who understand binary and those who don't.

June 28, 2012

Re: windowscodecs: Make sure that stream is not reused once the decoder is initialized.

by Vincent Povirk

Looks good to me.

June 28, 2012

mshtml: Always set the URL policy in the error cases?

by Francois Gouget

gcc 4.7 is complaining that policy may be used uninitialized in InternetHostSecurityManager_QueryCustomPolicy() and indeed there are many error cases in confirm_safety_load() and confirm_safety() where the policy is not set. The patch belowe seems to plug all these holes but I don't know if it really makes sense. diff --git a/dlls/mshtml/secmgr.c b/dlls/mshtml/secmgr.c index ff349ac..3f64a42 100644 --- a/dlls/mshtml/secmgr.c +++ b/dlls/mshtml/secmgr.c @@ -104,10 +104,9 @@ static HRESULT confirm_safety_load(HTMLDocumentNode *This, struct CONFIRMSAFETY CATID init_catid = CATID_SafeForInitializing; hres = ICatInformation_IsClassOfCategories(This->catmgr, &cs->clsid, 1, &init_catid, 0, NULL); + *ret = hres == S_OK ? URLPOLICY_ALLOW : URLPOLICY_DISALLOW; if(FAILED(hres)) return hres; - - *ret = hres == S_OK ? URLPOLICY_ALLOW : URLPOLICY_DISALLOW; } return S_OK; @@ -157,13 +156,17 @@ static HRESULT confirm_safety(HTMLDocumentNode *This, const WCHAR *url, struct C if(!This->catmgr) { hres = CoCreateInstance(&CLSID_StdComponentCategoriesMgr, NULL, CLSCTX_INPROC_SERVER, &IID_ICatInformation, (void**)&This->catmgr); - if(FAILED(hres)) + if(FAILED(hres)) { + *ret = URLPOLICY_DISALLOW; return hres; + } } hres = ICatInformation_IsClassOfCategories(This->catmgr, &cs->clsid, 1, &scripting_catid, 0, NULL); - if(FAILED(hres)) + if(FAILED(hres)) { + *ret = URLPOLICY_DISALLOW; return hres; + } if(hres != S_OK) { *ret = URLPOLICY_DISALLOW; -- 1.7.10

June 28, 2012