June 2012 - Wine-Devel - list.winehq.org

Re: gdiplus: Add a test to show that GdipCloneImage is not supposed to increase refcount of the source image stream, but clone it instead.

by Vincent Povirk

I think it's most likely not keeping the input stream in the new image at all. It's probably also worth testing SelectActiveFrame, GetPropertyItem, and GetImageRawFormat with clones of images. Maybe they don't work.

June 29, 2012

Re: include: fix mingw64 build

by Nicolas Le Cam

2012/6/29 Austin English <austinenglish(a)gmail.com>: > On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: >> 2012/6/29 Austin English <austinenglish(a)gmail.com>: >>> Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 >>> >>> -- >>> -Austin >>> >>> >>> >> Hi Austin, >> >> I already tried to fix it on Wine side, see [1], >> but Alexandre told me on IRC that the bug needs to be fixed in mingw-w64, >> as it shouldn't include crtdefs.h by default. >> >> BTW, won't that break mingw32 build ? >> >> [1] http://source.winehq.org/patches/data/84070 >> >> -- >> Nicolas Le Cam > > Thanks for the info. Have you or anyone else discussed this with > mingw64? I did a quick search on their bugtracker, but don't see > anything.. > http://sourceforge.net/search/?group_artifact_id=983354&type_of_search=arti… > > -- > -Austin No I didn't take the time to report the issue. I cloned their repo and wanted to send a patch, unfortunately I didn't have the time to work on that actually. -- Nicolas Le Cam

June 29, 2012

Re: include: fix mingw64 build

by Austin English

On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > 2012/6/29 Austin English <austinenglish(a)gmail.com>: >> Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 >> >> -- >> -Austin >> >> >> > Hi Austin, > > I already tried to fix it on Wine side, see [1], > but Alexandre told me on IRC that the bug needs to be fixed in mingw-w64, > as it shouldn't include crtdefs.h by default. > > BTW, won't that break mingw32 build ? > > [1] http://source.winehq.org/patches/data/84070 > > -- > Nicolas Le Cam Thanks for the info. Have you or anyone else discussed this with mingw64? I did a quick search on their bugtracker, but don't see anything.. http://sourceforge.net/search/?group_artifact_id=983354&type_of_search=arti… -- -Austin

June 29, 2012

Re: include: fix mingw64 build

by Nicolas Le Cam

2012/6/29 Austin English <austinenglish(a)gmail.com>: > Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 > > -- > -Austin > > > Hi Austin, I already tried to fix it on Wine side, see [1], but Alexandre told me on IRC that the bug needs to be fixed in mingw-w64, as it shouldn't include crtdefs.h by default. BTW, won't that break mingw32 build ? [1] http://source.winehq.org/patches/data/84070 -- Nicolas Le Cam

June 29, 2012

Re: wbemprox: Add a Win32_LogicalDisk class stub.

by John Yani

NFS requests "Size" and "FreeSpace" fields. Not sure if it require them to be set.

June 28, 2012

Re: wbemprox: Add a Win32_LogicalDisk class stub.

by John Yani

So, is this patch good?

June 28, 2012

Re: wbemprox: Add a Win32_LogicalDisk class stub.

by Hans Leidekker

On Thu, 2012-06-28 at 22:22 +0300, John Yani wrote: > On 28 June 2012 22:17, Hans Leidekker <hans(a)codeweavers.com> wrote: > > On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote: > > That's better. Does NFS actually query the Caption and Description properties? > > > > > Well, no. I just thought the output should be similar to the one on > winetestbot: https://testbot.winehq.org/JobDetails.pl?Key=19642&log_201=1#k201 No, that's just a test I wrote to investigate this stuff.

June 28, 2012

Re: wbemprox: Add a Win32_LogicalDisk class stub.

by John Yani

On 28 June 2012 22:17, Hans Leidekker <hans(a)codeweavers.com> wrote: > On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote: >> +static void fill_logicaldisk( struct table *table ) >> +{ >> + static const WCHAR caption[] = >> + {'C',':',0}; >> + static const WCHAR description[] = >> + {'L','o','c','a','l',' ','F','i','x','e','d',' ','D','i','s','k',0}; >> + static const WCHAR device_id[] = >> + {'C',':',0}; >> + struct record_logicaldisk *rec; >> + FIXME("returns a fake logical disks table\n"); >> + if (!(table->data = heap_alloc( sizeof(*rec) ))) >> + { >> + return; >> + } >> + rec = (struct record_logicaldisk *)(table->data); >> + rec->caption = caption; >> + rec->description = description; >> + rec->device_id = device_id; >> + table->num_rows = 1; >> + TRACE("created %u row(s)\n", table->num_rows); > > That's better. Does NFS actually query the Caption and Description properties? > > Well, no. I just thought the output should be similar to the one on winetestbot: https://testbot.winehq.org/JobDetails.pl?Key=19642&log_201=1#k201

June 28, 2012

Re: wbemprox: Add a Win32_LogicalDisk class stub.

by Hans Leidekker

On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote: > +static void fill_logicaldisk( struct table *table ) > +{ > + static const WCHAR caption[] = > + {'C',':',0}; > + static const WCHAR description[] = > + {'L','o','c','a','l',' ','F','i','x','e','d',' ','D','i','s','k',0}; > + static const WCHAR device_id[] = > + {'C',':',0}; > + struct record_logicaldisk *rec; > + FIXME("returns a fake logical disks table\n"); > + if (!(table->data = heap_alloc( sizeof(*rec) ))) > + { > + return; > + } > + rec = (struct record_logicaldisk *)(table->data); > + rec->caption = caption; > + rec->description = description; > + rec->device_id = device_id; > + table->num_rows = 1; > + TRACE("created %u row(s)\n", table->num_rows); That's better. Does NFS actually query the Caption and Description properties?

June 28, 2012

Re: user32: Add a test for ComboBox WM_WINDOWPOSCHANGED handling.

by Alexandre Julliard

Sergey Guralnik <serhio(a)etersoft.ru> writes: > @@ -5807,6 +5830,25 @@ static void test_combobox_messages(void) > log_all_parent_messages--; > ok_sequence(WmKeyDownComboSeq, "WM_KEYDOWN/VK_DOWN on a ComboBox", FALSE); > > + wp.hwnd = combo; > + wp.hwndInsertAfter = HWND_TOP; > + wp.cx = wp.cy = wp.x = wp.y = 50; > + wp.flags = 0; > + flush_sequence(); > + SendMessage(combo, WM_WINDOWPOSCHANGED, 0, (LPARAM)&wp); It doesn't make much sense to send this message directly. What are you trying to test? -- Alexandre Julliard julliard(a)winehq.org

June 28, 2012