June 2012 - Wine-Devel - list.winehq.org

Re: Fix the FIXME message to reflect the real problem.

by Juan Lang

On Mon, Jun 4, 2012 at 2:19 AM, Piotr Caban <piotr.caban(a)gmail.com> wrote: > On 06/02/12 13:35, max(a)mtew.isa-geek.net wrote: >> >> @@ -2735,7 +2735,7 @@ static BOOL CommitUrlCacheEntryInternal( >> goto cleanup; >> } >> >> - FIXME("entry already in cache - don't know what to do!\n"); >> + FIXME("collision handler needed - the entry is already in >> use!\n"); > > This message is not about entry being used. I think the old message is quite > accurate. The "don't know what to do" part is quite strange but I don't see > reason to change it. I agree. The reason we get these all the time is that we never fulfill requests from cache, but we do write to the cache, so for all potential cache hits, we write duplicate cache entries. After 4 entries have been written, we begin to see the fixme. If this message is annoying, it's working: we need to start fulfilling requests from cache, instead of just filling up users' hard drives. --Juan

June 4, 2012

Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono

by Vincent Povirk

Actually, now that I'm looking at the script a little more carefully, it doesn't actually install anything, just puts the installers in a place where Wine can find them. So if you already have native .NET installed, you won't get wine-mono in your prefix. If you're planning to install it, I'd argue that letting it install and letting winetricks remove it is faster than dismissing the dialog. It seems it would make sense to continue grabbing all the stable versions as new ones come out, since old versions of Wine will look for the old .msi installers. Sorry I misled you earlier, Dan.

June 4, 2012

re: comctl: allow label edit only if treeview style allows editing

by Dan Kegel

> I stopped doing > make test on my machine some time ago Bad developer, no donut :-) > , when I found out that some > tests do consistently fail on my machine (clean prefix or not), and > others consistently hang, thus preventing make test -k. I had the same problem, and wrote a little script to skip the bad tests. It was written for buildbot, but can be run standalone. Try downloading http://winezeug.googlecode.com/svn/trunk/buildbot/dotests.sh and http://winezeug.googlecode.com/svn/trunk/buildbot/dotests_blacklist.txt then run sh dotests.sh goodtests That will skip all the tests known to hang or fail. (The list might be a bit out of date, but it's easy to add new tests to the blacklist.) > I don't install wine-gecko, maybe that's the reason. Run https://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh then you'll never have to install it again. (Until it's updated, anyway.) - Dan

June 4, 2012

Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono

by Rosanne DiMesio

On Mon, 4 Jun 2012 06:24:26 -0700 Dan Kegel <dank(a)kegel.com> wrote: > >> The point of this script is to make life easier for me and > >> for the average user. It's not to make life easier for > >> people who don't like mono, mostly because I doubt > >> there are many of them. > There are many average users using apps that require real .NET. It doesn't make sense to force them to install mono and then have to uninstall it. -- Rosanne DiMesio <dimesio(a)earthlink.net>

June 4, 2012

Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono

by Dan Kegel

On Mon, Jun 4, 2012 at 12:05 AM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: >>> Wouldn't it be better (and more acceptable for people >>> disliking/wanting to avoid mono) to >>> - keep install-gecko.sh as is >>> - create install-mono.sh >>> - create wine-install-addons.sh calling the former >>> ? >> >> The point of this script is to make life easier for me and >> for the average user. It's not to make life easier for >> people who don't like mono, mostly because I doubt >> there are many of them. > > My comment was not only meant for "mono-haters", but it can also be > useful IMHO to split e.g. to limit download size.when one doesn't even > need mono, and it maybe clearer as well ("addons" is pretty generic). The script only has to be run once, so download size isn't really an issue. From the user's point of view, having a single script to get rid of all the !#&# download prompts is ideal, and splitting it would add complexity. - Dan

June 4, 2012

Re: comctl: allow label edit only if treeview style allows editing

by Daniel Jelinski

2012/6/4 Alexandre Julliard <julliard(a)winehq.org>: > Daniel Jelinski <djelinski1(a)gmail.com> writes: > >> From 21d26b76560f0c15a3d302883efa2d41d940a093 Mon Sep 17 00:00:00 2001 >> From: Daniel Jelinski <djelinski1(a)gmail.com> >> Date: Sat, 2 Jun 2012 07:23:32 +0200 >> Subject: comctl: allow label edit only if treeview style allows editing >> >> Native comctl behaves this way - noticed when debugging regedit > > It breaks the tests: > > ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so brsfolder.c && touch brsfolder.ok > brsfolder.c:225: Test failed: The new folder did not get the name foo > brsfolder.c:232: Test failed: SHBrowseForFolder did not return the pidl for the new folder. Expected 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\foo' got 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\New Folder' > make: *** [brsfolder.ok] Error 2 Ah, thank you for this information. I'll look into it. I stopped doing make test on my machine some time ago, when I found out that some tests do consistently fail on my machine (clean prefix or not), and others consistently hang, thus preventing make test -k. I don't install wine-gecko, maybe that's the reason. -- Regards, Daniel

June 4, 2012

Re: comctl: allow label edit only if treeview style allows editing

by Alexandre Julliard

Daniel Jelinski <djelinski1(a)gmail.com> writes: > From 21d26b76560f0c15a3d302883efa2d41d940a093 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Sat, 2 Jun 2012 07:23:32 +0200 > Subject: comctl: allow label edit only if treeview style allows editing > > Native comctl behaves this way - noticed when debugging regedit It breaks the tests: ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so brsfolder.c && touch brsfolder.ok brsfolder.c:225: Test failed: The new folder did not get the name foo brsfolder.c:232: Test failed: SHBrowseForFolder did not return the pidl for the new folder. Expected 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\foo' got 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\New Folder' make: *** [brsfolder.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

June 4, 2012

Re: [scrrun] Add initial support for Dictionary patch - 1/3

by Alistair Leslie-Hughes

Hi Vijay, On 4/06/2012 8:06 PM, Vijay Kiran Kamuju wrote: > Sending patch series for initial support for Scripting.Dictionary in scrrun.dll > > +static HRESULT WINAPI dictionary_put_Item(IDictionary *iface, VARIANT *key, VARIANT *item) > +{ > + FIXME("%p %p\n", iface, key); Please include all parameters in FIXME, they all seem to be missing the last one. Best Regards Alistair Leslie-Hughes

June 4, 2012

Re: [scrrun] Add initial support for Dictionary patch - 1/3

by Jacek Caban

Hi Vijay On 06/04/12 12:06, Vijay Kiran Kamuju wrote: > Sending patch series for initial support for Scripting.Dictionary in scrrun.dll > > The first patch will add dictionary.c > The second will add the necessary changes to Makefile and the scrrun.c > (mistake done will doing git commit - hence two patches) This split doesn't make sense. Please merge those patches. +static ULONG WINAPI dictionary_AddRef(IDictionary *iface) +{ + TRACE("%p\n", iface); + + return 2; +} + +static ULONG WINAPI dictionary_Release(IDictionary *iface) +{ + TRACE("%p\n", iface); + + return 1; +} Dictionary object should be heap-based. That requires proper reference counting and object structure. Cheers, Jacek

June 4, 2012

Re: [scrrun] - Add initial support for Dictionary - tests - patch 3/3

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18733 Your paranoid android. === WINEBUILD (build) === Make failed

June 4, 2012