June 2012 - Wine-Devel - list.winehq.org

Re: oleaut32: Add a test for BSTR cache.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18731 Your paranoid android. === W2KPROSP4 (32 bit vartype) === vartype.c:6166: Test failed: good_length_entries 98 out of 256 === WXPPROSP3 (32 bit vartype) === vartype.c:6166: Test failed: good_length_entries 99 out of 256

June 4, 2012

Re: [PATCH 1/2] joystick.cpl: First version of the joystick configuration applet

by Alexandre Julliard

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > This adds a control panel applet to configure the joysticks. It is > a property sheet and has 3 pages: > > * Joystick listing > * Axes and Button Testing > * Force Feedback testing > > All the function are stubs at the moment, the panel has no icon too. > > --- > configure.ac | 1 + > dlls/joystick.cpl/Makefile.in | 14 +++ > dlls/joystick.cpl/forcefeedback.c | 60 +++++++++++ > dlls/joystick.cpl/joystick.cpl.spec | 3 + > dlls/joystick.cpl/joystick.h | 63 ++++++++++++ > dlls/joystick.cpl/joystick.rc | 55 ++++++++++ > dlls/joystick.cpl/list.c | 57 +++++++++++ > dlls/joystick.cpl/main.c | 191 +++++++++++++++++++++++++++++++++++ > dlls/joystick.cpl/test.c | 60 +++++++++++ > 9 files changed, 504 insertions(+) > create mode 100644 dlls/joystick.cpl/Makefile.in > create mode 100644 dlls/joystick.cpl/forcefeedback.c > create mode 100644 dlls/joystick.cpl/joystick.cpl.spec > create mode 100644 dlls/joystick.cpl/joystick.h > create mode 100644 dlls/joystick.cpl/joystick.rc > create mode 100644 dlls/joystick.cpl/list.c > create mode 100644 dlls/joystick.cpl/main.c > create mode 100644 dlls/joystick.cpl/test.c It's called joy.cpl on Windows. Please also use compatible exports, and avoid creating a lot of empty source files. I'd expect that a single source file is sufficient for this. -- Alexandre Julliard julliard(a)winehq.org

June 4, 2012

Re: Fix the FIXME message to reflect the real problem.

by Piotr Caban

On 06/02/12 13:35, max(a)mtew.isa-geek.net wrote: > @@ -2735,7 +2735,7 @@ static BOOL CommitUrlCacheEntryInternal( > goto cleanup; > } > > - FIXME("entry already in cache - don't know what to do!\n"); > + FIXME("collision handler needed - the entry is already in use!\n"); This message is not about entry being used. I think the old message is quite accurate. The "don't know what to do" part is quite strange but I don't see reason to change it.

June 4, 2012

Re: [PATCH 1/4] server: Move completion from async object to async queue.

by Alexandre Julliard

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > Sorry I didn't reply to this sooner, I've been at a wedding at just > got back to the land of the Internet. I believe that it really does > need to be stored in the queue, otherwise in the case that the async > operation has not completed when the file descriptor is closed then > the cancel completion will not be able to propagate. I don't think that you can have an async queue that outlives its file descriptor. -- Alexandre Julliard julliard(a)winehq.org

June 4, 2012

Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono

by Frédéric Delanoy

On Mon, Jun 4, 2012 at 8:35 AM, Dan Kegel <dank(a)kegel.com> wrote: > On Sun, Jun 3, 2012 at 11:20 PM, Frédéric Delanoy > <frederic.delanoy(a)gmail.com> wrote: >> On Sun, Jun 3, 2012 at 7:02 PM, Dan Kegel <daniel.r.kegel(a)gmail.com> wrote: >>> http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh now >>> also installs mono. ... >> >> Wouldn't it be better (and more acceptable for people >> disliking/wanting to avoid mono) to >> - keep install-gecko.sh as is >> - create install-mono.sh >> - create wine-install-addons.sh calling the former >> ? > > The point of this script is to make life easier for me and > for the average user. It's not to make life easier for > people who don't like mono, mostly because I doubt > there are many of them. My comment was not only meant for "mono-haters", but it can also be useful IMHO to split e.g. to limit download size.when one doesn't even need mono, and it maybe clearer as well ("addons" is pretty generic). Frédéric

June 4, 2012

Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono

by Dan Kegel

On Sun, Jun 3, 2012 at 11:20 PM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > On Sun, Jun 3, 2012 at 7:02 PM, Dan Kegel <daniel.r.kegel(a)gmail.com> wrote: >> http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh now >> also installs mono. ... > > Wouldn't it be better (and more acceptable for people > disliking/wanting to avoid mono) to > - keep install-gecko.sh as is > - create install-mono.sh > - create wine-install-addons.sh calling the former > ? The point of this script is to make life easier for me and for the average user. It's not to make life easier for people who don't like mono, mostly because I doubt there are many of them. - Dan

June 4, 2012

Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono

by Frédéric Delanoy

On Sun, Jun 3, 2012 at 7:02 PM, Dan Kegel <daniel.r.kegel(a)gmail.com> wrote: > http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh now > also installs mono. > > It should be probably be called wine-install-addons.sh now, maybe > I'll rename it that soon. If you have a better idea for the name, > let me know. Wouldn't it be better (and more acceptable for people disliking/wanting to avoid mono) to - keep install-gecko.sh as is - create install-mono.sh - create wine-install-addons.sh calling the former ? Frédéric

June 4, 2012

Re: Wine in Humble Indie Bundle

by Dan Kegel

On Sun, Jun 3, 2012 at 5:16 PM, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > This comes up in one form or the other very often, though, doesn't it? > Company x releases software y with a Wine wrapper advertising "native linux > support" and users get upset. Personally, I'm glad they're thinking about > Linux and I think Wine fills a great role as a "transitional" step between > Windows and Linux, but I don't think it's any good to encourage using Wine > over making the game more portable. Besides, doesn't HIB have some rule > about requiring all games to support Linux natively? See http://www.reddit.com/r/IAmA/comments/ufxcg/were_humble_indie_bundle_v_crea… The guys who put together the indie bundle said -- snip -- The LIMBO Linux build was created by CodeWeavers who basically take a custom version of Wine and tune the game to make sure it runs flawlessly. This is our first experiment with CodeWeavers and we are watching carefully. If there are any bugs with the game, I don't want people to think "oh well, it uses Wine" -- these ought to be sent to CodeWeavers who should do their best to fix them. ... We typically help organize porting for the games in the bundle, and it's usually the toughest part! But we're rabid about trying to provide the best experience possible, and native ports usually do that. But in the case of LIMBO, our porting friends said there was some audio middleware that's not easily supported on Linux, we decided to see if we could experiment with another solution that could provide a rock-solid Linux gaming experience. CodeWeavers took it on—they do highly customized Linux wrappers to optimize specific pieces of software—and the prototypes worked incredibly well. They spent a lot of time tweaking and optimizing, and it passed their QA and our QA (and seemed to perform more consistently than even some of the native ports we've seen). But we get that software is hard, and so we'll try to keep an eye out for any showstoppers. Hit up contact(a)humblebundle.com with any issues and we'll make sure CodeWeavers hears about any LIMBO bugs that need fixing. -- snip -- So, no, they don't require games to be native, they just require them to run well. Regardless of whether a game is native, Java, or Wine, it's going to run into some problems post-release, and good game publishers will respond with fixes. - Dan

June 4, 2012

Re: Wine in Humble Indie Bundle

by Jerome Leclanche

On Mon, Jun 4, 2012 at 12:36 AM, Dan Kegel <dank(a)kegel.com> wrote: > Berillions wrote: > > the other petition does have a point about Wine not doing as well with > > sound as it should. > > Yes, there are some issues. > > For the record, here are a couple links to people talking about their > problems with the game: > http://askubuntu.com/questions/144915/limbo-game-has-no-sound > https://bbs.archlinux.org/viewtopic.php?id=142465 > ( from > http://www.reddit.com/r/IAmA/comments/ufxcg/were_humble_indie_bundle_v_crea… > ) > > Several people are trying to run it without proper graphics drivers, > and seeing crashes like the following; maybe Wine should > blacklist graphics drivers that can't handle common games? > > Unhandled exception: page fault on read access to 0xffffffff in 32-bit > code (0x7ca26b9b). > Backtrace: > =>0 0x7ca26b9b in swrast_dri.so (+0x195b9b) (0x00000000) > ... > 23 0x7e52ff27 Direct3DCreate9+0x66() in d3d9 (0x0033fa1c) > > > This comes up in one form or the other very often, though, doesn't it? Company x releases software y with a Wine wrapper advertising "native linux support" and users get upset. Personally, I'm glad they're thinking about Linux and I think Wine fills a great role as a "transitional" step between Windows and Linux, but I don't think it's any good to encourage using Wine over making the game more portable. Besides, doesn't HIB have some rule about requiring all games to support Linux natively? J. Leclanche

June 4, 2012

Re: Wine in Humble Indie Bundle

by Dan Kegel

Berillions wrote: > the other petition does have a point about Wine not doing as well with > sound as it should. Yes, there are some issues. For the record, here are a couple links to people talking about their problems with the game: http://askubuntu.com/questions/144915/limbo-game-has-no-sound https://bbs.archlinux.org/viewtopic.php?id=142465 ( from http://www.reddit.com/r/IAmA/comments/ufxcg/were_humble_indie_bundle_v_crea… ) Several people are trying to run it without proper graphics drivers, and seeing crashes like the following; maybe Wine should blacklist graphics drivers that can't handle common games? Unhandled exception: page fault on read access to 0xffffffff in 32-bit code (0x7ca26b9b). Backtrace: =>0 0x7ca26b9b in swrast_dri.so (+0x195b9b) (0x00000000) ... 23 0x7e52ff27 Direct3DCreate9+0x66() in d3d9 (0x0033fa1c)

June 3, 2012