July 2012 - Wine-Devel - list.winehq.org

Re: "Complimentary" msvcrt?

by Vincent Povirk

> If there's some code I'd must write natively to bind the Windows app > to the Linux system (e.g. interacting with some low-level Linux stuff), > can I build that library as a DLL with wineg++ / winelib and have > the WINE-invoked app use that? Yes. This is what I meant by a bridge between Linux and Windows code. The easiest way to do this is with LoadLibrary and GetProcAddress, but linking to a winelib dll is also possible.

July 31, 2012

Re: "Complimentary" msvcrt?

by Ilya Konstantinov

On Wed, Aug 1, 2012 at 12:34 AM, Vincent Povirk <madewokherd(a)gmail.com> wrote: > Visual C++ ships with headers and a compiler. Anyway, there's no > advantage to winelib as a build environment compared to MSVC or the > Platform SDK, assuming you are able to use one of those, except for > the ability to port to architectures other than x86, x86_64, and arm. Oooh. Now I understand what you mean: build with MSVC as usual, run in WINE on Linux. Thanks for the patience :-) If there's some code I'd must write natively to bind the Windows app to the Linux system (e.g. interacting with some low-level Linux stuff), can I build that library as a DLL with wineg++ / winelib and have the WINE-invoked app use that?

July 31, 2012

Re: "Complimentary" msvcrt?

by Vincent Povirk

>>> 1) provide Windows headers, to keep those DWORDs etc. defined >> >> Yes, but so does MSVC. > > MSVC as in Microsoft Visual C++? It only provides a C/C++ runtime. The > headers come > from the Platform SDK. In any case, here Winelib provides them, > probably slightly altered > so they'd built better on gcc. Visual C++ ships with headers and a compiler. Anyway, there's no advantage to winelib as a build environment compared to MSVC or the Platform SDK, assuming you are able to use one of those, except for the ability to port to architectures other than x86, x86_64, and arm. >>> 2) implement Windows APIs in terms of Linux as much as possible -- to keep those >>> CreateFileWs going, to avoid changing every single 'Sleep' to 'sleep' >>> "just because". >> >> Winelib doesn't do that. It uses the same implementation of the >> Windows API that is in Wine. > > Sleep and CreateFileW are Windows APIs. I want them implemented > for my C code to link to. Internally, they call into libc or Linux syscalls. > How is Winelib not what I want? Wine's CreateFileW does path mapping to simulate a Windows filesystem, regardless of whether you're using winelib. It's not a thin wrapper around Linux API's; it's exactly the same wrapper you get if you run a normal Windows program. Because it's the same API implementation, it doesn't offer any advantage over running the same code compiled with Microsoft's C/C++ compiler (which according to rumor is faster and has a better optimizer), while there is a significant disadvantage in the form of the work it takes to make that code build correctly.

July 31, 2012

Re: "Complimentary" msvcrt?

by Ilya Konstantinov

On Tue, Jul 31, 2012 at 11:15 PM, Vincent Povirk <madewokherd(a)gmail.com> wrote: >> Winelib is there to: >> 1) provide Windows headers, to keep those DWORDs etc. defined > > Yes, but so does MSVC. MSVC as in Microsoft Visual C++? It only provides a C/C++ runtime. The headers come from the Platform SDK. In any case, here Winelib provides them, probably slightly altered so they'd built better on gcc. >> 2) implement Windows APIs in terms of Linux as much as possible -- to keep those >> CreateFileWs going, to avoid changing every single 'Sleep' to 'sleep' >> "just because". > > Winelib doesn't do that. It uses the same implementation of the > Windows API that is in Wine. Sleep and CreateFileW are Windows APIs. I want them implemented for my C code to link to. Internally, they call into libc or Linux syscalls. How is Winelib not what I want? > Perhaps the io-layer aka libwapi library in Mono is closer to what you > describe, but that is very limited and only intended for internal use > in Mono. Interesting. I'll check it out to see what they've been up to.

July 31, 2012

Re: "Complimentary" msvcrt?

by Vincent Povirk

> Winelib is there to: > 1) provide Windows headers, to keep those DWORDs etc. defined Yes, but so does MSVC. > 2) implement Windows APIs in terms of Linux as much as possible -- to keep those > CreateFileWs going, to avoid changing every single 'Sleep' to 'sleep' > "just because". Winelib doesn't do that. It uses the same implementation of the Windows API that is in Wine. Perhaps the io-layer aka libwapi library in Mono is closer to what you describe, but that is very limited and only intended for internal use in Mono.

July 31, 2012

Re: "Complimentary" msvcrt?

by Ilya Konstantinov

On Tue, Jul 31, 2012 at 10:42 PM, Vincent Povirk <madewokherd(a)gmail.com> wrote: > Winelib is not a useful intermediate step in porting an existing > application to Linux, as most of the work involved in porting to > winelib will not help you with a native Linux port. At some point you > have to make a clean break from Windows, and winelib doesn't change > that. It just provides a way to delay that painful step, while doing > little to reduce the pain when it comes. Why not use Winelib as an abstraction layer? Keep in mind my users are enterprise and they do not mind the perceived "unsexy-ness" of a non-native port. I'm not going to present them with fugly non-native GUI anyway. I have a big bulk of "headless" code coming from Windows CE, that was ported to Windows without much difficulty, and now its heading to Linux as well. Winelib is there to: 1) provide Windows headers, to keep those DWORDs etc. defined 2) implement Windows APIs in terms of Linux as much as possible -- to keep those CreateFileWs going, to avoid changing every single 'Sleep' to 'sleep' "just because". The code will keep running on Windows too. Why can't Winelib keep serving as a rudimentary abstraction layer, as funny as that might sound? Our use of Windows is pretty basic. I don't believe we use a single function whose signature you don't already know by heart. (Except, maybe, for CryptoAPI, but I don't rule out re-implementing that chunk.) The code is full of MSC-isms and MSVCRT-isms but it's nothing too bad. So, then, why not?

July 31, 2012

Re: "Complimentary" msvcrt?

by Vincent Povirk

I have to wonder if you're using winelib in a way that's not appropriate. Winelib is not a useful intermediate step in porting an existing application to Linux, as most of the work involved in porting to winelib will not help you with a native Linux port. At some point you have to make a clean break from Windows, and winelib doesn't change that. It just provides a way to delay that painful step, while doing little to reduce the pain when it comes. Nor is there typically any advantage to running existing Windows code with winelib compared to running a Windows exe or dll in Wine. While it's true that winelib can be used to port Windows code to a new CPU architecture not targeted by MSVC, there's not much demand for this. Most people who think they want to use winelib want to do one of those things and don't realize that winelib doesn't solve any of their problems. Almost no one has a real use case for building existing Windows code with winelib. Given that, improving winelib's Windows source compatibility doesn't make it much more useful, and it probably isn't worth anyone's time. Winelib works best to support a limited amount of new code (a single .dll.so or .exe.so) that acts as a bridge between Linux and Windows code.

July 31, 2012

"Complimentary" msvcrt?

by Ilya Konstantinov

Hey, I apologize for the flood of "newbie" questions coming from me lately :-) At the very least, I'll be giving Winelib a decent challenge, and perhaps we could improve it a bit... Now, I've seen that Wine re-implements MSVCRT. However, this is a drop-in MSVCRT.DLL replacement, and it's incompatible with the rest of the GNU toolchain; for example, the GNU libstdc++ barfs on trying to include its own <wchar.h> and ending up including the msvcrt/wchar.h instead. I'm looking for something more humble -- a library for easy porting, implementing those functions not implemented by glibc itself -- e.g. _wfopen, _wgetenv. In fact, many MSVCRT functions can be made available by simply #define-ing them to their glibc counterparts. (Of course, this should be done carefully.) The main goal of this library should be source-level compatibility. Does such a thing exist? P.S. I know "real men" port their code to "real glibc", but I believe in taking small steps for bringing Linux into our codebase, thus decreasing friction with the rest of the developers.

July 31, 2012

Re: [2/2] msi: Try the registered install location first when resolving the target directory.

by Alexandre Julliard

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/msi/action.c | 18 +++++++++++++++--- > dlls/msi/msipriv.h | 1 + > 2 files changed, 16 insertions(+), 3 deletions(-) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so ../../../../wine/dlls/msi/tests/package.c && touch package.ok wine: Unhandled page fault on read access to 0x20006308e at address 0x2b39152590cf (thread 002c), starting debugger... Unhandled exception: page fault on read access to 0x20006308e in 64-bit code (0x00002b39152590cf). Register dump: rip:00002b39152590cf rsp:000000000022f700 rbp:0000000000000001 eflags:00010246 ( R- -- I Z- -P- ) rax:0000000000063090 rbx:0000000000000002 rcx:00000000000666c2 rdx:0000000000000000 rsi:0000000000000000 rdi:0000000000000001 r8:0000000000000010 r9:000000000022f790 r10:000000000022f740 r11:000000020006308e r12:0000000000062f10 r13:0000000000000000 r14:000000000005f1f8 r15:00002b39136f0d90 Stack dump: 0x000000000022f700: 0000000000000000 0000000000000000 0x000000000022f710: 0000000000000000 0000000000000000 0x000000000022f720: 0000000000000000 0000000000000008 0x000000000022f730: 000000000022f790 000000000022f740 0x000000000022f740: 00002b39136f0d90 00000000000666c0 0x000000000022f750: 00000000000658e0 0000000000063042 0x000000000022f760: 0000000000000054 000000000005f228 0x000000000022f770: 0000000000000000 0000000000065810 0x000000000022f780: 000000000005f190 00002b391525ae9c 0x000000000022f790: 0000000000000000 0000000000000000 0x000000000022f7a0: 00002b39136f0d90 00002b391528a1fc 0x000000000022f7b0: 0000000000064f00 0000000000000030 Backtrace: =>0 0x00002b39152590cf msi_build_directory_name+0x25f(count=0x2) [/home/julliard/wine/build/obj-elf64/dlls/msi/../../../wine/dlls/msi/action.c:2157] in msi (0x0000000000000001) 1 0x00002b391525ae9c ACTION_CostFinalize+0x35b(package=0x5f190) [/home/julliard/wine/build/obj-elf64/dlls/msi/../../../wine/dlls/msi/action.c:2179] in msi (0x000000000005f190) 2 0x00002b391524e45b ACTION_HandleStandardAction+0xba(package=0x5f190, action="CostFinalize", rc=0x22f85c) [/home/julliard/wine/build/obj-elf64/dlls/msi/../../../wine/dlls/msi/action.c:7397] in msi (0x000000000022f85c) 3 0x00002b391525d877 ACTION_PerformUIAction+0x46(package=0x5f190, action="CostFinalize", script=0xffffffff) [/home/julliard/wine/build/obj-elf64/dlls/msi/../../../wine/dlls/msi/action.c:7448] in msi (0x0000000000059f20) 4 0x00002b391528b1d3 MsiDoActionW+0xc2(hInstall=0x2, szAction="CostFinalize") [/home/julliard/wine/build/obj-elf64/dlls/msi/../../../wine/dlls/msi/install.c:108] in msi (0x0000000000000057) 5 0x00002b391528b436 MsiDoActionA+0x105(hInstall=0x2, szAction="CostFinalize") [/home/julliard/wine/build/obj-elf64/dlls/msi/../../../wine/dlls/msi/install.c:56] in msi (0x00002b3914b9af00) 6 0x00002b3914b5fabe func_package+0x45cd() [/home/julliard/wine/build/obj-elf64/dlls/msi/tests/../../../../wine/dlls/msi/tests/package.c:3017] in msi_test (0x000000000022fadc) 7 0x00002b3914a922aa main+0x2c9(argc=<internal error>, argv=<internal error>) [/home/julliard/wine/build/obj-elf64/dlls/msi/tests/../../../../wine/include/wine/test.h:557] in msi_test (0x00002b3914dc2fe0) 8 0x00002b3914b7b1b2 __wine_spec_exe_entry+0xa1(peb=<internal error>) [/home/julliard/wine/build/obj-elf64/dlls/winecrt0/../../../wine/dlls/winecrt0/exe_entry.c:36] in msi_test (0x00002b39131238f0) 9 0x000000007b873391 start_process+0xb0(peb=0x7fffffbef000) [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1052] in kernel32 (0x00002b3914b7b110) 10 0x00002b39139889de call_thread_func+0x6d(entry=0x7b8732e0, arg=0x7fffffbef000, frame=<internal error>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/signal_x86_64.c:3230] in ntdll (0x00007fff5dbb09f0) 11 0x00002b39139820ca call_thread_entry_point+0x29() in ntdll (0x00007fff5dbb09f0) 12 0x00002b39139549d6 start_process+0x15(kernel_start=<internal error>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2653] in ntdll (0x00007fff5dbb09f0) 13 0x00002b3912dfd283 wine_call_on_stack+0x12() in libwine.so.1 (0x00007fff5dbb09f0) 14 0x00002b3912dfd2d9 wine_switch_to_stack+0x8(func=<internal error>, arg=<internal error>, stack=<internal error>) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/port.c:59] in libwine.so.1 (0x00007fffffbef000) 15 0x00002b391395a480 LdrInitializeThunk+0x45f(kernel_start=0x7b8732e0, unknown2=<internal error>, unknown3=<internal error>, unknown4=<internal error>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2709] in ntdll (0x00007fffffbef000) 16 0x000000007b8797ed __wine_kernel_init+0x91c() [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1255] in kernel32 (0x00002b3913bea620) 17 0x00002b391395acf4 __wine_process_init+0x143() [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2918] in ntdll (0x00007fff5dbb1ca0) 18 0x00002b3912dfb488 wine_init+0x297(argc=0x3, argv=0x7fff5dbb2198, error="", error_size=0x400) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/loader.c:831] in libwine.so.1 (0x00007fff5dbb1ca0) 19 0x000000007bf00da2 main+0x71(argc=0x3, argv=0x7fff5dbb2198) [/home/julliard/wine/build/obj-elf64/loader/../../wine/loader/main.c:230] in <wine-loader> (0x00007fff5dbb2198) 20 0x00002b391338dead __libc_start_main+0xfc(main=<is not available>, argc=<is not available>, ubp_av=<is not available>, init=<is not available>, fini=<is not available>, rtld_fini=<is not available>, stack_end=0x7fff5dbb2188) [/home/aurel32/eglibc/eglibc-2.13/csu/libc-start.c:228] in libc.so.6 (0x0000000000000000) 21 0x000000007bf00e9d _start+0x28() in <wine-loader> (0x0000000000000000) 0x00002b39152590cf msi_build_directory_name+0x25f [/home/julliard/wine/build/obj-elf64/dlls/msi/../../../wine/dlls/msi/action.c:2157] in msi: cmpw $5c,(%r11) 2157 if ( i + 1 != count && dir[strlenW( dir ) - 1] != '\\') strcatW( dir, szBackSlash ); -- Alexandre Julliard julliard(a)winehq.org

July 31, 2012

Re: Error 123

by Alex Henrie

To use serial ports on Linux, your user must be a member of the "dialout" group. -Alex

July 31, 2012

Re: vbscript/tests: Use proper helpers for iface calls

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20486 Your paranoid android. === WNT4WSSP6 (32 bit createobj) === createobj.c:747: Test failed: CoCreateInstance failed: 80040154 createobj: unhandled exception c0000005 at 00402A21

July 31, 2012

Re: fusion: Use inline wrappers for calling COM methods.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20484 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

July 31, 2012

Re: sxs: Use inline wrappers for calling COM methods.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20483 Your paranoid android. === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

July 31, 2012

Re: gdiplus: Add more tests for GdipMeasureString using device with custom resolution. Take 3.

by Dmitry Timoshkov

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > This time with even more relaxed comparison of precalculated values (0.5 => 0.6). To make things clearer: I was working on this test under Windows with PSDK compiler, and once I replaced division 1/72 by multiplication to 72.0 the calculated values started to almost exactly match the ones returned by gdiplus APIs. Apparently testbot uses gcc and that change didn't improve things much, so I had to relax the test to pass under testbot. -- Dmitry.

July 31, 2012

Re: gdiplus: Add more tests for GdipMeasureString using device with custom resolution. Take 2. Resend.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20480 Your paranoid android. === WXPPROSP3 (32 bit graphics) === graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 === W2K3R2SESP2 (32 bit graphics) === graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 === WVISTAADM (32 bit graphics) === graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 === W2K8SE (32 bit graphics) === graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 === W7PRO (32 bit graphics) === graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 === W7PROX64 (32 bit graphics) === graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 === TEST64_W7SP1 (32 bit graphics) === graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 === W7PROX64 (64 bit graphics) === graphics.c:3592: Test failed: Expected 555.555603, got 555.012939 graphics.c:3606: Test failed: Expected 555.555603, got 555.012939 === TEST64_W7SP1 (64 bit graphics) === graphics.c:3592: Test failed: Expected 555.555603, got 555.012939 graphics.c:3606: Test failed: Expected 555.555603, got 555.012939

July 31, 2012

Re: __wine_uuidof causing a wall of "warning: returning reference to temporary" on g++

by Jacek Caban

On 07/30/12 13:13, Ilya Konstantinov wrote: > On Sun, Jul 29, 2012 at 9:47 PM, Jacek Caban <jacek(a)codeweavers.com > <mailto:jacek(a)codeweavers.com>> wrote: > > Upon first attempts to compile, I've received a wall of > "warning: returning reference to temporary" on Wine's headers > from g++. > All of those seem to stem from guidgen.h definition of > __wine_uuidof / __CRT_UUID_DECL for C++. > > > > I don't see these warnings here. Also Wine has the same code for > __uuidof as mingw-w64, which is much more widely used with g++ > (Wine is mostly tested on C), and I never heard about such > problem. Do you have any idea about what could be different in > your setup? What's your g++ version? > > > I'm using gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) to build my > Winelib app. > > As to the difference from mingw-w64, I see different code in there: > http://mingw-w64.svn.sourceforge.net/viewvc/mingw-w64?view=revision&revisio… > <http://mingw-w64.svn.sourceforge.net/viewvc/mingw-w64?view=revision&revisio…> > > > The idea is that if matches closer to the meaning of __uuidof, > which should return a reference to constant IID structure. > > > Understood. > > > I'd expect compiler to be smart enough to produce same code > without the reference anyway (after all it's an inline function), > but still being more explicit would be nice. Could you please test > if the attached patch fixes the problem for you? > > > Yep, it does. I've tested it more and sent a patch. Jacek

July 31, 2012

Re: gdiplus: Add more tests for GdipMeasureString using device with custom resolution. Take 2.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20479 Your paranoid android. === WXPPROSP3 (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === W2K3R2SESP2 (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === WVISTAADM (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === W2K8SE (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === W7PRO (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === W7PROX64 (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === TEST64_W7SP1 (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === W7PROX64 (64 bit graphics) === graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 185.185196, got 185.004303 graphics.c:3606: Test failed: Expected 185.185196, got 185.004303 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333344, got 133.203125 graphics.c:3606: Test failed: Expected 133.333344, got 133.203125 graphics.c:3592: Test failed: Expected 66.666672, got 66.601563 graphics.c:3606: Test failed: Expected 66.666672, got 66.601563 graphics.c:3592: Test failed: Expected 555.555603, got 555.012939 graphics.c:3606: Test failed: Expected 555.555603, got 555.012939 graphics.c:3592: Test failed: Expected 277.777802, got 277.506470 graphics.c:3606: Test failed: Expected 277.777802, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 185.185196, got 185.004303 graphics.c:3606: Test failed: Expected 185.185196, got 185.004303 === TEST64_W7SP1 (64 bit graphics) === graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 185.185196, got 185.004303 graphics.c:3606: Test failed: Expected 185.185196, got 185.004303 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333344, got 133.203125 graphics.c:3606: Test failed: Expected 133.333344, got 133.203125 graphics.c:3592: Test failed: Expected 66.666672, got 66.601563 graphics.c:3606: Test failed: Expected 66.666672, got 66.601563 graphics.c:3592: Test failed: Expected 555.555603, got 555.012939 graphics.c:3606: Test failed: Expected 555.555603, got 555.012939 graphics.c:3592: Test failed: Expected 277.777802, got 277.506470 graphics.c:3606: Test failed: Expected 277.777802, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 185.185196, got 185.004303 graphics.c:3606: Test failed: Expected 185.185196, got 185.004303

July 31, 2012

A milestone of sorts...

by Dan Kegel

I just ran into a CAD app whose 64 bit version runs better than its 32 bit version on Wine (the 32 bit version hangs with http://bugs.winehq.org/show_bug.cgi?id=31358 but the 64 bit version gets past that and seems to actually do something). Not very important, but kind of cool.

July 31, 2012

wine/windows/tchar.h - error "You must use msvcrt when building in Unicode/MBCS mode"

by Ilya Konstantinov

In 2004, somebody has asked a question: http://www.winehq.org/pipermail/wine-devel/2004-October/030349.html The reply from Alexandre was: > > Either there should be a overriding "wine/include/msvcrt/tchar.h" > > file with different defintions. Or the error message "You must use > > msvcrt when building in Unicode/MBCS mode" is simply superfluous. > It's not superfluous, but it probably needs a !defined(__MSVCRT__) in > there. >From what I see, today the situation is still the same. Is it simply because nobody has dealt with it? In any case, I've implemented Alexandre's change locally (in tchar.h). Now I'll be trying to use winelib's msvcrt with my code. It seems like a "damned if you do, damned if you don't" kind of thing. One issue I'm having now is wine/msvcrt being in the system includes path, thus causing libstdc++ to load winelib's <wchar.h>. Of course, this didn't go too well :-) My goal is to have a Linux app that's, generally speaking, a native app. I have the cooperation of the codebase developers, so they can follow directions to keep the code reasonably portable. At the same time, I don't want to burden them with mundane changes, so if Winelib can bridge over the two worlds sometimes, it'd be great. Perhaps we can have tchar.h operate in two modes: 1) a MSVCRT mode, where all the MSVCRT goodies are available, 2) a glibc mode, where it tries to map as many functions to glibc as possible?

July 30, 2012

Re: winex11.drv: xrandr1.2 don't assume CRTC 0 is active

by siro＠das-labor.org

July 30, 2012

Re: winex11.drv: xrandr1.2 don't assume CRTC 0 is active

by Henri Verbeet

On 30 July 2012 20:13, Alexandre Julliard <julliard(a)winehq.org> wrote: > This clearly needs a helper function. > I'm not sure if this really makes sense to begin with. CRTC 0 is supposed to be the primary display. With proper multihead support we'd be able to enumerate the other display as well, and change modes on them etc., but I suspect disabling the primary display isn't going to give very good results on native Windows either, except perhaps for applications that have multihead support themselves.

July 30, 2012

Re: Incompatibilities between different versions of msvcp dlls

by Alexandre Julliard

Piotr Caban <piotr.caban(a)gmail.com> writes: > In current way of implementing such differences it will lead to > keeping a copy of ios.c and locale.c files in msvcp60, msvcp71, > msvcp90 and msvcp100. The changes in code are minimal in these cases > (e.g. in ctype class case it's enough to remove _s functions in vtable > and change offsets in call_* macros for msvcp71/msvcp100). > > Do you have any ideas about solving this problem? Is it acceptable to > add version specific defines to make the files identical between dlls? If the changes are small enough you should be able to keep the files updated by doing a simple 3-way merge when you change one of them. -- Alexandre Julliard julliard(a)winehq.org

July 30, 2012

Re: [PATCH] ntdll: add mmap caching

by Alexandre Julliard

Michael Blumenkrantz <michael.blumenkrantz(a)gmail.com> writes: > Hi, > > Attached is a patch that I wrote a year ago with the help of Bernhard Loos > (jhgf). For various reasons, I didn't get around to submitting it until now. > > This patch adds caching to NtMapViewOfSection() to reduce the frequency of > blocking server requests which occur, instead replacing them with lookups to a > wine rbtree, which is populated during NtCreateSection() and cleared during > close_handle(). While I don't have any performance statistics to show, this > should yield some definite benefits in nearly every modern game given that they > all repeatedly read mmapped sections of files. > > Bernhard suggested to me, at the time of writing this, that there could be some > potential compatibility issues with regard to sharing, but I don't know nearly > enough about the internals here to speculate. There are worse issues, like the lack of locking, and the fact that you are slowing down the close handle path, which will impact every application for a debatable benefit in a few cases. You'll need to show very convincing benchmarks if you want to pursue this further. -- Alexandre Julliard julliard(a)winehq.org

July 30, 2012

Re: winex11.drv: xrandr1.2 don't assume CRTC 0 is active

by Alexandre Julliard

Patrick Rudolph <siro(a)das-labor.org> writes: > @@ -279,15 +279,34 @@ static int xrandr12_get_current_mode(void) > return 0; > } > > - if (!resources->ncrtc || !(crtc_info = pXRRGetCrtcInfo( gdi_display, resources, resources->crtcs[0] ))) > + if (!resources->ncrtc) > { > pXRRFreeScreenResources( resources ); > wine_tsx11_unlock(); > - ERR("Failed to get CRTC info.\n"); > + ERR("No CRTCs found.\n"); > return 0; > } > + for(i=0;resources->ncrtc;i++) > + { > + > + if (!(crtc_info = pXRRGetCrtcInfo( gdi_display, resources, resources->crtcs[i] ))) > + { > + pXRRFreeScreenResources( resources ); > + wine_tsx11_unlock(); > + ERR("Failed to get CRTC info.\n"); > + return 0; > + } > + /* verify that crtc i is active */ > + if((!crtc_info->mode) && (!crtc_info->width) && (!crtc_info->height)) > + if(i+1 < resources->ncrtc) /* crtc i is disabled, test for more crtcs */ > + pXRRFreeCrtcInfo( crtc_info ); > + else > + break; > + else > + break; > + } This clearly needs a helper function. -- Alexandre Julliard julliard(a)winehq.org

July 30, 2012

Error 123

by Zachary Shields

Hi, I just installed Wine on my comp and everything went well. However, when I installed my program and try to open it it gives me the error: Unable to open com port (win error code: 123) Anyone have any ideas on how to fix this? Thanks, Zachary -- Zachary Nischan Shields 317.627.3628 NischanPictures.com

July 30, 2012