July 2012 - Wine-Devel - list.winehq.org

Re: include: fix mingw64 build

by Nicolas Le Cam

2012/7/3 Jacek Caban <jacek(a)codeweavers.com>: > On 06/29/12 03:35, Austin English wrote: >> On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: >>> 2012/6/29 Austin English <austinenglish(a)gmail.com>: >>>> Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 >>>> >>>> -- >>>> -Austin >>>> >>>> >>>> >>> Hi Austin, >>> >>> I already tried to fix it on Wine side, see [1], >>> but Alexandre told me on IRC that the bug needs to be fixed in mingw-w64, >>> as it shouldn't include crtdefs.h by default. >>> >>> BTW, won't that break mingw32 build ? >>> >>> [1] http://source.winehq.org/patches/data/84070 >>> >>> -- >>> Nicolas Le Cam >> Thanks for the info. Have you or anyone else discussed this with >> mingw64? I did a quick search on their bugtracker, but don't see >> anything.. >> http://sourceforge.net/search/?group_artifact_id=983354&type_of_search=arti… > > FWIW, here is my proposed patch to mingw-w64: > > http://repo.or.cz/w/mingw-w64/jacek.git/commitdiff/5db96424c7b9ac4aa5a66bd0… > > We will see if they like it. > > Jacek Thanks a lot Jacek ! -- Nicolas Le Cam

July 3, 2012

Re: [PATCH 3/4] vbscript: Fixed function return crossing for loop

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19753 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

July 3, 2012

Re: include: fix mingw64 build

by Jacek Caban

On 06/29/12 03:35, Austin English wrote: > On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: >> 2012/6/29 Austin English <austinenglish(a)gmail.com>: >>> Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 >>> >>> -- >>> -Austin >>> >>> >>> >> Hi Austin, >> >> I already tried to fix it on Wine side, see [1], >> but Alexandre told me on IRC that the bug needs to be fixed in mingw-w64, >> as it shouldn't include crtdefs.h by default. >> >> BTW, won't that break mingw32 build ? >> >> [1] http://source.winehq.org/patches/data/84070 >> >> -- >> Nicolas Le Cam > Thanks for the info. Have you or anyone else discussed this with > mingw64? I did a quick search on their bugtracker, but don't see > anything.. > http://sourceforge.net/search/?group_artifact_id=983354&type_of_search=arti… FWIW, here is my proposed patch to mingw-w64: http://repo.or.cz/w/mingw-w64/jacek.git/commitdiff/5db96424c7b9ac4aa5a66bd0… We will see if they like it. Jacek

July 3, 2012

Re: [PATCH 4/4] jscript: Added more apply and call tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19754 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

July 3, 2012

Re: [PATCH 2/4] vbscript: Fixed 'exit do' statements crossing for in loops

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19752 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

July 3, 2012

Re: Wine on the front page of Reddit

by Erich E. Hoover

On Mon, Jul 2, 2012 at 11:18 PM, Caleb Hearon <caleb(a)chearon.net> wrote: > > Hi all, > > In a conversation between myself (MaggotBrain on the forums) and Jarrex, I expressed some frustration that Blizzard had been banning Diablo III users who used Wine. He posted some of the excerpts I sent him from WineHQ, and it quickly got to 17 pages on Blizzard's forums. > ... > And Wine hackers- great work, I've just finished playing 2 hours of Diablo III and it runs great. I also have been successfully playing Diablo III for some time, and it is concerning to me that this has escalated into a media frenzy. It is entirely possible that the people that have been banned have either had unauthorized access to their account or were actually cheating. It seems to me that outright blaming Blizzard for this situation is a good way to generate a lot of negative publicity and that this publicity could result in them intentionally changing their games to not work under Wine just to avoid these kinds of headaches in the future. Erich Hoover ehoover(a)mines.edu

July 3, 2012

Re: [1/2] kernel32/tests: Improve some traces for the CreateTimerQueueTimer() tests.

by Francois Gouget

On Tue, 3 Jul 2012, Marvin wrote: [...] > === WVISTAADM (32 bit sync) === > sync.c:924: Test failed: DeleteTimerQueueTimer > sync.c:925: Test failed: ChangeTimerQueueTimer I don't think this error is caused by my patch. I reran it through TestBot and it worked: https://testbot.winehq.org/JobDetails.pl?Key=19742 Yet this test does not fail usually. http://test.winehq.org/data/tests/kernel32:sync.html -- Francois Gouget <fgouget(a)codeweavers.com>

July 3, 2012

Re: League of Legends patches

by Dan Kegel

On Tue, Jul 3, 2012 at 1:08 AM, Andrea Canciani <ranma42(a)gmail.com> wrote: > I tried to follow the http://wiki.winehq.org/SubmittingPatches > guidelines, but this is my first submission to wine, so I guess the > patches might need further improvement. > Please point out any issues that need fixing. On an administrivial note, you should send one patch per email to wine-patches. Do you think you could write a test that (semi-)reliably causes the deadlock you're fixing? > The patches have been tested by Dan Kegel (in CC) and are currently > being used by many MacOSX and Linux users to run LoL. Our emails may have crossed - with these patches applied, dlls/ieframe/tests/webbrowser.ok seems to crash here: Unhandled exception: privileged instruction in 32-bit code (0x02786624). Backtrace: =>0 0x02786624 (0x0032fcd8) 1 0x688e22db func_webbrowser+0x3ca() [dlls/ieframe/tests/webbrowser.c:3382] Otherwise the tests seem to pass. Thanks, Dan

July 3, 2012

Re: user32: Add test for ComboBox repositioning behavior (try 2).

by Alexandre Julliard

Sergey Guralnik <serhio(a)etersoft.ru> writes: > Alexandre Julliard writes: >> There's no reason to test just WM_SIZE when we have support for >> testing >> full sequences. Once again, what are you trying to test? > > I only try to test that combobox should send WM_SIZE to it's wndproc > during > WM_WINDOWPOSCHANGED handling. Then just do a SetWindowPos and test the message sequence. There are plenty of examples in that file. -- Alexandre Julliard julliard(a)winehq.org

July 3, 2012

Re: mshtml: Always set the URL policy in the error cases?

by Jacek Caban

Hi Francois, On 06/28/12 16:27, Francois Gouget wrote: > gcc 4.7 is complaining that policy may be used uninitialized in > InternetHostSecurityManager_QueryCustomPolicy() and indeed there are > many error cases in confirm_safety_load() and confirm_safety() where the > policy is not set. The patch belowe seems to plug all these holes but I > don't know if it really makes sense. Sorry for the delay. I recall that exactly this issue has already popped out. I think that the current code is fine and there is nothing to fix. However, given that it happens in already released stable GCC, it seems like after all we have to do something about it. These are mostly theoretical code paths, so the way it's fixed doesn't really matter much. It would probably be more appropriate to add assert(SUCCEEDED(hres)); after IsClassOfCategories calls, which can't fail. Jacek

July 3, 2012