August 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] hhctrl.ocx: Implement HH_SET_WIN_TYPE (try 7).

by Alexandre Julliard

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > @@ -1784,11 +1785,25 @@ void ReleaseHelpViewer(HHInfo *info) > OleUninitialize(); > } > > -HHInfo *CreateHelpViewer(LPCWSTR filename, HWND caller) > +static BOOL info_in_list(HHInfo *info) > +{ > + HHInfo *i; > + > + LIST_FOR_EACH_ENTRY(i, &window_list, HHInfo, entry) > + { > + if(i == info) > + return TRUE; > + } > + return FALSE; > +} You should never need that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

Aug. 30, 2012

Re: kernel32: Add UTF-7 support. (try 4)

by Alexandre Julliard

Alex Henrie <alexhenrie24(a)gmail.com> writes: > + do > + { > + if (src[source_index] == 0 && srclen == -1) > + { > + if (dry_run) dest_index++; else if (write_to_w_string(dst, dstlen, &dest_index, 0)) return -1; > + /* when srclen=-1, terminate at the first null character found */ > + break; > + } > + else if (src[source_index] == '+') > + { > + WCHAR byte_pair = 0; > + short offset = 0; > + > + source_index++; /* skip the + sign */ > + > + if (src[source_index] == '-') > + { > + /* just a plus sign escaped as +- */ > + if (dry_run) dest_index++; else if (write_to_w_string(dst, dstlen, &dest_index, '+')) return -1; > + source_index++; > + continue; > + } You are not checking properly for the source string length. Also please add tests for such cases. -- Alexandre Julliard julliard(a)winehq.org

Aug. 30, 2012

Re: Moving pages to/from wiki

by Michael Stefaniuc

On 08/30/2012 06:05 PM, Jeremy Newman wrote: > On 08/29/2012 09:32 PM, Kyle Auble wrote: >> just checked http://cvs.winehq.org and sure enough, there is still a >> very outdated CVS repository there, but I can't find a template or a PHP >> applet for it, just the same links you found (most in WWN issues). I've >> CCed Jeremy Newman because I'm guessing the site admin would have to >> remove it. > > I am not opposed to removing it. We had left it up as a historical > archive, or for people that were not ready to switch to GIT yet. If > there is consensus then I can certainly take it down. According to Alexandre it is used by http://source.winehq.org/ for the "Wine Cross Reference". bye michael

Aug. 30, 2012

Re: Moving pages to/from wiki

by André Hentschel

Am 30.08.2012 04:32, schrieb Kyle Auble: > As for redirecting to http://www.winehq.org/cvs, since that was designed > as a notice page for people trying to browse the source code, I was > picturing just redirecting the links to http://source.winehq.org/git and > deleting http://www.winehq.org/cvs as only WWN issues and news would > still have dangling links. I don't want to remove it if there's another > reason for keeping it though. please don't remove it. there's still much linking to it on the web, or hiding links, like in sourcecodes somewhere -- Best Regards, André Hentschel

Aug. 30, 2012

Re: Moving pages to/from wiki

by Jeremy Newman

On 08/29/2012 09:32 PM, Kyle Auble wrote: > just checked http://cvs.winehq.org and sure enough, there is still a > very outdated CVS repository there, but I can't find a template or a PHP > applet for it, just the same links you found (most in WWN issues). I've > CCed Jeremy Newman because I'm guessing the site admin would have to > remove it. I am not opposed to removing it. We had left it up as a historical archive, or for people that were not ready to switch to GIT yet. If there is consensus then I can certainly take it down.

Aug. 30, 2012

Re: Moving pages to/from wiki

by Kyle Auble

Wed, Aug 29, 2012 16:09, André Hentschel wrote: > get the website source and do "grep -Ri cvs *" > then ignore wwn/ and news/ ... > all that should somehow bring you to http://www.winehq.org/cvs or be deleted grep -r "...." * is rapidly becoming a very good friend of mine ;) I just checked http://cvs.winehq.org and sure enough, there is still a very outdated CVS repository there, but I can't find a template or a PHP applet for it, just the same links you found (most in WWN issues). I've CCed Jeremy Newman because I'm guessing the site admin would have to remove it. As for redirecting to http://www.winehq.org/cvs, since that was designed as a notice page for people trying to browse the source code, I was picturing just redirecting the links to http://source.winehq.org/git and deleting http://www.winehq.org/cvs as only WWN issues and news would still have dangling links. I don't want to remove it if there's another reason for keeping it though. - Kyle

Aug. 30, 2012

Re: Moving pages to/from wiki

by André Hentschel

Am 29.08.2012 21:13, schrieb Kyle Auble: > I'm starting to work on moving static pages to and from the wiki, but I > wanted to ask for opinions on a few changes first: ... > 3. Do we still need the static "cvs" page, or should I just redirect any > links to it, then delete? On a related note, the WineHQ ToDo on the > wiki still claims that a browser for the old CVS source tree is > lurking on the site somewhere. Is that true, or do I need to cut that > line from the ToDo list? get the website source and do "grep -Ri cvs *" then ignore wwn/ and news/ the first lines already look like they need love: > include/htaccess.sample:RedirectPermanent /dev.shtml http://www.winehq.org/cvs > include/htaccess.sample:RedirectPermanent /dev.html http://www.winehq.org/cvs > include/htaccess.sample:RedirectPermanent /devstart.shtml http://www.winehq.org/cvs > include/htaccess.sample:RedirectMatch ^/cvsweb(.*)$ http://cvs.winehq.org/cvsweb$1 > include/htaccess.sample:RedirectMatch ^/patch.py(.*)$ http://cvs.winehq.org/patch.py$1 > include/wwn.php: if ($file == "." or $file == ".." or $file == "CVS" or $file == "interviews") and some things in templates all that should somehow bring you to http://www.winehq.org/cvs or be deleted -- Best Regards, André Hentschel

Aug. 29, 2012

Re: kernel32: Return correct drive type for empty drives

by Alexandre Julliard

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > Should fix bug #17037 > I followed your advice and now, I only ask the mountmgr when needed. > --- > dlls/kernel32/volume.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) This is failing here when the drive is empty: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so volume.c && touch volume.ok volume.c:132: Tests skipped: can't test removing fake drive volume.c:785: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87 make: *** [volume.ok] Error 1 If I put a DVD in I get: volume.c:813: Test failed: IOCTL_DVD_READ_STRUCTURE should have failed Probably the tests need some fixing. -- Alexandre Julliard julliard(a)winehq.org

Aug. 29, 2012

Moving pages to/from wiki

by Kyle Auble

I'm starting to work on moving static pages to and from the wiki, but I wanted to ask for opinions on a few changes first: 1. Move all static IRC pages to the wiki or add info from the wiki to the static templates? The static pages only mention #winehq and don't describe guidelines, but IRC details shouldn't change much right? 2. For the static About page, some languages also have wiki versions. Do we want to keep the sparser versions currently in use, or add the more detailed information from the wiki version? Both versions seem well-written, and exist for English, Hebrew, & Spanish (I deleted the Polish wiki version; it was a duplicate). 3. Do we still need the static "cvs" page, or should I just redirect any links to it, then delete? On a related note, the WineHQ ToDo on the wiki still claims that a browser for the old CVS source tree is lurking on the site somewhere. Is that true, or do I need to cut that line from the ToDo list? 4. Since licensing tends to be really static could we just redirect the WikiLicense page to the static license page, or should they be kept separate? While I'd think it wouldn't be too hard to reword the static page's intro to include other projects, I'm leery of editing any legal-ese without asking first. By the way, the WikiLicense page says it's LGPL v2.1 in the intro text, but the included license actually looks like v2.0 of the GPL with a modification for libraries. If the wiki version of the page should stay, I'll put in a copy of v2.1 - Kyle

Aug. 29, 2012

Re: [Tools] testbot: Add LICENSE and COPYING.LIB files.

by Francois Gouget

On Wed, 29 Aug 2012, Henri Verbeet wrote: > On 29 August 2012 16:35, Francois Gouget <fgouget(a)codeweavers.com> wrote: > > --- > > > > I think this made total sense when th WineTestBot was in its own > > repository. Now maybe the COPYING.LIB and LICENSE files can be > > considered to apply to all of the Wine tools and should go to the > > top-level directory? > > > Not all of the code in tools.git is under LGPL 2.1. (And personally > I'd argue that GPL 3 is probably more appropriate for most of the > things in there anyway.) Ok. So these files are in the right place then. As for LGPL 2.1 vs. GPL 3 I'm just documentin Ge's choices. -- Francois Gouget <fgouget(a)codeweavers.com>

Aug. 29, 2012