August 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 1/5] d3dx9: Add some traces to D3DXLoadSurfaceFromMemory().

by Henri Verbeet

2012/8/28 Rico Schüller <kgbricola(a)web.de>: > + FIXME("Format conversation missing %#x -> %#x\n", src_format, surfdesc.Format); I don't think that's really what we want it to say.

Aug. 28, 2012

Re: shell32: Make ShellExecute use native file association databases as fallback path (resend)

by Alexandre Julliard

Erik van Pienbroek <erik(a)vanpienbroek.nl> writes: > +#if defined(HAVE_FORK) && defined(HAVE_WAITPID) > +static UINT_PTR SHELL_try_native_execute ( const char *openCmd, const char *unixName ) > +{ > + UINT_PTR retval = SE_ERR_NOASSOC; > + pid_t cpid; > + struct stat st; > + > + if (stat(openCmd, &st) == -1) > + { > + TRACE("stat() %s failed: %s\n", openCmd, strerror(errno)); > + return retval; > + } > + > + cpid = fork(); > + if (!cpid) > + { > + /* Prevent the situation where the native file association database > + * tries to run wine to execute a program and we trigger this fallback > + * path again and end up in a recursive loop */ > + if (getenv("WINE_INSIDE_SHELLEXECUTE")) > + { > + TRACE("recursive loop detected, not continuing with ShellExecute call\n"); > + exit(EXIT_SUCCESS); > + } > + setenv("WINE_INSIDE_SHELLEXECUTE", "1", 0); > + > + TRACE("running %s %s\n", openCmd, unixName); > + execlp(openCmd, openCmd, unixName, (char*) NULL); > + /* execlp replaces the current process image with a new process image, > + * so no code below here should get executed by the forked child */ > + } else { > + int status; > + waitpid(cpid, &status, 0); > + TRACE("status %x\n", status); > + if(!WEXITSTATUS(status)) > + retval = 33; > + } > + > + return retval; > +} You want spawnvp(), but that sort of thing should probably go in winebrowser or something like that, and be configurable. -- Alexandre Julliard julliard(a)winehq.org

Aug. 28, 2012

Re: kernel32: Try to get the drive type from the mountmgr first [resend]

by Alexandre Julliard

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > Should fix bug #17037 > Now that my patch disappeared from source.winehq.org/patches, I'm resending it. > Before commenting, please read the e-mail I sent in July (winehq.org/pipermail/wine-devel/2012-July/096587.html) The goal here is to avoid a mountmgr round-trip for the common case, calling mountmgr first defeats this. -- Alexandre Julliard julliard(a)winehq.org

Aug. 28, 2012

Re: d3dx9: ID3DXConstantTable

by Rico Schüller

On 28.08.2012 10:50, Henri Verbeet wrote: > On 28 August 2012 09:12, Rico Schüller <kgbricola(a)web.de> wrote: >> 3. The wine_todo should be fixed in the test. Is there a way to disable them >> to show up, when running e.g. "wine d3dx9_36_test.exe.so shader"? It's a bit >> annoying when you search for your own failing tests. Well I could comment >> out the tests, but that's also not a very fine solution. >> > You can set WINETEST_PLATFORM=wine, but the easiest is probably to > just do "make shader.ok" instead of trying to run the test manually. > Thanks, that's exactly what I need. Cheers Rico

Aug. 28, 2012

Re: Wine bot results

by Alistair Leslie-Hughes

Hi Qian, > > $ i686-w64-mingw32-gcc -v > Using built-in specs. > COLLECT_GCC=i686-w64-mingw32-gcc > COLLECT_LTO_WRAPPER=/usr/lib/gcc/i686-w64-mingw32/4.6.1/lto-wrapper > Target: i686-w64-mingw32 > Configured with: ../../src/configure --build=i686-linux-gnu > --prefix=/usr --includedir='/usr/include' --mandir='/usr/share/man' > --infodir='/usr/share/info' --sysconfdir=/etc --localstatedir=/var > --libexecdir='/usr/lib/gcc-mingw-w64' --disable-maintainer-mode > --disable-dependency-tracking --prefix=/usr --disable-shared > --disable-multilib --enable-linker-build-id --with-system-zlib > --libexecdir=/usr/lib --without-included-gettext --libdir=/usr/lib > --enable-libstdcxx-time=yes --with-tune=generic > --enable-version-specific-runtime-libs > --enable-languages=c,c++,fortran --enable-lto --with-plugin-ld > --enable-fully-dynamic-string --target=i686-w64-mingw32 > --with-gxx-include-dir=/usr/include/c++/4.6 > --with-as=/usr/bin/i686-w64-mingw32-as > --with-ld=/usr/bin/i686-w64-mingw32-ld > Thread model: win32 > gcc version 4.6.1 (GCC) > $ i586-mingw32msvc-gcc -v Using built-in specs. Target: i586-mingw32msvc Configured with: /build/buildd/mingw32-4.2.1.dfsg/build_dir/src/gcc-4.2.1-2-dfsg/configure -v --prefix=/usr --target=i586-mingw32msvc --enable-languages=c,c++ --enable-threads --enable-sjlj-exceptions --disable-multilib --enable-version-specific-runtime-libs Thread model: win32 gcc version 4.2.1-sjlj (mingw32-2) Here is what install on my system, Ill try to update it to a later version. Best Regards Alistair Leslie-Hughes

Aug. 28, 2012

Re: Wine bot results

by Qian Hong

Hello Alistair, On Tue, Aug 28, 2012 at 6:04 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > http://testbot.winehq.org/JobDetails.pl?Key=21257 > http://testbot.winehq.org/JobDetails.pl?Key=21256 I downloaded your patch from http://testbot.winehq.org/GetFile.pl?JobKey=21257&StepKey=1 , compiled with i686-w64-mingw32-gcc on Ubuntu 10.10, then resubmit it to wine testbot, my result is the same as the one built by testbot: https://testbot.winehq.org/JobDetails.pl?Key=21288 Maybe it is interesting to know what compiler you use and which one is used by testbot. Though we should make sure we are always test on the same patch first =) $ i686-w64-mingw32-gcc -v Using built-in specs. COLLECT_GCC=i686-w64-mingw32-gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc/i686-w64-mingw32/4.6.1/lto-wrapper Target: i686-w64-mingw32 Configured with: ../../src/configure --build=i686-linux-gnu --prefix=/usr --includedir='/usr/include' --mandir='/usr/share/man' --infodir='/usr/share/info' --sysconfdir=/etc --localstatedir=/var --libexecdir='/usr/lib/gcc-mingw-w64' --disable-maintainer-mode --disable-dependency-tracking --prefix=/usr --disable-shared --disable-multilib --enable-linker-build-id --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --libdir=/usr/lib --enable-libstdcxx-time=yes --with-tune=generic --enable-version-specific-runtime-libs --enable-languages=c,c++,fortran --enable-lto --with-plugin-ld --enable-fully-dynamic-string --target=i686-w64-mingw32 --with-gxx-include-dir=/usr/include/c++/4.6 --with-as=/usr/bin/i686-w64-mingw32-as --with-ld=/usr/bin/i686-w64-mingw32-ld Thread model: win32 gcc version 4.6.1 (GCC) -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

Aug. 28, 2012

Re: [PATCH 6/6] Always define WIDL_C_INLINE_WRAPPERS

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21287 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Aug. 28, 2012

Re: Wine bot results

by Dmitry Timoshkov

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > I have a patch that when run on on the testbot, it fails on all but two > machines. > However when I build the exe myself and run it, it pass on all but two > machines. > > http://testbot.winehq.org/JobDetails.pl?Key=21257 > http://testbot.winehq.org/JobDetails.pl?Key=21256 > > Ubuntu 12.04. > > Any Ideas on the different results? This probably means that behaviour is undefined and depends on memory contents. -- Dmitry.

Aug. 28, 2012

Re: [PATCH 6/6] Always define WIDL_C_INLINE_WRAPPERS

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21286 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Aug. 28, 2012

Re: [PATCH 6/6] Always define WIDL_C_INLINE_WRAPPERS

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21285 Your paranoid android. === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Aug. 28, 2012