August 2012 - Wine-Devel - list.winehq.org

Re: kernel32: Handle neutral locale names better in GetLocaleInfoEx

by Nikolay Sivov

On 8/27/2012 07:20, Dmitry Timoshkov wrote: > Hi, > > Are you sure that GetLocaleInfo can't handle these cases on its own? I already added a test for that - for neutral LCID for English for example it still returns en-US as locale name and the rest of the locale entries I tested are from US locale as well. Regarding GetLocaleInfoEx - for neutral names it returns neutral locale name for LOCALE_SNAME index, however the rest of the data is still non-neutral. This mapping applies to LocaleNametoLCID too, it returns non-neutral LCID for neutral names.

Aug. 27, 2012

Re: [3/3] gdiplus: get_log_fontW helper requires a valid graphics object.

by Vincent Povirk

>> > + GdipFree(backup); >> >> I think you want GdipDeletePath. > > Other places of GdipAddPathString implementation need this fixed as well then. Nope, the existing use of GdipFree on backup is correct because the extra data associated with it has been copied to the original path (which had its data freed). Not the clearest way of doing things but it works. >> This seems very convoluted. Couldn't we just skip the size conversion >> in get_log_fontW when graphics is NULL? Any cases where the scaling >> would produce a size other than the em size need to be fixed in >> GdipAddPathString anyway. > > GdipAddPathString already creates an HDC to select hfont into it, so using > graphics object created from it seems pretty straightforward. Fair enough. On closer inspection, it looks like the behavior should be the same as before, so it doesn't really matter. I just prefer less memory management, all other things being equal.

Aug. 27, 2012

Re: msxml3: Implement xmldecl-version property for a reader

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21252 Your paranoid android. === W2KPROSP4 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === WXPPROSP3 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W2K3R2SESP2 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === WVISTAADM (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W2K8SE (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W7PRO (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W7PROX64 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === TEST64_W7SP1 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W7PROX64 (64 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 Timeout === TEST64_W7SP1 (64 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 Timeout

Aug. 27, 2012

Re: [3/3] gdiplus: get_log_fontW helper requires a valid graphics object.

by Dmitry Timoshkov

Vincent Povirk <madewokherd(a)gmail.com> wrote: > > + GdipFree(backup); > > I think you want GdipDeletePath. Other places of GdipAddPathString implementation need this fixed as well then. > This seems very convoluted. Couldn't we just skip the size conversion > in get_log_fontW when graphics is NULL? Any cases where the scaling > would produce a size other than the em size need to be fixed in > GdipAddPathString anyway. GdipAddPathString already creates an HDC to select hfont into it, so using graphics object created from it seems pretty straightforward. -- Dmitry.

Aug. 27, 2012

Re: [3/3] gdiplus: get_log_fontW helper requires a valid graphics object.

by Vincent Povirk

> + GdipFree(backup); I think you want GdipDeletePath. This seems very convoluted. Couldn't we just skip the size conversion in get_log_fontW when graphics is NULL? Any cases where the scaling would produce a size other than the em size need to be fixed in GdipAddPathString anyway.

Aug. 27, 2012

Re: kernel32: Handle neutral locale names better in GetLocaleInfoEx

by Dmitry Timoshkov

Hi, Are you sure that GetLocaleInfo can't handle these cases on its own? -- Dmitry.

Aug. 27, 2012

Unused msvcp100 functions?

by Francois Gouget

There are a lot of msvcp100 functions that look like they are unused: * In string.c all of the MSVCP__String_base_*(), MSVCP_basic_string_*(), MSVCP_basic_string_wchar_*() and MSVCP_char_traits_*() functions, basic_string_w?char_replace_helper(). * In locale.c _Locinfo__Locinfo_ctor_bstr(), codecvt_{short,wchar}__Id_func(), collate_{char,short}__Getcat(), various ctype_*() functions, etc. * In ios.c, the basic_istream_*() and basic_ostream_*() functions, ios_base_Index_func() and ios_base_Sync_func(). * In math.c a lot of std_Ctraits_{double,float,long}_*() functions. Is it just that the spec file needs to catch up or that they will be used soon? I attached a more precise list of the suspects. I did not actually verify that all of them are unused but based on the ones I looked at it seems to be the case. If they are indeed unused and will remain so I can submit a patch to remove them. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The software said it requires Win95 or better, so I installed Linux.

Aug. 27, 2012

Re: msvcr100: Add wmemmove_s and wmemcpy_s

by Dan Kegel

On Sun, Aug 26, 2012 at 1:29 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: >> But msvcr100's wmemmove_s/wmemcpy_s are different; they >> do not change errno. Tests in my patch confirm this. > > They do set errno, the tests are broken. Aw, foo. Thanks, resent with fixes.

Aug. 26, 2012

Re: About WineHQ Wiki

by Kyle Auble

Sorry if my replies come in large batches, I'm subscribed to the mailing list digest. Sun, 26 Aug 2012 10:08, Cheer Xiao wrote: > Hi all, > I'm a MoinMoin contributor, one of MoinMoin's participating students > in this year's Summer of Code. > 2012/8/26 Kyle Auble <randomidman48(a)yahoo.com>: >> Sat, 25 Aug 2012 14:44, Oleg Yarigin wrote: >>> When I edited pages in the WineHQ Wiki, I notised, its markup lankuage >>> isn`t so good as MediaWiki`s one. How do you think about moving the Wiki >>> into MediaWiki engine? Besides, moving each language section of the Wiki >>> into separated subdomain (like in Wikipedia) would be a good idea too. >> There are some pluggable parsers for Moinmoin, and there may be one >> that allows MediaWiki syntax. After going through and checking, >> categorizing, and editing so many pages, I definitely agree with your >> suggestion that each language be given a domain, instead of one flat >> namespace. Then maybe just add a single common "translation" menu to >> the side toolbar? > Indeed there is a MediaWiki parser[1]. > Also, take a look at MoinMoin 2.0[2]. It has multiple markups support > out of the box (including mediawiki of course). You can even mix them > in a single wiki instance - this is not necessarily a good idea, but > it helps when you have to migrate some content from another wiki by > hand. ... > Feature requests are welcome, but be noted that MoinMoin 2.0 is the > current development version (it's not a development "branch" since the > codebase is almost a total rewrite) and quite likely the feature you > want is already there (or a TODO). :) Hello, I'm glad to hear there's already a line of communication. Allowing people to use MediaWiki syntax will probably be a big plus. There have been performance problems, but I noticed both the Ubuntu and Moinmoin wikis are pretty snappy so I'm thinking it's due to a strained server and using an old version of Moinmoin (although the SystemInfo macro seems to be disabled, I ran across version info somewhere, and I think Wine Wiki is running Moinmoin 1.5 or 1.6). I'm not sure if other problems I've noticed have been fixed in v1.8 or 1.9 so I would have to try out those versions before checking against v2.0. One thing I have done is written up some python code to help convert HTML tables to Moinmoin ones. I checked in Moinmoin's script market, but could only find full-blown page converters, and their output was kind of messy. I probably got carried away, but I'll attach it to http://wiki.winehq.org/WineStatus because I'm using it to move WineHQ's static status pages to the wiki. I guess that would make it LGPL so if you want to salvage a few parts from it or have me submit it to your utility marketplace, just let me know. Sun, 26 Aug 2012 16:07, Andre Hentschel wrote: > Further it seems a bit more complicated with Wine, the moinmoin wiki is sponsored by http://lattica.com/ (whatever > sponsored means, didn't find further information) and the code > is not accessable via a wine git repo (maybe it should be in tools.git, website.git or its own). This also leads to the > fact that we still have no new wiki theme years after the > theme change on the website. > Now that we upgraded the Forum engine we (we as in laxdragon xD) could maybe do something about the wiki, it > needs love. > It seems Kyle is doing a good job at the content, but the content is not everything. Thank you for the compliment. I am actually planning on doing more coding soon, but besides ramping up, I though cleaning up the wiki some first would let me see where the different parts of the project are. Applying the theme from the rest of the WineHQ is on both the WikiToDo and my own list (no guarantees about how long I would take though). Sun, 26 Aug 2012 22:46, Cheer Xiao wrote: > And yes, as I noted in a previous post moin2 is *not* production-ready > yet and I don't suggest you jump ship now. :) > What I do strongly suggest, however, is that you upgrade to moin1.9 > first, since 1) there has been many security fixes[1] which are not > backported to old versions, and 2) upgrade to moin2 will only be > supported from moin1.9. Helping to upgrade the wiki is on my list somewhere between finishing a first round of polishing content and trying a couple of patches to Wine itself. Although the maintainer would actually have to deploy it, I could test and work some of the kinks out of the upgrade using a local install. Dimi Paun put a lot of work into setting up the wiki in the first place and is the maintainer at lattica. From the git logs and mail list, it seems like he has been really busy with other things for a while. At times, Jeremy Newman has raised the possibility of moving the wiki to WineHQ: http://www.winehq.org/pipermail/wine-devel/2006-June/048712.html I remember stumbling across another email too, but I can't find it right now. If it's still a possibilty, I think the first step would be somehow setting up datadumps so we could start on the upgrade. If there is already a feature for admins to do that, maybe Dimi could start putting a daily/weekly tarball on WineHQ's FTP site. If it requires a custom patch though, I could look into doing that too. -Kyle

Aug. 26, 2012

Re: po: Update German translation

by Julian Rüger

I'm very sorry for sending another private mail to the list... When I chose "Answer to sender" my Mailclient asked if I wanted to send a private mail, but the sender is wine-devel. Damn. Am Sonntag, den 26.08.2012, 17:47 +0200 schrieb Julian Rüger: > Hi André, > > war ich zu langsam? ;) > > Das Komma ist an der Stelle grammatikalisch falsch, glaube ich. > "Die verbundenen Controller" sollten auch Plural bleiben. Mein Vorschlag > wäre irgendwie so etwas: > > "Nach dem De-/Aktivieren eines Gerätes wird die Liste der verbundenen > Controller bis zum Neustart dieses Applets nicht [mehr] aktualisiert." > > Viele Grüsse, > Julian > > Am Samstag, den 25.08.2012, 13:40 +0200 schrieb André Hentschel: > > > "After disabling or enabling a device, the connected joysticks won't be " > > "updated here until you restart this applet." > >-msgstr "" > >+msgstr "Nach dem deaktivieren oder aktivieren eines Gerätes, wird der " > >+"verbundene Controller hier bis zum Neustart des Applets nicht mehr " > >+"aktualisiert."

Aug. 26, 2012