September 2012 - Wine-Devel

Re: dmusic: Fix a copy and paste error

by Christian Costa

Le 29/09/2012 17:11, Sven Baars a écrit : > This should fix http://bugs.winehq.org/show_bug.cgi?id=31805 > > Good catch !

Sept. 29, 2012

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.

by Christian Costa

Le 28/09/2012 09:05, Hans Leidekker a écrit : > On Thu, 2012-09-27 at 23:07 +0200, Christian Costa wrote: >>>> if (!(cabinet_file = get_cabinet_filename(mi))) >>> The requirement that the continuous cabinet name matches the next cabinet in the media table >>> might simply be too strict. Perhaps we need to try them one by one and let FDI decide based >>> on the setID and iCabinet fields. Can you please add some tests? >>> >> Does not seem trivial to test this but I will try. > It shouldn't be too hard, we already have some tests for continuous cabinets. > > > Ok. I will take a look.

Sept. 29, 2012

Re: [PATCH] wined3d: move texture reference decrement to end of usage (Coverity)

by Henri Verbeet

On 29 September 2012 11:14, Marcus Meissner <marcus(a)jet.franken.de> wrote: > Hi, > > I do not fully understand all this, but it seem the decref needs to > be behind the last usage of prev. > Sort of. It's probably better to do it like this, but a non-zero bind_count implies a non-zero reference count as well, so in practice there's no danger of using prev after it's free'd.

Sept. 29, 2012

Re: Fwd: CIA going down: KGB wants your commits!

by Stefan Dösinger

Am Donnerstag, 27. September 2012, 16:10:56 schrieb Austin English: > IRC bots running in > our personal servers listen for SOAP messages sent by kgb-clients Shouldn't you call them kgb-agents? :-)

Sept. 29, 2012

Re: comctl32: use GetWindowLong to check for scrollbar (try 2)

by Nikolay Sivov

On 9/28/2012 20:43, Daniel Jelinski wrote: > Corrected from first try: > - uses GetWindowLong instead of GetWindowLongPtr > - does not touch dwStyle Sorry, was busy to reply earlier. I think this fix is ok if it really helps, thanks for working on this.

Sept. 28, 2012

Re: [PATCH] configure: use -Wp, -D_FORTIFY_SOURCE=0 instead of -D_FORTIFY_SOURCE=0

by Anssi Hannula

28.09.2012 18:14, Alexandre Julliard kirjoitti: > Anssi Hannula <anssi.hannula(a)iki.fi> writes: > >> Some Linux distributions (at least Mageia) build packages with >> -Wp,-D_FORTIFY_SOURCE=2 by default. There is a check in configure which >> checks for enabled fortify and adds "-U_FORTIFY_SOURCE >> -D_FORTIFY_SOURCE=0". Unfortunately, -Wp,-Dfoo are applied after -Dfoo, >> so the added flags fail to override the fortify in the CFLAGS. > > I would say that's a distro bug. Defaulting to Fortify is already broken > enough, but making it even harder to disable is stupid. I don't think > we want to get into that kind of arms race. Well, the intention is probably not to make it harder to override. Mageia uses the -Wp,x form simply because Mandriva and Fedora use that as well (according to logs at http://koji.fedoraproject.org/ ), I'm not sure if Fedora had some good reason to not use -D_FORTIFY_SOURCE=2 originally... IMHO those three distros (esp. Fedora) using -Wp,x is enough justification to add the "-Wp," prefixes to the existing fortify hack in wine configure.ac. However, I do understand and accept your position that it is not really wine's job to override all the weird compilation flags the user might be using. I wouldn't have sent the patch at all if the existing fortify hack hadn't already been there in the configure script :) For the record, Fedora already disables fortify for wine build, and Mageia is currently rolling updated wine packages that have fortify disabled. Mandriva seems to still be affected. No idea if there are more distributions using -Wp,-D_FORTIFY_SOURCE=2 for package builds. -- Anssi Hannula

Sept. 28, 2012

Re: [PATCH] configure: use -Wp, -D_FORTIFY_SOURCE=0 instead of -D_FORTIFY_SOURCE=0

by Alexandre Julliard

Anssi Hannula <anssi.hannula(a)iki.fi> writes: > Some Linux distributions (at least Mageia) build packages with > -Wp,-D_FORTIFY_SOURCE=2 by default. There is a check in configure which > checks for enabled fortify and adds "-U_FORTIFY_SOURCE > -D_FORTIFY_SOURCE=0". Unfortunately, -Wp,-Dfoo are applied after -Dfoo, > so the added flags fail to override the fortify in the CFLAGS. I would say that's a distro bug. Defaulting to Fortify is already broken enough, but making it even harder to disable is stupid. I don't think we want to get into that kind of arms race. -- Alexandre Julliard julliard(a)winehq.org

Sept. 28, 2012

Re: gdiplus: Reuse an existing image stream in GdipImageSelectActiveFrame. Take 2.

by Vincent Povirk

Looks good, thanks.

Sept. 28, 2012

Re: [PATCH 2/2] vbscript: Added MonthName implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21880 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Sept. 28, 2012

Re: gdi32: Fixed freetype working function

by Alexandre Julliard

Сергей Мосин <svmosin(a)gmail.com> writes: > The function WineEngAddFontMemResourceEx in gdi32/fretype.c contained > strange XOR operation with some random number 0x87654321, instead of > returning the real font handle. Do you have an app that depends on this? What does it do with the handle? -- Alexandre Julliard julliard(a)winehq.org

Sept. 28, 2012

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.

by Hans Leidekker

On Thu, 2012-09-27 at 23:07 +0200, Christian Costa wrote: > >> if (!(cabinet_file = get_cabinet_filename(mi))) > > The requirement that the continuous cabinet name matches the next cabinet in the media table > > might simply be too strict. Perhaps we need to try them one by one and let FDI decide based > > on the setID and iCabinet fields. Can you please add some tests? > > > Does not seem trivial to test this but I will try. It shouldn't be too hard, we already have some tests for continuous cabinets.

Sept. 28, 2012

Re: CIA going down: KGB wants your commits!

by Charles Davis

On Sep 27, 2012, at 5:10 PM, Austin English wrote: > -- > -Austin > > ---------- Forwarded message ---------- > From: Martín Ferrari <martin.ferrari(a)gmail.com> > Date: Thu, Sep 27, 2012 at 3:52 PM > Subject: CIA going down: KGB wants your commits! > To: debian-project(a)lists.debian.org, Debian Developers > <debian-devel(a)lists.debian.org> > > > Hi there! > > Not to "to knock 'em when they're down", but since it seems that the CIA.vc > service has officially closed recently (cannot find exactly when did that > happen), I think it's worthwhile offering this little project we (dam@, > gregoa@, and me) have since a few years ago, called KGB (ha-ha). > > It's a very simple and dumb client-server architecture: IRC bots running in > our personal servers listen for SOAP messages sent by kgb-clients called > from post-commit hooks in repos out there. The bot just relays and formats > a message, nothing fancier than that. > > So, if you're looking for a simple IRC notification of your commits, this > might be of help. I'd like to put forward another alternative, from the guy who maintained the CIA scripts for git: http://www.catb.org/esr/irker/ (Yeah, that ESR.) After the CIA announcement, he rushed to get it out as a replacement, though he's seen this coming and has been working on this for quite some time. It's even backwards-compatible (to some extent) with CIA: it can take XML-RPC notifications sent by CIA clients. Just making sure you evaluate all your options. :) Oh, and personally, I wouldn't trust anything associated with the KGB. (Just kidding... ;) Chip > > You can either run your own bot (debian package kgb-bot), or use ours. As > for the client, alioth does not have it installed, but you can run it off > /home/groups/kgb. There's a sample configuration there too. In > /home/groups/pkg-perl/meta/pkg-perl-post-receive you can see how to use it > from a post-commit hook. > > If you rather use our bots, we'll need you to provide: a project/repository > name, an IRC channel, and a password (used to avoid spam, not really > secure). > > -- > Martín Ferrari > > > -- > To UNSUBSCRIBE, email to debian-devel-REQUEST(a)lists.debian.org > with a subject of "unsubscribe". Trouble? Contact listmaster(a)lists.debian.org > Archive: http://lists.debian.org/CAL60Pd_7zoPk4w4rta49-jymxzKOU+K7DdqZUiqsP32KZ9bQBA… > >

Sept. 28, 2012

Fwd: CIA going down: KGB wants your commits!

by Austin English

-- -Austin ---------- Forwarded message ---------- From: Martín Ferrari <martin.ferrari(a)gmail.com> Date: Thu, Sep 27, 2012 at 3:52 PM Subject: CIA going down: KGB wants your commits! To: debian-project(a)lists.debian.org, Debian Developers <debian-devel(a)lists.debian.org> Hi there! Not to "to knock 'em when they're down", but since it seems that the CIA.vc service has officially closed recently (cannot find exactly when did that happen), I think it's worthwhile offering this little project we (dam@, gregoa@, and me) have since a few years ago, called KGB (ha-ha). It's a very simple and dumb client-server architecture: IRC bots running in our personal servers listen for SOAP messages sent by kgb-clients called from post-commit hooks in repos out there. The bot just relays and formats a message, nothing fancier than that. So, if you're looking for a simple IRC notification of your commits, this might be of help. You can either run your own bot (debian package kgb-bot), or use ours. As for the client, alioth does not have it installed, but you can run it off /home/groups/kgb. There's a sample configuration there too. In /home/groups/pkg-perl/meta/pkg-perl-post-receive you can see how to use it from a post-commit hook. If you rather use our bots, we'll need you to provide: a project/repository name, an IRC channel, and a password (used to avoid spam, not really secure). -- Martín Ferrari -- To UNSUBSCRIBE, email to debian-devel-REQUEST(a)lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmaster(a)lists.debian.org Archive: http://lists.debian.org/CAL60Pd_7zoPk4w4rta49-jymxzKOU+K7DdqZUiqsP32KZ9bQBA…

Sept. 27, 2012

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.

by Christian Costa

Le 27/09/2012 11:26, Hans Leidekker a écrit : > On Thu, 2012-09-27 at 09:59 +0200, Christian Costa wrote: > >> diff --git a/dlls/msi/media.c b/dlls/msi/media.c >> index 612624d..8a39fcd 100644 >> --- a/dlls/msi/media.c >> +++ b/dlls/msi/media.c >> @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet(FDINOTIFICATIONTYPE fdint, >> >> if (strcmpiW( mi->cabinet, cab )) >> { >> - ERR("Continuous cabinet does not match the next cabinet in the Media table\n"); >> - goto done; >> + LPSTR next_cab; >> + >> + WARN("Continuous cabinet %s does not match the next cabinet %s in the media table\n", debugstr_w(cab), debugstr_w(mi->cabinet)); >> + >> + /* Use cabinet name from the media table */ >> + next_cab = strdupWtoA(mi->cabinet); >> + /* Modify path to cabinet file with full filename (psz3 points to a 256 bytes buffer that can be modified contrary to psz1 and psz2) */ >> + strcat(pfdin->psz3, "\\"); >> + strcat(pfdin->psz3, next_cab); >> + /* Path psz3 and cabinet psz1 are concatenated by FDI so just reset psz1 */ >> + *pfdin->psz1 = 0; >> + msi_free(next_cab); >> } >> >> if (!(cabinet_file = get_cabinet_filename(mi))) > The requirement that the continuous cabinet name matches the next cabinet in the media table > might simply be too strict. Perhaps we need to try them one by one and let FDI decide based > on the setID and iCabinet fields. Can you please add some tests? > > > Does not seem trivial to test this but I will try. Thanks Christian

Sept. 27, 2012

Re: is CreateThread(CREATE_SUSPENDED) fully functional?

by André Hentschel

Am 27.09.2012 09:13, schrieb Joerg-Cyril.Hoehle(a)t-systems.com: > Hi, > > Recently I thought I found a use-case for CreateThread(CREATE_SUSPENDED). > The idiom is to get the thread handle before the thread starts a life on its own. > > I looked at the kernel tests, > http://source.winehq.org/source/dlls/kernel32/tests/thread.c#L460 > > However, both invocations with CREATE_SUSPENDED actually test the > pair CreateThread + SuspendThread. The tests do not prove that CREATE_SUSPENDED works! > They only prove that the suspend counter and perhaps SuspendThread work. > > a) Does Wine not support CREATE_SUSPENDED, so that the tests do the best they can? > In such a case, a WARN("ignoring SUSPENDED flag, beware of race conditions\n") would be appropriate. > > or > b) CREATE_SUSPENDED is fully supported on all platforms. > Then the tests need some refinement. Why did you only had a look at the tests? I checked the source in 30 seconds and answered the question for me: CREATE_SUSPENDED is an essential part of the CreateThread Implementation. Anyway, more tests are always welcome. -- Best Regards, André Hentschel

Sept. 27, 2012

Re: is CreateThread(CREATE_SUSPENDED) fully functional?

by Vincent Povirk

I'm pretty sure CREATE_SUSPENDED works. It's such a basic thing that would cause many race conditions if it did not, including in parts of Wine that use it and in the test you just linked. If the new thread were not initially suspended, it would be possible for the thread to return between the initial CreateThread call and the following SuspendThread call. This would cause the first WaitForSingleObject to succeed and the test to fail. I guess you could change the test to include a wait before the first SuspendThread call, but given that there probably aren't any broken implementations that this would specifically catch (and those implementations would already fail sometimes), I don't see the point.

Sept. 27, 2012

Re: [1/3] gdiplus: Move font substitution test into a separate body.

by Vincent Povirk

The series looks good to me. Very cool to have a fix for this.

Sept. 27, 2012

Re: gdiplus: Reuse an existing image stream in GdipImageSelectActiveFrame.

by Vincent Povirk

> @@ -3898,7 +3894,7 @@ GpStatus WINGDIPAPI GdipImageSelectActiveFrame(GpImage *image, GDIPCONST GUID *d > return Ok; > } > > - IStream_Release(stream); > + IStream_Release(image->stream); > return stat; > } I don't think it's necessary to AddRef/Release the stream anymore in GdipImageSelectActiveFrame. Creating the new image and freeing the old one will update the refcount as necessary. And it's a bit confusing since technically the current image->stream is released by free_image_data then overwritten (with the same value, fortunately) by copying new_image to image. Looks good otherwise.

Sept. 27, 2012

'sort' implementation (Bug 27933) - any easy way?

by Ann and Jason Edmeades

Hello, While working on more of the 'for' processing in the command shell, I've come across a stumbling block that wildcard expansion 'ordering' is not guaranteed (findfirst/findnext) meaning I cannot automate tests for some of the key bits - this is frustrating as we really need tests for the things I'm looking at as the code is getting complex. Looking in the cmd testsuite, there's already some commented out tests as well, saying we really need a 'sort' implementation, and that would also resolve the problem I have at the moment. Therefore, I'd like to know if there's any simple way to implement a command line sort program which we can call from the command shell. This has subsequently been raised as bug 27933. My first thought was to avoid reinventing the wheel and to have a windows program called sort which parses its parameters and then runs the Unix 'sort' command with an equivalent command line. I think most of the windows command line parameters have Unix equivalents, and for the majority of cases it would be a case of transposing a windows path to a Unix path, and just running the Unix sort. However, I then started to get concerned about stdin / stdout... Is there any way to take the windows stdin and 'connect it' to the unix program you spawn, and vica-versa for the stdout. Whilst I dont accurately need this for the testsuite, without it the wine implementation would not match the windows one. So I think my specific questions are... 1. Is wrappering an existing (Linux) 'sort' program an option for this, or do we really need a whole unique implementation of sort (which I would have no idea how to write!)? If it is an option, the two key questions I have are: 2. How do I handle stdin / stdout, so sort can work in pipes / redirects 3. Is it ok to use wine_get_unix_file_name to convert files and directories to the unix equivalents when building the unix equivalent command line? (as per winepath) Thanks. Jason

Sept. 27, 2012

Re: d3dx9_36 [patch 6/6]: Implement D3DXSHEvalHemisphereLight

by Rico Schüller

Well I think, if you rework a series, please add something like try xyz or so ... Also try to avoid to add / remove some patches, at least if they actually don't have anything todo with the rest of the patch set (if they could be submitted on their own). On 27.09.2012 10:00, Nozomi Kodama wrote: > + TRACE("%u, %p, %p, %p, %p, %p, %p\n", order, dir, &top, &bottom, rout, gout, bout); Sure, that's an other form of the trace. I think we hadn't one with such a version... other traces in the file look like (the one marked with * is my preferred version): TRACE("out %p, order %u, a %p, b %p\n", out, order, a, b); * TRACE("(%p, %p, %u)\n", pout, pin, n); I don't think it makes much sense to print the address for &top. It doesn't gather some useful information, does it? Instead you may print the actual content for r,g,b if you like. > + if ( gout ) Also here, I prefer "if (gout)" ... I know there are several occurrences for the other style ... I should have mentioned that earlier ... it's not something which is critical... git grep "if (" dlls/d3dx9_36/* | wc -l reveals ~2000 while git grep "if ( " dlls/d3dx9_36/* | wc -l does ~100 > + ok(relative_error(expected, blue_out[j]) < admitted_error, > + "Blue: case %u, order %u: expected[%u] = %f, received %f \n", l, order, j, expected, blue_out[j]); Please indent 8 instead of 2 spaces when a new line is used ... Cheers Rico

Sept. 27, 2012

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.

by Hans Leidekker

On Thu, 2012-09-27 at 09:59 +0200, Christian Costa wrote: > diff --git a/dlls/msi/media.c b/dlls/msi/media.c > index 612624d..8a39fcd 100644 > --- a/dlls/msi/media.c > +++ b/dlls/msi/media.c > @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet(FDINOTIFICATIONTYPE fdint, > > if (strcmpiW( mi->cabinet, cab )) > { > - ERR("Continuous cabinet does not match the next cabinet in the Media table\n"); > - goto done; > + LPSTR next_cab; > + > + WARN("Continuous cabinet %s does not match the next cabinet %s in the media table\n", debugstr_w(cab), debugstr_w(mi->cabinet)); > + > + /* Use cabinet name from the media table */ > + next_cab = strdupWtoA(mi->cabinet); > + /* Modify path to cabinet file with full filename (psz3 points to a 256 bytes buffer that can be modified contrary to psz1 and psz2) */ > + strcat(pfdin->psz3, "\\"); > + strcat(pfdin->psz3, next_cab); > + /* Path psz3 and cabinet psz1 are concatenated by FDI so just reset psz1 */ > + *pfdin->psz1 = 0; > + msi_free(next_cab); > } > > if (!(cabinet_file = get_cabinet_filename(mi))) The requirement that the continuous cabinet name matches the next cabinet in the media table might simply be too strict. Perhaps we need to try them one by one and let FDI decide based on the setID and iCabinet fields. Can you please add some tests?

Sept. 27, 2012

Re: dsound: Don't bother shrinking the secondary buffer list.

by Michael Stefaniuc

Hello Jörg, as always it depends. On 09/27/2012 09:37 AM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: >> +#include <assert.h> > > your patch is already committed, yet I believe that the least that dsound needs is new asserts. > > Asserts in dsound have been a PITA in Wine for the last decade. > > It's ok for the kernel to crash in an assert. IMHO it is not ok for an optional thing like sound. > > The assert's backtrace will not help anybody, because the logical error will have happened much earlier. I disagree. It helps GyB to open regression bug reports and it helps me to fix them. > Instead, a plain ERR would have been just as telling. Let's quote > http://www.winehq.org/docs/winedev-guide/debugging#DBG-CLASSES > "ERR: Messages in this class indicate serious errors in Wine, > such as as conditions that should never happen by design." > > I recommend: > - assert(device->buffers[0] == pDSB); > + if (pdevice->buffers[0] != pDSB) > + ERR("broken device buffer %p\n", device->buffers[0]); > HeapFree(GetProcessHeap(), 0, device->buffers); > device->buffers = NULL; > > The ERR is IMHO revealing enough in a user's log. That's too late if it hits the user. I had reviewed the code: That code is an implementation detail completely outside the control of the applications. Barring a memory corruption there is no way for it to fail. The assert is there for two reasons: - To crash during "make test" when the next developer touches that code. - As a comment less likely to be removed by Alexandre ;) > If a sound component detects a bogus state, > I'd very much prefer that it disables sound -- without crashing. In general "it depends" of course. In this particular case the ERR would be useless noise as the assert is only for the last sound buffer that is removed; usually at program exit. Until then the code does what you prefer: silently drops sound buffers without crashing thus deferring the crash to the program exit. A crash on program exit does get reported, more so than an ERR on the command line. bye michael

Sept. 27, 2012

Re: d3dx9_36 [patch 1/6]: Implement D3DXSHMultiply4

by Rico Schüller

On 27.09.2012 09:56, Nozomi Kodama wrote: > +FLOAT* WINAPI D3DXSHMultiply4(FLOAT *out, CONST FLOAT *a, CONST FLOAT *b) FLOAT * WINAPI D3DXSHMultiply4(FLOAT *out, const FLOAT *a, const FLOAT *b) A minor nitpick, anyone against something like? I think that was what Matteo meant in http://www.winehq.org/pipermail/wine-devel/2012-September/096924.html with "Fix the FLOAT*"? > + TRACE("(%p, %p, %p)\n", out, a, b); I would probably prefer: TRACE("out %p, a %p, b %p\n", out, a, b); I know the other Multiply functions and so on use your trace format... > + out[0] = 0.28209479f * a[0] * b[0]; There are still double spaces ... Hint: it's not the only occurrence. Cheers Rico

Sept. 27, 2012

Re: d3dx9_36 [patch 2/6]: Speed-up some tests

by Rico Schüller

On 27.09.2012 09:57, Nozomi Kodama wrote: > - FLOAT a[64], b[64], got; > + FLOAT a[49], b[49], got; > CONST FLOAT expected[] = > { 0.5f, 0.5f, 25.0f, 262.5f, 1428.0f, 5362.0f, 15873.0f, 39812.0f, 88400.0f, }; > > - for (i = 0; i < 64; i++) > + for (i = 0; i < 49; i++) > > - for (i = 0; i < 9; i++) > + for (i = 0; i <= D3DXSH_MAXORDER + 1; i++) Again: You may correct the (array) size for the expected value ... If we run til element 7 instead of 8, I think the last element could be thrown away? Cheers Rico

Sept. 27, 2012

dsound: Don't bother shrinking the secondary buffer list.

by Joerg-Cyril.Hoehle＠t-systems.com

Michael, >+#include <assert.h> your patch is already committed, yet I believe that the least that dsound needs is new asserts. Asserts in dsound have been a PITA in Wine for the last decade. It's ok for the kernel to crash in an assert. IMHO it is not ok for an optional thing like sound. The assert's backtrace will not help anybody, because the logical error will have happened much earlier. Instead, a plain ERR would have been just as telling. Let's quote http://www.winehq.org/docs/winedev-guide/debugging#DBG-CLASSES "ERR: Messages in this class indicate serious errors in Wine, such as as conditions that should never happen by design." I recommend: - assert(device->buffers[0] == pDSB); + if (pdevice->buffers[0] != pDSB) + ERR("broken device buffer %p\n", device->buffers[0]); HeapFree(GetProcessHeap(), 0, device->buffers); device->buffers = NULL; The ERR is IMHO revealing enough in a user's log. If a sound component detects a bogus state, I'd very much prefer that it disables sound -- without crashing. Regards, Jörg Höhle

Sept. 27, 2012

is CreateThread(CREATE_SUSPENDED) fully functional?

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, Recently I thought I found a use-case for CreateThread(CREATE_SUSPENDED). The idiom is to get the thread handle before the thread starts a life on its own. I looked at the kernel tests, http://source.winehq.org/source/dlls/kernel32/tests/thread.c#L460 However, both invocations with CREATE_SUSPENDED actually test the pair CreateThread + SuspendThread. The tests do not prove that CREATE_SUSPENDED works! They only prove that the suspend counter and perhaps SuspendThread work. a) Does Wine not support CREATE_SUSPENDED, so that the tests do the best they can? In such a case, a WARN("ignoring SUSPENDED flag, beware of race conditions\n") would be appropriate. or b) CREATE_SUSPENDED is fully supported on all platforms. Then the tests need some refinement. Thank you, Jörg Höhle

Sept. 27, 2012

Re: Re : d3dx9 [patch 1/5]: Implement D3DXSHMultiply4

by Rico Schüller

On 26.09.2012 19:09, Nozomi Kodama wrote: > >> + D3DXSHMultiply4(c, a, b); > >>What happens if you use something like D3DXSHMultiply4(c, c, c). Is > that allowed? > > Tests in native show that D3DXSHMultiply gives what I implemented. > We can not reuse a input variable as output (we don't obtain what we > expect logically). I gave it a try, and your implementation seems to be correct. I tried: D3DXSHMultiply4(c, a, c); D3DXSHMultiply4(c, c, b); // used c[i] = ((float)i) / 20; to not give always -nan D3DXSHMultiply4(c, c, c); They look pretty much the same for wine and native. Why then not add a test for this? Sure, you don't get what you logically expect, but we need to reproduce the results and that has not always something to do with logic :-) . It is a little bit contrary to the part below, because when you change the order and reuse code, the calculation for this corner cases might get wrong (I'm not sure, haven't tried it). > > >Also is there a reason why it uses slightly different values than e.g. > D3DXSHMultiply3? Why don't we >use defines? A problem might be to find > good names... Maybe the Multiply functions could share the >same base? > To me it looks like they do share a lot of calculations, And if the > order doesn't matter (see >comment above) then it may be possible to > rearrange the calculation. > > > >ta = 0.28209479f * a[0] - 0.12615663f * a[6] - 0.21850969f * a[8]; > >vs > >ta = 0.28209479f * a[0] - 0.12615662f * a[6] - 0.21850968f * a[8]; > > I do the computations with a formal computation software. Unfortunately > I did not use the same for D3DXSHMultiply4 and D3DXSHMultiply3 ..... > (Xcas vs Maple). And obtain the exact values look beyond the capacities > of these softwares. > > And even the worst, since the integrated functions oscillate, the > internal algorithm of the software are not robust to compute the > integrals. For a given number of significative digits, that's why we > obtain slightly different values for the both softwares. > > Addind defines will add tons on variables for no gain. But I can > simplify slightly the function by calling D3DXSHMultiply3. Ok, no problem. See above. I'd say compatibility before simplicity. It was just a thought, because there was no test / comment in the code that makes my suggestion a stupid idea, but the test above makes this idea obsolete. Cheers Rico

Sept. 26, 2012

Re : d3dx9 [patch 1/5]: Implement D3DXSHMultiply4

by Nozomi Kodama

>On 26.09.2012 12:17, Nozomi Kodama wrote: >> + ta =0.28209479f * a[0]+ 0.14567312f * a[8]+ 0.12615663f * a[6]; >> + tb =0.28209479f * b[0]+ 0.14567312f * b[8]+ 0.12615663f * b[6]; >> + out[13] += ta * b[13] + tb * a[13]; <> + t = a[13] * b[13]; >> + out[0] +=0.28209479f *t; >Please use spaces with care. >The preferred way is "x = 123 * a[0] + 456 * b[234]; Mostly one space is enough, only use two or more if >you like to indent something, that's mostly not the case when calculating a value. Even then, please be >consistent across your patch. oops!!! I will take care of this one. >> + D3DXSHMultiply4(c, a, b); >>What happens if you use something like D3DXSHMultiply4(c, c, c). Is that allowed? Tests in native show that D3DXSHMultiply gives what I implemented. We can not reuse a input variable as output (we don't obtain what we expect logically). >Also is there a reason why it uses slightly different values than e.g. D3DXSHMultiply3? Why don't we >use defines? A problem might be to find good names... Maybe the Multiply functions could share the >same base? To me it looks like they do share a lot of calculations, And if the order doesn't matter (see >comment above) then it may be possible to rearrange the calculation. > >ta = 0.28209479f * a[0] - 0.12615663f * a[6] - 0.21850969f * a[8]; >vs >ta = 0.28209479f * a[0] - 0.12615662f * a[6] - 0.21850968f * a[8]; I do the computations with a formal computation software. Unfortunately I did not use the same for D3DXSHMultiply4 and D3DXSHMultiply3 ..... (Xcas vs Maple). And obtain the exact values look beyond the capacities of these softwares. And even the worst, since the integrated functions oscillate, the internal algorithm of the software are not robust to compute the integrals. For a given number of significative digits, that's why we obtain slightly different values for the both softwares. Addind defines will add tons on variables for no gain. But I can simplify slightly the function by calling D3DXSHMultiply3. I will give it a try. I worry about efficiency. Best regards Nozomi >Cheers >Rico

Sept. 26, 2012

Re: oledb32: Add support for IDBInitialize interface in IDataInitialize

by Alexandre Julliard

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Changelog: > oledb32: Add support for IDBInitialize interface in IDataInitialize It doesn't work here: ../../../tools/runtest -q -P wine -M oledb32.dll -T ../../.. -p oledb32_test.exe.so database.c && touch database.ok database.c:43: Test failed: Unable to load oledb library make[1]: *** [database.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

Sept. 26, 2012

Re: (try 3) imm32: there is only 1 default Hwnd per thread

by Aric Stewart

Ok I will continue my investigates and try to resolve this or at least generate good test cases. This would also be easier with the thread work with user handles that I have needed in imm32 for longer than I remember the details about. :) But they relate to patches 8d12fc61d5321350ad63b173bdfb50feef1f4b56 and cc945706a4933cda0d204ba07a13e93fccb66d18 -aric On 9/26/12 10:26 AM, Alexandre Julliard wrote: > Aric Stewart <aric(a)codeweavers.com> writes: > >> Do you want to delay on this fix until I figure our what should be >> happening with IMMGWL_IMC. Or I can have a second patch addressing >> IMMGWL_IMC and how that is suppose to be handled. > > I think a few more test cases would be a good idea at this point. >

Sept. 26, 2012

Re: (try 3) imm32: there is only 1 default Hwnd per thread

by Alexandre Julliard

Aric Stewart <aric(a)codeweavers.com> writes: > Do you want to delay on this fix until I figure our what should be > happening with IMMGWL_IMC. Or I can have a second patch addressing > IMMGWL_IMC and how that is suppose to be handled. I think a few more test cases would be a good idea at this point. -- Alexandre Julliard julliard(a)winehq.org

Sept. 26, 2012

Re: (try 3) imm32: there is only 1 default Hwnd per thread

by Aric Stewart

On 9/26/12 10:18 AM, Alexandre Julliard wrote: > Aric Stewart <aric(a)codeweavers.com> writes: > >> - if (data->imeWnd == NULL) >> + if (defWnd == NULL) >> { >> /* create the ime window */ >> - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, >> + defWnd = CreateWindowExW( WS_EX_TOOLWINDOW, >> data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, >> 0, data->immKbd->hIME, 0); >> - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); >> - IMM_GetThreadData()->hwndDefault = data->imeWnd; >> + SetWindowLongPtrW(defWnd, IMMGWL_IMC, (LONG_PTR)data); >> + IMM_GetThreadData()->hwndDefault = defWnd; > > So now, shouldn't you be resetting IMMGWL_IMC at some point? > Yeah, I am digging into that as we speak. My testing on testbot is not giving me any real rational results on that area. At least nothing matching my documentation as to how it is suppose to work. I need to get my Japanese VM back up and working and really try to dig into that. Right now it is working and more correct that it was. My guess is that we should not be dealing with IMMGWL_IMC at all at that point anyway. Do you want to delay on this fix until I figure our what should be happening with IMMGWL_IMC. Or I can have a second patch addressing IMMGWL_IMC and how that is suppose to be handled. -aric

Sept. 26, 2012

Re: (try 3) imm32: there is only 1 default Hwnd per thread

by Alexandre Julliard

Aric Stewart <aric(a)codeweavers.com> writes: > - if (data->imeWnd == NULL) > + if (defWnd == NULL) > { > /* create the ime window */ > - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > + defWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > 0, data->immKbd->hIME, 0); > - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > - IMM_GetThreadData()->hwndDefault = data->imeWnd; > + SetWindowLongPtrW(defWnd, IMMGWL_IMC, (LONG_PTR)data); > + IMM_GetThreadData()->hwndDefault = defWnd; So now, shouldn't you be resetting IMMGWL_IMC at some point? -- Alexandre Julliard julliard(a)winehq.org

Sept. 26, 2012

Re: (resend) imm32: there is only 1 default Hwnd per thread

by Aric Stewart

On 9/26/12 7:27 AM, Alexandre Julliard wrote: > Aric Stewart <aric(a)codeweavers.com> writes: > >> This corrects issues with applications that create and manage multiple IMCs >> try 2: >> avoid premature destruction of the window >> --- >> dlls/imm32/imm.c | 22 ++++++++++++---------- >> dlls/imm32/tests/imm32.c | 28 ++++++++++++++++++++++++++++ >> 2 files changed, 40 insertions(+), 10 deletions(-) >> >> >> >> diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c >> index 7394101..a18aa26 100644 >> --- a/dlls/imm32/imm.c >> +++ b/dlls/imm32/imm.c >> @@ -678,10 +678,6 @@ static BOOL IMM_DestroyContext(HIMC hIMC) >> data->immKbd->pImeSelect(hIMC, FALSE); >> SendMessageW(data->IMC.hWnd, WM_IME_SELECT, FALSE, (LPARAM)GetKeyboardLayout(0)); >> >> - if (IMM_GetThreadData()->hwndDefault == data->imeWnd) >> - IMM_GetThreadData()->hwndDefault = NULL; >> - DestroyWindow(data->imeWnd); >> - >> ImmDestroyIMCC(data->IMC.hCompStr); >> ImmDestroyIMCC(data->IMC.hCandInfo); >> ImmDestroyIMCC(data->IMC.hGuideLine); >> @@ -2323,12 +2319,18 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) >> >> if (data->imeWnd == NULL) >> { >> - /* create the ime window */ >> - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, >> - data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, >> - 0, data->immKbd->hIME, 0); >> - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); >> - IMM_GetThreadData()->hwndDefault = data->imeWnd; >> + HWND def = IMM_GetThreadData()->hwndDefault; >> + if (def == NULL) >> + { >> + /* create the ime window */ >> + data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, >> + data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, >> + 0, data->immKbd->hIME, 0); >> + SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); >> + IMM_GetThreadData()->hwndDefault = data->imeWnd; >> + } >> + else >> + data->imeWnd = def; > > So why is there a window in the IMC at all, if it's not used for > anything? > So looking and reading my documentation I can see i had a bit of a miss-understanding about the default IME window all the way back to when i initial did the code for loading IME as separate dlls. This is a leftover from that. There should not be a window in the IMC. I will remove that. -aric

Sept. 26, 2012

Re: [PATCH 2/8] vbscript: Added VT_R8 support to to_int

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21824 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 26, 2012

Re: [PATCH 1/8] vbscript: Added Round implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21823 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 26, 2012

Re: (resend) imm32: there is only 1 default Hwnd per thread

by Alexandre Julliard

Aric Stewart <aric(a)codeweavers.com> writes: > This corrects issues with applications that create and manage multiple IMCs > try 2: > avoid premature destruction of the window > --- > dlls/imm32/imm.c | 22 ++++++++++++---------- > dlls/imm32/tests/imm32.c | 28 ++++++++++++++++++++++++++++ > 2 files changed, 40 insertions(+), 10 deletions(-) > > > > diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c > index 7394101..a18aa26 100644 > --- a/dlls/imm32/imm.c > +++ b/dlls/imm32/imm.c > @@ -678,10 +678,6 @@ static BOOL IMM_DestroyContext(HIMC hIMC) > data->immKbd->pImeSelect(hIMC, FALSE); > SendMessageW(data->IMC.hWnd, WM_IME_SELECT, FALSE, (LPARAM)GetKeyboardLayout(0)); > > - if (IMM_GetThreadData()->hwndDefault == data->imeWnd) > - IMM_GetThreadData()->hwndDefault = NULL; > - DestroyWindow(data->imeWnd); > - > ImmDestroyIMCC(data->IMC.hCompStr); > ImmDestroyIMCC(data->IMC.hCandInfo); > ImmDestroyIMCC(data->IMC.hGuideLine); > @@ -2323,12 +2319,18 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) > > if (data->imeWnd == NULL) > { > - /* create the ime window */ > - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > - data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > - 0, data->immKbd->hIME, 0); > - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > - IMM_GetThreadData()->hwndDefault = data->imeWnd; > + HWND def = IMM_GetThreadData()->hwndDefault; > + if (def == NULL) > + { > + /* create the ime window */ > + data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > + data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > + 0, data->immKbd->hIME, 0); > + SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > + IMM_GetThreadData()->hwndDefault = data->imeWnd; > + } > + else > + data->imeWnd = def; So why is there a window in the IMC at all, if it's not used for anything? -- Alexandre Julliard julliard(a)winehq.org

Sept. 26, 2012

Re: d3dx9 [patch 1/5]: Implement D3DXSHMultiply4

by Rico Schüller

On 26.09.2012 12:17, Nozomi Kodama wrote: > + ta =0.28209479f * a[0]+ 0.14567312f * a[8]+ 0.12615663f * a[6]; > + tb =0.28209479f * b[0]+ 0.14567312f * b[8]+ 0.12615663f * b[6]; > + out[13] += ta * b[13] + tb * a[13]; > + t = a[13] * b[13]; > + out[0] +=0.28209479f *t; Please use spaces with care. The preferred way is "x = 123 * a[0] + 456 * b[234]; Mostly one space is enough, only use two or more if you like to indent something, that's mostly not the case when calculating a value. Even then, please be consistent across your patch. > + D3DXSHMultiply4(c, a, b); What happens if you use something like D3DXSHMultiply4(c, c, c). Is that allowed? Also is there a reason why it uses slightly different values than e.g. D3DXSHMultiply3? Why don't we use defines? A problem might be to find good names... Maybe the Multiply functions could share the same base? To me it looks like they do share a lot of calculations, And if the order doesn't matter (see comment above) then it may be possible to rearrange the calculation. ta = 0.28209479f * a[0] - 0.12615663f * a[6] - 0.21850969f * a[8]; vs ta = 0.28209479f * a[0] - 0.12615662f * a[6] - 0.21850968f * a[8]; Cheers Rico

Sept. 26, 2012

Re: winspool/tests: Don't crash when AddJob/GetJob fails (win8)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21799 Your paranoid android. === WINEBUILD (build) === Can't determine base name

Sept. 25, 2012

Re: ImmIsUIMessageA/W

by André Hentschel

Am 25.09.2012 21:54, schrieb Henri Verbeet: > On 25 September 2012 21:12, André Hentschel <nerv(a)dawncrow.de> wrote: >> I don't remember the app, be free to patch it in again, at best with tests. >> > Wasn't that for World of Tanks? > Oh, true. thx. It's all about http://bugs.winehq.org/show_bug.cgi?id=27554 d08fa61a568c618278132cd6abb6a093a5c7799a break WoT and 7673d67c1e1cfdcdf7560beea9162c3699329aa5 fixed it -- Best Regards, André Hentschel

Sept. 25, 2012

Re: Wine Mono 0.0.6 Release - Because hey, why not?

by Vincent Povirk

So, it seems I've screwed up this release. Sorry about that. It won't be added to Wine, and I'll try again later. Specifically, I messed up the flags on the mono-registry64 msi component, and I forgot to commit the guids for the new System.Web.Http.SelfHost msi components (which means packages built from the source tarball will have different guids, and weird things could happen to that component when upgrading from them).

Sept. 25, 2012

Re: ImmIsUIMessageA/W

by Henri Verbeet

On 25 September 2012 21:12, André Hentschel <nerv(a)dawncrow.de> wrote: > I don't remember the app, be free to patch it in again, at best with tests. > Wasn't that for World of Tanks?

Sept. 25, 2012

Re: ImmIsUIMessageA/W

by André Hentschel

Am 25.09.2012 14:48, schrieb Aric Stewart: >> >>> also you eliminate the part where if the incoming hWndIME is NULL we send the message to the thread's default IME window. >> >> my changes made an app happy IIRC, further i think i was skeptical about IMM_GetThreadData()->hwndDefault because of the dead code. >> maybe it should be patched in again, not sure. >> >> > > I would be curious about this. What was your app and could I test it? I find there are many applications that are half-ime aware. That use ImmIsUIMessage with a NULL hwnd and expect the message to be processed but the default IME window. So we need that behavior to remain true. > > I would be curious why your app was unhappy about that. I don't remember the app, be free to patch it in again, at best with tests. -- Best Regards, André Hentschel

Sept. 25, 2012

Re: imm32: there is only 1 default Hwnd per thread

by Aric Stewart

On 9/25/12 1:38 PM, Alexandre Julliard wrote: > Aric Stewart <aric(a)codeweavers.com> writes: > >> @@ -2323,12 +2323,18 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) >> >> if (data->imeWnd == NULL) >> { >> - /* create the ime window */ >> - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, >> - data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, >> - 0, data->immKbd->hIME, 0); >> - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); >> - IMM_GetThreadData()->hwndDefault = data->imeWnd; >> + HWND def = IMM_GetThreadData()->hwndDefault; >> + if (def == NULL) >> + { >> + /* create the ime window */ >> + data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, >> + data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, >> + 0, data->immKbd->hIME, 0); >> + SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); >> + IMM_GetThreadData()->hwndDefault = data->imeWnd; >> + } >> + else >> + data->imeWnd = def; > > So what happens to the window if the first IMC is destroyed? > The window should stick around until the thread data is destroyed. Theoretically the IMC that has this window is the default one for the thread. Which cannot be destroyed until the thread data is destroyed. I see the issue you are worried about and I will work to resolve that. -aric

Sept. 25, 2012

Re: imm32: there is only 1 default Hwnd per thread

by Alexandre Julliard

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -2323,12 +2323,18 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) > > if (data->imeWnd == NULL) > { > - /* create the ime window */ > - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > - data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > - 0, data->immKbd->hIME, 0); > - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > - IMM_GetThreadData()->hwndDefault = data->imeWnd; > + HWND def = IMM_GetThreadData()->hwndDefault; > + if (def == NULL) > + { > + /* create the ime window */ > + data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > + data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > + 0, data->immKbd->hIME, 0); > + SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > + IMM_GetThreadData()->hwndDefault = data->imeWnd; > + } > + else > + data->imeWnd = def; So what happens to the window if the first IMC is destroyed? -- Alexandre Julliard julliard(a)winehq.org

Sept. 25, 2012

Re: [PATCH] iphlpapi: Set DhcpEnabled to TRUE for all interfaces.

by André Hentschel

Am 25.09.2012 18:40, schrieb Qian Hong: > Hi Juan, > > On Tue, Sep 25, 2012 at 11:53 PM, Juan Lang <juan.lang(a)gmail.com> wrote: >> >> I think this is fine, but you'd want to remove/fix some outdated >> comments I wrote at the same time: > > Thank you very much! > I'll send an improved version tomorrow since I just drank some beer > right now and I think it is not compatible with Wine ;-) That's a known bug http://bugs.winehq.org/show_bug.cgi?id=27162 -- Best Regards, André Hentschel

Sept. 25, 2012

Re: [PATCH] iphlpapi: Set DhcpEnabled to TRUE for all interfaces.

by Qian Hong

Hi Juan, On Tue, Sep 25, 2012 at 11:53 PM, Juan Lang <juan.lang(a)gmail.com> wrote: > > I think this is fine, but you'd want to remove/fix some outdated > comments I wrote at the same time: Thank you very much! I'll send an improved version tomorrow since I just drank some beer right now and I think it is not compatible with Wine ;-) -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

Sept. 25, 2012

Re: [PATCH] iphlpapi: Set DhcpEnabled to TRUE for all interfaces.

by Juan Lang

Hi Qian, > There is a winpcap based network authentication client which check for the DhcpEnabled value, this patch make the app happy and then the app works with André's pcap wrapper [1]. > > Please let me know if this is acceptable, or we have to correctly implement DhcpEnabled status? I think this is fine, but you'd want to remove/fix some outdated comments I wrote at the same time: * NOTES * Since GetAdaptersInfo never returns adapters that have DHCP enabled, * this function does nothing. * * FIXME * Stub, returns ERROR_NOT_SUPPORTED. */ DWORD WINAPI IpReleaseAddress(PIP_ADAPTER_INDEX_MAP AdapterInfo) { TRACE("AdapterInfo %p\n", AdapterInfo); /* not a stub, never going to support this (and I never mark an adapter as DHCP enabled, see GetAdaptersInfo, so this should never get called) */ The same comments are in IpRenewAddress. Historical reason: when I wrote iphlpapi's first implementation, I had recently been working on a Windows app that released and renewed IP addresses on DHCP-enabled interfaces, because Windows at the time was pretty poor at doing so in response to changes to wireless connection state. I figured I wouldn't be the only one to have had to work around this issue, so I didn't want to have to implement IpReleaseAddress and IpRenewAddress in Wine. That was almost 10 years ago now, so these reasons no longer apply. I'm pretty sure the app I wrote isn't in use any longer, and even if it is, it isn't in use on Wine (I also wrote a Linux version.) Thanks, --Juan

Sept. 25, 2012

Re: ImmIsUIMessageA/W

by Aric Stewart

Hi Andre, On 9/24/12 3:00 PM, André Hentschel wrote: > Am 21.09.2012 18:46, schrieb Aric Stewart: >> Hi Andre, >> >> I have a quick question for you. I am looking into why IME unaware applications are no longer showing their composition window and found it was because of: >> >> commit 7673d67c1e1cfdcdf7560beea9162c3699329aa5 >> Author: André Hentschel <nerv(a)dawncrow.de> >> Date: Sat Jun 25 16:13:41 2011 +0200 >> >> imm32: Test and fix ImmIsUIMessageA/W. >> >> in that patch I see that you eliminate the part where we check if there is a default IME window and if not then create one. >> >> if (!IMM_GetThreadData()->hwndDefault) >> ImmGetDefaultIMEWnd(NULL); > > Hi, > this code snippet was a useless construct it seems, because ImmGetDefaultIMEWnd returns IMM_GetThreadData()->hwndDefault which is obviously zero and it's not stored. > You are correct here. It was previously the case that we did not create the default IME window until it was requested. That changed and so now it is useless and can be removed. > >> also you eliminate the part where if the incoming hWndIME is NULL we send the message to the thread's default IME window. > > my changes made an app happy IIRC, further i think i was skeptical about IMM_GetThreadData()->hwndDefault because of the dead code. > maybe it should be patched in again, not sure. > > I would be curious about this. What was your app and could I test it? I find there are many applications that are half-ime aware. That use ImmIsUIMessage with a NULL hwnd and expect the message to be processed but the default IME window. So we need that behavior to remain true. I would be curious why your app was unhappy about that. thanks! -aric

Sept. 25, 2012

Re: vbscript: Added Space() implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21787 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 25, 2012

Re: [PATCH 1/2] mshtml: Added DISPATCH_PROPERTYGET|DISPATCH_METHOD flags support for elements exposed as window properties

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21785 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 25, 2012

Re: shlwapi: PathCreateFromUrlA() should not crash when given NULL buffers.

by Alexandre Julliard

Francois Gouget <fgouget(a)codeweavers.com> writes: > Add NULL and insufficient buffer tests for PathCreateFromUrl(). > --- > dlls/shlwapi/path.c | 3 +++ > dlls/shlwapi/tests/path.c | 49 +++++++++++++++++++++++++++++---------------- > 2 files changed, 35 insertions(+), 17 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M shlwapi.dll -T ../../.. -p shlwapi_test.exe.so path.c && touch path.ok path.c:322: Test succeeded inside todo block: got len = 22 expected 22 from url file:///localhost/c:/foo/bar path.c:322: Test succeeded inside todo block: got len = 19 expected 19 from url file://host//c:/foo/bar make: *** [path.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

Sept. 25, 2012

Re: oledb32: Add support for IDBInitialize interface in IDataInitialize

by Alistair Leslie-Hughes

On 25/09/2012 8:44 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=21782 > > Your paranoid android. > > > === WNT4WSSP6 (32 bit marshal) === > marshal.c:66: Test failed: CoMarshalInterface failed with error 0x80040155 > marshal.c:239: Test failed: "CoUnmarshalInterface" failed with error 0x8003001e > marshal: unhandled exception c0000005 at 004165D0 > This test was already failing for some boxes. See http://test.winehq.org/data/6ebf13960be6105243536113625b5ca50883c8c9/index_… Best Regards Alistair Leslie-Hughes

Sept. 25, 2012

Re: oledb32: Add support for IDBInitialize interface in IDataInitialize

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21782 Your paranoid android. === WNT4WSSP6 (32 bit marshal) === marshal.c:66: Test failed: CoMarshalInterface failed with error 0x80040155 marshal.c:239: Test failed: "CoUnmarshalInterface" failed with error 0x8003001e marshal: unhandled exception c0000005 at 004165D0

Sept. 25, 2012

Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)

by Per Johansson

On Tue, Sep 25, 2012 at 10:57 AM, Francois Gouget <fgouget(a)free.fr> wrote: > On Tue, 25 Sep 2012, Per Johansson wrote: > > > Hi, > > > > I should probably add a note that when I wrote this I had some doubts it > it > > belongs in start.exe, and I still somewhat do. > > > > The alternative would be to write a new program. The advantage to that > is: > > Start.exe already has a /unix option so adding a /AppleEvent one may > make sense. > > I have two questions though (I apologize if careful reading the patch > would answer them). > > How would this new /AppleEvent option be used? > It will be used in file type association scripts created by winemenubuilder (patch 6/6). You won't invoke it manually since it only makes sense if there's an AppleEvent waiting to be delivered. The AppleEvent is sent to an application by OS X when you open a document. Is AppleEvent how they call DDE on Mac OS X<g>? > Pretty much, details differ but it serves the same function. AppleEvents have existed since 1991 and are pretty much unchanged since then at the API level. Mac OS prefers a single instance of each application and the events are therefore sent by the OS instead of a new instance of the application. This patch only checks for an event at launch, but since it usually immediately exits it's then ready to relaunch and check for another event. Regards, -- Per Johansson

Sept. 25, 2012

Re: [5/5] dxgi/tests: Test some reference counts.

by Alexandre Julliard

Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> writes: > --- > dlls/dxgi/tests/device.c | 69 > ++++++++++++++++++++++++++++++++++------------ > 1 file changed, 51 insertions(+), 18 deletions(-) In general testing reference count values is not useful, unless you have an app that depends on it. -- Alexandre Julliard julliard(a)winehq.org

Sept. 25, 2012

Re: Spam applications for testbot accounts

by Francois Gouget

On Mon, 17 Sep 2012, Scott Ritchie wrote: > Never underestimate the overeagerness of bots, I suppose... > > We're getting a lot of spam applications for testbot accounts now, maybe 2-3 > per day. Some are easy to discard because they put stuff like penis pills > into the info field, but others look like just names. Suggestions are > welcome. Is this something that calls for some anti-bot / capcha mechanism in the TestBot? If so please enter a bug on the TestBot's bug tracker: http://bugs.winehq.org/buglist.cgi?product=Wine-Testbot -- Francois Gouget <fgouget(a)codeweavers.com>

Sept. 25, 2012

Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)

by Francois Gouget

On Tue, 25 Sep 2012, Per Johansson wrote: > Hi, > > I should probably add a note that when I wrote this I had some doubts it it > belongs in start.exe, and I still somewhat do. > > The alternative would be to write a new program. The advantage to that is: Start.exe already has a /unix option so adding a /AppleEvent one may make sense. I have two questions though (I apologize if careful reading the patch would answer them). How would this new /AppleEvent option be used? Is AppleEvent how they call DDE on Mac OS X<g>? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Nouvelle version : les anciens bogues ont été remplacés par de nouveaux.

Sept. 25, 2012

Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)

by Per Johansson

Hi, I should probably add a note that when I wrote this I had some doubts it it belongs in start.exe, and I still somewhat do. The alternative would be to write a new program. The advantage to that is: 1. start.exe is left more similar to it's windows counterpart. 2. This other program could handle multiple files sent in the same AppleEvent, which is possible. 3. The same program could also act as a proxy for a dock icon, handling clicks and activating windows (this is a later project). I'd imagine it'd be called winehostproxy or somesuch and handle several types of interaction with the host (is that what we call it btw?). If you think that's more appropriate I can work on that instead of adding this to start. Regards, -- Per Johansson 2012/9/23 Per Johansson <pelle(a)morth.org> >

Sept. 25, 2012

Re: Overriding the check for ownership of a prefix

by Scott Ritchie

On 9/24/12 2:48 AM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Scott, > > I don't think you need to override this check, esp. given that > there's a good reason for it being there: The good reason doesn't apply in this use case. Overriding it fixes every problem I'm facing without having to do anything complicated or manual. >> Note that there is a problem with this setup if the app modifies >> the registry and we then need to update the prefix-default >> registry > > I've excellent experience with symbolic links. In fact, none of the > apps (games) I use are installed directly within any .wine prefix. > Drive_c/Program Files/Games is a symbolic link to a large partition. > Your apps don't need to have conflicting registry settings then. I can't assume I'll always be so lucky. >> Imagine a distro package containing a Windows game in the form of >> a read-only copy of an installed prefix (into, say, /opt). > > So I recommend the following setup: - Have the game's main directory > be something like /opt/games/XYZ in UNIX, but tell it to install to > C:\games/XYZ - During installation, write down all registry keys that > the app creates and every file that it stores outside of its local > directory. > > Beware: the name of the directory C:\Program.. depends upon every > user's locale at .wine creation time! Use C:\Games\ instead to avoid > that pitfall. > > For every user: - After .wine is created normally, add a symlink > from Drive_c/Games to /opt/games - Add registry keys or dlls needed > by the app. > > wineprefixcreate ln -s /opt/games/XYZ $HOME/.wine/drive_c/games cp -p > whatever.dll $HOME/.wine/drive_c/windows/system32/ wine regedit > xyz.reg > > Trivial, isn't it? > We can't assume apps will install cleanly, or only need the files in their install directories; copying to windows system folder does happen, and then it becomes a real mess. > Typically, you don't need to recreate the content of user-local > APPDATA directories. The app will create them upon each run, since > they ought to run with different users on one machine. > > Caveat: Although my .wine and games directories are distinct, I've no > experience with write-protecting the games partition. Obviously, > this only has a chance to work with modern apps, written after MS > started recommending separating the app's dir from its per-local > configuration files to be since stored in ~/LOCALAPPDATA or the like. > Thus w9x/w2k-era games are ruled out. Still, I don't know where > those apps attempt to store e.g. crash logs. > > I've seen apps write high-scores or savegames to their central > directory when w2k was set in winecfg, and use HKCU/LOCALAPPDATA > (what's the exact name?) when running in xp mode. > > I've made excellent experience with plenty of apps sharing a single > .wine-games prefix with such a setup. I.e. you don't need one prefix > per app. Like on a real box, the apps ought to be able to coexist. > Perhaps. But separate prefixes give us so many advantages here, at the mere cost of some disk space. > Drawback: when I was initially attracted to Wine 5 years ago, every > .wine was a tiny 3-4MB. Nowadays it's more than 10 times that size, > and I'm not happy with that. Using a single onion-union-fs to share > drive_c/xyz may be interesting -- for as long as one single version > of Wine is in use. > > Regards, Jörg Höhle > Thank you though, you do propose one alternative.

Sept. 25, 2012

d3dx9: Implement D3DXSHEvalDirectionalLight

by Nozomi Kodama

Hello, do it remain problems with this patch? Nozomi

Sept. 24, 2012

Wine Mono 0.0.6 Release - Because hey, why not?

by Vincent Povirk

I have published version 0.0.6 of Wine Mono on Sourceforge, because it's probably not good to let it get too stale. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.6/wine-mono-0.0.… The binary is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.6/wine-mono-0.0.… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 0.0.4: * Updated the visual basic class libraries from upstream. * Updated mono from 2.11.1 to 2.11.4. Unfortunately, there wasn't a nice changelog like 2.11.1 had. Here are some highlights: * Beginnings of support for hosting ActiveX controls inside winforms. (Alistair Leslie-Hughes) * Various HttpClient-related fixes. (Martin Baulig) * "Intermediate" state check boxes now rendered in winforms. (Steven Boswell II) * ACL support on Windows. (James Bellinger) * One can now specify WINE_MONO_TRACE=wrapper to log all transitions between native and managed code, which is sort of the Mono equivalent of a relay log. * RVA fields can now be accessed properly via the ldsfld[a] instruction. This should help with Managed C++ support. * Fix for winehq bug 30947 - Mono would cause a hang when a dll is loaded after Mono is loaded but before it is used to run any .NET code. * Because of a problem with the build system, MonoPosixHelper.dll was not present, and this prevented some builtin methods in Mono from working correctly. This has been resolved. * Added hashes for all included files in the msi package, which is needed for msi to replace the files on upgrade. * Added 64-bit registry entries to the msi package.

Sept. 24, 2012

Re: ImmIsUIMessageA/W

by André Hentschel

Am 21.09.2012 18:46, schrieb Aric Stewart: > Hi Andre, > > I have a quick question for you. I am looking into why IME unaware applications are no longer showing their composition window and found it was because of: > > commit 7673d67c1e1cfdcdf7560beea9162c3699329aa5 > Author: André Hentschel <nerv(a)dawncrow.de> > Date: Sat Jun 25 16:13:41 2011 +0200 > > imm32: Test and fix ImmIsUIMessageA/W. > > in that patch I see that you eliminate the part where we check if there is a default IME window and if not then create one. > > if (!IMM_GetThreadData()->hwndDefault) > ImmGetDefaultIMEWnd(NULL); Hi, this code snippet was a useless construct it seems, because ImmGetDefaultIMEWnd returns IMM_GetThreadData()->hwndDefault which is obviously zero and it's not stored. > also you eliminate the part where if the incoming hWndIME is NULL we send the message to the thread's default IME window. my changes made an app happy IIRC, further i think i was skeptical about IMM_GetThreadData()->hwndDefault because of the dead code. maybe it should be patched in again, not sure. -- Best Regards, André Hentschel

Sept. 24, 2012

Re: [PATCH] dmusic: Add master clock tests.

by Andrew Eikum

On Sun, Sep 23, 2012 at 08:44:59PM +0200, Christian Costa wrote: > @@ -66,6 +68,11 @@ static void test_dmusic(void) > return; > } > > + hr = IDirectMusic_GetMasterClock(dmusic, &guid_clock, &clock); > + ok(hr == S_OK, "IDirectMusic_GetMasterClock returned: %x\n", hr); > + ok(clock != NULL, "No clock returned\n"); > + trace(" guidPort = %s\n", debugstr_guid(&guid_clock)); > + Minor nit-pick: you never release the clock.

Sept. 24, 2012

Re: [PATCH 2/2] mshtml: Added function overriding tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21757 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 24, 2012

Re: [PATCH 1/2] jscript: Added support for limit argument in String.split

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21756 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 24, 2012

Re: Assorted spelling fixes.

by Julian Rüger

Hi Francois, > - /* if we set the bufferpointer to NULL here UrlUnescape fails and string gets not converted */ > + /* if we set the buffer pointer to NULL here UrlUnescape fails and the string is not converted */ for consistency with the other buffer pointer comments and better readability, I suggest you add a comma here: + /* if we set the buffer pointer to NULL here, UrlUnescape fails and the string is not converted */ Best regards, Julian

Sept. 24, 2012

Re: [PATCH 4/4] mshtml: Added IHTMLElement::contains implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21753 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Sept. 24, 2012

Re: [PATCH 2/4] mshtml: Added function overriding tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21751 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 24, 2012

RFC: Locale-independent case-insensitive string comparison

by Francois Gouget

diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 28f82a3..f465ad7 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -640,7 +640,7 @@ static void HTTP_FixURL(http_request_t *request) } } - if(CSTR_EQUAL != CompareStringW( LOCALE_SYSTEM_DEFAULT, NORM_IGNORECASE, + if(CSTR_EQUAL != CompareStringW( LOCALE_INVARIANT, NORM_IGNORECASE, request->path, strlenW(request->path), szHttp, strlenW(szHttp) ) && request->path[0] != '/') /* not an absolute path ?? --> fix it !! */ { In this code snippet it feels wrong to have this string comparison depend on the system locale, which in Wine's case would come from the user's Unix locale. Isn't this a case where LOCALE_INVARIANT would be better? However I have not found a case where this makes a difference anyway, either with 'http:' or with 'file:'. That is, 'file:' always matches 'FILE:', even in Turkish, as long as I don't use NORM_LINGUISTIC_CASING. Conversely, 'fîle:' is different from 'FILE:' no matter what. Once I have a CompareString() test-case I can make some for UrlIs(), PathCreateFormURL(), possibly ShellExecute(), etc. -- Francois Gouget <fgouget(a)codeweavers.com>

Sept. 24, 2012

Re: [PATCH] d3dx9_36: Cube texture can be loaded as a simple texture. The first face texture is taken in that case.

by Christian Costa

2012/9/24 Józef Kucia <joseph.kucia(a)gmail.com> > Hi, > > > On Sun, Sep 23, 2012 at 8:44 PM, Christian Costa <titan.costa(a)gmail.com>wrote: > >> + hr = IDirect3DTexture9_LockRect(texture, 0, &lock_rect, NULL, >> D3DLOCK_READONLY); >> + ok(hr == D3D_OK, "IDirect3DTexture9_LockTexture returned %#x, >> expected %#x\n", hr, D3D_OK); >> + if (SUCCEEDED(hr)) >> + for (i = 0; i < 16; i++) >> + ok(((BYTE*)lock_rect.pBits)[i] == dds_cube_map[128+i], >> "Byte at index %u is 0x%02x, expected 0x%02x\n", i, >> ((BYTE*)lock_rect.pBits)[i], dds_cube_map[144+i]); >> + IDirect3DTexture9_Release(texture); >> > > You should call IDirect3DTexture9_UnlockRect before > IDirect3DTexture9_Release. > > > Good catch ! Thanks !

Sept. 24, 2012

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.

by Henri Verbeet

On 23 September 2012 22:40, Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> wrote: > > +struct refresh_rates { Formatting. > +struct refresh_rates refresh_list[] = This should be static const. > + ok(hr == E_INVALIDARG, "GetDesc unexpectedly returend %#x.\n", hr); "returned". > + for (i = 0; i < sizeof(refresh_list)/sizeof(struct refresh_rates); i++) I generally prefer "sizeof(*refresh_list)", or perhaps "sizeof(refresh_list[0])" over "sizeof(struct refresh_rates)" in this kind of situation. > + "Numerator %d is %d.\n", i, result_desc.BufferDesc.RefreshRate.Numerator); These are unsigned variables.

Sept. 24, 2012

Re: [3/4] dxgi: Avoid division by zero. Based on patch by Eduard - Gabriel Munteanu.

by Henri Verbeet

On 23 September 2012 22:40, Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> wrote: > +static UINT dxgi_rational_to_uint(DXGI_RATIONAL *rational) "rational" should be const.

Sept. 24, 2012

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.

by Józef Kucia

On Sun, Sep 23, 2012 at 10:40 PM, Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> wrote: > +struct refresh_rates refresh_list[] = > +{ > + {60, 60, FALSE, FALSE}, > + {60, 0, TRUE, FALSE}, > + {60, 1, TRUE, TRUE}, > + { 0, 60, TRUE, FALSE}, > + { 0, 0, TRUE, FALSE}, > +}; It's probably better to declare it inside test_createswapchain(). It could also be static const. > + hr = IDXGISwapChain_Release(swapchain); > + ok(hr == 0, "Release failed, hr %d.\n", hr); It should be assigned to refcount. > + hr = IDXGIFactory_Release(factory); > + ok(SUCCEEDED(hr), "Release failed, hr %#x.\n", hr); > + > + hr = IDXGIAdapter_Release(adapter); > + ok(SUCCEEDED(hr), "Release failed, hr %#x.\n", hr); > + > + hr = IUnknown_Release(obj); > + ok(SUCCEEDED(hr), "Release failed, hr %#x.\n", hr); Release doesn't return HRESULT and the value returned by Release shouldn't be tested with SUCCEEDED. refcount = IDXGIFactory_Release(factory); ok(!refcount, "ID3DXGIFactory has %u references left\n", refcount);

Sept. 24, 2012

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.

by Alexandre Julliard

Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> writes: > --- > dlls/dxgi/tests/Makefile.in | 2 +- > dlls/dxgi/tests/device.c | 147 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 148 insertions(+), 1 deletion(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dxgi.dll -T ../../.. -p dxgi_test.exe.so device.c && touch device.ok device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. make: *** [device.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

Sept. 24, 2012

Overriding the check for ownership of a prefix

by Joerg-Cyril.Hoehle＠t-systems.com

Scott, I don't think you need to override this check, esp. given that there's a good reason for it being there: >Note that there is a problem with this setup if the app modifies the >registry and we then need to update the prefix-default registry I've excellent experience with symbolic links. In fact, none of the apps (games) I use are installed directly within any .wine prefix. Drive_c/Program Files/Games is a symbolic link to a large partition. >Imagine a distro package containing a Windows game in the form of a >read-only copy of an installed prefix (into, say, /opt). So I recommend the following setup: - Have the game's main directory be something like /opt/games/XYZ in UNIX, but tell it to install to C:\games/XYZ - During installation, write down all registry keys that the app creates and every file that it stores outside of its local directory. Beware: the name of the directory C:\Program.. depends upon every user's locale at .wine creation time! Use C:\Games\ instead to avoid that pitfall. For every user: - After .wine is created normally, add a symlink from Drive_c/Games to /opt/games - Add registry keys or dlls needed by the app. wineprefixcreate ln -s /opt/games/XYZ $HOME/.wine/drive_c/games cp -p whatever.dll $HOME/.wine/drive_c/windows/system32/ wine regedit xyz.reg Trivial, isn't it? Typically, you don't need to recreate the content of user-local APPDATA directories. The app will create them upon each run, since they ought to run with different users on one machine. Caveat: Although my .wine and games directories are distinct, I've no experience with write-protecting the games partition. Obviously, this only has a chance to work with modern apps, written after MS started recommending separating the app's dir from its per-local configuration files to be since stored in ~/LOCALAPPDATA or the like. Thus w9x/w2k-era games are ruled out. Still, I don't know where those apps attempt to store e.g. crash logs. I've seen apps write high-scores or savegames to their central directory when w2k was set in winecfg, and use HKCU/LOCALAPPDATA (what's the exact name?) when running in xp mode. I've made excellent experience with plenty of apps sharing a single .wine-games prefix with such a setup. I.e. you don't need one prefix per app. Like on a real box, the apps ought to be able to coexist. Drawback: when I was initially attracted to Wine 5 years ago, every .wine was a tiny 3-4MB. Nowadays it's more than 10 times that size, and I'm not happy with that. Using a single onion-union-fs to share drive_c/xyz may be interesting -- for as long as one single version of Wine is in use. Regards, Jörg Höhle

Sept. 24, 2012

Re: [PATCH] d3dx9_36: Cube texture can be loaded as a simple texture. The first face texture is taken in that case.

by Józef Kucia

Hi, On Sun, Sep 23, 2012 at 8:44 PM, Christian Costa <titan.costa(a)gmail.com>wrote: > + hr = IDirect3DTexture9_LockRect(texture, 0, &lock_rect, NULL, > D3DLOCK_READONLY); > + ok(hr == D3D_OK, "IDirect3DTexture9_LockTexture returned %#x, > expected %#x\n", hr, D3D_OK); > + if (SUCCEEDED(hr)) > + for (i = 0; i < 16; i++) > + ok(((BYTE*)lock_rect.pBits)[i] == dds_cube_map[128+i], > "Byte at index %u is 0x%02x, expected 0x%02x\n", i, > ((BYTE*)lock_rect.pBits)[i], dds_cube_map[144+i]); > + IDirect3DTexture9_Release(texture); > You should call IDirect3DTexture9_UnlockRect before IDirect3DTexture9_Release.

Sept. 24, 2012

Re: Assorted spelling fixes.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21742 Your paranoid android. === W2K3R2SESP2 (32 bit sync) === sync.c:972: Test failed: DeleteTimerQueueTimer

Sept. 24, 2012

Re: [7/8] windowscodecs: Calculate transparent color index for global GIF palette.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21729 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Sept. 24, 2012

Re: [1/8] windowscodecs: Add some tests for GIF palette.

by Vincent Povirk

Series looks good to me.

Sept. 24, 2012

Re: WineHQ on CMS/Framework

by Kyle Auble

Sun, Sep 23, 2012 04:33, Aleksey Bragin wrote: > Two prototype websites were made, one using Drupal7 and another one > (more recent and more complete) using Typo3. What's important is that we > have a substantial set of interconnected services too: I honestly haven't heard of Typo3 before now (I guess it really hasn't caught on outside the German-speaking world yet), but my first impression is that may be closer to what we would want than Drupal. I've heard that Drupal can be very brittle and hard to use if your design doesn't fit a template. The fact that your T3 prototype is more complete despite being a younger site seems like a hint that it has been more productive for you. Being able to integrate most of your services with the CMS is also very reassuring. Have you come across a situation where you think having a framework would have helped? The main scenario I'm picturing is if someday we wanted to combine data from different parts of the website (for example, bugzilla queries along with related git patches). That may be overdoing things, but I feel like those cross-connections are one of the main things that could really help WineHQ. Right now it seems like there's a lot of good information, but it may be spread out over forum threads, mailing lists, the wiki, AppDB, etc. with no simple way to connect the dots (even after using search). - Kyle

Sept. 23, 2012

re: Question from new developer

by Dan Kegel

Chris wrote: > 1. I discovered later that I don't think this is the root of my > original bug - and in fact doesn't seem to affect behavior of my > program. Is it still worth submitting? Generally, fixes are more likely to get committed when they don't break anything (did you run all the conformance tests?), their tests cases pass on all versions of windows (did you send your patch to testbot?), improve the behavior of a real program (I don't think you have demonstrated this yet), and are written from a position of relatively deep understanding. So you might want to find a more solid fix for your first submission. Welcome, and good luck! - Dan

Sept. 23, 2012

Re: comctl32/listview: update dwStyle before checking for scrollbar

by Daniel Jelinski

2012/9/22 Daniel Jelinski <djelinski1(a)gmail.com>: > 2012/9/22 Nikolay Sivov <nsivov(a)codeweavers.com>: >> And apparently we have code in WM_STYLECHANGED handler to deal with scroll >> bars: >> >> --- >> if (((lpss->styleOld & WS_HSCROLL) != 0)&& >> ((lpss->styleNew & WS_HSCROLL) == 0)) >> ShowScrollBar(infoPtr->hwndSelf, SB_HORZ, FALSE); >> >> if (((lpss->styleOld & WS_VSCROLL) != 0)&& >> ((lpss->styleNew & WS_VSCROLL) == 0)) >> ShowScrollBar(infoPtr->hwndSelf, SB_VERT, FALSE); >> --- >> >> these lines were edited 10 years ago last time, sure it could be a noop >> but that raises a question why it's here. > > Dead code. I meant to remove these in the next patch, since there are > no bugs against scrollbars in listview. I guess user32 was way less > capable back then. Now that I think about it, it's not exactly dead code - it will be executed when someone tries to hide scrollbars by setting window style. Needs a more thorough review. Regards, Daniel

Sept. 23, 2012

Re: Question from new developer

by Bruno Jesus

On Fri, Sep 21, 2012 at 8:41 PM, Chris Teague <chris.teague(a)gmail.com> wrote: > I submitted bug 31753 for an application that I use, and started > making an attempt to fix it. I started with the last few messages > from the log: > > fixme:win:LockWindowUpdate (0x501c4), partial stub! > fixme:win:LockWindowUpdate ((nil)), partial stub! > wine: Unhandled page fault on read access to 0x00000023 at address > 0x78680087 (thread 0009), starting debugger... > > Looking at LockWindowUpdate(), I discovered that it had no conformance > tests. I wrote a few covering all the possible scenarios I could > think of (only 4 of them), and ran them on wine as well as cross > compiling them and running on XP. To my surprise, one of the tests > fails on wine, but passes on WinXP! This was great news, so I dug a > little further. Specifically the problem was attempting to do a > "unlock" operation by passing NULL, when the the function was already > unlocked. Windows treats this as an error and returns 0, while wine > returns 1. > So I fixed it, patch is attached (also at: > https://dl.dropbox.com/u/477050/0001-Fixed-LockWindowUpdate.txt) > I have two big questions: > 1. I discovered later that I don't think this is the root of my > original bug - and in fact doesn't seem to affect behavior of my > program. Is it still worth submitting? I do believe it alleviates > the need for the "fixme" in the LockWindowUpdate function. The fixme is there because the function is far away from implemented, you can read more about it at the long standing bug 52 ( http://bugs.winehq.org/show_bug.cgi?id=52 ). IMO adding tests that prove something is wrong are always good. > 2. If it is worth submitting, could someone take a look at it and > point out all the dumb things I've done? I'm happy with the logic of > the code, but I'm sure I've done something horribly wrong in terms of > doing it the preferred way. You should join all tests in the same function and use an existing file. You need to fix the whitespace issues, you didn't follow the surrounding code style (possibly your editor was configured differently from the file). You are also not freeing the created windows. > Thanks, > Chris Teague I'm not used to reviewing patches, I hope someone else can do a better review. Best wishes, Bruno

Sept. 23, 2012

Re: WineHQ on CMS/Framework

by Aleksey Bragin

We had same question in the ReactOS web site. We have our own in-house developed CMS called RosCMS now, however there is a strong desire to change it to something maintained by 3rd party, so Drupal and Typo3 were considered. Two prototype websites were made, one using Drupal7 and another one (more recent and more complete) using Typo3. What's important is that we have a substantial set of interconnected services too: * JIRA (formerly Bugzilla, integrated authentication with the main website) * Mailing lists (no need for integration) * FishEye as a source code browser (integrated) * GIT mirror with source code browser (no need for integration) * Doxygen source code browser (no need for integration) * MediaWiki (fully integrated, single sign-on) * Forums (fully integrated, single sign-on) * Compatibility database (integrated with RosCMS, single sign-on, however it's ported neither to D7 nor T3) * Test manager (http://www.reactos.org/testman ) * Paste service (fully integrated to prevent spam, single sign-on) * Trunk builds download manager (http://www.reactos.org/getbuilds/ ) If any help is needed, let me know, would be glad to share. Best regards, Aleksey Bragin. On 22.09.2012 7:32, Kyle Auble wrote: > After working on the wiki for a while, I finally wanted to ask about > possibly moving WineHQ to a CMS or web framework. > > First off, while there are a couple of mentions on the wiki and mailing > lists, is there still much interest in doing this? If there is, I think > the second question is which kind of system do we want to use? > > While http://wiki.winehq.org/WinehqDesign mentions Drupal, which has a > lot of plugins and features for easy editing, I've read that a CMS can > become a hassle if your website needs to do more complex things than > serving regular chunks of content. WineHQ provides a bug-tracker, a > forum, a wiki, mailing lists, source-code browsers, and other tools > besides static content, with lots of interconnections between them. If > we did go with a web framework, we could still probably run a CMS on top > of it for the AppDB and static pages. >

Sept. 23, 2012

Re: comctl32/listview: update dwStyle before checking for scrollbar

by Daniel Jelinski

2012/9/22 Nikolay Sivov <nsivov(a)codeweavers.com>: > I see. Now a question is how scroll bars are enabled/disabled in a case > you're trying to fix, > and a message test should be added for listview after that. What I'm seeing > - ControlSpy > running on XP shows style change messages after I toggle scrollbar bits, but > we don't have its source so > who knows what it does. Do you toggle these bits using SetWindowLong or SetScrollInfo? Wine uses SetScrollInfo, which is probably the reason why we don't get these messages. My first try at this bug was updating cached dwStyle in LISTVIEW_UpdateScroll: http://source.winehq.org/source/dlls/comctl32/listview.c#L2058 However, that was not sufficient for a sample application I created in Delphi - seems that Delphi creates the scrollbar elsewhere. Probably the code could be rewritten to not depend on WS_HSCROLL and WS_VSRCOLL being correct: http://source.winehq.org/source/dlls/comctl32/listview.c#L10881 is the only line that depends on it. > And apparently we have code in WM_STYLECHANGED handler to deal with scroll > bars: > > --- > if (((lpss->styleOld & WS_HSCROLL) != 0)&& > ((lpss->styleNew & WS_HSCROLL) == 0)) > ShowScrollBar(infoPtr->hwndSelf, SB_HORZ, FALSE); > > if (((lpss->styleOld & WS_VSCROLL) != 0)&& > ((lpss->styleNew & WS_VSCROLL) == 0)) > ShowScrollBar(infoPtr->hwndSelf, SB_VERT, FALSE); > --- > > these lines were edited 10 years ago last time, sure it could be a noop > but that raises a question why it's here. Dead code. I meant to remove these in the next patch, since there are no bugs against scrollbars in listview. I guess user32 was way less capable back then. Regards, Daniel

Sept. 22, 2012

Re: comctl32/listview: update dwStyle before checking for scrollbar

by Nikolay Sivov

On 9/22/2012 20:41, Daniel Jelinski wrote: > Hello Nikolay, > I'm not sure. There are some tests: > http://source.winehq.org/source/dlls/user32/tests/msg.c#L1613 > Comments indicate that some systems send WM_STYLECHANGED to windows > with non-client area, and no systems send it to windows without it. I > haven't figured out yet if the comment is true or to which category > ListView belongs. > > Out of curiosity I checked which systems send WM_STYLECHANGED: > http://testbot.winehq.org/JobDetails.pl?Key=21701 > Vista and Windows 7 do send it, others do not, neither does Wine. > Judging by the code it doesn't look like a quick fix to me (but I > wouldn't mind if someone proved me wrong here). I see. Now a question is how scroll bars are enabled/disabled in a case you're trying to fix, and a message test should be added for listview after that. What I'm seeing - ControlSpy running on XP shows style change messages after I toggle scrollbar bits, but we don't have its source so who knows what it does. And apparently we have code in WM_STYLECHANGED handler to deal with scroll bars: --- if (((lpss->styleOld & WS_HSCROLL) != 0)&& ((lpss->styleNew & WS_HSCROLL) == 0)) ShowScrollBar(infoPtr->hwndSelf, SB_HORZ, FALSE); if (((lpss->styleOld & WS_VSCROLL) != 0)&& ((lpss->styleNew & WS_VSCROLL) == 0)) ShowScrollBar(infoPtr->hwndSelf, SB_VERT, FALSE); --- these lines were edited 10 years ago last time, sure it could be a noop but that raises a question why it's here. > > Regards, > Daniel > > PS. I guess I should have used GetWindowLong instead on > GetWindowLongPtr. Not sure if I should bother with resending now. It doesn't matter in case of retrieving style bits, server stores it as unsigned int, so most significant int in 64-bits is always zeroed I guess. > > > 2012/9/22 Nikolay Sivov <nsivov(a)codeweavers.com>: >> On 9/21/2012 23:07, Daniel Jelinski wrote: >> >>> dwStyle is updated only in WM_STYLECHANGED, which is not sent >>> when displaying and hiding scrollbars. >>> Fixes the issue where there was a large margin between items >>> and horizontal scrollbar (e.g. in file open dialog). >> Are you sure it's really not supposed to be sent when WS_HSCROLL/WS_VSCROLL >> bits are changed? >> A quick test with ControlSpy shows style changing messages when I set/reset >> these. So it's possible there's a bug >> outside of comctl32.

Sept. 22, 2012

Re: comctl32/listview: update dwStyle before checking for scrollbar

by Daniel Jelinski

Hello Nikolay, I'm not sure. There are some tests: http://source.winehq.org/source/dlls/user32/tests/msg.c#L1613 Comments indicate that some systems send WM_STYLECHANGED to windows with non-client area, and no systems send it to windows without it. I haven't figured out yet if the comment is true or to which category ListView belongs. Out of curiosity I checked which systems send WM_STYLECHANGED: http://testbot.winehq.org/JobDetails.pl?Key=21701 Vista and Windows 7 do send it, others do not, neither does Wine. Judging by the code it doesn't look like a quick fix to me (but I wouldn't mind if someone proved me wrong here). Regards, Daniel PS. I guess I should have used GetWindowLong instead on GetWindowLongPtr. Not sure if I should bother with resending now. 2012/9/22 Nikolay Sivov <nsivov(a)codeweavers.com>: > On 9/21/2012 23:07, Daniel Jelinski wrote: > >> dwStyle is updated only in WM_STYLECHANGED, which is not sent >> when displaying and hiding scrollbars. >> Fixes the issue where there was a large margin between items >> and horizontal scrollbar (e.g. in file open dialog). > > Are you sure it's really not supposed to be sent when WS_HSCROLL/WS_VSCROLL > bits are changed? > A quick test with ControlSpy shows style changing messages when I set/reset > these. So it's possible there's a bug > outside of comctl32.

Sept. 22, 2012

Re: comctl32/listview: update dwStyle before checking for scrollbar

by Nikolay Sivov

On 9/21/2012 23:07, Daniel Jelinski wrote: > dwStyle is updated only in WM_STYLECHANGED, which is not sent > when displaying and hiding scrollbars. > Fixes the issue where there was a large margin between items > and horizontal scrollbar (e.g. in file open dialog). Are you sure it's really not supposed to be sent when WS_HSCROLL/WS_VSCROLL bits are changed? A quick test with ControlSpy shows style changing messages when I set/reset these. So it's possible there's a bug outside of comctl32.

Sept. 22, 2012

WineHQ on CMS/Framework

by Kyle Auble

After working on the wiki for a while, I finally wanted to ask about possibly moving WineHQ to a CMS or web framework. First off, while there are a couple of mentions on the wiki and mailing lists, is there still much interest in doing this? If there is, I think the second question is which kind of system do we want to use? While http://wiki.winehq.org/WinehqDesign mentions Drupal, which has a lot of plugins and features for easy editing, I've read that a CMS can become a hassle if your website needs to do more complex things than serving regular chunks of content. WineHQ provides a bug-tracker, a forum, a wiki, mailing lists, source-code browsers, and other tools besides static content, with lots of interconnections between them. If we did go with a web framework, we could still probably run a CMS on top of it for the AppDB and static pages. Finally, for the frameworks, it seems that one of the main differences is simply which language we want to deal with. Is there a strong preference for using a specific language? Right now the various parts outside of Wine proper use a mix of Perl, PHP, and Python. This also raises the question of whether there's any desire to (over the very long term) try consolidating all the code outside Wine around one or two languages. I'm guessing it wouldn't be worth the trouble (different tools for different jobs), but if there is a strong reason to, it would probably be good to pick a framework in the language we want to emphasize. - Kyle

Sept. 22, 2012

Question from new developer

by Chris Teague

I submitted bug 31753 for an application that I use, and started making an attempt to fix it. I started with the last few messages from the log: fixme:win:LockWindowUpdate (0x501c4), partial stub! fixme:win:LockWindowUpdate ((nil)), partial stub! wine: Unhandled page fault on read access to 0x00000023 at address 0x78680087 (thread 0009), starting debugger... Looking at LockWindowUpdate(), I discovered that it had no conformance tests. I wrote a few covering all the possible scenarios I could think of (only 4 of them), and ran them on wine as well as cross compiling them and running on XP. To my surprise, one of the tests fails on wine, but passes on WinXP! This was great news, so I dug a little further. Specifically the problem was attempting to do a "unlock" operation by passing NULL, when the the function was already unlocked. Windows treats this as an error and returns 0, while wine returns 1. So I fixed it, patch is attached (also at: https://dl.dropbox.com/u/477050/0001-Fixed-LockWindowUpdate.txt) I have two big questions: 1. I discovered later that I don't think this is the root of my original bug - and in fact doesn't seem to affect behavior of my program. Is it still worth submitting? I do believe it alleviates the need for the "fixme" in the LockWindowUpdate function. 2. If it is worth submitting, could someone take a look at it and point out all the dumb things I've done? I'm happy with the logic of the code, but I'm sure I've done something horribly wrong in terms of doing it the preferred way. Thanks, Chris Teague

Sept. 21, 2012

ImmIsUIMessageA/W

by Aric Stewart

Hi Andre, I have a quick question for you. I am looking into why IME unaware applications are no longer showing their composition window and found it was because of: commit 7673d67c1e1cfdcdf7560beea9162c3699329aa5 Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Jun 25 16:13:41 2011 +0200 imm32: Test and fix ImmIsUIMessageA/W. in that patch I see that you eliminate the part where we check if there is a default IME window and if not then create one. if (!IMM_GetThreadData()->hwndDefault) ImmGetDefaultIMEWnd(NULL); also you eliminate the part where if the incoming hWndIME is NULL we send the message to the thread's default IME window. These changes cause the IME to stop working for IME unaware applications. Where the changed intentional and if so based on what documentation? thanks! -aric

Sept. 21, 2012

Re: [3/3] gdiplus: Add an ability to cache bitmap properties and use distinct metadata loaders for different image formats. Take 2.

by Vincent Povirk

This looks good to me.

Sept. 21, 2012

Re: scrrun: Correct Invoke parameter

by Jacek Caban

Hi Alistair, On 09/21/12 14:12, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > scrrun: Correct Invoke parameter > --- a/dlls/scrrun/dictionary.c +++ b/dlls/scrrun/dictionary.c @@ -153,7 +153,7 @@ static HRESULT WINAPI dictionary_Invoke(IDictionary *iface, DISPID dispIdMember, hr = get_typeinfo(IDictionary_tid, &typeinfo); if(SUCCEEDED(hr)) { - hr = ITypeInfo_Invoke(typeinfo, &iface, dispIdMember, wFlags, + hr = ITypeInfo_Invoke(typeinfo, This, dispIdMember, wFlags, pDispParams, pVarResult, pExcepInfo, puArgErr); This really should be an interface, not an object. &This->IDistionary_iface or simply iface would be the right thing to do. Jacek

Sept. 21, 2012

Re: Overriding the check for ownership of a prefix

by Scott Ritchie

On 9/20/12 3:07 AM, Francois Gouget wrote: > On Wed, 19 Sep 2012, Scott Ritchie wrote: > [...] >> There is one major snag, however: unionfs displays the owner as root until the >> user has modified/copied it. This means Wine refuses to launch as the user >> with the "root-owned" prefix. > > Wine checks the ownership of the $WINEPREFIX directory right? So > wouldn't touching a file in $WINEPREFIX before starting Wine work? > system.reg would be a good candidate. Alternatively, create/delete some > other file. > Yes, unfortunately unionfs displays a sort of mixed permission structure: files are owned by the user once they are modified, but the hosting directory name itself can't be modified in this way, which is exactly what Wine checks.

Sept. 20, 2012

Re: [3/3] gdiplus: Add an ability to cache bitmap properties and use distinct metadata loaders for different image formats.

by Vincent Povirk

> @@ -2123,6 +2125,8 @@ static void move_bitmap(GpBitmap *dst, GpBitmap *src, BOOL clobber_palette) > if (dst->metadata_reader) > IWICMetadataReader_Release(dst->metadata_reader); > dst->metadata_reader = src->metadata_reader; > + dst->prop_count = src->prop_count; > + dst->prop_item = src->prop_item; > if (dst->image.stream) > IStream_Release(dst->image.stream); > dst->image.stream = src->image.stream; I think you should be freeing dst->prop_item here. > @@ -2850,6 +2923,12 @@ GpStatus WINGDIPAPI GdipGetAllPropertyItems(GpImage *image, UINT size, > > if (prop_count != count || prop_size != size) return InvalidParameter; > > + if (((GpBitmap *)image)->prop_item) > + { > + memcpy(buf, ((GpBitmap *)image)->prop_item, prop_size); > + return Ok; > + } > + > reader = ((GpBitmap *)image)->metadata_reader; > if (!reader) return PropertyNotFound; I think you have to change the values here so they point into the user buffer. > +typedef GpStatus (*metadata_reader_func)(GpBitmap *bitmap, IWICBitmapDecoder *decoder, UINT frame); ... > + if (metadata_reader) > + metadata_reader(bitmap, decoder, active_frame); > + else if (IWICBitmapFrameDecode_QueryInterface(frame, &IID_IWICMetadataBlockReader, (void Either your metadata reader function should return void, or you should check the returned status. Otherwise, this looks good to me.

Sept. 20, 2012

Re: jscript: Added support for RegExp.$* properties

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21683 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 20, 2012

Re: Overriding the check for ownership of a prefix

by Francois Gouget

On Wed, 19 Sep 2012, Scott Ritchie wrote: [...] > There is one major snag, however: unionfs displays the owner as root until the > user has modified/copied it. This means Wine refuses to launch as the user > with the "root-owned" prefix. Wine checks the ownership of the $WINEPREFIX directory right? So wouldn't touching a file in $WINEPREFIX before starting Wine work? system.reg would be a good candidate. Alternatively, create/delete some other file. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

Sept. 20, 2012

Re: [3/8] winemenubuilder/tests: Added tests for XDG files

by Per Johansson

19 sep 2012 kl. 23:52 skrev Marvin <testbot(a)testbot.winehq.org>: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=21661 Hi all, Failure is: xdg.o: In function `func_xdg': /var/lib/winetestbot/build-mingw32/programs/winemenubuilder/tests/../../../../wine-git/programs/winemenubuilder/tests/xdg.c:423: undefined reference to `_setenv' /var/lib/winetestbot/build-mingw32/programs/winemenubuilder/tests/../../../../wine-git/programs/winemenubuilder/tests/xdg.c:424: undefined reference to `_setenv' collect2: ld returned 1 exit status I could use some help resolving that. I tried using SetEnvironmentVariableA already, but then it doesn't work, the changed variable is not found by winemenubuilder. Should I perhaps change winemenubuilder to use GetEnvironmentVariableA instead of getenv, will that work with the normal Unix environment? Regards, -- Per Johansson

Sept. 20, 2012

Overriding the check for ownership of a prefix

by Scott Ritchie

So, I believe I have a legitimate use case for ignoring this, and want to know what sort of patch would go forward. Imagine a distro package containing a Windows game in the form of a read-only copy of an installed prefix (into, say, /opt). When the user launches the app (via desktop file) this in turn launches a script that does the following: 1) Makes a temporary folder 2) Sets up a unionfs-fuse copy-on-write mount between ~/.appname and the read-only packaged prefix in /opt, mounted in the temporary folder 3) Runs the app with WINEPREFIX= the temp folder 4) When the app is finished, unmounts the temp folder This all works quite fine: new (or modified) files within the prefix get stored in ~/.appname, to be restored the next time the user runs the app. Distinct users can run the app simultaneously, as they each have their own prefix. Excess file-copying is avoided, as only the user-modified files need to be stored in the home folders. There is one major snag, however: unionfs displays the owner as root until the user has modified/copied it. This means Wine refuses to launch as the user with the "root-owned" prefix. Simply commenting out this part of the code makes Wine work fine, however I'd like to be able to have a proper solution. Would something like a command-line switch or environment variable be acceptable here? Thanks, Scott Ritchie * Note that there is a problem with this setup if the app modifies the registry and we then need to update the prefix-default registry, but that's a different feature request

Sept. 20, 2012

Re: [8/8] winemenubuilder: Implement OS X application bundles. (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21663 Your paranoid android. === WINEBUILD (build) === Make failed

Sept. 19, 2012

Re: [7/8] winemenubuilder: Use a dispatch table to access XDG specific parts, extracted to different file.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21662 Your paranoid android. === WINEBUILD (build) === Make failed

Sept. 19, 2012

Re: shell32: Add tests for ShellExecute()'s handling of file URLs. (try2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21655 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === Timeout === W2KPROSP4 (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 === WVISTAADM (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W2K8SE (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W7PRO (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W7PROX64 (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === TEST64_W7SP1 (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W7PROX64 (64 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === TEST64_W7SP1 (64 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2

Sept. 19, 2012

Re: [3/8] winemenubuilder/tests: Added tests for XDG files

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

Sept. 19, 2012

Re: [3/8] winemenubuilder/tests: Added tests for XDG files

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

Sept. 19, 2012

Re: [3/8] winemenubuilder/tests: Added tests for XDG files

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

Sept. 19, 2012

Re: [3/8] winemenubuilder/tests: Added tests for XDG files

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

Sept. 19, 2012

Re: shell32: Add tests for ShellExecute()'s handling of file URLs.

by Juan Lang

Hi Francois, pretty sure you didn't mean to leave this hunk in: @@ -2296,9 +2406,13 @@ START_TEST(shlexec) init_test(); +#if 0 test_argify(); test_lpFile_parsed(); test_filename(); +#endif + test_fileurl(); +#if 0 test_find_executable(); test_lnks(); test_exes(); @@ -2308,6 +2422,7 @@ START_TEST(shlexec) test_commandline(); test_directory(); test_trojans(); +#endif --Juan

Sept. 19, 2012

Re: shell32: Add tests for ShellExecute()'s handling of file URLs.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21649 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Sept. 19, 2012

Re: [1/2] scrrun: Moved creating filesystem object to its own function

by Alexandre Julliard

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -194,13 +245,33 @@ HRESULT WINAPI DllUnregisterServer(void) > > HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID* ppv) > { > + scrruncf *This; > + HRESULT hr = CLASS_E_CLASSNOTAVAILABLE; > + > + TRACE("(%s, %s, %p): stub\n", debugstr_guid(rclsid), debugstr_guid(riid), ppv); > + > + if(!ppv) > + return E_INVALIDARG; > + > + This = HeapAlloc(GetProcessHeap(), 0, sizeof(scrruncf)); > + > + This->IClassFactory_iface.lpVtbl = &scrruncf_vtbl; > + This->pfnCreateInstance = NULL; > + This->ref = 1; > + > if(IsEqualGUID(&CLSID_FileSystemObject, rclsid)) { > - TRACE("(CLSID_WshShell %s %p)\n", debugstr_guid(riid), ppv); > - return IClassFactory_QueryInterface(&FileSystemFactory, riid, ppv); > + TRACE("(CLSID_FileSystemObject %s %p)\n", debugstr_guid(riid), ppv); > + This->pfnCreateInstance = &create_filesystem; > + This->clsid = IID_IFileSystem3; > + } You could just as well continue using static instances of the class factory, and using the IID as a clsid doesn't make much sense. -- Alexandre Julliard julliard(a)winehq.org

Sept. 19, 2012

Re: [PATCH 1/2] user32/tests: Add tests for class small icons (try 3).

by Alexandre Julliard

Sergey Guralnik <serhio(a)etersoft.ru> writes: > +todo_wine > + ok( hsmicon != NULL, "GetClassLong should return non-zero handle\n"); > + for(i = 0; i < 100; i++) > + if(hsmicon != (HICON)GetClassLongPtrW(hwnd, GCLP_HICONSM)) > + { > + ok(FALSE, "Always should return the same icon handle\n"); > + break; > + } This doesn't make sense, it's not going to return the same thing 99 times and then suddenly something different. -- Alexandre Julliard julliard(a)winehq.org

Sept. 19, 2012

Re: ole32: Add CoGetDefaultContext stub

by Huw Davies

On Wed, Sep 19, 2012 at 09:09:55AM +0200, Michael Stefaniuc wrote: > > +/*********************************************************************** > > + * CoGetContextToken [OLE32.@] > copy and paste error ^^^ > > > + */ > > +HRESULT CoGetDefaultContext(APTTYPE type, REFIID riid, LPVOID *ppv) ...and a missing WINAPI. Huw.

Sept. 19, 2012

Re: ole32: Add CoGetDefaultContext stub

by Michael Stefaniuc

Hallo Alistair, > --- > dlls/ole32/compobj.c | 9 +++++++++ > dlls/ole32/ole32.spec | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c > index 0055d15..2ea1dc9 100644 > --- a/dlls/ole32/compobj.c > +++ b/dlls/ole32/compobj.c > @@ -4279,6 +4279,15 @@ HRESULT WINAPI CoGetContextToken( ULONG_PTR *token ) > return S_OK; > } > > +/*********************************************************************** > + * CoGetContextToken [OLE32.@] copy and paste error ^^^ > + */ > +HRESULT CoGetDefaultContext(APTTYPE type, REFIID riid, LPVOID *ppv) bye michael

Sept. 19, 2012

user32/tests: Add tests for class small icons (try 3).

by Sergey Guralnik

There are two patches that stay at queue more than weeek, and have no comments yet: From 5c723835fb9b8b56ccaf2a22256524c84b358fe9 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Tue, 11 Sep 2012 10:24:56 +0400 Subject: [PATCH 1/2] user32/tests: Add tests for class small icons (try 3). From 49d6118117ccfb4efecbb9839b279cc286b19392 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Tue, 11 Sep 2012 13:40:54 +0400 Subject: [PATCH 2/2] user32: Add internal class small icons functionality (try 3). Is something wrong with them? -- Sergey

Sept. 19, 2012

user32/tests: Add test for SetFocus() (with few todo)(Try 2).

by Sergey Guralnik

Alexandre Julliard writes: > Not really. If you want to test purely the Wine behavior, then you > shouldn't be waiting for window manager events. If the window manager > is > involved then you can't guarantee that a given window will always get > focus. > If your app breaks because the window manager doesn't give it focus > at a > certain point, then pretty much the only solution is to change the wm > policy, or use a different wm. Thanks for explanations. -- Sergey

Sept. 19, 2012

Re: [PATCH 3/3] jscript: Added support for no new line between return and expression rule

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21637 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Sept. 18, 2012

Re: [PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386

by Jacek Caban

Hi Juan, On 09/17/12 22:42, Juan Lang wrote: > Hi Jacek, > > + * that NaN value representation has 52 (almost) free bytes. > > You mean bits, yes? Yes, of course. > While you're at it, > + * jsval_t structure is used to represent JavaScript dynamicaly-typed values. > > dynamically is spelled with two l's. Thanks for catching those. I will fix it while resubmitting after I will fix exception value propagation. Thanks, Jacek

Sept. 18, 2012

Re: [PATCH 3/6] vbscript: Added support for do..loop statement without an expression

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21628 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 18, 2012

Re: [PATCH 2/6] vbscript: Added Len implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21627 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 18, 2012

Re: [PATCH 1/6] vbscript: Fixed parsing if statements with empty body

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21626 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 18, 2012

Re: [PATCH 2/2] jscript: Added support for host objects being part of scope chain

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21625 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Sept. 18, 2012

Re: [PATCH 1/2] oleaut32/tests: Don't take the size of a pointer (Clang).

by Michael Stefaniuc

Hello Charles, On 09/18/2012 07:51 AM, Charles Davis wrote: > From: Charles Davis <cdavis(a)mymail.mines.edu> > > Contrary to what a novice C programmer might expect, when you declare an > array parameter to a function, what you actually get is a pointer. > Therefore, using sizeof() on the parameter will return the size of a > pointer, and not 8*sizeof(UINT) as was intended here. Since the array was please fix it in a way to not confuse a novice C programmer; e.g. passing it a pointer to a MYSTRUCT. That way you can avoid the magic constant 8 too. > explicitly declared as being 8 elements long, just use the number 8 in > the for loop instead. > --- > dlls/oleaut32/tests/tmarshal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/oleaut32/tests/tmarshal.c b/dlls/oleaut32/tests/tmarshal.c > index be8ef94..ad56123 100644 > --- a/dlls/oleaut32/tests/tmarshal.c > +++ b/dlls/oleaut32/tests/tmarshal.c > @@ -596,10 +596,10 @@ static HRESULT WINAPI Widget_VarArg( > } > > > -static BOOL mystruct_uint_ordered(UINT uarr[8]) > +static BOOL mystruct_uint_ordered(UINT uarr[]) > { > int i; > - for (i = 0; i < sizeof(uarr) / sizeof(uarr[0]); i++) > + for (i = 0; i < 8; i++) > if (uarr[i] != i) > return 0; > thanks bye michael

Sept. 18, 2012

Spam applications for testbot accounts

by Scott Ritchie

Never underestimate the overeagerness of bots, I suppose... We're getting a lot of spam applications for testbot accounts now, maybe 2-3 per day. Some are easy to discard because they put stuff like penis pills into the info field, but others look like just names. Suggestions are welcome. In the meantime it would be nice if anyone requesting a legit account put some sort of non-spammy text in there like "Hey I'm a human I read wine-devel"

Sept. 17, 2012

Re: [PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386

by Juan Lang

Hi Jacek, + * that NaN value representation has 52 (almost) free bytes. You mean bits, yes? While you're at it, + * jsval_t structure is used to represent JavaScript dynamicaly-typed values. dynamically is spelled with two l's. Thanks, --Juan

Sept. 17, 2012

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes. Take 3.

by Vincent Povirk

> Can I please get a feedback on this gdiplus series along with another one > "gdiplus: Add some tests for GIF properties." ? Yeah, I don't know why those patches would still be New. I didn't look carefully, but it all seemed fine to me. As far as what you're doing with pixel offsets, I haven't verified that's how it works but it seems likely (and probably equally applies to the other interpolation modes). The discrepancy is probably because we're not applying pixel offsets to destination co-ordinates, which we'll have to do eventually.

Sept. 17, 2012

Re: [PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386

by Jacek Caban

Please ignore this last patch. It has one more dependency that I didn't send yet. On 09/17/12 15:21, Jacek Caban wrote: > --- > dlls/jscript/jsutils.c | 4 +- > dlls/jscript/jsval.h | 143 > +++++++++++++++++++++++++++++++++++++---------- > 2 files changed, 114 insertions(+), 33 deletions(-) >

Sept. 17, 2012

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).

by Alexandre Julliard

Sergey Guralnik <serhio(a)etersoft.ru> writes: >> That's mostly testing the window manager focus policy, I don't think >> that makes sense. What are you trying to demonstrate with this? > > I try to show that some applications rely on finishing all side focus > switching, which are result of call to some window management function, > before this function returns. > For example my app hopes that result of call to SetFocus() will not be > distorted in message loop due call to DestroyWindow(), that made before > call to SetFocus(). > Is my explanation clear enough? Not really. If you want to test purely the Wine behavior, then you shouldn't be waiting for window manager events. If the window manager is involved then you can't guarantee that a given window will always get focus. If your app breaks because the window manager doesn't give it focus at a certain point, then pretty much the only solution is to change the wm policy, or use a different wm. -- Alexandre Julliard julliard(a)winehq.org

Sept. 17, 2012

Re: d3dx9 [patch 1/2]: Implement D3DXSHEvalDirectionalLight

by Henri Verbeet

On 17 September 2012 09:52, Rico Schüller <kgbricola(a)web.de> wrote: > longer lines into two. Though, I don't know the actual recommended line > length, but 200 seems a bit long... I only found this > http://www.winehq.org/pipermail/wine-devel/2010-September/086996.html . > Yeah, 100 is safe, but it's not a hard limit. Personally I use 120 in wined3d.

Sept. 17, 2012

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).

by Sergey Guralnik

Alexandre Julliard wrote: > Sergey Guralnik <serhio at etersoft.ru> writes: > >> I've sent next patch more than month ago, and have no comments about >> it. >> >> From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 >> 2001 >> From: Sergey Guralnik <serhio at etersoft.ru> >> Date: Thu, 9 Aug 2012 17:12:56 +0400 >> Subject: user32/tests: Add test for SetFocus() (with few todo)(Try >> 2). >> >> Is anything wrong with this one? > > That's mostly testing the window manager focus policy, I don't think > that makes sense. What are you trying to demonstrate with this? I try to show that some applications rely on finishing all side focus switching, which are result of call to some window management function, before this function returns. For example my app hopes that result of call to SetFocus() will not be distorted in message loop due call to DestroyWindow(), that made before call to SetFocus(). Is my explanation clear enough? -- Sergey

Sept. 17, 2012

Re: d3dx9 [patch 1/2]: Implement D3DXSHEvalDirectionalLight

by Rico Schüller

On 17.09.2012 00:33, Nozomi Kodama wrote: > + { { rout, gout, bout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, ... > + { rout, bout, gout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, > + { bout, rout, gout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, I think it doesn't make much sense to test this, they are doing basically all three the same. The name of the variable doesn't matter. Besides we test for (rout, rout, rout), these might be good to test: (rout, gout, gout), (rout, rout, bout), (rout, gout, rout). Maybe the naming of the variables is a bit confusing... I used the starting name for the name, hence you could also use the expected value name or rename the variables to out1, out2, out3 to not make confusion with the expected / started color. Though I'm fine with all cases... > + } > + > + startindex += order * order; > + } I would indent the startindex... Some style comments (I have no strong opinion about that, just like to mention it): The brackets "()" in &(table[90]) could be left out. You may also break the longer lines into two. Though, I don't know the actual recommended line length, but 200 seems a bit long... I only found this http://www.winehq.org/pipermail/wine-devel/2010-September/086996.html . Cheers Rico

Sept. 17, 2012

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes. Take 3.

by Dmitry Timoshkov

Hi, Can I please get a feedback on this gdiplus series along with another one "gdiplus: Add some tests for GIF properties." ? -- Dmitry.

Sept. 17, 2012

Wine Mono update

by Alistair Leslie-Hughes

Hi, Mono 2.11.4 has been released which contains a few patches which removes most of the exceptions from the AxHost class. This class has been the cause of a few applications from starting (DDO and LOTRO launchers to name a few) I purpose a new wine-mono to be built. What sort of milestones should we look for to trigger a new wine-mono release? Best Regards Alistair Leslie-Hughes

Sept. 16, 2012

very slow updating of client area

by Andrew Makhorin

Hello, Please see below a function that processes WM_PAINT message. Being run under Wine this function updates the client area (50x120 chars) about 50 times slower than under Windows XP. Could anyone please explain me what might be wrong and suggest how to fix that? Thank you, Andrew Makhorin /*********************************************************************** * update_panel_area - update client area of panel window * * This routine updates the client area of the window associated with * the specified panel. (It is called when the panel window procedure * receives the message WM_PAINT.) */ void update_panel_area(PANELX *px) { PAINTSTRUCT ps; HFONT old_hfont; HPEN old_hpen, hpen; int row, col, row1, row2, col1, col2; xassert(px != NULL); /* if the update region is empty, do nothing */ if (!GetUpdateRect(px->window, NULL, FALSE)) goto done; /* start updating */ BeginPaint(px->window, &ps); old_hfont = SelectObject(ps.hdc, px->hfont); hpen = CreatePen(PS_SOLID, 0, 0x000000); old_hpen = SelectObject(ps.hdc, hpen); /* given the update region, determine which rows and columns of the display area should be updated (note that the update region reported by BeginPaint does not include right-most and bottom-most pixels, so we subtract 1 in order not to update an extra row and column out of the update region) */ row1 = 1 + ps.rcPaint.top / px->fy; row2 = 1 + (ps.rcPaint.bottom - 1) / px->fy; col1 = 1 + ps.rcPaint.left / px->fx; col2 = 1 + (ps.rcPaint.right - 1) / px->fx; /* updating is performed according to information in the buffer array of the panel display area (see rpsed.h) */ for (row = row1; row <= row2; row++) { for (col = col1; col <= col2; col++) { FMTCHAR c; int x, y; char buf[1]; /* get formatted character at position (row,col) */ if (1 <= row && row <= px->p->nrows+1 && 1 <= col && col <= px->p->ncols+1) c = px->p->c[row][col]; else c = px->p->std_char[FMT_SPACE]; /* paint this character */ x = (col - 1) * px->fx; y = (row - 1) * px->fy; SetTextColor(ps.hdc, palette->value[c.f]); SetBkColor(ps.hdc, palette->value[c.b]); SetBkMode(ps.hdc, OPAQUE); buf[0] = c.c; TextOut(ps.hdc, x, y, buf, 1); /* paint the underline, if specified */ if (c.a & FMT_UNDERLINE) { SetBkMode(ps.hdc, TRANSPARENT); TextOut(ps.hdc, x, y, "_", 1); } /* paint the vertical bar, if specified */ if (c.a & FMT_MARGIN) { MoveToEx(ps.hdc, x, y, NULL); LineTo(ps.hdc, x, y + px->fy); } } } /* finish updating */ SelectObject(ps.hdc, old_hfont); SelectObject(ps.hdc, old_hpen); DeleteObject(hpen); EndPaint(px->window, &ps); done: return; }

Sept. 16, 2012

d3d9 implementation

by Luchezar Belev

hello i have been writing some d3d9/d3d8 implementation on top of opengl as a pet project i mainly work on it under windows, but also made it run under wine. i thought you guys might find it interesting to try it out. It works fine with all the games i got - there are no major problems. they are guild wars (1), wow, league of legends, tomb raider underworld, titan quest, skyrim. it requires opengl 3.3 or higher. attached is zip archive with binaries (2 files) and a readme. (i'm not sure i want to give away the sources yet.)

Sept. 15, 2012

Re: d3dx9_36 [patch 1/2]: Implement D3DXSHEvalDirectionalLight

by Henri Verbeet

On 14 September 2012 14:04, Rico Schüller <kgbricola(a)web.de> wrote: > + FLOAT s, temp[max( 1, order * order )]; > Is this allowed in c and does it really work the way one would expect? > It is in C99 (look into VLAs), but Wine doesn't allow C99 features.

Sept. 14, 2012

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).

by Alexandre Julliard

Sergey Guralnik <serhio(a)etersoft.ru> writes: > I've sent next patch more than month ago, and have no comments about > it. > > From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 2001 > From: Sergey Guralnik <serhio(a)etersoft.ru> > Date: Thu, 9 Aug 2012 17:12:56 +0400 > Subject: user32/tests: Add test for SetFocus() (with few todo)(Try 2). > > Is anything wrong with this one? That's mostly testing the window manager focus policy, I don't think that makes sense. What are you trying to demonstrate with this? -- Alexandre Julliard julliard(a)winehq.org

Sept. 14, 2012

Re: d3dx9_36 [patch 1/2]: Implement D3DXSHEvalDirectionalLight

by Rico Schüller

On 14.09.2012 11:07, Nozomi Kodama wrote: > Hello > > one remark about this patch. > > Test in real windows shows that D3DXSHEvalDirectionalLight accepts order > > D3DXSH_MAXORDER or order < D3DXSH_MINORDER. > But in these cases, the colour outputs are unpredictable. For the same > calling arguments, D3DSXHEvalDirectionalLight returns different colours. > > That explains the simplicity of the implementation of this function. > > Nozomi. > + FLOAT s, temp[max( 1, order * order )]; Is this allowed in c and does it really work the way one would expect? + for (order = D3DXSH_MINORDER; order <= D3DXSH_MAXORDER; order++) ... + if ( ( order == 0 ) || ( j >= order * order ) ) Why would you check for order == 0? That's imho never the case that this is true. At least if you only test from D3DXSH_MINORDER onward. + unsigned int j, order, start[] = {0, 4, 13, 29, 54}; Using the start[] looks a bit ugly ... why don't you calculate the index? + expected = table[start[order - 2] + j]; ! You've again trailing white spaces. What happens in the following test case? Which result is returned? D3DXSHEvalDirectionalLight(order, &dir, 1.7f, 2.6f, 3.5f, rout, rout, rout); Well the implementation seems to be correct, but it may be nice to test for this as well. Maybe in another patch. Cheers Rico

Sept. 14, 2012

Re: [PATCH] advapi32: Eliminate dead stores (Clang).

by Alexandre Julliard

Charles Davis <cdavis5x(a)gmail.com> writes: > @@ -615,9 +613,9 @@ static DWORD mac_write_credential(const CREDENTIALW *credential, BOOL preserve_b > attr_list.count = 0; > attr_list.attr = NULL; > } > - status = SecKeychainItemModifyAttributesAndData(keychain_item, &attr_list, > - preserve_blob ? 0 : strlen(password), > - preserve_blob ? NULL : password); > + SecKeychainItemModifyAttributesAndData(keychain_item, &attr_list, > + preserve_blob ? 0 : strlen(password), > + preserve_blob ? NULL : password); I expect you'd want to handle that error instead. -- Alexandre Julliard julliard(a)winehq.org

Sept. 14, 2012

Re: [4/4] windowscodecs: Implement Graphic Control Extension metadata reader.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21585 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Sept. 14, 2012

Re: [3/4] windowscodecs: Implement Image Descriptor metadata reader.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21584 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Sept. 14, 2012

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).

by Sergey Guralnik

I've sent next patch more than month ago, and have no comments about it. From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Thu, 9 Aug 2012 17:12:56 +0400 Subject: user32/tests: Add test for SetFocus() (with few todo)(Try 2). Is anything wrong with this one? -- Sergey

Sept. 14, 2012

Re: vcomp: better stub for _vcomp_fork

by Alexandre Julliard

Dan Kegel <dank(a)kegel.com> writes: > @@ -41,6 +42,80 @@ double CDECL omp_get_wtime(void) > return GetTickCount() / 1000.0; > } > > +/* Call helper with the ncount args after ncount */ > +extern void WINAPIV _vcomp_fork(DWORD parallel, int ncount, void *helper, ...); > +#ifdef __i386__ > +__ASM_GLOBAL_FUNC( _vcomp_fork, > + "push %ebp\n\t" > + "movl %esp,%ebp\n\t" > + > + /* Push varargs */ > + "movl 12(%ebp),%ecx\n\t" /* if (nargs > 0) */ > + "test %ecx,%ecx\n\t" > + "jz copyend\n\t" > + "leal 20(%ebp),%edx\n\t" /* dx -> first vararg */ > + "leal (%edx,%ecx,4),%edx\n\t" /* dx += nargs * sizeof arg */ > + "copyloop:\n\t" /* while (nargs-- > 0) */ > + "sub $4,%edx\n\t" > + "pushl (%edx)\n\t" /* push next vararg */ > + "dec %ecx\n\t" > + "jnz copyloop\n\t" > + "copyend:\n\t" > + > + /* Call helper and return */ > + "call *16(%ebp)\n\t" > + "movl %ebp,%esp\n\t" > + "pop %ebp\n\t" > + "ret\n\t" > + ) > +#endif There are several places that already implement that sort of thing the right way, you should copy one of them instead of reinventing the wheel. -- Alexandre Julliard julliard(a)winehq.org

Sept. 13, 2012

Re: d3dx9_36 [patch 1/2: try 2]: Implement D3DXSHEvalDirectionalLight

by Alexandre Julliard

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > @@ -2231,6 +2231,40 @@ FLOAT* WINAPI D3DXSHEvalDirection(FLOAT *out, UINT order, CONST D3DXVECTOR3 *dir > return out; > } > > +HRESULT WINAPI D3DXSHEvalDirectionalLight(UINT order, CONST D3DXVECTOR3 *dir, FLOAT Rintensity, FLOAT Gintensity, FLOAT Bintensity, FLOAT *Rout, FLOAT *Gout, FLOAT *Bout) > +{ > + FLOAT s, temp[36]; > + UINT j; > + > + TRACE("Order %u, Vector %p, Red %f, Green %f, Blue %f, Rout %p, Gout %p, Bout %p\n", order, dir, Rintensity, Gintensity, Bintensity, Rout, Gout, Bout); > + > + if ( order > D3DXSH_MAXORDER ) > + { > + FIXME("This case is not implemented yet. Anyway, following to MSDN, this case should not happen\n"); > + > + return D3D_OK; > + } You should test the expected results for that case too, the implementation should be easy either way. -- Alexandre Julliard julliard(a)winehq.org

Sept. 13, 2012

Re: [PATCH 4/4] ntdll: Add more complete implementation of NtPowerInformation

by Alexandre Julliard

James Eder <jimportal(a)gmail.com> writes: > @@ -2261,7 +2242,19 @@ NTSTATUS WINAPI NtInitiatePowerAction( > SystemAction,MinSystemState,Flags,Asynchronous); > return STATUS_NOT_IMPLEMENTED; > } > - > + > +#ifdef linux > +static int have_cpufreq(void) > +{ > + FILE* f = fopen("/sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq", "r"); > + if(f) > + { > + fclose(f); > + return 1; > + } > + return 0; > +} > +#endif You don't want to open a file just to see if you will be able to open it for real later on. You'll need to check the subsequent open anyway, so you can do the fallback at that point. -- Alexandre Julliard julliard(a)winehq.org

Sept. 13, 2012

Re: [PATCH 1/2] jscript: Don't leave current scope in return statement before evaluating the expression

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21565 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 13, 2012

Re: [PATCH 5/6] mshtml: Added IHTMLDocument4::fireEvent implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21559 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 13, 2012

Translations of the About Pages

by Kyle Auble

I just submitted a draft rewrite of WineHQ's About page in English that integrates some things from the wiki page, but there are still Hebrew and Spanish about pages on the wiki. I started working on translating the Spanish one, but realized someone else should probably do it after one paragraph, and my Hebrew is even weaker. I think the goal is still to move all central pages to WineHQ so I'd like to remove those versions from the wiki soon too. If any Hebrew or Spanish-speaking contributors would prefer to work from the wiki content though, I can leave it up for a while. If you would rather translate from the new English version to keep the different translations in sync though, I'll go ahead and clean up the wiki some more. - Kyle

Sept. 13, 2012

Re: [2/2] windowscodecs: Create Graphic Control Extension metadata block for a GIF frame.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21552 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Sept. 13, 2012

Re: [1/2] windowscodecs: Create Image Descriptor metadata block for a GIF frame.

by Dmitry Timoshkov

Vincent Povirk <madewokherd(a)gmail.com> wrote: > > + stream = create_stream(&IMD_data, sizeof(IMD_data)); > > Er, where is create_stream defined? I don't see it in git or a previous patch. It's added by 5373f8520d2fec729730aaa6a3278cefa46f9414 -- Dmitry.

Sept. 13, 2012

Re: [1/2] windowscodecs: Create Image Descriptor metadata block for a GIF frame.

by Vincent Povirk

> + stream = create_stream(&IMD_data, sizeof(IMD_data)); Er, where is create_stream defined? I don't see it in git or a previous patch.

Sept. 13, 2012

Re: dssenh: implementing the dssenh cryptographic service provider

by Juan Lang

Hi Marek, On Wed, Sep 12, 2012 at 2:57 PM, Marek Chmiel <kcmark(a)gmail.com> wrote: > Hello all, > over the summer I had a chance to complete the regression test suite > for the DSSENH cryptographic provider; thank you to those that helped > along the way. I am currently researching how to implement the actual > provider, and any suggestions would be greatly appreciated. A question > I have is: RSAENH AND DSSENH both use the same encryption algorithms > (I am not 100% sure about that yet), so for example could I use one > that was written for RSAENH or shall I write those functions on my own > using Libtomcrypt? There are some algorithms in common, e.g. MD5 and SHA1. For these, I think you'd want to copy/paste the existing implementation from rsaenh into dssenh. There are other algorithms, e.g. DSS aka DSA, e.g. DH, that are not. For these, I think you'd want to use an existing implementation, but since none exists in Wine, you'd have to import new code. libtomcrypt's license makes it relatively easy to use. Hope that helps, --Juan

Sept. 12, 2012

dssenh: implementing the dssenh cryptographic service provider

by Marek Chmiel

Hello all, over the summer I had a chance to complete the regression test suite for the DSSENH cryptographic provider; thank you to those that helped along the way. I am currently researching how to implement the actual provider, and any suggestions would be greatly appreciated. A question I have is: RSAENH AND DSSENH both use the same encryption algorithms (I am not 100% sure about that yet), so for example could I use one that was written for RSAENH or shall I write those functions on my own using Libtomcrypt? Thank you. --Marek

Sept. 12, 2012

Re: ddraw: Don't print a fixme for the flags in DirectDrawEnumerateExA; they don't change the outcome

by Michael Stefaniuc

After talking to Henri on irc, please ignore this patch. There are patches out there to enumerate more devices than the primary one and then the flags do play a role. On 09/12/2012 11:08 PM, Michael Stefaniuc wrote: > --- > dlls/ddraw/main.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/dlls/ddraw/main.c b/dlls/ddraw/main.c > index 61e8ec9..b79b12e 100644 > --- a/dlls/ddraw/main.c > +++ b/dlls/ddraw/main.c > @@ -377,12 +377,9 @@ HRESULT WINAPI DirectDrawEnumerateExA(LPDDENUMCALLBACKEXA Callback, void *Contex > DDENUM_NONDISPLAYDEVICES)) > return DDERR_INVALIDPARAMS; > > - if (Flags) > - FIXME("flags 0x%08x not handled\n", Flags); > - > TRACE("Enumerating default DirectDraw HAL interface\n"); > > - /* We only have one driver by now */ > + /* We have only one driver (primary) which is always enumerated regardless of the flags */ > __TRY > { > static CHAR driver_desc[] = "DirectDraw HAL", > bye michael

Sept. 12, 2012

Re: [PATCH 4/4] ntdll: Add more complete implementation of NtPowerInformation

by Ken Thomases

On Sep 12, 2012, at 2:17 PM, James Eder wrote: > - valSize = sizeof(longVal); > - if (!sysctlbyname("hw.cpufrequency", &longVal, &valSize, NULL, 0)) > - cpuHz = longVal; I haven't tried building, but this would still leave the warning about longVal being declared but never used, right? I don't see you removing that declaration. Regards, Ken

Sept. 12, 2012

Re: [2/2] windowscodecs: Add a bunch of GIF metadata tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21528 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Sept. 12, 2012

Re: msls31: Add stub dll.

by Josh DuBois

Thanks for the feedback! I'll clean up and re-submit. (Now I'll have to decide whether to change my comment style for everything I write, or just try to remember to fix them for winehq patches ... ;) ) On 9/11/12 11:58 AM, Austin English wrote: > On Tue, Sep 11, 2012 at 9:32 AM, Josh DuBois <duboisj(a)codeweavers.com> wrote: >> Presence of a stub of msls31.dll allows Visio 2003 to open .svg files, which >> it fails to do without the stub. >> Visio 2003 does complain that some values in the files are missing or of the >> incorrect data type when opening these files, but it will nonetheless open >> them and can edit them successfully when the stubbed .dll is present. > @@ -0,0 +1,79 @@ > +70 stub LssbFDoneDisplay > +65 stub LsCompressSubline > +1 stub LsCreateContext > +3 stub LsCreateLine > ..etc. > > Does it really need them by ordinal? The spec files are typically > sorted alphabetically by function name, e.g.,: > +@ stub LsCompressSubline > +@ stub LsCreateContext > +@ stub LsCreateLine > +@ stub LssbFDoneDisplay > ..etc. > > Some other minor things: > A) you don't need to include the changes to configure, just configure.ac. > > B) Your comments are formatted a bit strange > /* --------------------------------------------------------------- > ** msls31.dll > ** Copyright CodeWeavers, Inc. > ** Created: 9/10/2012 by Josh DuBois for CodeWeavers. > > most files have: > /* > * msls31.dll > * > * Copyright 2012 Josh DuBois for CodeWeavers, Inc. > * > */ > > similar for your comment about preferring the native version. > > Welcome to Wine! >

Sept. 11, 2012

Re: [PATCH 5/5] ntdll: Add more complete implementation of NtPowerInformation

by James Eder

On Mon, Sep 10, 2012 at 11:16 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > First, there are some compiler warnings: Fixed > Then, you are off by an order of magnitude. You're dividing by 10 million rather than 1 million to go from Hz to MHz. and fixed > I would say you should probably remove that semi-stub warning. Doh! I sent without that one. I'll remove the warning and send again probably tomorrow or the next day. I'll wait a bit to see if we get any comments from the BSD side. I am downloading FreeBSD for testing in a QEMU but I'm not sure how long it will take for me to get it up and rolling. Thanks Ken! -- Jim

Sept. 11, 2012

Re: msls31: Add stub dll.

by Austin English

On Tue, Sep 11, 2012 at 9:32 AM, Josh DuBois <duboisj(a)codeweavers.com> wrote: > Presence of a stub of msls31.dll allows Visio 2003 to open .svg files, which > it fails to do without the stub. > Visio 2003 does complain that some values in the files are missing or of the > incorrect data type when opening these files, but it will nonetheless open > them and can edit them successfully when the stubbed .dll is present. @@ -0,0 +1,79 @@ +70 stub LssbFDoneDisplay +65 stub LsCompressSubline +1 stub LsCreateContext +3 stub LsCreateLine ..etc. Does it really need them by ordinal? The spec files are typically sorted alphabetically by function name, e.g.,: +@ stub LsCompressSubline +@ stub LsCreateContext +@ stub LsCreateLine +@ stub LssbFDoneDisplay ..etc. Some other minor things: A) you don't need to include the changes to configure, just configure.ac. B) Your comments are formatted a bit strange /* --------------------------------------------------------------- ** msls31.dll ** Copyright CodeWeavers, Inc. ** Created: 9/10/2012 by Josh DuBois for CodeWeavers. most files have: /* * msls31.dll * * Copyright 2012 Josh DuBois for CodeWeavers, Inc. * */ similar for your comment about preferring the native version. Welcome to Wine! -- -Austin

Sept. 11, 2012

Re: wininet: disable TLSv1.1/1.2 by default

by Alexandre Julliard

Hiroshi Miura <miurahr(a)linux.com> writes: > How do you think whether we should implement similar way or not? > If we adopt similar fall back mechanism, compatibility may become well, > but is it good behavior? If it's possible to implement some sort of automatic fall back, that would certainly be preferable. -- Alexandre Julliard julliard(a)winehq.org

Sept. 11, 2012

Re: [PATCH 5/5] ntdll: Add more complete implementation of NtPowerInformation

by Ken Thomases

Hi James, On Sep 10, 2012, at 10:27 AM, James Eder wrote: > I've sent a patch set that I need some help testing. The first four > in the series should be fine as they don't change anything specific to > a particular platform. The last one however makes some changes which > are platform specific (affects Linux, Apple, and various BSDs). I've > tested the Linux code but I do not have an Apple, for example, to test > that code. While the code looks good to me and is is largely based > off of code removed from fill_cpu_info(), it is still worth some > concern that it hasn't seen any real testing. If you have a Mac or > BSD, I would be grateful if you could try the patches out to make sure > things are working as expected. You'll find a few more details in the > commit message http://source.winehq.org/patches/data/89698 . Thanks for this work. First, there are some compiler warnings: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/usr/X11/include/freetype2 -I/usr/X11/include -g -gstabs -o nt.o nt.c nt.c: In function ‘fill_cpu_info’: nt.c:1207: warning: unused variable ‘longVal’ nt.c: In function ‘NtPowerInformation’: nt.c:2470: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 6 has type ‘ULONG’ nt.c:2470: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 7 has type ‘ULONG’ nt.c:2470: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 8 has type ‘ULONG’ nt.c:2470: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 9 has type ‘ULONG’ nt.c:2470: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 10 has type ‘ULONG’ nt.c:2470: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 11 has type ‘ULONG’ Then, you are off by an order of magnitude. You're dividing by 10 million rather than 1 million to go from Hz to MHz. After I fixed that, it gave: trace:ntdll:NtPowerInformation (11,0x0,0,0x1105f0,96) warn:ntdll:NtPowerInformation semi-stub: ProcessorInformation trace:ntdll:NtPowerInformation cpu_power[0] = 0 2800 2800 2800 0 0 trace:ntdll:NtPowerInformation cpu_power[1] = 1 2800 2800 2800 0 0 trace:ntdll:NtPowerInformation cpu_power[2] = 2 2800 2800 2800 0 0 trace:ntdll:NtPowerInformation cpu_power[3] = 3 2800 2800 2800 0 0 My machine is indeed a quad-core, 2.8 Ghz Mac Pro. I would say you should probably remove that semi-stub warning. Cheers, Ken

Sept. 11, 2012

Re: wininet: disable TLSv1.1/1.2 by default

by Hiroshi Miura

Hi, Are there any comment for it? It is a motivation that Evernote windows client cannot connect its server on Wine/OpenSSL 1.0.1. it is caused by server is only support TLS1.0/SSL3.0 , apache2/openssl 0.9.8 thing, but client ask TLS1.1/1.2 and then server returns that session is fails. I know wininet(in Microsoft implementation) has a behavior to re-try by TLS1.0 after TLS1.2 fails. It is discussed in IETF TLS maillist http://www.ietf.org/mail-archive/web/tls/current/msg08218.html How do you think whether we should implement similar way or not? If we adopt similar fall back mechanism, compatibility may become well, but is it good behavior? Hiroshi On 2012.08.26 11:51, Hiroshi Miura wrote: > > OpenSSL 1.0.x now support TLSv1.1 and TLSv1.2 > but Windows7 is disabled by default. > > Schannel registry indicate TLSv1.1/1.2 config. > > It fixes the error of Evernote client connection. > http://bugs.winehq.org/show_bug.cgi?id=30598 > > Signed-off-by: Hiroshi Miura <miurahr(a)linux.com> > --- > dlls/wininet/netconnection.c | 68 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > > > > > >

Sept. 10, 2012

Re: [PATCH] secur32/schannel: diabled TLS1.1/1.2 by Default

by Hiroshi Miura

On 20120910 18:14, Marcus Meissner wrote: > On Mon, Sep 10, 2012 at 12:14:51AM +0900, Hiroshi Miura wrote: >> -Set TLS1.1/1.2 disabled by Default that is >> same as Windows 7 default. >> >> See registry entry for schannel and control >> enable/disable tls versions. >> >> It also see grbitEnabledProtocols defined in >> credentials that take precedence over registry. > I think the regression issue with TLS 1.1/1.2 is the "empty fragments" > sending, right? > > Perhaps we can just disable that and not all of TLS 1.1/1.2? This patch is delivered from wininet problem. That is a problem when client try TLS1.1/1.2 to TLS1.0 only server and fails with SSL version alert. (incompatibility between evernote server/wine-client) A patch for wininet disables problematic TLS1.1/1.2 by default and add interface to enable it. I understand from my short research that 1) Windows see Schannel registry entry to control it. 2) wininet is hoped to re-implement using schannel That's a reason, I propose a patch for schannel for consistency. If you think a behavior is ok, that only wininet is affected from Schannel registry and schannel/winhttp is not configurable, it is easy to reject schennel patch. for "empty fragments", it is workaround for BEAST vulnerbility. It is not straight relation with above. Hiroshi

Sept. 10, 2012

Re: [PATCH 3/5] gdi32: Fixed localized font style name.

by Qian Hong

Hello, On Tue, Sep 11, 2012 at 1:05 AM, Qian Hong <fracting(a)gmail.com> wrote: > and the symbol font bug (with todo_wine because it need to be fixed in [PATCH 4/5].) Sorry for a typo, should be: with todo_wine because it need to be fixed in [PATCH 5/5]. Thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

Sept. 10, 2012

Re: [PATCH 5/5] ntdll: Add more complete implementation of NtPowerInformation

by James Eder

I've sent a patch set that I need some help testing. The first four in the series should be fine as they don't change anything specific to a particular platform. The last one however makes some changes which are platform specific (affects Linux, Apple, and various BSDs). I've tested the Linux code but I do not have an Apple, for example, to test that code. While the code looks good to me and is is largely based off of code removed from fill_cpu_info(), it is still worth some concern that it hasn't seen any real testing. If you have a Mac or BSD, I would be grateful if you could try the patches out to make sure things are working as expected. You'll find a few more details in the commit message http://source.winehq.org/patches/data/89698 . Also of concern is that the testbot seems to have only one processor. This results in most of the tests added in http://source.winehq.org/patches/data/89697 being skipped. So testbot doesn't seem that helpful for this test. As for the implementation of the test itself, would it be better to use broken() and just test Wine for the Win7 behavior? From my testing, the test as is works for XP, Win7, and Wine with my patch set. If we can write the test to work everywhere, don't use broken()? There are more details in the patch itself so please have a look and let me know what you think. -- Jim

Sept. 10, 2012

Re: [PATCH 2/3] jscript: Added support for no new line between continue and identifier rule

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21489 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 10, 2012

Re: [PATCH 1/3] jscript: Added support for no new line between break and identifier rule

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21488 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 10, 2012

Re: mshtml: Added support for navigating to anchors with IDs containing '#'

by Jacek Caban

On 09/10/12 12:19, Alexandre Julliard wrote: > Jacek Caban <jacek(a)codeweavers.com> writes: > >> --- >> dlls/mshtml/navigate.c | 42 +++++++++++++++++++++++++++++++++++++++--- >> dlls/mshtml/nsiface.idl | 11 +++++++++++ >> 2 files changed, 50 insertions(+), 3 deletions(-) > It doesn't work here: > > ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so htmldoc.c && touch htmldoc.ok > htmldoc.c:4650: Test failed: unexpected riid {5C8B21BC-EF6E-4599-A26F-FACC05B4ADBE} > make: *** [htmldoc.ok] Error 1 This looks like a bug in Gecko that doesn't set result to NULL when an element is not found. Could you please confirm it with attached patch (I'm interested in the error trace I've added). Thanks, Jacek

Sept. 10, 2012

Re: mshtml: Added support for navigating to anchors with IDs containing '#'

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/navigate.c | 42 +++++++++++++++++++++++++++++++++++++++--- > dlls/mshtml/nsiface.idl | 11 +++++++++++ > 2 files changed, 50 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so htmldoc.c && touch htmldoc.ok htmldoc.c:4650: Test failed: unexpected riid {5C8B21BC-EF6E-4599-A26F-FACC05B4ADBE} make: *** [htmldoc.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

Sept. 10, 2012

Re: [PATCH] secur32/schannel: diabled TLS1.1/1.2 by Default

by Marcus Meissner

On Mon, Sep 10, 2012 at 12:14:51AM +0900, Hiroshi Miura wrote: > -Set TLS1.1/1.2 disabled by Default that is > same as Windows 7 default. > > See registry entry for schannel and control > enable/disable tls versions. > > It also see grbitEnabledProtocols defined in > credentials that take precedence over registry. I think the regression issue with TLS 1.1/1.2 is the "empty fragments" sending, right? Perhaps we can just disable that and not all of TLS 1.1/1.2? Ciao, Marcus

Sept. 10, 2012

Re: [PATCH 5/5] vbscript: Added support for VT_NULL in stack_pop_bool

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21486 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 10, 2012

Re: [PATCH 4/5] vbscript: Added support for comparing to null

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21485 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 10, 2012

Re: [PATCH 3/5] mshtml: Check if value is function only when it needs to be in invoke_builtin_prop

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21484 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 10, 2012

Re: [PATCH 2/5] mshtml: Use first script host's GUID as default script guid

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21483 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 10, 2012

Re: [PATCH 6/9] mshtml: Use first script host's GUID as default script guid

by Jacek Caban

On 09/07/12 19:15, Alexandre Julliard wrote: > Jacek Caban <jacek(a)codeweavers.com> writes: > >> dlls/mshtml/htmlwindow.c | 1 - >> dlls/mshtml/mshtml_private.h | 1 - >> dlls/mshtml/script.c | 18 ++++++++++-------- >> dlls/mshtml/tests/vbtest.html | 15 +++++++++++++-- >> 4 files changed, 23 insertions(+), 12 deletions(-) > It doesn't work here on 64-bit: > > ../../../../wine/tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so ../../../../wine/dlls/mshtml/tests/script.c && touch script.ok > script.c:620: Test failed: L"got an exception" > script.c:620: Test failed: L"counter = 3" > make: *** [script.ok] Error 2 It required another vbscript patch to be applied first, sorry about that. Jacek

Sept. 10, 2012

Re: [PATCH] secur32/schannel: diabled TLS1.1/1.2 by Default

by Hiroshi Miura

Hi, On 2012年09月03日 05:21, Henri Verbeet wrote: > On 2 September 2012 10:58, Hiroshi Miura <miurahr(a)linux.com> wrote: >> -Set TLS1.1/1.2 disabled by Default that is >> same as Windows 7 default. >> > Aside from whether disabling TLS1.1+ is appropriate or not, or if this > is the right implementation, this patch also add %COMPAT to the > priority string, which wasn't there before. > > Thanks. I'd like to rework it and post again. You may think it need 1)when wininet, winhttp is configured with schannel registry values, schannel also behave with this configuration. 2) or in order to prepare when wininet, winhttp is reimplement with schannel, schannel also behave same. If not, this work is going to pick when it needed. Hiroshi

Sept. 9, 2012

Re: Wine, fullscreen applications, and RandR 1.2

by Andy Ritger

On Sat, Sep 08, 2012 at 12:08:06AM -0700, Henri Verbeet wrote: > On 8 September 2012 01:22, Andy Ritger <aritger(a)nvidia.com> wrote: > > In any case, there is an enthusiast community around immersive gaming; e.g., > > > > http://www.nvidia.com/object/3d-vision-surround-technology.html > > > > In those cases, the content across the monitors is rendered as one > > big screen, rather than rendered separately per display with different > > view frustums. > > > > With RandR 1.1 + NVIDIA MetaModes, users could achieve that sort of > > configuration with Wine. They can't really do that now with Wine and > > RandR 1.2. > > > How does that work in Windows? In a typical D3D9 application you would > normally end up with one adapter per display. Unless the application > is multihead aware, switching to fullscreen mode would just make the > application fullscreen on the primary display. Does the display driver > change how the displays are presented to the application? Yes. As I understand it: the NVIDIA Windows driver, to support those sorts of immersive gaming configurations, presents one adapter to the Windows OS, which in turn presents that one adapter to the application (e.g., one 7680x1600 adapter, rather than 3 2560x1600 adapters). This is conceptually similar to NVIDIA Linux driver's MetaMode + RandR 1.1 (or XF86VidMode). There are definitely cases where you would want the application to be multihead aware so that they can make more intelligent use of each monitor. But in the case of monitors with similar geometry, abstracting the complexity of multiple monitors away from the application has had some success. Somewhat timely, a related article was just posted on phoronix: http://www.phoronix.com/scan.php?page=news_item&px=MTE3OTQ That article suggests that there should be some coordination between fullscreen applications and window managers. Since that would also introduce complexity, and would be needed across multiple applications (and multiple window managers), a suspect one or more helper libraries to centralize and abstract the complexity might be a good approach. Thanks for the feedback in this thread. I'll give some thought to what these sorts of helper libraries might look like. Thanks, - Andy

Sept. 8, 2012

Re: Wine, fullscreen applications, and RandR 1.2

by Henri Verbeet

On 8 September 2012 01:22, Andy Ritger <aritger(a)nvidia.com> wrote: > In any case, there is an enthusiast community around immersive gaming; e.g., > > http://www.nvidia.com/object/3d-vision-surround-technology.html > > In those cases, the content across the monitors is rendered as one > big screen, rather than rendered separately per display with different > view frustums. > > With RandR 1.1 + NVIDIA MetaModes, users could achieve that sort of > configuration with Wine. They can't really do that now with Wine and > RandR 1.2. > How does that work in Windows? In a typical D3D9 application you would normally end up with one adapter per display. Unless the application is multihead aware, switching to fullscreen mode would just make the application fullscreen on the primary display. Does the display driver change how the displays are presented to the application?

Sept. 8, 2012

Re: [PATCH 1/2] gdi32/tests: Added tests for symbol fonts.

by Qian Hong

Hello, Please ignore this series of patch, I'll provide a fix for the failure test.

Sept. 8, 2012

Re: [PATCH 2/2] gdi32: Fixed get_name_table_entry for symbol fonts.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21462 Your paranoid android. === W7PROX64 (32 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === TEST64_W7SP1 (32 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === W7PROX64 (64 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === TEST64_W7SP1 (64 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular

Sept. 8, 2012

Re: [PATCH 1/2] gdi32/tests: Added tests for symbol fonts.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21461 Your paranoid android. === W7PROX64 (32 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === TEST64_W7SP1 (32 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === W7PROX64 (64 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === TEST64_W7SP1 (64 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular

Sept. 8, 2012

Re: Wine, fullscreen applications, and RandR 1.2

by Andy Ritger

On Thu, Sep 06, 2012 at 01:05:42AM -0700, Henri Verbeet wrote: > On 5 September 2012 22:45, Andy Ritger <aritger(a)nvidia.com> wrote: > > On Wed, Sep 05, 2012 at 11:26:23AM -0700, Henri Verbeet wrote: > >> From Wine's point of view, we'd just get a bunch of extra code to maintain > >> because nvidia does things differently from everyone else. > > > > Eventually, I hope NVIDIA isn't unique about this approach to viewport > > configuration. The drawbacks aren't NVIDIA-specific. > > > > The concern about added code maintenance to Wine is fair; is that concern > > lessened if the details of viewport configuration are abstracted by a new > > standard library? > > > A little, but adding extra dependencies isn't without its costs > either. You'd also have to wait a fair bit before it ends up in common > distributions. (And that means things like "Debian stable" or "RHEL", > not "Ubuntu & Fedora".) Yes; understood. > >> Perhaps there's a use case for a "big screen" setup, but that too is > >> something that's probably best handled on the RandR / X server level > >> instead of Wine. > > > > I don't think we can have it both ways: > > > > * RandR 1.1 gives you one "big screen" per X screen; the user can > > configure what is within that big screen via NVIDIA's MetaModes. > > > > * RandR 1.2 gives applications control of each individual CRTC/output. > > > > Are you suggesting we go back to something more like RandR 1.1? > > > I imagine you could configure things in e.g. xorg.conf so that the > displays show up as a single CRTC / output instead of individual > CRTCs, perhaps depending on how the MetaModes are setup. Or perhaps > there's some way to make this fit it with some of the new > functionality in RandR 1.5. The main point though is that there's no > reasonable way for Wine to decide to do one or the other > automatically. We could of course add a configuration option for that, > but at that point it makes more sense to do it globally for all > applications in RandR or the X server. RandR 1.2+ intentionally gives control of the individual CRTCs/outputs to client applications, with the goal of moving display configuration policy out of the X server. But I agree it is a burden for every fullscreen application to have to decide for itself how to configure the available CRTCs/outputs. Here again maybe some helper library can help bridge the gap. > >> I don't think you can actually do "immersive gaming" > >> properly without support from the application though, you'll get > >> fairly significant distortion at the edges if you just render to such > >> a setup as if it was a single very wide display. > > > > I'm sorry; I don't understand the distortion concern. Are you referring > > to the bezel of the monitor occupying physical space, but not pixel space > > in the X screen? I believe people often address that by configuring > > "dead space" in the X screen between their monitors. > > > No, I mean the distortion caused by perspective projection, because > you're essentially projecting a spherical "world" onto a flat screen. > An application that is aware of this could e.g. use a separate camera > for each display to mitigate this, or perhaps adjust the projection > matrix. Maybe there is a distortion concern in theory (though it may depend on whether the monitors are all in the same plane or tilted to "wrap around" the user), but in practice it seems to normally work out well enough. I suppose maybe users use side displays for peripheral vision, and then move their viewport such that the content they care about is in the center display. In any case, there is an enthusiast community around immersive gaming; e.g., http://www.nvidia.com/object/3d-vision-surround-technology.html In those cases, the content across the monitors is rendered as one big screen, rather than rendered separately per display with different view frustums. With RandR 1.1 + NVIDIA MetaModes, users could achieve that sort of configuration with Wine. They can't really do that now with Wine and RandR 1.2. > > Since we have some differing viewpoints that won't be quickly resolved, > > how about as a compromise we add a way for users to force Wine from > > RandR 1.2 back to RandR 1.1? That would at least let users achieve > > some of the configurations they cannot configure with top of tree. > > If that seems fair, what is the preferred configuration mechanism to > > do that? Just a simple environment variable? > > > You could perhaps extend the existing "UseXRandR" registry setting > (see dlls/winex11.drv/x11drv_main.c) to take a version number. It's > not something we've heard a lot of users about though. Sounds good; I'll look into that. Thanks, - Andy

Sept. 7, 2012

Re: [PATCH 6/9] mshtml: Use first script host's GUID as default script guid

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > dlls/mshtml/htmlwindow.c | 1 - > dlls/mshtml/mshtml_private.h | 1 - > dlls/mshtml/script.c | 18 ++++++++++-------- > dlls/mshtml/tests/vbtest.html | 15 +++++++++++++-- > 4 files changed, 23 insertions(+), 12 deletions(-) It doesn't work here on 64-bit: ../../../../wine/tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so ../../../../wine/dlls/mshtml/tests/script.c && touch script.ok script.c:620: Test failed: L"got an exception" script.c:620: Test failed: L"counter = 3" make: *** [script.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

Sept. 7, 2012

Re: [2/5] vcomp: add better stub for _vcomp_fork (resend)

by Dan Kegel

On Fri, Sep 7, 2012 at 7:21 AM, Dan Kegel <dank(a)kegel.com> wrote: > As I mentioned earlier, the testbot can't handle vcomp.dll tests > until a fix for http://bugs.winehq.org/show_bug.cgi?id=31609 > is deployed. > > It can handle vcomp100.dll tests, though (no manifest). I guess I can submit > the series again with the vcomp100 forwarding and tests > in a sixth patch, that would show things are working. > > In my earlier testing with testbot and vcomp100, IIRC, the tests did pass. > But double-checking isn't a bad idea. Here's a run with the current tests: https://testbot.winehq.org/JobDetails.pl?Key=21451 showing them passing on all platforms that have vcomp100 installed. I think I need to resend the patch series without private stuff in omp.h, though, so the tests can build with mingw and native headers. And it might be good for the tests to skip if the dll they need doesn't exist. - Dan

Sept. 7, 2012

Re: [2/5] vcomp: add better stub for _vcomp_fork (resend)

by Dan Kegel

As I mentioned earlier, the testbot can't handle vcomp.dll tests until a fix for http://bugs.winehq.org/show_bug.cgi?id=31609 is deployed. It can handle vcomp100.dll tests, though (no manifest). I guess I can submit the series again with the vcomp100 forwarding and tests in a sixth patch, that would show things are working. In my earlier testing with testbot and vcomp100, IIRC, the tests did pass. But double-checking isn't a bad idea. On Thu, Sep 6, 2012 at 9:14 PM, Marvin <testbot(a)testbot.winehq.org> wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=21417 > > Your paranoid android. > > > === WNT4WSSP6 (32 bit main) === > Timeout

Sept. 7, 2012

Re: [PATCH 2/2] user32: Correct class small icons behavior (try 2).

by Sergey Guralnik

On 2012-09-07 15:24, Sergey Guralnik wrote: > This patch based on MSDN's description of WNDCLASSEX structure: ... hIconSm: Handle to a small icon that is associated with the window class. If this member is NULL, the system searches the icon resource specified by the hIcon member for an icon of the appropriate size to use as the small icon. ... -- Sergey

Sept. 7, 2012

Re: [PATCH 9/9] vbscript: Added support for VT_NULL in stack_pop_bool

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21447 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 7, 2012

Re: [PATCH 8/9] vbscript: Added support for comparing to null

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21446 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 7, 2012

Re: [PATCH 7/9] mshtml: Check if value is function only when it needs to be in invoke_builtin_prop

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21445 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 7, 2012

Re: [PATCH 6/9] mshtml: Use first script host's GUID as default script guid

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21444 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 7, 2012

Re: [PATCH 2/2] user32: Correct class small icons behavior.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21433 Your paranoid android. === WINEBUILD (build) === Make failed

Sept. 7, 2012

Re: [PATCH 1/2] user32/tests: Added test for class icons handling.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21432 Your paranoid android. === WINEBUILD (build) === Make failed

Sept. 7, 2012

Re: [PATCH 4/5] gdi32: Added font name tests on non English locale.

by Qian Hong

Hello, On Fri, Sep 7, 2012 at 2:28 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > You should avoid that sort of thing, it will be hard to debug, > particularly since get_ttf_nametable_entry itself has ok() calls. Store > the result in a variable instead. Thanks for review! I've sent a improved version. -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

Sept. 7, 2012

Re: [PATCH 1/3] user32: Implement RegisterRawInputDevices().

by Alexandre Julliard

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > @@ -2931,3 +2965,14 @@ DECL_HANDLER(set_cursor) > reply->new_clip = input->desktop->cursor.clip; > reply->last_change = input->desktop->cursor.last_change; > } > + > +DECL_HANDLER(update_rawinput_devices) > +{ > + const struct rawinput_device *devices = get_req_data(); > + unsigned int i; > + > + for (i = 0; i < req->device_count; ++i) > + { > + update_rawinput_device(&devices[i]); > + } > +} device_count is redundant (and unsafe), this should use the data size instead. -- Alexandre Julliard julliard(a)winehq.org

Sept. 7, 2012

Re: [4/5] vcomp: better stubs for _vcomp_for_static_simple_init, _vcomp_for_static_end

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21419 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

Sept. 7, 2012

Re: [3/5] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21418 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

Sept. 7, 2012

Re: [2/5] vcomp: add better stub for _vcomp_fork (resend)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21417 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

Sept. 7, 2012

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes. Take 2.

by Dmitry Timoshkov

I hope that I've addressed Vincent's concern about todo_wine blanket coverage, is there anything else that prevents these 2 patches from being accepted? -- Dmitry.

Sept. 7, 2012

Re: [PATCH 4/5] gdi32: Added font name tests on non English locale.

by Alexandre Julliard

Qian Hong <fracting(a)gmail.com> writes: > @@ -4110,7 +4120,9 @@ static void test_fullname2_helper(const char *Family) > > bufW[0] = 0; > bufA[0] = 0; > - ok(get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size), "FAMILY (family name) could not be read\n"); > + ok(get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size, GetSystemDefaultLangID()) || > + get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size, TT_MS_LANGID_ENGLISH_UNITED_STATES), You should avoid that sort of thing, it will be hard to debug, particularly since get_ttf_nametable_entry itself has ok() calls. Store the result in a variable instead. -- Alexandre Julliard julliard(a)winehq.org

Sept. 6, 2012

Re: [PATCH 4/6] msvcp60: Fixed RTTI structure on 64-bit systems (try2)

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > try2: > - fixed base pointer offset calculation (patches 4,5,6) You should pass the module handle from DllMain instead. -- Alexandre Julliard julliard(a)winehq.org

Sept. 6, 2012

Re: [PATCH 2/2] kernel32: Return correct drive type for empty drives (try2)

by Alexandre Julliard

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -2544,7 +2544,8 @@ static NTSTATUS DVD_ReadStructure(int dev, const DVD_READ_STRUCTURE *structure, > } > > if (ioctl(dev, DVD_READ_STRUCT, &s) < 0) > - return STATUS_INVALID_PARAMETER; > + /* Will be converted into ERROR_INVALID_FUNCTION */ > + return (errno == ENOMEDIUM) ? STATUS_INVALID_DEVICE_REQUEST : STATUS_INVALID_PARAMETER; That doesn't make much sense, you probably want to use FILE_GetNtStatus. -- Alexandre Julliard julliard(a)winehq.org

Sept. 6, 2012