September 2012 - Wine-Devel

Re: [PATCH 1/6] mshtml: Moved getting frame by name to separated function

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > On 09/03/12 16:13, Alexandre Julliard wrote: >> Jacek Caban <jacek(a)codeweavers.com> writes: >> >>> --- >>> dlls/mshtml/htmlwindow.c | 127 >>> ++++++++++++++++++++++++++-------------------- >>> 1 files changed, 72 insertions(+), 55 deletions(-) >> gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ >> -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe >> -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body >> -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits >> -Wunused-but-set-parameter -Wwrite-strings -gdwarf-2 -gstrict-dwarf >> -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -Werror >> -I/usr/include/freetype2 -g -O2 -o htmlwindow.o htmlwindow.c >> htmlwindow.c: In function ‘HTMLWindow2_item’: >> htmlwindow.c:416:13: error: variable ‘hres’ set but not used [-Werror=unused-but-set-variable] >> cc1: all warnings being treated as errors >> make: *** [htmlwindow.o] Error 1 > > My GCC didn't warn about it. I've resent a fixed version. You are still not using hres. -- Alexandre Julliard julliard(a)winehq.org

Sept. 3, 2012

Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.

by Alexandre Julliard

Alex Henrie <alexhenrie24(a)gmail.com> writes: > 2012/9/3 Alexandre Julliard <julliard(a)winehq.org>: >> You don't have a single test with an explicit source length, so >> obviously you are not going to find problems in that area. Like I said, >> you need a lot more tests. > > example_2 already tests an explicit source length. In all the other > examples srclen = strlen(src) + 1, see > http://source.winehq.org/git/wine.git/blob/2097c5ddb6bec24cf4bbd440a6f401cf… > > So again, what specific additional test, or what specific change to > the existing tests, do you want to see? Think about what the code is doing, and how to test it. In particular spend some time thinking about the source length parameter. -- Alexandre Julliard julliard(a)winehq.org

Sept. 3, 2012

Re: [PATCH] msctf: also free the sink in the non-source branch (Coverity)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21357 Your paranoid android. === TEST64_W7SP1 (32 bit inputprocessor) === inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink

Sept. 3, 2012

Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.

by Alex Henrie

2012/9/3 Alexandre Julliard <julliard(a)winehq.org>: > You don't have a single test with an explicit source length, so > obviously you are not going to find problems in that area. Like I said, > you need a lot more tests. example_2 already tests an explicit source length. In all the other examples srclen = strlen(src) + 1, see http://source.winehq.org/git/wine.git/blob/2097c5ddb6bec24cf4bbd440a6f401cf… So again, what specific additional test, or what specific change to the existing tests, do you want to see? -Alex

Sept. 3, 2012

Re: wined3d: Use backup swapchain DC for devices created with desktop window.

by Matteo Bruni

2012/9/3 Henri Verbeet <hverbeet(a)gmail.com>: > On 3 September 2012 00:51, Adam Jakubek <ajakubek(a)gmail.com> wrote: >> Hi, >> >> This patch causes wined3d to use backup swapchain DC when >> IDirect3DDevice9 is created using the desktop window. >> Windows allows to create such device as long its type is >> D3DDEVTYPE_REF or D3DDEVTYPE_NULLREF. >> >> Unpatched Wine will fail in IDirect3D9_CreateDevice method, since it >> incorrectly uses the X root window. >> >> Relevant d3d test case is included. >> Patch closes bug #18490. >> > How is actual rendering to the desktop window supposed to work? > Interpreting MSDN it looks like D3DDEVTYPE_NULLREF devices don't actually render anything. The intended use case probably is to be able to create and load resources which can be shared (as in D3D9Ex-like resource sharing) with the "real" D3D device. D3DDEVTYPE_REF would trigger the reference rasterizer, which AFAIK isn't usually installed on user systems, so maybe this one ends up being the same as NULLREF in the common case. Of course this needs some tests/research.

Sept. 3, 2012

Re: [PATCH 1/6] mshtml: Moved getting frame by name to separated function

by Jacek Caban

On 09/03/12 16:13, Alexandre Julliard wrote: > Jacek Caban <jacek(a)codeweavers.com> writes: > >> --- >> dlls/mshtml/htmlwindow.c | 127 >> ++++++++++++++++++++++++++-------------------- >> 1 files changed, 72 insertions(+), 55 deletions(-) > gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -Werror -I/usr/include/freetype2 -g -O2 -o htmlwindow.o htmlwindow.c > htmlwindow.c: In function ‘HTMLWindow2_item’: > htmlwindow.c:416:13: error: variable ‘hres’ set but not used [-Werror=unused-but-set-variable] > cc1: all warnings being treated as errors > make: *** [htmlwindow.o] Error 1 My GCC didn't warn about it. I've resent a fixed version. Thanks, Jacek

Sept. 3, 2012

Re: [PATCH 1/6] mshtml: Moved getting frame by name to separated function

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/htmlwindow.c | 127 > ++++++++++++++++++++++++++-------------------- > 1 files changed, 72 insertions(+), 55 deletions(-) gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -Werror -I/usr/include/freetype2 -g -O2 -o htmlwindow.o htmlwindow.c htmlwindow.c: In function ‘HTMLWindow2_item’: htmlwindow.c:416:13: error: variable ‘hres’ set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors make: *** [htmlwindow.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

Sept. 3, 2012

Re: [PATCH 6/6] mshtml: Added IHTMLIFrameElement3 stub implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21355 Your paranoid android. === WXPPROSP3 (32 bit dom) === dom.c:5225: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:5262: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 === WVISTAADM (32 bit dom) === dom.c:5225: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:5262: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002

Sept. 3, 2012

Re: d3dx9_36: Implement D3DXSHRotate

by Henri Verbeet

On 3 September 2012 12:02, Rico Schüller <kgbricola(a)web.de> wrote: > + sinb = sqrt( 1.0f - matrix->u.m[2][2] * matrix->u.m[2][2] ); > > I'd prefer to declare the variables as locally as possible. > As an aside, you'll probably want to use floating point functions like sqrtf() instead of ones operating on doubles like sqrt() in most of d3dx9. That's not a new issue though.

Sept. 3, 2012

Re: Wine Gecko 1.8-beta1

by Jacek Caban

On 09/02/12 20:52, Vincent Povirk wrote: >> On related note, I seriously consider dropping debug builds and replace >> them by unstripped release build or even just a separated package >> containing only debug symbols for the release build. > No one has complained about the debugging symbols in Wine Mono yet. > They are included mostly because I don't know how to get rid of them, > and it seems silly to put effort into that given the debug symbols > have proven useful so far. Are you suggesting shipping unstripped builds as default package version? That's not an option, xul.dll alone is over 700MB unstripped. Jacek

Sept. 3, 2012