January 2013 - Wine-Devel - list.winehq.org

Re: [website] Added simplified chinese

by Jeremy Newman

Thanks for looking at it. I'll do a mass move of the .cvsignore files later. Jactry should just leave it out if his final patch. We prefer UTF-8 as that is what the underlying template engine of the website understands. Modern browsers should be able to use it just fine (hopefully, even in China). -N On Wed 30 Jan 2013 10:45:28 AM CST, Hin-Tak Leung wrote: > --- On Wed, 30/1/13, Jeremy Newman <jnewman(a)codeweavers.com> wrote: > >> Patch looks good to me. Since I >> cannot read it, I need someone else here on wine devel to >> vouch for the translation. Just to make sure it is legit and >> not a very tricky spam or just a pass through google >> translate. >> >> You will also need to add a string to the >> $this->languages array in the data class >> (include/data.php) >> >> I also noticed we are still using .cvsignore files, oops. >> Those should get moved to .gitignore, but I can do that >> later. > > The translation of the content is largely okay. I also find it a bit strange with the .cvsignore file, and also the google_analytic.template file - I think that probably should be factored out into a language-neutral template. > > Just a note that the encoding is zh_CN.utf8, rather than the more-common-in-China zh_CN.GB18030 . > > (I think you can find me as a distant-past code contributor - got a couple of patches in, in the mshtml area, I think, a long time ago - and active on bugzilla for some years). > >

Jan. 30, 2013

Re: [website] Added simplified chinese

by Hin-Tak Leung

--- On Wed, 30/1/13, Jeremy Newman <jnewman(a)codeweavers.com> wrote: > Patch looks good to me. Since I > cannot read it, I need someone else here on wine devel to > vouch for the translation. Just to make sure it is legit and > not a very tricky spam or just a pass through google > translate. > > You will also need to add a string to the > $this->languages array in the data class > (include/data.php) > > I also noticed we are still using .cvsignore files, oops. > Those should get moved to .gitignore, but I can do that > later. The translation of the content is largely okay. I also find it a bit strange with the .cvsignore file, and also the google_analytic.template file - I think that probably should be factored out into a language-neutral template. Just a note that the encoding is zh_CN.utf8, rather than the more-common-in-China zh_CN.GB18030 . (I think you can find me as a distant-past code contributor - got a couple of patches in, in the mshtml area, I think, a long time ago - and active on bugzilla for some years).

Jan. 30, 2013

Re: [PATCH 8/8] wininet: Get rid of WORKREQ* types

by Juan Lang

Hi Jacek, just wanted to say these series of patches make me happy :) lpfnHungarianNotationDieDieDie ;) --Juan

Jan. 30, 2013

Re: [website] Added simplified chinese

by Jactry

Hi Jeremy, 2013/1/30 Jeremy Newman <jnewman(a)codeweavers.com>: >Patch looks good to me. Since I cannot read it, I need someone else here on wine devel to vouch for the >translation. Just to make sure it is legit and not a very tricky spam or just a pass through google translate. So happy to hear that. But please ignore this patch first and I will send a newer soon. There was some wrong in the first patch... >You will also need to add a string to the $this->languages array in the data class (include/data.php) Thanks for your remind. And I found that was anthor problem: the folder of Simplified Chinese in "templates" named "zh_CN", but the picture in "images/lang/" named "zh.png". I think "zh.png" should be renamed as "zh_CN.png". ( In general, something about "Simplified Chinese" was signed as "zh_CN" and "zh_TW" was left for "Traditional Chinese") 2013/1/30 Jeremy Newman <jnewman(a)codeweavers.com> > Patch looks good to me. Since I cannot read it, I need someone else here > on wine devel to vouch for the translation. Just to make sure it is legit > and not a very tricky spam or just a pass through google translate. > > You will also need to add a string to the $this->languages array in the > data class (include/data.php) > > I also noticed we are still using .cvsignore files, oops. Those should get > moved to .gitignore, but I can do that later. > > -N > > On Tue 29 Jan 2013 08:34:28 AM CST, Jactry wrote: > >> >>

Jan. 30, 2013

[PATCH] Support for game DRM which overwrite the GS segment selector

by Alessandro Pignotti

Hi again, I've quickly implemented the aforementioned idea of fixing the segment in the segfault handler when needed. I'm attaching my proposed patch. Alessandro Il giorno mer, 30/01/2013 alle 16.44 +0100, Alessandro Pignotti ha scritto: > Hi everyone, > > I'm trying to get a specific game which employs a seemingly custom > protection scheme to work. The DRM does various bad things as usual, but > a very bad one is manipulating to GS segment selector and setting it to > a NULL segment. The GS segment is used by libc though in various ways > (stack protection and syscall support, and probably others). > > I managed to get the activation procedure to go further and further by > enclosing each offending syscall using the following 2 macros. > > #define SAFE_GS_START \ > do { \ > wine_set_gs(ntdll_get_thread_data()->gs); \ > do > > #define SAFE_GS_END \ > while(0); \ > } while(0) > > Still, this method is very cumbersome since system calls happens in many > places even outside of ntdll. Fixing the GS is also needed to support > sigsetjmp which is used by wine's exception handling. > > I'd like to ask for feedback about what would be a sane way of > supporting this application. A possible solution would be to modify > wine's segfault handler to check if the instruction has a GS prefix > (0x65 IIRC) and try to execute the instruction again after fixing the > GS. > > Please keep me in CC since I'm not subscribed to the ML. > > Regards, > Alessandro Pignotti

Jan. 30, 2013

Re: [website] Added simplified chinese

by Jactry

Hi Jeremy, 2013/1/30 Jeremy Newman <jnewman(a)codeweavers.com> > Patch looks good to me. Since I cannot read it, I need someone else here > on wine devel to vouch for the translation. Just to make sure it is legit > and not a very tricky spam or just a pass through google translate. > So happy to hear that. But please ignore this patch first and I will send a newer soon. There was some wrong in the first patch... > > You will also need to add a string to the $this->languages array in the > data class (include/data.php) > > Thanks for your remind. And I found that was anthor problem: the folder of Simplified Chinese in "templates" named "zh_CN", but the picture in "images/lang/" named "zh.png". I think "zh.png" should be renamed as "zh_CN.png". ( In general, something about "Simplified Chinese" was signed as "zh_CN" and "zh_TW" was left for "Traditional Chinese") 2013/1/30 Jeremy Newman <jnewman(a)codeweavers.com> > Patch looks good to me. Since I cannot read it, I need someone else here > on wine devel to vouch for the translation. Just to make sure it is legit > and not a very tricky spam or just a pass through google translate. > > You will also need to add a string to the $this->languages array in the > data class (include/data.php) > > I also noticed we are still using .cvsignore files, oops. Those should get > moved to .gitignore, but I can do that later. > > -N > > On Tue 29 Jan 2013 08:34:28 AM CST, Jactry wrote: > >> >>

Jan. 30, 2013

Re: [website] Added simplified chinese

by Jeremy Newman

Patch looks good to me. Since I cannot read it, I need someone else here on wine devel to vouch for the translation. Just to make sure it is legit and not a very tricky spam or just a pass through google translate. You will also need to add a string to the $this->languages array in the data class (include/data.php) I also noticed we are still using .cvsignore files, oops. Those should get moved to .gitignore, but I can do that later. -N On Tue 29 Jan 2013 08:34:28 AM CST, Jactry wrote: >

Jan. 30, 2013

Support for game DRM which overwrite the GS segment selector

by Alessandro Pignotti

Hi everyone, I'm trying to get a specific game which employs a seemingly custom protection scheme to work. The DRM does various bad things as usual, but a very bad one is manipulating to GS segment selector and setting it to a NULL segment. The GS segment is used by libc though in various ways (stack protection and syscall support, and probably others). I managed to get the activation procedure to go further and further by enclosing each offending syscall using the following 2 macros. #define SAFE_GS_START \ do { \ wine_set_gs(ntdll_get_thread_data()->gs); \ do #define SAFE_GS_END \ while(0); \ } while(0) Still, this method is very cumbersome since system calls happens in many places even outside of ntdll. Fixing the GS is also needed to support sigsetjmp which is used by wine's exception handling. I'd like to ask for feedback about what would be a sane way of supporting this application. A possible solution would be to modify wine's segfault handler to check if the instruction has a GS prefix (0x65 IIRC) and try to execute the instruction again after fixing the GS. Please keep me in CC since I'm not subscribed to the ML. Regards, Alessandro Pignotti

Jan. 30, 2013

Re: windowscodecs: Implement GetThumbnail in the ICO frame decoder.

by Dmitry Timoshkov

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > It's still better to return WINCODEC_ERR_CODECNOTHUMBNAIL instead of > E_INVALIDARG E_INVALIDARG -> E_NOTIMPL -- Dmitry.

Jan. 30, 2013

Re: windowscodecs: Implement GetThumbnail in the ICO frame decoder.

by Dmitry Timoshkov

Hans Leidekker <hans(a)codeweavers.com> wrote: > > static HRESULT WINAPI IcoFrameDecode_GetThumbnail(IWICBitmapFrameDecode *iface, > > IWICBitmapSource **ppIThumbnail) > > { > > - FIXME("(%p,%p)\n", iface, ppIThumbnail); > > - return E_NOTIMPL; > > + TRACE("(%p,%p)\n", iface, ppIThumbnail); > > + > > + if (!ppIThumbnail) return E_INVALIDARG; > > + > > + *ppIThumbnail = NULL; > > + return WINCODEC_ERR_CODECNOTHUMBNAIL; > > } > > The test added by 6395af1ae7b0cc5f2f1f82796502e2a605bc5a6b says otherwise, GetThumbnail > is supported for ICO frames. It's still better to return WINCODEC_ERR_CODECNOTHUMBNAIL instead of E_INVALIDARG. Real implementation depends on the codec set, and although obviously MS implementation returns a real interface, that doesn't mean that an implementation that returns WINCODEC_ERR_CODECNOTHUMBNAIL is wrong. -- Dmitry.

Jan. 30, 2013