January 2013 - Wine-Devel - list.winehq.org

Re: [PATCH] ieframe/tests: Don't convert to long path name until the file exists

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24128 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === Timeout === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2607: Test failed: expected GetOverridesKeyPath webbrowser.c:2612: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2613: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3046: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

Jan. 24, 2013

Re: [1/5] comctl32/tests: more tests for icon spacing calculation

by Alexandre Julliard

Daniel Jelinski <djelinski1(a)gmail.com> writes: > +#ifdef _WIN64 > + /* NOTE: -1 is not treated the same as (DWORD)-1 by 64bit listview */ > + ret = SendMessage(hwnd, LVM_SETICONSPACING, 0, (DWORD)-1); > +todo_wine { > + expect(100, LOWORD(ret)); > + expect(0xFFFF, HIWORD(ret)); > +} > + ret = SendMessage(hwnd, LVM_SETICONSPACING, 0, 0xBAADF00DDEADBEEFLL); Please avoid ifdefs and long long constants. -- Alexandre Julliard julliard(a)winehq.org

Jan. 24, 2013

Re: ws2_32: Use assignment instead of memcpy to copy structs.

by Michael Stefaniuc

Forgot to add the credit for this patch series as I didn't wrote this coccinelle script: Found using the memcpy-assign.cocci script submitted for inclusion into the Linux kernel: https://systeme.lip6.fr/pipermail/cocci/2013-January/000121.html bye michael On 01/24/2013 02:21 PM, Michael Stefaniuc wrote: > --- > dlls/ws2_32/socket.c | 2 +- > dlls/ws2_32/tests/sock.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index c390828..6fd1e34 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -2183,7 +2183,7 @@ static BOOL interface_bind( SOCKET s, int fd, struct sockaddr *addr ) > > if (setsockopt(fd, IPPROTO_IP, IP_UNICAST_IF, &ifindex, sizeof(ifindex)) != 0) > goto cleanup; /* Failed to suggest egress interface */ > - memcpy(&specific_interface_filter, &generic_interface_filter, sizeof(generic_interface_filter)); > + specific_interface_filter = generic_interface_filter; > specific_interface_filter.iface_rule.k = adapter->Index; > filter_prog.len = sizeof(generic_interface_filter)/sizeof(struct sock_filter); > filter_prog.filter = (struct sock_filter *) &specific_interface_filter; > diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c > index 56a64bc..4b4b99a 100644 > --- a/dlls/ws2_32/tests/sock.c > +++ b/dlls/ws2_32/tests/sock.c > @@ -2725,7 +2725,7 @@ static void test_getsockname(void) > return; > } > > - memcpy(&sa_get, &sa_set, sizeof(sa_set)); > + sa_get = sa_set; > if (getsockname(sock, (struct sockaddr*) &sa_get, &sa_get_len) == 0) > ok(0, "getsockname on unbound socket should fail\n"); > else {

Jan. 24, 2013

Re: ieframe: Fixed a race in tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24121 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === Timeout === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2607: Test failed: expected GetOverridesKeyPath webbrowser.c:2612: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2613: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3046: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

Jan. 24, 2013

Re: [PATCH 2/2] vbscript: Added GetObject tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24115 Your paranoid android. === W2KPROSP4 (32 bit createobj) === createobj.c:999: Test failed: ParseScriptText failed: 8007007e createobj.c:1000: Test failed: expected QI_IObjectWithSite createobj.c:1001: Test failed: expected SetSite createobj.c:1002: Test failed: expected reportSuccess createobj.c:1008: Test failed: hres = 8007007e createobj.c:1009: Test failed: expected QI_IObjectWithSite createobj.c:1010: Test failed: expected SetSite createobj.c:1015: Test failed: ParseScriptText failed: 8007007e createobj.c:1016: Test failed: expected QI_IObjectWithSite createobj.c:1017: Test failed: expected reportSuccess

Jan. 24, 2013

Please perform MIDI test with MS OS

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, if you can, please download the test executable from https://testbot.winehq.org/JobDetails.pl?Key=24107 and run it on a native MS machine (32 and 64 bit). Please send me the results, no need to post. I particularly welcome test results from old w9k machines! Thank you, Jörg Höhle

Jan. 24, 2013

Re: [PATCH] kernel32: implement condition variables (try 5)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24106 Your paranoid android. === W7PROX64 (32 bit sync) === sync.c:947: Test failed: DeleteTimerQueueTimer sync.c:948: Test failed: ChangeTimerQueueTimer

Jan. 24, 2013

Re: [PATCH 5/5] d3d*/tests: Add simple DrawRectPatch tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24105 Your paranoid android. === WXPPROSP3 (32 bit device) === device.c:6157: Test failed: Failed to get caps, hr 0x8876086a. === W2K3R2SESP2 (32 bit device) === device.c:6157: Test failed: Failed to get caps, hr 0x8876086a. === WVISTAADM (32 bit device) === device.c:6157: Test failed: Failed to get caps, hr 0x8876086a. === W2K8SE (32 bit device) === device.c:6157: Test failed: Failed to get caps, hr 0x8876086a. === W7PRO (32 bit device) === device.c:6157: Test failed: Failed to get caps, hr 0x8876086a. === W7PROX64 (32 bit device) === device.c:6157: Test failed: Failed to get caps, hr 0x8876086a. === TEST64_W7SP1 (32 bit device) === device.c:6157: Test failed: Failed to get caps, hr 0x8876086a. === W7PROX64 (64 bit device) === device.c:6157: Test failed: Failed to get caps, hr 0x8876086a. === TEST64_W7SP1 (64 bit device) === device.c:6157: Test failed: Failed to get caps, hr 0x8876086a.

Jan. 24, 2013

Re: [PATCH 5/5] d3d*/tests: Add simple DrawRectPatch tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24104 Your paranoid android. === WXPPROSP3 (32 bit device) === device.c:4661: Test failed: Failed to get caps, hr 0x8876086a. === W2K3R2SESP2 (32 bit device) === device.c:4661: Test failed: Failed to get caps, hr 0x8876086a. === WVISTAADM (32 bit device) === device.c:4661: Test failed: Failed to get caps, hr 0x8876086a. === W2K8SE (32 bit device) === device.c:4661: Test failed: Failed to get caps, hr 0x8876086a. === W7PRO (32 bit device) === device.c:4661: Test failed: Failed to get caps, hr 0x8876086a. === W7PROX64 (32 bit device) === device.c:4661: Test failed: Failed to get caps, hr 0x8876086a. === TEST64_W7SP1 (32 bit device) === device.c:4661: Test failed: Failed to get caps, hr 0x8876086a.

Jan. 24, 2013

Re: po: Update Lithuanian translation

by Lauri Kenttä

I don't really read Lithuanian, but just in case: "No Ports" means "number of ports" or more exactly "number of datagrams which were rejected because the port in the datagram was invalid". Reference: http://msdn.microsoft.com/en-us/library/windows/desktop/aa366929%28v=vs.85%… André, any chance to make the original string (netstat.rc:52, "No Ports") better? -- Lauri Kenttä

Jan. 23, 2013