October 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 1/3] ddraw/tests: Add surface lockability tests.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-10-23 15:10, schrieb Marvin: > === w864 (32 bit ddraw2) === The test timed out > > === w864 (32 bit ddraw1) === ddraw1: unhandled exception c0000005 > at 0041212F > > === w864 (32 bit ddraw7) === Timeout Failure running script in VM: > network read timed out > > === w864 (64 bit ddraw7) === ddraw7.c:3683: Test failed: Got > unexpected, hr 0x80004002, case 2. ddraw7.c:3683: Test failed: Got > unexpected, hr 0x80004002, case 3. ddraw7.c:3683: Test failed: Got > unexpected, hr 0x80004002, case 4. > > === w864 (32 bit ddraw4) === Failure running script in VM: network > read timed out As far as I can see those failures are unrelated to my patch. I'm working on fixing those failures. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSZ9F6AAoJEN0/YqbEcdMw/9kP/RFMHfdekgOOItmPyBDNmVbX 6M8XsjwBtD/VCYWVd/8LuKltT4KJULDlfRviOSjxQrymbLil4eTSM5ejDoW4Axg8 p1Gs6pijZ0M7XVSDyasoW/jxe7mJJx732uWUDDIhtd91nwYKryI+L4c7OhxXMT6Q FpIKfLAtvGdXuqe5qfxkdYGOkq+gwieQIi3TS9Jl+kxmnbkH9sYxrYpE9kt47MeO DUa/OlOB4WZ/zgaAb0N3jeRCF7Ue0quTS+emIIzZ6nT1jHbOzvc9Qy4jsEW0wlWC NEa6dVPl4qzXNMYyJk4/lteHVNkrILwVQPy+3ioanZs85KrpUtwzoEa+/oUvA67F JRqr1XgOpFjw7agur36uG4fSHukx3tTKrBWJEMgy2sXYj8noS9Jc4yPnUk54ZSdi 0xL8Jtze1/iQOIKo0AzqoDqnZbWiVvAHyYAGwNaci6sQQCeaPgDdFYvwh5uMr65Y 4xh+3KQFhgPmaHi8yHCZtKg9OZxWZFACaJITf1qeXDWVAsQnm5QCKo5+mBxO0ny5 MVbaMJO8ta0X8Mjo3KWPH3MMF+ZPvdNsQ+rv1RinGGAofTPJii5/a/1SXqcafB/5 MZkhDRres6O1qQeOBiHbiS/TxH7esvwLON1T5HYEbgKUMQfNnA4UiCRFbgIoYDkR O+mmAKB3S1OLI3nTMu1o =JQ58 -----END PGP SIGNATURE-----

Oct. 23, 2013

Re: [PATCH 1/3] ddraw/tests: Add surface lockability tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2972 Your paranoid android. === w864 (32 bit ddraw2) === The test timed out === w864 (32 bit ddraw1) === ddraw1: unhandled exception c0000005 at 0041212F === w864 (32 bit ddraw7) === Timeout Failure running script in VM: network read timed out === w864 (64 bit ddraw7) === ddraw7.c:3683: Test failed: Got unexpected, hr 0x80004002, case 2. ddraw7.c:3683: Test failed: Got unexpected, hr 0x80004002, case 3. ddraw7.c:3683: Test failed: Got unexpected, hr 0x80004002, case 4. === w864 (32 bit ddraw4) === Failure running script in VM: network read timed out

Oct. 23, 2013

Re: [23/23] user32/tests: Enable user32 tests compilation with __WINESRC__ defined.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2971 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

Oct. 23, 2013

Re: server: Add support for pending write flag to the serial device. Take 2.

by Dmitry Timoshkov

Wolfgang Walter <wine(a)stwm.de> wrote: > I have no intention to discuss that all again. Please think about the problem. > Hint: writing twice as many bytes with 150 baud needs more time, significantly > more time then TIMEOUT. Not really. Francois sent an investigation with pretty exhaustive explanation of the behvaiour of COM-port UARTs regarding timings and baud rates. -- Dmitry.

Oct. 23, 2013

Re: server: Add support for pending write flag to the serial device. Take 2.

by Wolfgang Walter

Am Mittwoch, 23. Oktober 2013, 18:41:15 schrieben Sie: > Wolfgang Walter <wine(a)stwm.de> wrote: > > With privious test I mean the test which starts at line 836: > > S(U(ovl_write)).Offset = 0; > > S(U(ovl_write)).OffsetHigh = 0; > > ovl_write.hEvent = CreateEventW(NULL, TRUE, FALSE, NULL); > > before = GetTickCount(); > > SetLastError(0xdeadbeef); > > res = WriteFile(hcom, tbuf, sizeof(tbuf), &bytes, &ovl_write); > > after = GetTickCount(); > > > > todo_wine > > > > ok(!res && GetLastError() == ERROR_IO_PENDING, "WriteFile returned %d, > > > > error %d\n", res, GetLastError()); > > todo_wine > > > > ok(!bytes, "expected 0, got %u\n", bytes); > > ok(after - before < 30, "WriteFile took %d ms to write %d Bytes at %d > > > > Baud\n", > > > > after - before, bytes, baud); > > > > /* don't wait for WriteFile completion */ > > > > This tests sends 17 bytes but does not wait till all have been sent. > > That's the point of the test. > > > So the > > next test which fails under wine (comm.c:860: Test failed: WaitCommEvent > > failed with a timeout) does not start with a empty tx queue. There should > > be a sleep(TIMEOUT) after this test. > > State of the queue doesn't matter at all, the patch (which is the subject of > this message) is supposed to make this test work in all cases. I have no intention to discuss that all again. Please think about the problem. Hint: writing twice as many bytes with 150 baud needs more time, significantly more time then TIMEOUT. Regards, -- Wolfgang Walter Studentenwerk München Anstalt des öffentlichen Rechts

Oct. 23, 2013

Re: [02/02] d3d8: update locked_rect only if wined3d_surface_map succeeds

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-10-21 14:31, schrieb Lasse Rasinen: > On 21.10.2013, at 15.23, Henri Verbeet wrote: > >> On 21 October 2013 14:12, Lasse Rasinen <lrasinen(a)iki.fi> wrote: >>> Buildbot on the previous patch and Stefan Dösinger on Friday. >>> >> https://newtestbot.winehq.org/JobDetails.pl?Key=2784 says it >> passed the test that checked for NULL pBits and 0 Pitch. AFAIK >> Stefan didn't test d3d8 at all. Fyi, I tested the d3d8 behavior, and it consistently sets pBits and pitch to 0 on all tested machines: WinXP, ATI r200 (radeon 9000) WinVista, Nvidia G7x (geforce 7400) Win7, ATI r500 (radeon x1600) Win7, Nvidia Fermi (Geforce 460) Win7, AMD Evergreen (radeon hd 5770) D3D9 left those fields untouched. For d3d9 I only tested WinXP+r200 and Win7+Kepler. Volumes clear pBits and both pitches in d3d9 on those cards and presumably all others. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSZ7BzAAoJEN0/YqbEcdMw7MYP/1DoI3U/sqjvYk/1uH/sYoGg yGo/W0GGsQo1CV8YWsYxZ4oH8dduzJzC91fby05CueLx97Q/l87pwoOebQ1cEyoE aGFOokjNIh9M9Kbi+T/fzhiITK8WRowJ5KoxODl94RcomO6/rhs6XFkTw0CUYzJi Qgv1oMY8kRCmoJh7rwI/qe11M7XiP7NY8LQUcAice7KUL1aj/kKK3l4rwKUU2Yig 5ThlbludmL5+HJIg5z+3azjN0uFYqUU8khsQX+JbmNg8HL07kF/Q6eo2An3jLsnw z2TZz/YTW7Xvo7HzXNHslqulj3NsmtWA5hT/YqDmzpnXjumcKhX7JB36mvjXYYdx 30VXGWwtOORFkoa91W+4/kSmXEjAWiveU6bNSDw0ezRKMAYEDofAPeVahgIc1PfD lUCzDiTksE1gplvM1quqwTXQZNuC3kLQKcVIIXJdAY9ydgNgSuS+MJP9s0xnDLC3 G47+bq5Trs9eLJaAkqGCdSBHYTRzE/pJc7sQTsmcxnKr7aNMZCMC95tcioGL/RH8 8o9tqUjTqsz0kTilwNyRmtJCt4qKVaTbDAk7mb/lCHIlKMidipWMhaxAb9hce0bj PjbeSTKpV7diCl/VvYM+KUDVDsgX32FEQ2OOVabRnQkLET/gVVzTQ8ag4UddloaR vl/dq6dOlAdGMX+R42Yd =ORs7 -----END PGP SIGNATURE-----

Oct. 23, 2013

Re: [20/23] user32/tests: Fix window tests compilation with __WINESRC__ defined.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2968 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000700E2 fg 00030040 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000701F6 fg 00010046 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000500F4 fg 0001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00090138 fg 00010066 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w864 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000601BA fg 00010084 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000500F4 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000090138 fg 0000000000010066 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000

Oct. 23, 2013

Re: [18/23] user32/tests: Fix system parameters tests compilation with __WINESRC__ defined.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2966 Your paranoid android. === w864 (32 bit sysparams) === sysparams.c:2792: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2794: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784 sysparams.c:2490: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2503: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (64 bit sysparams) === sysparams.c:2792: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2794: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784 Timeout

Oct. 23, 2013

Re: server: Add support for pending write flag to the serial device. Take 2.

by Dmitry Timoshkov

Wolfgang Walter <wine(a)stwm.de> wrote: > With privious test I mean the test which starts at line 836: > > S(U(ovl_write)).Offset = 0; > S(U(ovl_write)).OffsetHigh = 0; > ovl_write.hEvent = CreateEventW(NULL, TRUE, FALSE, NULL); > before = GetTickCount(); > SetLastError(0xdeadbeef); > res = WriteFile(hcom, tbuf, sizeof(tbuf), &bytes, &ovl_write); > after = GetTickCount(); > todo_wine > ok(!res && GetLastError() == ERROR_IO_PENDING, "WriteFile returned %d, > error %d\n", res, GetLastError()); > todo_wine > ok(!bytes, "expected 0, got %u\n", bytes); > ok(after - before < 30, "WriteFile took %d ms to write %d Bytes at %d > Baud\n", > after - before, bytes, baud); > /* don't wait for WriteFile completion */ > > > This tests sends 17 bytes but does not wait till all have been sent. That's the point of the test. > So the > next test which fails under wine (comm.c:860: Test failed: WaitCommEvent > failed with a timeout) does not start with a empty tx queue. There should be a > sleep(TIMEOUT) after this test. State of the queue doesn't matter at all, the patch (which is the subject of this message) is supposed to make this test work in all cases. -- Dmitry.

Oct. 23, 2013

Re: server: Add support for pending write flag to the serial device. Take 2.

by Wolfgang Walter

Am Mittwoch, 23. Oktober 2013, 11:12:26 schrieben Sie: > Wolfgang Walter <wine(a)stwm.de> wrote: > > > ../../../tools/runtest -q -P wine -T ../../.. -M kernel32.dll -p > > > kernel32_test.exe.so comm.c && touch comm.ok comm.c:860: Test failed: > > > WaitCommEvent failed with a timeout > > > comm.c:881: Test failed: WaitCommEvent error 997 > > > comm.c:882: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 > > > comm.c:887: Test failed: WaitCommEvent used 1003 ms for waiting > > > comm.c:2226: Tests skipped: interactive tests (set > > > WINETEST_INTERACTIVE=1) > > > make: *** [comm.ok] Error 4 > > > > This is because the previous test fails: in the previous test wine > > actually > > write to the serial device and does not return with > > ERROR_INVALID_PARAMETER. > What is this "previous test" you are talking about? Obviously there is no > a failing test which checks for ERROR_INVALID_PARAMETER in the output posted > by Alexandre above. And it's worth to mention that these tests pass without > failures here with and without an external hardware turned on (with the > patch applied). With privious test I mean the test which starts at line 836: S(U(ovl_write)).Offset = 0; S(U(ovl_write)).OffsetHigh = 0; ovl_write.hEvent = CreateEventW(NULL, TRUE, FALSE, NULL); before = GetTickCount(); SetLastError(0xdeadbeef); res = WriteFile(hcom, tbuf, sizeof(tbuf), &bytes, &ovl_write); after = GetTickCount(); todo_wine ok(!res && GetLastError() == ERROR_IO_PENDING, "WriteFile returned %d, error %d\n", res, GetLastError()); todo_wine ok(!bytes, "expected 0, got %u\n", bytes); ok(after - before < 30, "WriteFile took %d ms to write %d Bytes at %d Baud\n", after - before, bytes, baud); /* don't wait for WriteFile completion */ This tests sends 17 bytes but does not wait till all have been sent. So the next test which fails under wine (comm.c:860: Test failed: WaitCommEvent failed with a timeout) does not start with a empty tx queue. There should be a sleep(TIMEOUT) after this test. The test for ERROR_INVALID_PARAMETER before that one (starting at line 831) does indeed not contribute any more to comm.c:860: Test failed: WaitCommEvent failed with a timeout any more. When we discussed this it did because then the the code still was: SetLastError(0xdeadbeef); res = WriteFile(hcom, tbuf, sizeof(tbuf), &bytes, NULL); todo_wine ok(!res, "WriteFile on an overlapped handle without ovl structure should fail\n"); todo_wine ok(GetLastError() == ERROR_INVALID_PARAMETER, "expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError()); So then there were even more bytes pending in the tx queue. Regards, -- Wolfgang Walter Studentenwerk München Anstalt des öffentlichen Rechts

Oct. 23, 2013