October 2013 - Wine-Devel - list.winehq.org

Re: [10/23] user32/tests: Fix input tests compilation with __WINESRC__ defined.

by Dmitry Timoshkov

Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote: > Dmitry, what has changed since? > (now that every test subdir is being migrated to compile with __WINESRC__) Nothing has changed on my part. Obviously the __WINESRC__ enforcement for the tests is not my idea, you need to ask somebody else about it. -- Dmitry.

Oct. 23, 2013

Re: [07/23] user32/tests: Fix DDE tests compilation with __WINESRC__ defined.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2955 Your paranoid android. === w864 (64 bit dde) === Timeout

Oct. 23, 2013

Re: [10/23] user32/tests: Fix input tests compilation with __WINESRC__ defined.

by Saulius Krasuckas

* On Wed, 23 Oct 2013, Dmitry Timoshkov wrote: > --- a/dlls/user32/tests/input.c > +++ b/dlls/user32/tests/input.c > @@ -929,7 +929,7 @@ static void test_Input_blackbox(void) > * key state set by SendInput(). */ > empty_message_queue(); > > - prevWndProc = SetWindowLongPtr(window, GWLP_WNDPROC, (LONG_PTR) WndProc2); > + prevWndProc = SetWindowLongPtrA(window, GWLP_WNDPROC, (LONG_PTR) WndProc2); > ok(prevWndProc != 0 || (prevWndProc == 0 && GetLastError() == 0), > "error: %d\n", (int) GetLastError()); > * On Fri, 8 Jun 2007, Saulius Krasuckas wrote: > --- a/dlls/user32/tests/input.c > +++ b/dlls/user32/tests/input.c > @@ -496,7 +496,7 @@ static void test_Input_blackbox(void) > * key state set by SendInput(). */ > empty_message_queue(); > > - prevWndProc = SetWindowLongPtr(window, GWLP_WNDPROC, (LONG_PTR) WndProc2); > + prevWndProc = SetWindowLongPtrA(window, GWLP_WNDPROC, (LONG_PTR) WndProc2); > ok(prevWndProc != 0 || (prevWndProc == 0 && GetLastError() == 0), > "error: %d\n", (int) GetLastError()); > It's nice to see the change is being offered by it's previous opponent six years later. Since Dmitry was strongly against it, questions go to him: * On Sat, 9 Jun 2007, Dmitry Timoshkov wrote: > "Saulius Krasuckas" <saulius2(a)ar.fi.lt> wrote: > > > Hello. I see some tests call [GS]etWindowLongPtr(..., GWLP_WNDPROC, > > ...). I think this is somewhat confusing. API offers both A- an W- > > versions of this function, while at my first glance I cannot firmly > > decide, what used name does refer to. > > > > Shouldn't occurences be renamed to ...WindowLongPtrA() here (or even > > all occurrences {by not requiring second parameter == GWLP_WNDPROC}) ? > > > > Same question stands for [GS]etWindowLong(). > > The code is correct as it is now, there is no need to change anything. Dmitry, what has changed since? (now that every test subdir is being migrated to compile with __WINESRC__) > > Did that restrict us from using single naming scheme? > > Personally I don't see any point in that. The tests are not forced to > use A/W API suffixes, that's done on purpose. Is the purpose gone now? S.

Oct. 23, 2013

Re: [02/23] user32/tests: Fix class tests compilation with __WINESRC__ defined.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2950 Your paranoid android. === w864 (32 bit class) === class.c:692: Test failed: Windows should be Unicode

Oct. 23, 2013

Re: [01/23] user32/tests: Fix broadcast tests compilation with __WINESRC__ defined.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2949 Your paranoid android. === w864 (64 bit broadcast) === The test timed out

Oct. 23, 2013

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.

by Dmitry Timoshkov

Qian Hong <qhong(a)codeweavers.com> wrote: > With Francois's great help, I've fixed most winstation failures. There > are still some random failures which seems hard to fix, I think the > tachyon modulation must be wrongly polarised. <grin> It looks like that these new winstation tests now leave a reference to a wineserver object which makes wineserver stay in memory after the tests have finished. Please fix. -- Dmitry.

Oct. 23, 2013

Re: server: Add support for pending write flag to the serial device. Take 2.

by Dmitry Timoshkov

Wolfgang Walter <wine(a)stwm.de> wrote: > > ../../../tools/runtest -q -P wine -T ../../.. -M kernel32.dll -p > > kernel32_test.exe.so comm.c && touch comm.ok comm.c:860: Test failed: > > WaitCommEvent failed with a timeout > > comm.c:881: Test failed: WaitCommEvent error 997 > > comm.c:882: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 > > comm.c:887: Test failed: WaitCommEvent used 1003 ms for waiting > > comm.c:2226: Tests skipped: interactive tests (set WINETEST_INTERACTIVE=1) > > make: *** [comm.ok] Error 4 > > This is because the previous test fails: in the previous test wine actually > write to the serial device and does not return with ERROR_INVALID_PARAMETER. What is this "previous test" you are talking about? Obviously there is no a failing test which checks for ERROR_INVALID_PARAMETER in the output posted by Alexandre above. And it's worth to mention that these tests pass without failures here with and without an external hardware turned on (with the patch applied). -- Dmitry.

Oct. 23, 2013

Re: server: Add support for pending write flag to the serial device. Take 2.

by Dmitry Timoshkov

Alexandre Julliard <julliard(a)winehq.org> wrote: > It doesn't work here: > > ../../../tools/runtest -q -P wine -T ../../.. -M kernel32.dll -p kernel32_test.exe.so comm.c && touch comm.ok > comm.c:860: Test failed: WaitCommEvent failed with a timeout > comm.c:881: Test failed: WaitCommEvent error 997 > comm.c:882: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 > comm.c:887: Test failed: WaitCommEvent used 1003 ms for waiting Could you please generate a +relay,+tid,+comm,+server log for me? -- Dmitry.

Oct. 23, 2013

Re: comdlg32/tests: Use BOOL type where appropriate

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2943 Your paranoid android. === w2008s64 (64 bit filedlg) === No test summary line found

Oct. 23, 2013

Re: [PATCH 5/6] user32/tests: Test SetUserObjectInformation for invisible winstation.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2941 Your paranoid android. === w2008s64 (32 bit winstation) === winstation.c:927: Test failed: unexpected foreground window 0001004E

Oct. 22, 2013