October 2013 - Wine-Devel - list.winehq.org

Re: oleaut32: Added a preliminary test, for scale overflow, in VarDecCmp. (try 2) (resend)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2926 Your paranoid android. === build (build) === Patch failed to apply

Oct. 22, 2013

Re: oleaut32: Added a preliminary test, for scale overflow, in VarDecCmp. (resend)

by Dmitry Timoshkov

Christopher Cope <ccope3(a)utk.edu> wrote: > --- a/dlls/oleaut32/vartype.c > +++ b/dlls/oleaut32/vartype.c > @@ -5836,7 +5836,9 @@ HRESULT WINAPI VarDecRound(const DECIMAL* pDecIn, int cDecimals, DECIMAL* pDecOu > HRESULT WINAPI VarDecCmp(const DECIMAL* pDecLeft, const DECIMAL* pDecRight) > { > HRESULT hRet; > - DECIMAL result; > + static DECIMAL scaleFactor; Is there a reason to make this variable static? -- Dmitry.

Oct. 22, 2013

Re: shlwapi: Test and fix the behaviour of the CopyTo method for file sizes not multiple of the internal buffer size, on SHCreateStreamOnFileEx-returned IStreams.

by Vincent Povirk

We should probably still exit the loop if fewer bytes were read than requested, rather than do another read at the end of the file.

Oct. 21, 2013

Re: [PATCH] wined3d: Use GL_ARB_texture_mirror_clamp_to_edge when available.

by Henri Verbeet

On 21 October 2013 21:20, Rico Schüller <kgbricola(a)web.de> wrote: > As wgl.h is a bit out of date, it still uses the > GL_MIRROR_CLAMP_TO_EDGE_ATI instead of GL_MIRROR_CLAMP_TO_EDGE (which is > only available in headers for OpenGL 4.4). > The wine/wgl.h header is generated from the GL .spec files by dlls/opengl32/make_opengl, so in principle all you'd have to do would be to run that script to get the new constant. Unfortunately Khronos seems to have decided to no longer update the .spec files, since there are shiny new XML files now.

Oct. 21, 2013

Re: msvcrt: Make first call to fwrite bufferred

by Piotr Caban

Please ignore this patch, it slows down fwrite on unbuffered FILE's. On 10/21/13 15:43, Piotr Caban wrote: > Without this patch fwrite allocates the buffer on first call and doesn't > use it. > --- > dlls/msvcrt/file.c | 125 > +++++++++++++++++++++++------------------------------ > 1 file changed, 54 insertions(+), 71 deletions(-) > > > > >

Oct. 21, 2013

Re: [02/02] d3d8: update locked_rect only if wined3d_surface_map succeeds

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2910 Your paranoid android. === w864 (32 bit device) === device.c:2481: Test failed: Expected foreground window 000401A4, got 00010084. device.c:3174: Test failed: Expected wndproc 0x4107a0, got 0x4107a0. device.c:4029: Test failed: pBits changed on double lock. device.c:4030: Test failed: Pitch changed on double lock.

Oct. 21, 2013

Re: [01/02] d3d9: update locked_rect only if wined3d_surface_map succeeds

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2909 Your paranoid android. === w864 (32 bit device) === device: unhandled exception c0000005 at 740D14C8 === w864 (64 bit device) === device: unhandled exception c0000005 at 000007F84EDD90EB

Oct. 21, 2013

Re: [23/23] kernel32/tests: Enable kernel32 tests compilation with __WINESRC__ defined.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2908 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

Oct. 21, 2013

Re: [02/02] d3d8: update locked_rect only if wined3d_surface_map succeeds

by Lasse Rasinen

On 21.10.2013, at 15.23, Henri Verbeet wrote: > On 21 October 2013 14:12, Lasse Rasinen <lrasinen(a)iki.fi> wrote: >> Buildbot on the previous patch and Stefan Dösinger on Friday. >> > https://newtestbot.winehq.org/JobDetails.pl?Key=2784 says it passed > the test that checked for NULL pBits and 0 Pitch. AFAIK Stefan didn't > test d3d8 at all. > >> There's the one misbehaving app (Artemis spaceship sim) that cares. Will update test. >> > Isn't that d3d9? > D'oh. I can't read, apparently. Apologies. In that case, yes, this patch can be dropped; let's see what the buildbot thinks about the other one.

Oct. 21, 2013

Re: [02/02] d3d8: update locked_rect only if wined3d_surface_map succeeds

by Henri Verbeet

On 21 October 2013 14:12, Lasse Rasinen <lrasinen(a)iki.fi> wrote: > Buildbot on the previous patch and Stefan Dösinger on Friday. > https://newtestbot.winehq.org/JobDetails.pl?Key=2784 says it passed the test that checked for NULL pBits and 0 Pitch. AFAIK Stefan didn't test d3d8 at all. > There's the one misbehaving app (Artemis spaceship sim) that cares. Will update test. > Isn't that d3d9?

Oct. 21, 2013