October 2013 - Wine-Devel - list.winehq.org

Re: winemac: Add registry settings to make Option keys send Alt rather than accessing additional characters from the keyboard layout.

by Ken Thomases

On Oct 10, 2013, at 3:11 AM, Phil Krylov wrote: > Every time I press Cmd-Space to switch keyboard layouts, Wine > activates menu as if I would have pressed Alt, so I have to press > Command once again to exit it. It does not happen in Windows, though, > when I use Alt-Shift to switch layouts, so the real problem is not > related to Alt interpretation of Cmd, but to incorrect emulation of > Windows behaviour when a keyboard layout switch hotkey is pressed. Does the attached patch help? By the way, you should file a bug report about this issue so that it doesn't get lost. Regards, Ken

Oct. 21, 2013

Re: shell32: Avoid leaks and add parameter checks in SHCreateShellFolderView[Ex]. (try 2)

by Thomas Faber

shlfolder.c:229: this is the last test seen before the exception Unrelated to my changes. The new tests succeed in Win8 x64. On 2013-10-20 22:28, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://newtestbot.winehq.org/JobDetails.pl?Key=2885 > > Your paranoid android. > > > === w864 (64 bit shlfolder) === > shlfolder: unhandled exception c0000005 at 000007F851EBABDC >

Oct. 20, 2013

Re: shell32: Avoid leaks and add parameter checks in SHCreateShellFolderView[Ex]. (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2885 Your paranoid android. === w864 (64 bit shlfolder) === shlfolder: unhandled exception c0000005 at 000007F851EBABDC

Oct. 20, 2013

Re: shell32: Avoid leaks and add parameter checks in SHCreateShellFolderView[Ex].

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2880 Your paranoid android. === w864 (64 bit shlfolder) === shlfolder: unhandled exception c0000005 at 000007F851EBABDC

Oct. 20, 2013

Re: shell32: Avoid leaks and add parameter checks in SHCreateShellFolderView[Ex].

by Nikolay Sivov

On 10/20/2013 21:01, Thomas Faber wrote: > + if (0) > + { > + // crash on win7 > + pSHCreateShellFolderViewEx(NULL, NULL); > + pSHCreateShellFolderViewEx(NULL, &psv); > + pSHCreateShellFolderViewEx(&csfv, NULL); > + } Please no cpp comments. > + MAKEFUNC_ORD(SHCreateShellFolderViewEx, 174); > + MAKEFUNC_ORD(SHCreateShellFolderView, 256); These call are exported by name at least on XP, probably 2000 too, so it makes no sense to use ordinals here. > + if (!pSHCreateShellFolderView || !pSHCreateShellFolderViewEx) > + { > + win_skip("SHCreateShellFolderView or SHCreateShellFolderViewEx missing.\n"); > + return; > + } I don't think it's really possible to have *Ex version without non-Ex one. > + hr = SHGetDesktopFolder(&desktop); > + ok(hr == S_OK, "got (0x%08x)\n", hr); > + if (FAILED(hr)) > + { > + skip("No desktop folder\n"); > + return; > + } It's not going to fail, so a ok() test is enough. > + memset(&sfvc, 0, sizeof(sfvc)); > + sfvc.cbSize = sizeof(sfvc); > + sfvc.pshf = desktop; > + psv = (void *)0xdeadbeef; > + hr = pSHCreateShellFolderView(&sfvc, &psv); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + ok(psv != NULL, "psv = %p\n", psv); > + if (psv && psv != (void *)0xdeadbeef) > + { > + refCount = IShellView_Release(psv); > + ok(refCount == 0, "refCount = %u\n", refCount); > + } It's simpler than that. Set 'psv' to NULL and test for it being set after a call. > + test_SHCreateShellFolderView(); You're testing two calls here, so they probably deserve two separate test functions.

Oct. 20, 2013

Re: shell32/tests: Use BOOL type where appropriate

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2879 Your paranoid android. === wxppro (32 bit shlexec) === shlexec.c:1197: Test failed: expected 1 args, got 4 shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec.', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\%nasty% $file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\%NASTY~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:/DOCUME~1/winetest/LOCALS~1/Temp/wt1.tmp/test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.noassoc.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~2.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\masked file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\MASKED~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\masked file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\MASKED~1.SHL' shlexec.c:1631: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1939: Test failed: argvA4 expected 'C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1947: Test failed: argvA4 expected 'C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:2250: Test failed: argvA3 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.sde', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SDE' shlexec.c:2250: Test failed: argvA3 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.sde', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SDE' shlexec.c:2240: Test failed: argcA expected 5, but got 4 === wvista (32 bit shlexec) === shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC34E.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC34E.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1530: Test failed: argvA3 expected 'Open', but key not found or empty shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtC34E.tmp\test file.noassoc', but key not found or empty === w2008s64 (32 bit shlexec) === shlexec.c:1538: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt9F4A.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt9F4A.tmp\test file.shlexec' shlexec.c:2606: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt9F4A.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt9F4A.tmp\test2.exe' shlexec.c:2619: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt9F4A.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt9F4A.tmp\test2.exe' shlexec.c:2631: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt9F4A.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt9F4A.tmp\test2.exe' === w864 (32 bit shlexec) === shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc', but key not found or empty shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\wt4E20.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\wt4E20.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2059: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\wt4E20.tmp" Exec") succeeded: rc=42 === w2008s64 (64 bit shlexec) === shlexec.c:1538: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wtDF85.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wtDF85.tmp\test file.shlexec' shlexec.c:2606: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wtDF85.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wtDF85.tmp\test2.exe' shlexec.c:2619: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wtDF85.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wtDF85.tmp\test2.exe' shlexec.c:2631: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wtDF85.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wtDF85.tmp\test2.exe' === w864 (64 bit shlexec) === shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc', but key not found or empty shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\wt9DA6.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\wt9DA6.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2059: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\wt9DA6.tmp" Exec") succeeded: rc=42 === w864 (64 bit shlfolder) === shlfolder: unhandled exception c0000005 at 000007F851EBABDC

Oct. 19, 2013

Re: server: Implement job objects (try 2)

by Andrew Cook

On 17/10/13 15:11, Andrew Cook wrote: > --- > dlls/kernel32/tests/process.c | 172 ++++++++++++++++++++++- > dlls/ntdll/sync.c | 127 +++++++++++++++-- > server/process.c | 313 > ++++++++++++++++++++++++++++++++++++++++++ > server/process.h | 3 + > server/protocol.def | 33 +++++ > 5 files changed, 636 insertions(+), 12 deletions(-) > > Is there something wrong with this patch?

Oct. 18, 2013

Re: [1/2] gdiplus: Reimplement GdipCloneBitmapArea without using GdipBitmapLockBits.

by Vincent Povirk

This series looks good to me.

Oct. 18, 2013

Re: [PATCH 2/2] ole32: Pass last_unlock_releases to IExternalConnection_ReleaseConnection().

by Alexandre Julliard

Huw Davies <huw(a)codeweavers.com> writes: > --- > dlls/ole32/stubmanager.c | 2 +- > dlls/ole32/tests/marshal.c | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M oleaut32.dll -p oleaut32_test.exe.so tmarshal.c && touch tmarshal.ok tmarshal.c:191: Test failed: fLastReleaseCloses = 0, expected 1 tmarshal.c:191: Test failed: fLastReleaseCloses = 0, expected 1 make: *** [tmarshal.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

Oct. 18, 2013

Re: [PATCH 1/2] ole32/tests: Add tests to show that CoLockObjectExternal() calls ReleaseConnection() with the appropriate va

by Huw Davies

On Fri, Oct 18, 2013 at 07:13:06AM -0500, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://newtestbot.winehq.org/JobDetails.pl?Key=2863 Hi Marvin, Looks like you had the same problem running a NOP test: https://newtestbot.winehq.org/JobDetails.pl?Key=2866 The wxppro failure is strange as you seem to be trying to run test 'and'. Huw.

Oct. 18, 2013