October 2013 - Wine-Devel - list.winehq.org

Re: shlwapi: Test and fix the behaviour of the CopyTo method for file sizes not multiple of the internal buffer size, on SHC

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3116 Your paranoid android. === wvista (32 bit istream) === istream.c:669: Test failed: SHCreateStreamOnFileEx failed with ret=0x8007007b === w2008s64 (64 bit istream) === istream.c:669: Test failed: SHCreateStreamOnFileEx failed with ret=0x8007007b

Oct. 30, 2013

Re: shlwapi: Test and fix the behaviour of the CopyTo method for file sizes not multiple of the internal buffer size, on SHCreateStreamOnFileEx-returned IStreams. (try 4)

by Alexandre Julliard

"David Quintana (gigaherz)" <gigaherz(a)gmail.com> writes: > +{ > + HRESULT ret; > + IStream* src; > + IStream* dst; > + ULARGE_INTEGER count, read, written; > + > + CHAR srcPathA[MAX_PATH]; > + CHAR dstPathA[MAX_PATH]; > + > + WCHAR srcPath[MAX_PATH]; > + WCHAR dstPath[MAX_PATH]; > + > + const CHAR *srcFileName = "SHCreateStreamOnFileEx-src.dat"; > + const CHAR *dstFileName = "SHCreateStreamOnFileEx-dst.dat"; > + > + GetTempPathA(MAX_PATH, srcPathA); > + lstrcatA(srcPathA, srcFileName); > + MultiByteToWideChar(CP_ACP, 0, srcPathA, -1, srcPath, MAX_PATH); > + > + GetTempPathA(MAX_PATH, dstPathA); > + lstrcatA(dstPathA, dstFileName); > + MultiByteToWideChar(CP_ACP, 0, dstPathA, -1, dstPath, MAX_PATH); There's no reason to use such specific file names, just use GetTempFileName or something like that. -- Alexandre Julliard julliard(a)winehq.org

Oct. 30, 2013

Re: winex11.drv: Add TIMESTAMP to X clipboard TARGETS

by Andrey Vostrikov

Alexandre Julliard wrote: > Andrey Vostrikov <av.linux.dev(a)gmail.com> writes: > >> Alexandre Julliard wrote: >>> Andrey Vostrikov <andrey.vostrikov(a)cogentembedded.com> writes: >>> >>>> + else if(event->target == x11drv_atom(TIMESTAMP)) /* Return event timestamp */ >>>> + { >>>> + /* TIMESTAMP selection request */ >>>> + XChangeProperty(display, request, rprop, event->target, >>>> + 32, PropModeReplace, (unsigned char*)&event->time, 1); >>> That's not the correct timestamp. >>> >> What would be the correct one then? > > The time when we acquired the selection. > Hi Alexandre, This is updated patch. It obtains X server timestamp similar as in GTK+ library, by pinging X window when selection is acquired. Best regards, Andrey

Oct. 30, 2013

Re: [PATCH 3/5] d3d9/tests: Use explicit A calls.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3115 Your paranoid android. === w864 (32 bit device) === device: unhandled exception c0000005 at 74C714C8 === w864 (64 bit device) === device: unhandled exception c0000005 at 000007F9366B90EB

Oct. 30, 2013

Re: winex11.drv: Add TIMESTAMP to X clipboard TARGETS

by Alexandre Julliard

Andrey Vostrikov <av.linux.dev(a)gmail.com> writes: > Alexandre Julliard wrote: >> Andrey Vostrikov <andrey.vostrikov(a)cogentembedded.com> writes: >> >>> + else if(event->target == x11drv_atom(TIMESTAMP)) /* Return event timestamp */ >>> + { >>> + /* TIMESTAMP selection request */ >>> + XChangeProperty(display, request, rprop, event->target, >>> + 32, PropModeReplace, (unsigned char*)&event->time, 1); >> That's not the correct timestamp. >> > What would be the correct one then? The time when we acquired the selection. -- Alexandre Julliard julliard(a)winehq.org

Oct. 30, 2013

Re: winex11.drv: Add TIMESTAMP to X clipboard TARGETS

by Andrey Vostrikov

Alexandre Julliard wrote: > Andrey Vostrikov <andrey.vostrikov(a)cogentembedded.com> writes: > >> + else if(event->target == x11drv_atom(TIMESTAMP)) /* Return event timestamp */ >> + { >> + /* TIMESTAMP selection request */ >> + XChangeProperty(display, request, rprop, event->target, >> + 32, PropModeReplace, (unsigned char*)&event->time, 1); > That's not the correct timestamp. > What would be the correct one then? CurrentTime is zero and does not help. event->time is very close to what is needed and fixes an issue.

Oct. 30, 2013

Re: [PATCH 2/5] d3d9/tests: Avoid windowsx.h.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3114 Your paranoid android. === w864 (32 bit device) === device: unhandled exception c0000005 at 74C714C8 === w864 (64 bit device) === device: unhandled exception c0000005 at 000007F9366B90EB

Oct. 30, 2013

Re: winex11.drv: Add TIMESTAMP to X clipboard TARGETS

by Alexandre Julliard

Andrey Vostrikov <andrey.vostrikov(a)cogentembedded.com> writes: > + else if(event->target == x11drv_atom(TIMESTAMP)) /* Return event timestamp */ > + { > + /* TIMESTAMP selection request */ > + XChangeProperty(display, request, rprop, event->target, > + 32, PropModeReplace, (unsigned char*)&event->time, 1); That's not the correct timestamp. -- Alexandre Julliard julliard(a)winehq.org

Oct. 30, 2013

Re: crypt32: Check number of bytes returned by ReadFile and avoid a memory leak on error path.

by Dmitry Timoshkov

This patch is marked as superseded in the tracker but it is not. -- Dmitry.

Oct. 30, 2013

Re: [PATCH] quartz/tests: Enable compilation with -D__WINESRC__

by Nikolay Sivov

Hi. No, it's not new. This runs has it already http://test.winehq.org/data/ddd6fd1ecbc4c25cf6c69202934c8bf2a3f01daf/index_… On Tue, Oct 29, 2013 at 6:38 PM, Marvin <testbot(a)winehq.org> wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://newtestbot.winehq.org/JobDetails.pl?Key=3099 > > Your paranoid android. > > > === w864 (32 bit filtergraph) === > filtergraph: unhandled exception c0000005 at 00404347 > > === w864 (64 bit filtergraph) === > filtergraph: unhandled exception c0000005 at 0000000000403DF2 > > >

Oct. 29, 2013