October 2013 - Wine-Devel - list.winehq.org

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.

by Qian Hong

On Thu, Oct 10, 2013 at 8:42 PM, Qian Hong <qhong(a)codeweavers.com> wrote: > Sorry for introduced the failures, I'd like to investigate, however I > can't reproduce the failures on my own Win7. I try to run > winetest-latest.exe on the testbot, but it ran timeout (as expect), is > there any way I can increase the timeout value from 120 to something > like 1800? Oh, forgot to say: the test failures are most likely caused by side effects of other tests, I can't reproduce it on our testbots if only winstation tests are executed, that is why I asked for increasing the timeout so I can run a full test of winetest-latest.exe -- Regards, Qian Hong - http://www.codeweavers.com

Oct. 10, 2013

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.

by Qian Hong

Hello, On Thu, Oct 10, 2013 at 6:48 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Can you please fix the test failures introduced by your previous changes > first? cf. https://test.winehq.org/data/tests/user32:winstation.html Sorry for introduced the failures, I'd like to investigate, however I can't reproduce the failures on my own Win7. I try to run winetest-latest.exe on the testbot, but it ran timeout (as expect), is there any way I can increase the timeout value from 120 to something like 1800? Thanks! -- Regards, Qian Hong - http://www.codeweavers.com

Oct. 10, 2013

Re: ieframe: Compile tests with __WINESRC__ define.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2688 Your paranoid android. === wxppro (32 bit webbrowser) === webbrowser.c:792: Test failed: ReadyState = 1, expected 4

Oct. 10, 2013

Re: wmvcore: Stub implementation of IWMMetadataEditor interface

by Nikolay Sivov

On 10/10/2013 14:58, Jeff Latimer wrote: > --- > dlls/wmvcore/Makefile.in | 2 +- > dlls/wmvcore/wmvcore_main.c | 100 > +++++++++++++++++++++++++++++++++++++++++++- > include/wmsdkidl.idl | 11 ++--- > 3 files changed, 105 insertions(+), 8 deletions(-) > +typedef struct MetadataEditorImpl { > + IWMMetadataEditor MetadataEditor_iface; > + LONG ref; > +} MetadataEditorImpl; > +static inline MetadataEditorImpl *impl_from_MetadataEditor(IWMMetadataEditor *iface) Please follow naming convetions for interfaces. > +HRESULT WINAPI WMCreateEditor_close(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} > +HRESULT WINAPI WMCreateEditor_flush(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} This looks totally wrong. Also please keep implementation functions order and interface methods order the same.

Oct. 10, 2013

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.

by Alexandre Julliard

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/user32/tests/winstation.c | 57 > ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:winstation.html -- Alexandre Julliard julliard(a)winehq.org

Oct. 10, 2013

Re: xmllite: Use BOOL type where appropriate

by Nikolay Sivov

On 10/10/2013 00:36, Frédéric Delanoy wrote: > --- > dlls/xmllite/reader.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c > index 0a4423c..a216951 100644 > --- a/dlls/xmllite/reader.c > +++ b/dlls/xmllite/reader.c > @@ -726,7 +726,7 @@ static void readerinput_grow(xmlreaderinput *readerinput, int length) > } > } > > -static inline int readerinput_is_utf8(xmlreaderinput *readerinput) > +static inline BOOL readerinput_is_utf8(xmlreaderinput *readerinput) > { > static char startA[] = {'<','?'}; > static char commentA[] = {'<','!'}; > @@ -953,7 +953,7 @@ static void reader_skipn(xmlreader *reader, int n) > } > } > > -static inline int is_wchar_space(WCHAR ch) > +static inline BOOL is_wchar_space(WCHAR ch) > { > return ch == ' ' || ch == '\t' || ch == '\r' || ch == '\n'; > } > @@ -1055,7 +1055,7 @@ static HRESULT reader_parse_versioninfo(xmlreader *reader) > } > > /* ([A-Za-z0-9._] | '-') */ > -static inline int is_wchar_encname(WCHAR ch) > +static inline BOOL is_wchar_encname(WCHAR ch) > { > return ((ch >= 'A' && ch <= 'Z') || > (ch >= 'a' && ch <= 'z') || > @@ -1269,7 +1269,7 @@ static HRESULT reader_parse_comment(xmlreader *reader) > } > > /* [2] Char ::= #x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x10000-#x10FFFF] */ > -static inline int is_char(WCHAR ch) > +static inline BOOL is_char(WCHAR ch) > { > return (ch == '\t') || (ch == '\r') || (ch == '\n') || > (ch >= 0x20 && ch <= 0xd7ff) || > @@ -1279,7 +1279,7 @@ static inline int is_char(WCHAR ch) > } > > /* [13] PubidChar ::= #x20 | #xD | #xA | [a-zA-Z0-9] | [-'()+,./:=?;!*#@$_%] */ > -static inline int is_pubchar(WCHAR ch) > +static inline BOOL is_pubchar(WCHAR ch) > { > return (ch == ' ') || > (ch >= 'a' && ch <= 'z') || > @@ -1292,7 +1292,7 @@ static inline int is_pubchar(WCHAR ch) > (ch == '_') || (ch == '\r') || (ch == '\n'); > } > > -static inline int is_namestartchar(WCHAR ch) > +static inline BOOL is_namestartchar(WCHAR ch) > { > return (ch == ':') || (ch >= 'A' && ch <= 'Z') || > (ch == '_') || (ch >= 'a' && ch <= 'z') || > @@ -1312,7 +1312,7 @@ static inline int is_namestartchar(WCHAR ch) > } > > /* [4 NS] NCName ::= Name - (Char* ':' Char*) */ > -static inline int is_ncnamechar(WCHAR ch) > +static inline BOOL is_ncnamechar(WCHAR ch) > { > return (ch >= 'A' && ch <= 'Z') || > (ch == '_') || (ch >= 'a' && ch <= 'z') || > @@ -1336,7 +1336,7 @@ static inline int is_ncnamechar(WCHAR ch) > (ch >= 0xfdf0 && ch <= 0xfffd); > } > > -static inline int is_namechar(WCHAR ch) > +static inline BOOL is_namechar(WCHAR ch) > { > return (ch == ':') || is_ncnamechar(ch); > } I don't actually see what this will achieve, but I see such patches are accepted. Is it a new style rule?

Oct. 10, 2013

Re: [PATCH 5/5] user32: Implement better stub of OpenInputDesktop.

by Qian Hong

Hi Vincent, Thanks a lot for the advice, I'll try that. On Thu, Oct 10, 2013 at 12:41 AM, Vincent Povirk <madewokherd(a)gmail.com> wrote: > I don't think it's possible to properly implement SwitchDesktop in > either the X11 or Mac driver. There's just nothing sensible for it to > do. > That's one reason that I didn't try to implement SwitchDesktop, I was not very sure about this, thanks for confirming. > One possible strategy would be to implement SwitchDesktop in user32 > and wineserver. Wineserver could logically track the input desktop, > and OpenInputDesktop would return the "correct" desktop, but > SwitchDesktop wouldn't really do anything. If in the future we decide > there's something SwitchDesktop can do that makes sense, we can add a > function for it to the user driver, and OpenInputDesktop probably > won't need to change. I ever though about this, but gave up. After more thought, I agree that this is a better approach, thanks again! -- Regards, Qian Hong - http://www.codeweavers.com

Oct. 10, 2013

Re: winemac: Add registry settings to make Option keys send Alt rather than accessing additional characters from the keyboard layout.

by Phil Krylov

Hello, On Thu, Oct 10, 2013 at 3:24 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > On Oct 9, 2013, at 4:49 PM, Phil Krylov wrote: >> Do you consider adding an option to stop interpreting Command as Alt? > > I have not considered it. What would be gained? Do you want the Command key interpreted as the Windows key? Do you want something else to happen when Command is pressed? Every time I press Cmd-Space to switch keyboard layouts, Wine activates menu as if I would have pressed Alt, so I have to press Command once again to exit it. It does not happen in Windows, though, when I use Alt-Shift to switch layouts, so the real problem is not related to Alt interpretation of Cmd, but to incorrect emulation of Windows behaviour when a keyboard layout switch hotkey is pressed. On the other hand, Option is labeled as Alt, and works this way with the X11 driver, so it seems logical to process Cmd as Win key. And it would hack around my actual problem ;) -- Ph.

Oct. 10, 2013

Re: Fix text rotation problem in GM_ADVANCED graphics mode caused by incorrect implementation of GetTextExtentPointW().

by Ralf Habacker

On 01.10.2013 12:12, Alexandre Julliard wrote: > Ralf Habacker <ralf.habacker(a)freenet.de> writes: > >> With other patches i have been told to implement such stuff in the dib >> driver. Unfortunally this do not works in this case, because in the top >> level function it looks like having driver specific stuff using display >> coordinates. > It would still most likely have to be in the driver, though maybe the > driver would not be calling that exact entry point. In any case, you > can't change the DC transform like this. You are refering to the usage of setting hard coded values ? Instead I should decompose the rotation and reset only that part ? Ralf

Oct. 10, 2013

Re: kernel32/tests: Add tests for job objects (try 7)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2683 Your paranoid android. === w864 (64 bit process) === process.c:2092: Test failed: Unexpected completion event: 6, 0000000000000158, 00000000000002F0

Oct. 10, 2013