October 2013 - Wine-Devel - list.winehq.org

Re: WineTestBot status update

by Francois Gouget

On Sun, 27 Oct 2013, Jeremy White wrote: > And I meant to ask, but did not: does it make sense to throw > hardware at some of the issues? We've got additional systems > we could easily rig as slaves... The current VM host is far from fully utilized. The CPU is over 90% idle. The only point that worries me is the I/O but I hope disabling Windows Defender will have greatly reduced it. To get good performance we need to: * Solve the VM revert issue. * Tweak the self-imposed limits on active VMs and reverts. Currently we only allow up to 2 active VMs and 1 revert, that's 2 running VMs or 1 running VM and one revert. Given that the bos has 8 cores and each VM normally uses at most 2, I think we can go up to 4 running VMs. We can probably also allow up to 2 reverts, though that's likely more disk-limited. I think we can also reduce the post-revert sleep phase (from 30 seconds down to 10 or less). * Defuse 'test-bombs', though these are mostly a corner case really (once the __WINESRC__ work is done it will be some time before we get such patches again). But there's other reasons to do that work anyway (bug 33065). -- Francois Gouget <fgouget(a)codeweavers.com>

Oct. 28, 2013

Re: WineTestBot status update

by Dmitry Timoshkov

Francois Gouget <fgouget(a)codeweavers.com> wrote: > On Mon, 28 Oct 2013, Dmitry Timoshkov wrote: > [...] > > Yes, there are still ways for the new testbot improvements. When time from > > time I send patches for testing I send them to both old and new testbots. > > While old tesbot completes the job in minutes (usually 3-5), the new one > > almost always completes the request several hours later. > > I think that's because of two factors: > * The current __WINESRC__ jobs which I like to call testbot-bombs. > That's because these patches tend to touch multiple tests which > creates one task per test per base VM, so 8 tasks per test, plus the > build one. So for instance a patch fixing the 11 advapi32 tests would > create 89 tasks (1 build + 11 tests * 8 VMs), so 89 reverts. There's > been many such patches lately and that delays the tests coming after > them. When I sent a patch to testbot last time there were no __WINESRC__ related patches in the queue... > * The old TestBot is not processing wine-patches emails anymore. That > means it's essentially has nothing to do but work on your jobs. ... and nightly test run has been finished as well. Also there were no other things related to wine-patches processing running either. > > Looking at the job status it shows that the build is complete and VMs > > are online and ready but nothing happens further on. > > That's strange. It can happen if it's waiting on a VM that's offline or > undergoing maintenance. There can also be cases where the build VM gets > a bit ahead (but normally the TestBot tries to complete the jobs one at > a time). When next time I'll be playing with the tests what additional info could I provide for better diagnosing the problem? -- Dmitry.

Oct. 28, 2013

Re: WineTestBot status update

by Francois Gouget

On Mon, 28 Oct 2013, Dmitry Timoshkov wrote: [...] > Yes, there are still ways for the new testbot improvements. When time from > time I send patches for testing I send them to both old and new testbots. > While old tesbot completes the job in minutes (usually 3-5), the new one > almost always completes the request several hours later. I think that's because of two factors: * The current __WINESRC__ jobs which I like to call testbot-bombs. That's because these patches tend to touch multiple tests which creates one task per test per base VM, so 8 tasks per test, plus the build one. So for instance a patch fixing the 11 advapi32 tests would create 89 tasks (1 build + 11 tests * 8 VMs), so 89 reverts. There's been many such patches lately and that delays the tests coming after them. * The old TestBot is not processing wine-patches emails anymore. That means it's essentially has nothing to do but work on your jobs. Defusing the TestBot bombs will be one of my next TestBot tasks after these two VMs are back online. The way it will work is to build custom WineTest binaries with just the tests we need to run, and to run that binary on each VM. So in the above case we'll only have 1 + 8 tasks. > Looking at the job status it shows that the build is complete and VMs > are online and ready but nothing happens further on. That's strange. It can happen if it's waiting on a VM that's offline or undergoing maintenance. There can also be cases where the build VM gets a bit ahead (but normally the TestBot tries to complete the jobs one at a time). -- Francois Gouget <fgouget(a)codeweavers.com>

Oct. 28, 2013

Re: WineTestBot status update

by Dmitry Timoshkov

Francois Gouget <fgouget(a)codeweavers.com> wrote: > I also uncovered two other potential performance issues: > * Some VMs have Windows Defender and apparently it was starting a full > disk scan as soon as the VM was ready to run the tests. That's > clearly not good so I disabled Windows Defender in all VMs. > > * Most VMs were still using 20% of the CPU when idle. That's fine if > only one VM is running but could impact performance (through > increased interrupt rates) if many are running at once (like on the > WineTestBot). Apparently the culprit is the USB Tablet device that's > added by default. So I removed it from all VMs too (and now the mouse > is even more laggy than before when I work on the VMs :-( But that > does not impact the tests). > > So there is still a lot of work to do on the WineTestBot, and that's > not even counting fixing all the failing tests. Yes, there are still ways for the new testbot improvements. When time from time I send patches for testing I send them to both old and new testbots. While old tesbot completes the job in minutes (usually 3-5), the new one almost always completes the request several hours later. Looking at the job status it shows that the build is complete and VMs are online and ready but nothing happens further on. -- Dmitry.

Oct. 28, 2013

Re: WineTestBot status update

by Jeremy White

And I meant to ask, but did not: does it make sense to throw hardware at some of the issues? We've got additional systems we could easily rig as slaves... Cheers, Jeremy

Oct. 28, 2013

Re: WineTestBot status update

by Jeremy White

This is great, thanks! > msi:action and msi:install went from an average of 99 and 90 seconds > down to 48 and 39 seconds and they are not timing out anymore. The > remaining troublesome tests are now ddraw:ddraw{2,4,7}, shell32:shlexec, > and winspool.drv:info. > Just summarizing: we have a hoped for fix for the XP revert time issue; if that holds, then we have those troublesome tests, and fixing failures to go. Is that about the size of it? Cheers, Jeremy

Oct. 28, 2013

Re: [01/02] d3d9: update locked_rect only if wined3d_surface_map succeeds

by Lasse Rasinen

Marvin <testbot(a)winehq.org> writes: > Full results can be found at > https://newtestbot.winehq.org/JobDetails.pl?Key=2909 > [...] > === w864 (32 bit device) === > device: unhandled exception c0000005 at 740D14C8 > > === w864 (64 bit device) === > device: unhandled exception c0000005 at 000007F84EDD90EB I've had a look at the logs and as far as I can tell, the failing test is not exercising the change I made. If anyone can shed some light on this, I'd be happy to resubmit the patch with the improved test failure reporting. (Although my personal drive for this patch has gone down as the new OS X has a new compiler that doesn't break it on unpatched master) -- Lasse Rasinen lrasinen(a)iki.fi

Oct. 27, 2013

WineTestBot status update

by Francois Gouget

We switched to the new WineTestBot near the start of September. Early on it ran into a problem when it was flooded with tests due to the __WINESRC__ tests work and it failed to keep up. The reason is that as time went on the time it takes to get the VMs back to a clean state ready to run the tests (the revert time) kept increasing as can be seen on this graph: http://fgouget.free.fr/wtb/vm1-revtimes.png There one can see the increased activity in september that what was caused by the surge in test patches. But the most remarkable feature is the Windows XP revert times which increase linearly, reaching over 30 minutes. The revert times for the other VMs are much more random but still seem to increase somewhat (1). The reason for the increase is still unknown. The revert time fell down a few times and now I suspect this corresponds to times when the VM was restored from backup. So at the start of October I upgraded to QEMU 1.6.0 and restored all the VMs from backup, hoping this would solve the problem. The revert times did get much better and the WineTestBot now manages to keep up: http://fgouget.free.fr/wtb/vm1-revtimes-new.png The upgrade happened around the 2nd of october and the revert times fell at that point. But looking at more recent data it's clear that the Windows XP revert times are increasing again, while those of the other VMs remain stable (see vm1-revtimes.xls for the raw data). That XP VM is one of the first ones I created, so it probably was created with a pretty old QEMU version. Futhermore it was only an out of the box SP2 and did not have any of the later updates. So I decided to recreate it from scratch, using QEMU 1.6.0, and to add all the other updates as I was at it. And I'm hoping that this time things will be better. That's why this VM is currently in 'maintenance' mode. I also took down the 32-bit Windows 8 VM for maintenance. It too is missing proper updates and the plan is to upgrade it to Windows 8.1. Another issue has been that the tests are running a bit slow, a particular point of pain was msi:action and msi:install which were regularly timing out. See: http://fgouget.free.fr/wtb/runtimes.htm So while rebuilding the Windows XP VM I did some performance tests. That paid off. I found that switching the emulated disk cache mode from writeback to default roughly halves the msi run times: http://fgouget.free.fr/wtb/runtimes2.htm msi:action and msi:install went from an average of 99 and 90 seconds down to 48 and 39 seconds and they are not timing out anymore. The remaining troublesome tests are now ddraw:ddraw{2,4,7}, shell32:shlexec, and winspool.drv:info. I also uncovered two other potential performance issues: * Some VMs have Windows Defender and apparently it was starting a full disk scan as soon as the VM was ready to run the tests. That's clearly not good so I disabled Windows Defender in all VMs. * Most VMs were still using 20% of the CPU when idle. That's fine if only one VM is running but could impact performance (through increased interrupt rates) if many are running at once (like on the WineTestBot). Apparently the culprit is the USB Tablet device that's added by default. So I removed it from all VMs too (and now the mouse is even more laggy than before when I work on the VMs :-( But that does not impact the tests). So there is still a lot of work to do on the WineTestBot, and that's not even counting fixing all the failing tests. (1) It's almost as if the increasing Windows XP revert times were pulling up the other VM revert times. Yet there's only one revert at a given time, so I don't see how this would be possible. (2) Setting the cache mode to writeback was improving the performance quite a bit with the pre-upgrade QEMU version. But obviously it's not true anymore. Another interesting point is that the Virtio mode improves performance by a factor of 10 (down from 450 seconds to 45 in msi:action). Yet Windows 8 posts the fastest times yet in the basic IDE mode (~23 seconds). I couldn't get Windows 8 working with the Virtio disk yet and I have not verified that it's really doing the same set of tests. So that remains to be confirmed. Here is some performance data taken from the Windows XP VM while the TestBot was idle. From it cache=default looks like it's a completely separate mode! msi:action | msi:install | msi:msi 448 460 520| 487 439 | 238 229 VGA, qcow2 ide disk, cache:default 44 45 42 | 47 49 46 | 24 23 21 VGA, qcow2 virtio disk, cache:default 48 45 50 | 47 48 48 | 23 23 24 VMVGA/VGA, qcow2 virtio disk, cache:default 47 46 | 48 46 | 23 22 22 VMVGA, qcow2 virtio disk, cache:default 47 47 | 49 48 | 24 23 VMVGA, raw virtio disk, cache:default 62 67 67 | 64 60 63 | 29 27 27 VMVGA, raw virtio disk, cache:none 111 92 72 113 | 101 101 | 37 37 40 VMVGA, raw virtio disk, cache:writethrough 61 64 53 | 70 59 58 | 36 28 29 VMVGA, raw virtio disk, cache:writeback 46 44 | | VMVGA, raw virtio disk, cache:default 71 55 68 | | VMVGA, raw virtio disk, cache:writeback 65 71 72 69| | VMVGA, raw virtio disk, cache:none 76 118 111 | | VMVGA, raw virtio disk, cache:writethrough 50 48 47 | | VMVGA, raw virtio disk, cache:default And the preliminary Windows 8 performance. I hope it holds up. msi:action | msi:install | msi:msi 23 22 22 | 16 15 16 | 13 13 15 VGA, qcow2 ide disk, cache:default -- Francois Gouget <fgouget(a)codeweavers.com>

Oct. 27, 2013

Re: winspool.drv/tests: Fix the OpenPrinter() tests error reporting.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3070 Your paranoid android. === w864 (32 bit info) === info.c:2923: Test failed: AddJobA() failed le=50 info.c:2929: Test failed: GetJobA() failed le=87 info: unhandled exception c0000005 at 0040B24A === w864 (64 bit info) === info.c:2923: Test failed: AddJobA() failed le=50 info.c:2929: Test failed: GetJobA() failed le=87 info.c:2972: Test failed: AddJobA() failed le=50 info.c:2978: Test failed: GetJobA() failed le=87 info: unhandled exception c0000005 at 00000000004099E0

Oct. 27, 2013

Re: Raise the minimum version of FreeBSD to 8.0.

by Gerald Pfeifer

On Mon, 4 Mar 2013, Frédéric Delanoy wrote: >> We've had this as a requirement in the FreeBSD ports for quite a >> while (and the Wiki describes some background). > You should also change the version in the various README.xx > translations (in 'documentation' directory). Done thusly. New patch below. (Had some fun with Japanese on my lowly remote test machine and hope that for more substanial changes I don't have to provide translations for all? ;-) Gerald diff --git a/README b/README index 8dbc614..1627081 100644 --- a/README +++ b/README @@ -29,7 +29,7 @@ especially the wealth of information found at http://www.winehq.org. To compile and run Wine, you must have one of the following: Linux version 2.0.36 or later - FreeBSD 7.0 or later + FreeBSD 8.0 or later Solaris x86 9 or later NetBSD-current Mac OS X 10.5 or later @@ -39,7 +39,7 @@ systems mentioned above are supported. Other operating systems which support kernel threads may be supported in the future. FreeBSD info: - Wine will generally not work properly on versions before FreeBSD 7.0. + Wine will generally not work properly on versions before FreeBSD 8.0. See http://wiki.freebsd.org/Wine for more information. Solaris info: diff --git a/documentation/README.de b/documentation/README.de index f42b30d..ff1ee9c 100644 --- a/documentation/README.de +++ b/documentation/README.de @@ -32,7 +32,7 @@ Um Wine kompilieren und ausführen zu können, brauchen Sie eines der folgenden Betriebssysteme: Linux version 2.0.36 oder neuer - FreeBSD 7.0 oder neuer + FreeBSD 8.0 oder neuer Solaris x86 9 oder neuer NetBSD-current Mac OS X 10.5 oder neuer @@ -43,7 +43,7 @@ Andere Betriebssysteme, die Kernel-Threads unterstützen, werden unter Umständen in der Zukunft unterstützt. FreeBSD-Info: - Wine läuft prinzipiell erst ab FreeBSD 7.0 richtig. Siehe dazu auch + Wine läuft prinzipiell erst ab FreeBSD 8.0 richtig. Siehe dazu auch http://wiki.freebsd.org/Wine für weitere Informationen. Solaris-Info: diff --git a/documentation/README.es b/documentation/README.es index 9497855..c0a318d 100644 --- a/documentation/README.es +++ b/documentation/README.es @@ -30,7 +30,7 @@ http://www.winehq.org. Para compilar y ejecutar Wine, deberá tener uno de los siguientes: Linux versión 2.0.36 o superior - FreeBSD 7.0 o superior + FreeBSD 8.0 o superior Solaris x86 9 o superior NetBSD-current Mac OS X 10.5 o superior @@ -42,7 +42,7 @@ podrían obtener soporte en el futuro. Información sobre FreeBSD: Por lo general Wine no funcionará correctamente en versiones anteriores a - FreeBSD 7.0. Visite http://wiki.freebsd.org/Wine para más información. + FreeBSD 8.0. Visite http://wiki.freebsd.org/Wine para más información. Información sobre Solaris: Lo más probable es que necesite compilar con el conjunto de herramientas GNU diff --git a/documentation/README.fi b/documentation/README.fi index 15b8302..5e03199 100644 --- a/documentation/README.fi +++ b/documentation/README.fi @@ -28,7 +28,7 @@ ennen kaikkea Internetissä osoitteessa http://www.winehq.org/. Winen kääntämiseen tarvitaan jokin seuraavista: Linuxin versio 2.0.36 tai uudempi - FreeBSD 7.0 tai uudempi + FreeBSD 8.0 tai uudempi Solaris x86 9 tai uudempi NetBSD-current Mac OS X 10.5 tai uudempi @@ -38,7 +38,7 @@ mainittuja käyttöjärjestelmiä tuetaan; tulevaisuudessa saatetaan lisätä tu muillekin käyttöjärjestelmille, joissa on tarvittava tuki säikeille. Tietoa FreeBSD:lle: - Pääsääntöisesti Wine ei toimi vanhemmilla versioilla kuin FreeBSD 7.0. + Pääsääntöisesti Wine ei toimi vanhemmilla versioilla kuin FreeBSD 8.0. Osoitteessa http://wiki.freebsd.org/Wine kerrotaan tästä lisää. Tietoa Solarikselle: diff --git a/documentation/README.fr b/documentation/README.fr index 0d0c2ef..3c8ac4e 100644 --- a/documentation/README.fr +++ b/documentation/README.fr @@ -30,7 +30,7 @@ Pour compiler et exécuter Wine, vous devez disposer d'un des systèmes d'exploitation suivants : Linux version 2.0.36 ou ultérieur - FreeBSD 7.0 ou ultérieur + FreeBSD 8.0 ou ultérieur Solaris x86 9 ou ultérieur NetBSD-current Mac OS X 10.5 ou ultérieur diff --git a/documentation/README.it b/documentation/README.it index ad6b692..46ccf7c 100644 --- a/documentation/README.it +++ b/documentation/README.it @@ -31,7 +31,7 @@ si trova all'indirizzo http://www.winehq.org. Per compilare ed eseguire Wine, è necessario avere uno dei seguenti sistemi: Linux versione 2.0.36 o successiva - FreeBSD 7.0 o successiva + FreeBSD 8.0 o successiva Solaris x86 9 o successiva NetBSD-current Mac OS X 10.5 o successiva @@ -42,7 +42,7 @@ che forniscono kernel threads potrebbero essere supportati in futuro. Informazioni per FreeBSD: In generale Wine non funzionerà correttamente con versioni precedenti - a FreeBSD 7.0. + a FreeBSD 8.0. Leggere http://wiki.freebsd.org/Wine per maggiori informazioni. Informazioni per Solaris: diff --git a/documentation/README.ja b/documentation/README.ja index bd9d48a..f44d371 100644 --- a/documentation/README.ja +++ b/documentation/README.ja @@ -30,7 +30,7 @@ READMEというファイル]を含む）Wineソースのトップレベルディ Wineをコンパイルし実行するには、以下のうち一つを持っていなければなりません: Linux バージョン2.0.36以上 - FreeBSD 7.0以降 + FreeBSD 8.0以降 Solaris x86 9以降 NetBSD-current Mac OS X 10.5以降 @@ -41,7 +41,7 @@ Wineをコンパイルし実行するには、以下のうち一つを持って将来サポートされるかもしれません。 FreeBSD情報: - Wineは一般的にFreeBSD 7.0より前のバージョン上で正しく動作しないでしょう。 + Wineは一般的にFreeBSD 8.0より前のバージョン上で正しく動作しないでしょう。詳細については http://wiki.freebsd.org/Wine を参照してください。 Solaris情報: diff --git a/documentation/README.pt_br b/documentation/README.pt_br index 296425b..3e5ec27 100644 --- a/documentation/README.pt_br +++ b/documentation/README.pt_br @@ -31,7 +31,7 @@ encontrada em http://www.winehq.org. Para compilar e executar o Wine, voc?deve ter o seguinte: Linux vers? 2.0.36 ou posterior - FreeBSD 7.0 ou posterior + FreeBSD 8.0 ou posterior Solaris x86 9 ou posterior NetBSD-atual Mac OS X 10.5 ou posterior diff --git a/documentation/README.ru b/documentation/README.ru index 70fc5db..c228fc6 100644 --- a/documentation/README.ru +++ b/documentation/README.ru @@ -29,7 +29,7 @@ Wine Installer для компоновки и установки Wine. В кат Компиляция и запуск Wine поддерживается в следующих операционных системах: Linux версии 2.0.36 или более новой - FreeBSD 7.0 или более новой + FreeBSD 8.0 или более новой Solaris x86 9 или более новой NetBSD-текущей версии Mac OS X 10.5 или более новой @@ -40,7 +40,7 @@ Wine Installer для компоновки и установки Wine. В кат возможно будут поддерживаться Wine в будущем. FreeBSD: - Wine не будет работать как следует на версиях ниже, чем FreeBSD 7.0. + Wine не будет работать как следует на версиях ниже, чем FreeBSD 8.0. Посетите <http://wiki.freebsd.org/Wine> для дополнительной информации. Solaris: diff --git a/documentation/README.sv b/documentation/README.sv index d5fe643..d51a54a 100644 --- a/documentation/README.sv +++ b/documentation/README.sv @@ -27,7 +27,7 @@ information och tips om hur problem kan l F? att kompilera och k?a Wine kr?s ett av f?jande: Linux version 2.0.36 eller senare - FreeBSD 7.0 eller senare + FreeBSD 8.0 eller senare Solaris x86 9 eller senare NetBSD-current Mac OS X 10.5 eller senare

Oct. 27, 2013