November 2013 - Wine-Devel - list.winehq.org

Re: include: Add interfaces ICLRMetaHostPolicy,ICLRDebugging

by Chris Wulff

On Oct 1, 2013, at 10:51 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > include: Add interfaces ICLRMetaHostPolicy,ICLRDebugging > > > Best Regards > Alistair Leslie-Hughes > <0002-Add-interfaces-ICLRMetaHostPolicy-ICLRDebugging.patch> >

Nov. 1, 2013

Re: mscoree: Implement CreateInterface (try 2)

by Chris Wulff

On Oct 1, 2013, at 10:48 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Reuse CLRCreateInterface for the time being. > > Changelog: > mscoree: Implement CreateInterface > > > Best Regards > Alistair Leslie-Hughes > <0001-Implement-CreateInterface.patch> >

Nov. 1, 2013

Re: mscoree: Implement CreateInterface (try 2)

by Chris Wulff

On Oct 1, 2013, at 10:48 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Reuse CLRCreateInterface for the time being. > > Changelog: > mscoree: Implement CreateInterface > > > Best Regards > Alistair Leslie-Hughes > <0001-Implement-CreateInterface.patch> >

Nov. 1, 2013

Re: winhttp/tests: Fix the test failure messages.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3165 Your paranoid android. === w8 (32 bit url) === url.c:465: Test failed: unexpected path: L"?" url.c:467: Test failed: unexpected extra info: L"?" url.c:468: Test failed: unexpected extra info length: 1

Nov. 1, 2013

Re: kernel32/tests: Remove a couple of incorrect CreateFile() console tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3163 Your paranoid android. === w8 (32 bit console) === console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 18, got 00000144 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 20, got 00000154 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 21, got 00000150 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 22, got 0000014C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 23, got 00000158 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 24, got 0000015C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 25, got 00000160 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 26, got 00000164 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 28, got 00000168 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 29, got 0000016C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 30, got 00000170 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 31, got 00000174 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 32, got 00000178 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 33, got 0000017C console.c:1420: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1420: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1420: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1663: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1663: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1663: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 18, got 00000138 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 20, got 0000013C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 21, got 0000014C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 22, got 00000148 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 23, got 00000144 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 24, got 00000150 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 25, got 00000154 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 26, got 00000158 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 28, got 0000015C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 29, got 00000160 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 30, got 00000164 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 31, got 00000168 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 32, got 0000016C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 33, got 00000170 console.c:1420: Test failed: [13] Expected output count to be 0, got 2003875511 console.c:1420: Test failed: [15] Expected output count to be 0, got 2003875511 console.c:1420: Test failed: [18] Expected output count to be 3735928559, got 2003875511 console.c:1663: Test failed: [13] Expected output count to be 0, got 2003875511 console.c:1663: Test failed: [15] Expected output count to be 0, got 2003875511 console.c:1663: Test failed: [18] Expected output count to be 3735928559, got 2003875511 === w864 (64 bit console) === console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 18, got 0000000000000054 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 20, got 0000000000000058 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 23, got 0000000000000060

Nov. 1, 2013

Re: winhttp: netconn_query_data_available() is not used anymore so remove it.

by Jacek Caban

Hi Francois, On 11/01/13 10:34, Francois Gouget wrote: > --- > dlls/winhttp/net.c | 20 -------------------- > dlls/winhttp/winhttp_private.h | 1 - > 2 files changed, 21 deletions(-) > > diff --git a/dlls/winhttp/net.c b/dlls/winhttp/net.c > index 6d9b82a..ac8ae56 100644 > --- a/dlls/winhttp/net.c > +++ b/dlls/winhttp/net.c > @@ -712,26 +712,6 @@ BOOL netconn_recv( netconn_t *conn, void *buf, size_t len, int flags, int *recvd > return TRUE; > } > > -BOOL netconn_query_data_available( netconn_t *conn, DWORD *available ) > -{ > -#ifdef FIONREAD > - int ret; > - ULONG unread; > -#endif > - *available = 0; > - if (!netconn_connected( conn )) return FALSE; > - > - if (conn->secure) > - { > - *available = conn->peek_len; > - return TRUE; > - } > -#ifdef FIONREAD > - if (!(ret = ioctlsocket( conn->socket, FIONREAD, &unread ))) *available = unread; > -#endif > - return TRUE; > -} > - I think we should use this function instead. I will send a patch. Jacek

Nov. 1, 2013

Re: shell32/tests: Disable a test that crashes on Windows 8.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3162 Your paranoid android. === w8 (32 bit shlfolder) === shlfolder.c:792: Test failed: Filename should be stored as wchar-string at this position! shlfolder.c:1867: Test failed: The filename should be stored in unicode at this position! shlfolder.c:1867: Test failed: The filename should be stored in unicode at this position! shlfolder.c:1867: Test failed: The filename should be stored in unicode at this position! shlfolder.c:3970: Test failed: Not equal (or near equal), got 102 and 104 shlfolder.c:3656: Test failed: Got 0x00000000 === w864 (32 bit shlfolder) === shlfolder.c:3656: Test failed: Got 0x00000000 === w864 (64 bit shlfolder) === shlfolder.c:3656: Test failed: Got 0x00000000

Nov. 1, 2013

Re: msvcr: Added _crt_debugger_hook function

by Piotr Caban

On 11/01/13 00:41, Andrey Zhezherun wrote: > +/********************************************************************* > + * _crt_debugger_hook (MSVCRT.@) > + */ > +void CDECL MSVCRT__crt_debugger_hook(int reserved) > +{ > + TRACE(""); > +} The trace needs to end with '\n' character. Probably it's better to use ERR or FIXME here. Why do you need this function? In all cases I've seen the function was called only when the application was working incorrectly. Cheers, Piotr

Nov. 1, 2013

Re: Assorted spelling fixes.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3159 Your paranoid android. === w8 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00404347 === w864 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00404347 === w864 (64 bit filtergraph) === filtergraph: unhandled exception c0000005 at 0000000000403DF2

Nov. 1, 2013

Re: msvcr: Implemented _chsize_s

by Piotr Caban

On 11/01/13 00:40, Andrey Zhezherun wrote: > --- wine-1.7.5.orig/include/msvcrt/io.h 2013-10-25 18:45:30.000000000 +0100 > +++ wine-1.7.5/include/msvcrt/io.h 2013-10-30 11:34:59.000000000 +0000 > @@ -87,6 +87,7 @@ > int __cdecl _access(const char*,int); > int __cdecl _chmod(const char*,int); > int __cdecl _chsize(int,__msvcrt_ulong); > +__int64 __cdecl _chsize_s(int,__int64); > int __cdecl _close(int); > int __cdecl _commit(int); > int __cdecl _creat(const char*,int); There should be int (or errno_t) instead of __int64.

Nov. 1, 2013