November 2013 - Wine-Devel - list.winehq.org

Re: user32/tests: When EnumDisplaySettings() fails unexpectedly, trace how many calls were made.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3158 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2792: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2794: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784 sysparams.c:2490: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2503: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (32 bit sysparams) === sysparams.c:2792: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2794: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784 sysparams.c:2490: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2503: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (64 bit sysparams) === sysparams.c:2792: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2794: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784

Nov. 1, 2013

Re: kernel32/tests: Windows 8 returns different error codes.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3157 Your paranoid android. === w8 (32 bit console) === console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 18, got 00000144 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 18, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 20, got 00000154 console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 20, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 21, got 00000150 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 21, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 22, got 0000014C console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 22, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 23, got 00000158 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 23, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 24, got 0000015C console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 24, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 25, got 00000160 console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 25, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 26, got 00000164 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 26, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 28, got 00000168 console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 28, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 29, got 0000016C console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 29, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 30, got 00000170 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 30, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 31, got 00000174 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 31, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 32, got 00000178 console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 32, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 33, got 0000017C console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 33, got 0 console.c:1423: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1423: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1423: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1666: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1666: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1666: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 18, got 00000138 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 18, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 20, got 0000013C console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 20, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 21, got 0000014C console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 21, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 22, got 00000148 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 22, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 23, got 00000144 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 23, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 24, got 00000150 console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 24, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 25, got 00000154 console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 25, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 26, got 00000158 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 26, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 28, got 0000015C console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 28, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 29, got 00000160 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 29, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 30, got 00000164 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 30, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 31, got 00000168 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 31, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 32, got 0000016C console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 32, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 33, got 00000170 console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 33, got 0 console.c:1423: Test failed: [13] Expected output count to be 0, got 2003875511 console.c:1423: Test failed: [15] Expected output count to be 0, got 2003875511 console.c:1423: Test failed: [18] Expected output count to be 3735928559, got 2003875511 console.c:1666: Test failed: [13] Expected output count to be 0, got 2003875511 console.c:1666: Test failed: [15] Expected output count to be 0, got 2003875511 console.c:1666: Test failed: [18] Expected output count to be 3735928559, got 2003875511 === w864 (64 bit console) === console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 18, got 0000000000000054 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 18, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 20, got 0000000000000058 console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 20, got 0 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 21, got 0 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 22, got 0 console.c:1115: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 23, got 0000000000000060 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 23, got 0 console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 24, got 0 console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 25, got 0 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 26, got 0 console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 28, got 0 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 29, got 0 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 30, got 0 console.c:1118: Test failed: Expected GetLastError() to return 32/0 for index 31, got 0 console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 32, got 0 console.c:1118: Test failed: Expected GetLastError() to return 87/0 for index 33, got 0

Nov. 1, 2013

Re: user32/tests: When EnumDisplaySettings() fails unexpectedly, trace how many calls were made.

by Henri Verbeet

On 1 November 2013 10:19, Francois Gouget <fgouget(a)free.fr> wrote: > --- > > This does not fix the test failures. The goal is mainly to know if > EnumDisplaySettings() fails on the firts pass, which would indicate > something is wrong, or later on which would be more like it returning a > different error code. Though the error code that gets returned > (ERROR_MOD_NOT_FOUND iirc) is quite weird in this context. > For what it's worth, I have the impression that display resolution weirdness is also causing some of the failures in the d3d9 tests on Windows 8.

Nov. 1, 2013

Re: WineTestBot status update

by Henri Verbeet

On 1 November 2013 02:16, Francois Gouget <fgouget(a)codeweavers.com> wrote: > d3d10:effect (4, yes same errors on 32/64-bit, VMs and real hardware) The effect.c:3956 failure looks like a bug that got fixed, so the existing result should probably be marked broken, and the todo_wine removed. I'm less sure about the other 3, but it's probably ok to just mark them as broken(). For what it's worth, most / all of the tests in d3d10/tests should be hardware independent, so it's expected that you get the same results everywhere as long as you use the same version of Windows.

Nov. 1, 2013

Re: [PATCH 2/6] wined3d: Add a function for allocating aligned resource memory (try 3)

by Henri Verbeet

On 31 October 2013 20:06, Mihai-Augustin Serbanescu <romanux(a)gmail.com> wrote: > Hello, > I am having trouble playing League of Legends in using Wine and I've heard > that allocating twice the amount of > memory for each resource in wined3d_resource_allocate_sysmem() would help > with that issue. > Can you please point how can I do that? You'd change the line "if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, resource->size + align)))" into "if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (resource->size * 2) + align)))" Although it may be just as easy to just add "size *= 2;" at the top of resource_init().

Nov. 1, 2013

Re: [PATCH] quartz/tests: Enable compilation with -D__WINESRC__

by Francois Gouget

On Tue, 29 Oct 2013, Nikolay Sivov wrote: > Hi. > > No, it's not new. This runs has it already > http://test.winehq.org/data/ddd6fd1ecbc4c25cf6c69202934c8bf2a3f01daf/index_… Yep. It would actually be nice to fix it since it's one of the failures that happens systematically accross the board on Windows 8 and 8.1, including on real hardware: http://test.winehq.org/data/cb0ef08839e515d7a9053923d27ef8899978a263/index_… -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Computers are like airconditioners They stop working properly if you open WINDOWS

Nov. 1, 2013

Re: msvcrt: support for _chsize_s (try #4)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3152 Your paranoid android. === build (build) === Make failed

Nov. 1, 2013

Re: [PATCH] kernel32: use ANSI code page if current thread locale is invalid

by Dmitry Timoshkov

Daniel Lehman <dlehman(a)esri.com> wrote: > case CP_THREAD_ACP: > - if (NtCurrentTeb()->CurrentLocale == GetUserDefaultLCID()) return ansi_cptable; > + if (!IsValidCodePage(NtCurrentTeb()->CurrentLocale) || > + NtCurrentTeb()->CurrentLocale == GetUserDefaultLCID()) return ansi_cptable; Please change the checks order, so that a valid locale doesn't need to go through IsValidCodePage(). Also the check needs to be fixed, locale id is not a codepage. -- Dmitry.

Nov. 1, 2013

Re: WineTestBot status update

by Francois Gouget

The WineTestBot has a new Windows XP VM. Windows Update keeps breaking which prevented me from installing all the updates I wanted so I'll do some more work on it at some point. Currently it has SP3 and Internet Explorer 7. I also redid the old Window 8 VM and upgraded it to Windows 8.1 VM which is exciting. Btw, there are a lot of failures on Windows 8 and 8.1. Most of them also happen on my laptop, i.e. on real hardware (and a Windows 8 set up by Acer, not me): http://test.winehq.org/data/cb0ef08839e515d7a9053923d27ef8899978a263/index_… That means there's a lot of work to get the tests in shape. If you know anything about one of the tests below your help would be greatly appreciated: advapi32:security (2-4) cmd.exe:batch (1) crypt32:encode (3-6) crypt32:sip (1) d3d10:effect (4, yes same errors on 32/64-bit, VMs and real hardware) kernel32:console (80) kernel32:heap (20) kernel32:locale (65) kernel32:module (8) kernel32:virtual (2) mmdevapi:render (1 error in common) msctf:inputprocessor (1 error in common) mshtml:activex (4) ntdll:path (2) ntdll:pipe (8) ole32:marshall (36-39) quartz:filtergraph (crash) rpcrt4:cstub (crash) shell32:ebrowser (3-4) shell32:shellpath (3-14) shell32:shlexec (13) shlwapi:assoc (1) shlwapi:ordinal (25) urlmon:misc (2) urlmon:protocol (46-71) urlmon:sec_mgr (17-20) urlmon:uri (3) urlmon:url (94) user32:cursoricon (55) user32:edit (4) user32:msg (9-11) user32:sysparams (6-7) user32:win (11) wininet:urlcache (17) winmm:midi (32) wintrust:crypt (2) wintrust:softpub (crash) -- Francois Gouget <fgouget(a)codeweavers.com>

Nov. 1, 2013