December 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 1/6] qcap: Added IPersistPropertyBag::Load implementation.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3892 Your paranoid android. === build (build) === Patch failed to apply

Dec. 30, 2013

Status of WineD3D on Windows

by Peter Lehmkuhle

Hi all, I'm not sure if this is the right list for this question, but I guess I'll find out soon. :) On http://wiki.winehq.org/WineD3DOnWindows it is written that "DirectDraw [..] can't be used at this point due to a conflict with opengl32.dll." I guess that's the current status, because the ddraw.dll is not included in the last build. Are there any plans to change this in the near future? TIA for an answer. Best regards, Peter

Dec. 30, 2013

Re: msrle32: Added tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3886 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

Dec. 30, 2013

Re: Win32_PnPEntity WMI class

by Luke A. Guest

Hi, I just added this code to hardcode in the USB cable, but it fails getting the value for the DeviceID field. I can't see any calls to the registry and t should just get the static data from the table, but it's failing. Anyone know what I've done wrong? Thanks, Luke.

Dec. 29, 2013

Help about implementing WSACleanup (ws2_32)

by Bruno Jesus

Hi, in an attempt to fix bugs 18670 and 26031 I would like to try implementing WSACleanup more properly. My limited knowledge in the interactions between the ws2_32 dll and wine server makes me think this is easy. The idea is to add the created socket in WSASocketW in a list and remove it from the list when closesocket is called. When the last WSACleanup is called it would iterate through the socket list and destroy the remaining sockets. When WSASocketW is called it calls the server to create the socket, when closesocket is called the server is also called and the function sock_destroy takes care of shutting down the socket. Currently I'm thinking about doing this in the dll side because the server is not aware of WSACleanup, but maybe it should because it needs to avoid calling any async operation completion. My questions are: 1) When I open 2 programs that use ws2_32 dll the global variables memory is not shared, right? Otherwise the WSAStartup/Cleanup count could be messed up if one application didn't call the Cleanup function. I hope this true so the socket list would not have to take care of different processes id. I understand that one application can have multiple threads and that's what the struct per_thread_data is about, but I hope the dll is not shared among different processes. 2) Is this a reasonable approach? If yes, is there any example of a critical protected list (add, iterate, remove items) that I could use? Best wishes, Bruno

Dec. 29, 2013

Re: [PATCH 2/2] dmusic/tests: Add some COM tests for IDirectMusic/IDirectMusicCollection

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3877 Your paranoid android. === w2008s64 (32 bit dmusic) === dmusic.c:244: Test failed: DirectMusic8 create failed: 80040154, expected CLASS_E_NOAGGREGATION dmusic.c:251: Test failed: DirectMusic8 create failed: 80040154, expected E_NOINTERFACE dmusic.c:256: Test failed: DirectMusic8 create failed: 80040154, expected S_OK dmusic: unhandled exception c0000005 at 00401FDE === w2008s64 (64 bit dmusic) === dmusic.c:244: Test failed: DirectMusic8 create failed: 80040154, expected CLASS_E_NOAGGREGATION dmusic.c:251: Test failed: DirectMusic8 create failed: 80040154, expected E_NOINTERFACE dmusic.c:256: Test failed: DirectMusic8 create failed: 80040154, expected S_OK dmusic: unhandled exception c0000005 at 0000000000401EC2

Dec. 28, 2013

Re: qedit/tests: Constify some character strings

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3869 Your paranoid android. === w2008s64 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 0040185A === w2008s64 (64 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00000000004017C3

Dec. 28, 2013

Re: wtsapi32: partial implementation of WTSEnumerateProcessesW (resend)

by Stefan Leichter

Thursday 19 December 2013 André Hentschel <nerv(a)dawncrow.de> > > diff --git a/dlls/wtsapi32/wtsapi32.c b/dlls/wtsapi32/wtsapi32.c > > index 898b95d..53c6325 100644 > > --- a/dlls/wtsapi32/wtsapi32.c > > +++ b/dlls/wtsapi32/wtsapi32.c > > @@ -18,9 +18,13 @@ > > > > #include "config.h" > > #include <stdarg.h> > > #include <stdlib.h> > > > > -#include "windef.h" > > -#include "winbase.h" > > +#include "ntstatus.h" > > +#define WIN32_NO_STATUS > > +#include "winternl.h" > > > > #include "wtsapi32.h" > > > > +#include "wine/library.h" > > +#include "wine/server.h" > > +#include "wine/unicode.h" > > > > #include "wine/debug.h" > > do you need that all? You are right, this can be done better > > > WINE_DEFAULT_DEBUG_CHANNEL(wtsapi); > > > > @@ -84,14 +88,65 @@ BOOL WINAPI WTSEnumerateProcessesA(HANDLE hServer, > > DWORD Reserved, DWORD Version > > > > BOOL WINAPI WTSEnumerateProcessesW(HANDLE hServer, DWORD Reserved, DWORD > > Version, > > > > PWTS_PROCESS_INFOW* ppProcessInfo, DWORD* pCount) > > > > { > > > > - FIXME("Stub %p 0x%08x 0x%08x %p %p\n", hServer, Reserved, Version, > > - ppProcessInfo, pCount); > > + SYSTEM_PROCESS_INFORMATION *spi; > > + ULONG size = 0x4000; > > + void *buf = NULL; > > + NTSTATUS status; > > + DWORD i,lcount = 0; > > + WTS_PROCESS_INFOW *linfo; > > can't you use sizeof(*spi) or a multiple of it for size? or clean it up > somehow else... Of course sizeof(*spi) can be used. > > > if (!ppProcessInfo || !pCount) return FALSE; > > > > *pCount = 0; > > *ppProcessInfo = NULL; > > > > + if (hServer != WTS_CURRENT_SERVER_HANDLE) > > + { > > + FIXME("Only WTS_CURRENT_SERVER_HANDLE is impemented\n"); > > + return FALSE; > > + } > > + > > + do { > > + size *= 2; > > + HeapFree(GetProcessHeap(), 0, buf); > > + buf = HeapAlloc(GetProcessHeap(), 0, size); > > + if (!buf) > > + return FALSE; > > + > > + status = NtQuerySystemInformation(SystemProcessInformation, buf, > > size, NULL); + } while(status == STATUS_INFO_LENGTH_MISMATCH); > > + > > + if (status != STATUS_SUCCESS) > > + { > > + HeapFree(GetProcessHeap(), 0, buf); > > + SetLastError(RtlNtStatusToDosError(status)); > > + return FALSE; > > + } > > + > > + spi = buf; > > why not dropping buf completely? The main problem is that the value of NextEntryOffset is different from one spi to the next. Something like spi[i] can't be done. Therefore i need to keep the reference to the first SYSTEM_PROCESS_INFORMATION element. > > > + do { > > + lcount++; > > + spi = (SYSTEM_PROCESS_INFORMATION *)(((PCHAR)spi) + > > spi->NextEntryOffset); + } while(spi->NextEntryOffset != 0); > > isn't there an easier way to get the count? I don't see any > > > + linfo = HeapAlloc(GetProcessHeap(), 0, lcount * > > sizeof(WTS_PROCESS_INFOW)); + if(!linfo) > > + return FALSE; > > + > > + for(i = 0, spi = buf; i < lcount; i++) > > + { > > + linfo[i].SessionId = 0; > > + linfo[i].ProcessId = HandleToUlong(spi->UniqueProcessId); > > + linfo[i].pProcessName = spi->ProcessName.Buffer; > > + linfo[i].pUserSid = NULL; > > + spi = (SYSTEM_PROCESS_INFORMATION *)(((PCHAR)spi) + > > spi->NextEntryOffset); + } > > + *ppProcessInfo = linfo; > > + *pCount = lcount; > > + FIXME("pUserSid not filled\n"); > > + > > + HeapFree(GetProcessHeap(), 0, buf); > > > > return TRUE; > > > > } > > > > diff --git a/include/wtsapi32.h b/include/wtsapi32.h > > index f4bab56..0476478 100644 > > --- a/include/wtsapi32.h > > +++ b/include/wtsapi32.h > > @@ -135,6 +135,8 @@ typedef struct _WTS_SERVER_INFOW > > > > DECL_WINELIB_TYPE_AW(WTS_SERVER_INFO) > > DECL_WINELIB_TYPE_AW(PWTS_SERVER_INFO) > > > > +#define WTS_CURRENT_SERVER_HANDLE NULL > > + > > maybe some more WTS_ defines while you're at it I though we add the content of the header files on demand. The prototyp of WTSEnumerateProcessesW is already in the header file. What do you have in mind? > > > void WINAPI WTSCloseServer(HANDLE); > > BOOL WINAPI WTSConnectSessionA(ULONG, ULONG, PSTR, BOOL); > > BOOL WINAPI WTSConnectSessionW(ULONG, ULONG, PWSTR, BOOL);

Dec. 28, 2013

Re: Re: kernel32/tests: add test for RemoveDirectory

by Zhenbo Li

2013/12/26 刘涛 <wendaotao(a)163.com>: > I think that if you want GetLastError(), "SetLastError( 0xdeadbeef );" > should be added before every function which could SetLastError(). Thanks for mentioning that. Most wine test cases don't call SetLastError, I don't know the reason, and I just followed previous code. BTW, in patch f39c64a85ce3617bd1008f I've added `SetLastError(0xdeadbeef)`, but it was removed by Alexandre Julliard -- Have a nice day! Zhenbo Li

Dec. 28, 2013

Re: Bruno Jesus : ws2_32: Do not convert EAI_xxx return in case of success.

by Bruno Jesus

On Fri, Dec 27, 2013 at 5:31 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Module: wine > Branch: master > Commit: fc5884c23296c0f121442d0832b0187074e95a10 > ... > @@ -5365,6 +5365,8 @@ static int convert_aiflag_u2w(int unixflags) { > static int convert_eai_u2w(int unixret) { > int i; > > + if (!unixret) return 0; > + > for (i=0;ws_eai_map[i][0];i++) > if (ws_eai_map[i][1] == unixret) > return ws_eai_map[i][0]; Hi, Alexandre. I just would like to say that my patch was based on the other use case of the convert_eai_u2w function, that is just call the function to convert EAI results. Zero is not an EAI result (there is no EAI_SUCCESS or something like that) so in my patch I just avoided calling the conversion function. I'm talking about this use case: http://source.winehq.org/source/dlls/ws2_32/socket.c#L5488 In summary, I think my original patch [1] could get a new reviewing. [1] - http://source.winehq.org/patches/data/101198 Best wishes, Bruno

Dec. 27, 2013