April 2013 - Wine-Devel - list.winehq.org

Re: kernel32/path: Potential off-by-one error, help needed!

by Ken Thomases

On Apr 22, 2013, at 1:17 PM, Kirill Smirnov wrote: > While debugging bug #33307 (http://bugs.winehq.org/show_bug.cgi?id=33307) I found a suspicious piece of code, looking like off-by-one error. > > Unfortunately, I'm not familiar with this part of wine and I don't know how to write corresponding test case. > > If you familiar with this module, please, take a look at this wanna-be-a-bug and the proposed patch. I'm not familiar with the module, but on reviewing your patch and the local code it does appear that you have found a bug. Your fix seems reasonable, although I think I'd change the memcpy() to use dest_name.Length + sizeof(WCHAR) as the length. That way you don't have to duplicate the memcpy with two different lengths. I don't think you have to worry about a test case. This isn't a question about observable behavior of some Win32 API, it's just making Wine not write past the end of a buffer. Cheers, Ken

April 23, 2013

Re: user32: add assembly wrapper for calling hook procedures.

by Dan Kegel

Thanks. I saw the 'doesn't apply' status at source.winehq.org/patches, so was going to take another look tonight. On Mon, Apr 22, 2013 at 4:40 PM, James Eder <jimportal(a)gmail.com> wrote: > Dan, the patch doesn't build for 64-bit Wine. On the #else side you have > an unwanted semicolon. > > -- > Jim

April 23, 2013

Re: user32: add assembly wrapper for calling hook procedures.

by James Eder

Dan, the patch doesn't build for 64-bit Wine. On the #else side you have an unwanted semicolon. -- Jim

April 22, 2013

Re: Wine History

by Scott Ritchie

On 04/20/2013 05:50 PM, André Hentschel wrote: > Hi, > meanwhile everyone should know that Wine turns 20 this year. AJ said in this years Keynote we'll need to find a way to celebrate this in June. > So i did some research on this and found "Wine History" mails by Dan Kegel from 2002 and much earlier Bob Amstadt talking about late May or early June 1993. > The date listed on Wikipedia is July the 4th, but i was still curious about that late May. > I think i finally found this late May (30th) discussion and want to share it: > https://groups.google.com/d/msg/comp.os.linux/7TFhxP6IUVQ/gVHAeP_ZBVUJ > > It's of course hard to tell when a project was really born, but as far as i understand, this discussion inspired Bob to write an initial loader. > I was just 5 at this time, so maybe someone can tell some more about it? :) > > Reading that thread, it seems that WABI was an important "Wine before Wine" -- albeit proprietary and made for SunOS (and bundling a CPU emulator!) Perhaps we should mention it in our history page.

April 22, 2013

Re: Application for GSoC 2013 - improve Richedit

by André Hentschel

Am 22.04.2013 12:51, schrieb Jactry Zeng: > Hi folks, > > I am Jactry Zeng, a sophomore majoring in Electronic Science from China. > My nickname in #winehackers is Jactry. > > I would like to apply for this year's GSoC to work for wine. I have reported some bugs[1] of wine > and submitted a few easy patches[2] for wine. And I feel quite good to study in wine community. > > I am so interested in Richedit module[3]. Because a lot of software I tested was blocked by bugs of > Richedit, such as wordpad, GTalk, QQ, Weibo Desktop and AliWangwang etc. I would like to work for > this module during GSoC. I've reported a few bugs regarding Richedit[4]. And for bug 33191[5], I > have written a simple testcase to reproduce this bug. > > And I found ITextDocument is just a stub now, I want to implement some function of it, such as > ITextDocument::New, ITextDocument::Open, ITextDocument::Save, ITextDocument::Range, ITextDocument > ::GetName and ITextDocument::GetDefaultTabStop etc. > These functions are documented in MSDN[6], what's better, thanks to kind people on codeproject[7], > there are some sample applications for study, which will give me a lot of help on re-implementing > ITextDocument. Hi Jactry, thanks for the interest in Wine. I'm not that much familiar with Richedit, but as i understand you have your own idea and it's not related to "Richedit - implement Windowless mode" from the ideas page. That's fine, i'm just curious. Your idea sounds good and shows that you made your homework. In case it's mostly implementing ITextDocument you should consider naming it something like "Implement/Improve ITextDocument in Richedit". Today the Student application period opens, so be free to send in your proposal.

April 22, 2013

kernel32/path: Potential off-by-one error, help needed!

by Kirill Smirnov

Hi! While debugging bug #33307 (http://bugs.winehq.org/show_bug.cgi?id=33307) I found a suspicious piece of code, looking like off-by-one error. Unfortunately, I'm not familiar with this part of wine and I don't know how to write corresponding test case. If you familiar with this module, please, take a look at this wanna-be-a-bug and the proposed patch. -- Kirill

April 22, 2013

Re: [user32] Add DECLSPEC_NOINLINE, use it on call_hook_proc()

by Qian Hong

On Sat, Apr 20, 2013 at 1:38 AM, Dan Kegel <dank(a)kegel.com> wrote: >> I tried explicitly add 'inline' to every static functions in hook.c >> but complie with -O0, to see if the bug can be reproduced in this way, >> but nothing happen, this make me doubt being inline is not the >> culprit. > > call_hook_proc is probably the only function whose inlining matters > for this problem (since my patch solved your problem at -O2). > > (inline is only a hint. FORCEINLINE is stronger.) Thanks Dan and André, I tried FORCEINLINE and tried bisect on gcc flags to reproduce the bug but failed with strange gcc behaviors, then Dan had worked out an actual fix for this bug, what I learned is, understanding the real bug seems faster than playing with gcc flags... Anyway, thanks Dan and André as always! -- Regards, Qian Hong - http://www.winehq.org

April 22, 2013

Re: [PATCH 1/2] wined3d: Remove leftover texture accesses in GLSL shader generation

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-04-22 14:54, schrieb Henri Verbeet: > On 22 April 2013 14:48, Stefan Dösinger <stefan(a)codeweavers.com> > wrote: >> Personally I don't like ifs without braces if either the >> condition or the instruction is spread over more than one line. >> > Well, I do disagree, but note that that reasoning doesn't actually > apply here, both are single-line. Oh right, I changed that from a first version of the patch before sending. /me bangs head against wall and will resend. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRdTPPAAoJEN0/YqbEcdMw/5kP/2N5YFuzEKsjVLR29ArqBEha qsYuQUOLq6OhguUK/cksTidnVIMQ9V99aFVTz1RXdgAfWqVhIZ9UhE8M1cSKTq2m +VJEtCmDzsuocUg7ZWNq+WOPivE65D/HpS+j1g6B3VTfeRXUAWNAICHz3B7jB1lO wmFLXOuWPha2G6n89o+nN3lFBhNSU3ViFMxwjPWXKqrrAxRKGRIKR6aHyKqajpsP dIeppHO6UXcj9Pxb44GpXdlwgKYa17eIM95i7pzTV0m4mmyMRGGr4L4HCVcZhXuk PUULZE5lKJM6Ada8g3xTtsfOc+SazSWyhZpFgczqBAGQy4y4gn24xcMREz0xtEwI v27xFuKFXP2XHi6sSbAkTg1FF+S+hL+S2Kn5J7SAHa2jPD8YHf1zZlevCvHW6Gpi S2ivTys+wNnHEOjfv+dnR7fOBHkCJhMs6f6loGvaeGKx5i5q/HsopcrxeZJXfIuc oFRZJgw6HbzPWltb3jvA6XTmDQFUH49QvqY3DoZRO+Q5aTw29Zt6MC1hhEVdZMWf it2RVlKfdd+t9Ou9hDkzI4Qn0hxx7cwsbQXignghwQfeiMKjrZQDhn2GPqKv1wEM Krl/ZHoagBnodiFr7HGdhewrHntGxTEphR5ygZc/mgJtV7A6wqDPmzbPCX6OJxkK SJDm3wSw3f+t11u6AyXC =M+Ry -----END PGP SIGNATURE-----

April 22, 2013

Re: [PATCH 1/2] wined3d: Remove leftover texture accesses in GLSL shader generation

by Henri Verbeet

On 22 April 2013 14:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Personally I don't like ifs without braces if either the condition or > the instruction is spread over more than one line. > Well, I do disagree, but note that that reasoning doesn't actually apply here, both are single-line.

April 22, 2013

Re: [PATCH 1/2] wined3d: Remove leftover texture accesses in GLSL shader generation

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-04-22 14:42, schrieb Henri Verbeet:> On 21 April 2013 16:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >> - if (texture && texture->target == GL_TEXTURE_RECTANGLE_ARB) >> - sample_flags |= WINED3D_GLSL_SAMPLE_RECT; + if >> (priv->cur_ps_args->np2_fixup & (1 << sampler_idx)) + { + >> sample_flags |= WINED3D_GLSL_SAMPLE_NPOT; + } > I don't think the added braces are an improvement, but otherwise this looks ok. Personally I don't like ifs without braces if either the condition or the instruction is spread over more than one line. Afaics the code isn't quite consistent in either direction. I can resend the patch without the braces if you disagree. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRdTGfAAoJEN0/YqbEcdMwKIcP/ieIu1iHckCe1hSoG+Xx5YAm 4DBCjak4xlf1NfmVSik0RduCCG4mR1w2ZWkYXzrHuHUsQlh3ILsNe3nsHIOj/M4K R82tmWfCS0iV5xThnGiIdVs4/7lkwcs8ZJGZDWhN8bvDZ3CtJCVSCepulPt1LJ8Q +G2S18OKGIXgtQTYNPgvGK5V3QSpuSkAWkmfL45II9vD1/Qs4/SIEF/6jQrJ9cya 7DRnYhMRdZaz0zfrvjrq6rUQOWwtLPj50zDCINLS1w6prMZugyB9zdB5xmnAjzu2 eR9Dvh/7USzoFkbv2KwFwBQhxj5202+iUoDJEcKZ765GveeN5d3+GghLN8M1B8jR 9alSRqsirWvxiu/HT5W3e4Hm83TMp1XOrAgfrCQHjg9PGfQ/vWVjpf+uVh5xprzC gRLW6ko5I9QKsFDuoeg5revedX2BP2z+iUH1zRIZhLnegdnEwVaIuuhPVZ4bW1WB QqxfaMBuKJ8B86g8OEcE8BMHDF9qXCnd9ewS0qHpPwshvkBP3GJdJt1w5tVmvp/1 s/OTV4gBYIF6ZzWX89Boi0dWyUnUGFGl9n4FJbN3473SeJor0HkZHAgqXLbDgP/D AbpmEgdiRhPTRGIfO42mwSqdOZjyXOvh5E2HoUlfxoM5xCqKkzrC2HqGHowUaxUy FWJtBflkY/oslt8BQsLS =qysk -----END PGP SIGNATURE-----

April 22, 2013