April 2013 - Wine-Devel - list.winehq.org

Re: [AppDB] version: Only display comments section in case version has maintainers

by Rosanne DiMesio

On Sun, 28 Apr 2013 18:47:25 -0400 Christopher Cope <ccope3(a)utk.edu> wrote: > I understand the premise, but I disagree. A lot of apps that I use don't have maintainers. However, the comments are typically helpful. I believe this should be approached differently. > So volunteer to be a maintainer. -- Rosanne DiMesio <dimesio(a)earthlink.net>

April 28, 2013

Re: [AppDB] version: Only display comments section in case version has maintainers

by Christopher Cope

I understand the premise, but I disagree. A lot of apps that I use don't have maintainers. However, the comments are typically helpful. I believe this should be approached differently. "André Hentschel" <nerv(a)dawncrow.de> wrote: >Am 28.04.2013 18:57, schrieb Rosanne DiMesio: >> Forced moderation of comments could work for apps with maintainers >who are doing their job, but most of the spam I recently deleted was in >unmaintained apps. My suggestion would be to block comments altogether >on unmaintained apps, not just because of spam, but because of other >inappropriate things that are not being monitored, such as posting >links to illegal downloads. As for the maintainers who clearly aren't >doing their jobs (about 20-25% of the spam I found was in entries with >maintainers), admins already have the capability of removing them. > > >--- > include/version.php | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >diff --git a/include/version.php b/include/version.php >index 8f02b24..bf1d7ab 100644 >--- a/include/version.php >+++ b/include/version.php >@@ -1180,9 +1180,12 @@ class version { > > echo note::displayNotesForEntry($this->iVersionId); > >- // Comments Section >- if($this->iVersionId) >- Comment::view_app_comments($this->iVersionId); >+ if(sizeof($aMaintainers)>0) >+ { >+ // Display comments section in case version has >maintainers >+ if($this->iVersionId) >+ Comment::view_app_comments($this->iVersionId); >+ } > } > > public static function lookup_name($versionId) >-- >1.7.10.4

April 28, 2013

Re: [AppDB]: Recent UCE/Spam waves in AppDBs comments

by Rosanne DiMesio

On Sun, 28 Apr 2013 02:02:18 +0200 Joerg Schiermeier <news(a)Schiermeier-IT.de> wrote: > I just saw again a lot of spam posted into the AppDB. > Thanks to Rosanne who deleted this senseless and useless mails > rapidly. > But isn't there a real solution for this problem? > OK, to kill this guys maybe the best way, but than I will get seriously > problems. :-) So please, isn't there a way to set up a filter - for > user names or, with more effect, for IPs of this bad guys ISPs? > I know, this will cause 'collateral damage' but if it helps to prevent > the next wave of spam - I think it's OK. > > This maybe a task for AppDBs administrator, isn't it? > Joerg, As frustrating as it is for admins not to have the ability to ban AppDB spammers, my experience with spam on the forum tells me that banning alone, at best, barely slows down the determined ones. Ban one username, they will create another. Ban one IP, they will use a different one. The only thing that got spam under control on the forum was the forced moderation of posts by new users. We still get spammers trying, of course, but once they see that their post will never appear, most move on to easier targets. Unfortunately, the AppDB is one of them. Forced moderation of comments could work for apps with maintainers who are doing their job, but most of the spam I recently deleted was in unmaintained apps. My suggestion would be to block comments altogether on unmaintained apps, not just because of spam, but because of other inappropriate things that are not being monitored, such as posting links to illegal downloads. As for the maintainers who clearly aren't doing their jobs (about 20-25% of the spam I found was in entries with maintainers), admins already have the capability of removing them. Of course, making either of those changes would depend on someone with the requisite skills caring enough to take the time to modify the AppDB code. I fulfill the latter but unfor -- Rosanne DiMesio <dimesio(a)earthlink.net>

April 28, 2013

Re: winex11.drv: Fixed XInput2 errors with mislabeled mice axis.

by Dmitry Timoshkov

"Cope, Christopher Edward" <ccope3(a)utk.edu> wrote: > @@ -1638,16 +1636,14 @@ static void X11DRV_RawMotion( XGenericEventCookie *xev ) > if (XIMaskIsSet( event->valuators.mask, class->number )) > { > double val = *values++; > - if (class->label == x11drv_atom( Rel_X ) || > - (!class->label && class->number == 0 && class->mode == XIModeRelative)) > + if (class->label == x11drv_atom( Rel_X ) || class->mode == XIModeRelative) > { > input.u.mi.dx = dx = val; > if (class->min < class->max) > input.u.mi.dx = val * (virtual_screen_rect.right - virtual_screen_rect.left) > / (class->max - class->min); > } > - else if (class->label == x11drv_atom( Rel_Y ) || > - (!class->label && class->number == 1 && class->mode == XIModeRelative)) > + else if (class->label == x11drv_atom( Rel_Y ) || class->mode == XIModeRelative) > { > input.u.mi.dy = dy = val; > if (class->min < class->max) How is this supposed to distinguish motion in X and Y direction? -- Dmitry.

April 28, 2013

[AppDB]: Recent UCE/Spam waves in AppDBs comments

by Joerg Schiermeier

Hi list, hello Rosanne, I just saw again a lot of spam posted into the AppDB. Thanks to Rosanne who deleted this senseless and useless mails rapidly. But isn't there a real solution for this problem? OK, to kill this guys maybe the best way, but than I will get seriously problems. :-) So please, isn't there a way to set up a filter - for user names or, with more effect, for IPs of this bad guys ISPs? I know, this will cause 'collateral damage' but if it helps to prevent the next wave of spam - I think it's OK. This maybe a task for AppDBs administrator, isn't it? -- Kindly regards Joerg Schiermeier Bielefeld/Germany

April 28, 2013

Re: qedit/tests: Improve test messages

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25328 Your paranoid android. === W2KPROSP4 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588 === W2K8SE (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588

April 27, 2013

Re: qedit/tests: Improve test messages

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25328 Your paranoid android. === W2KPROSP4 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588 === W2K8SE (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588

April 27, 2013

[AppDB]: Recent UCE/Spam waves in AppDBs comments

by Joerg Schiermeier

Hi list, hello Rosanne, I just saw again a lot of spam posted into the AppDB. Thanks to Rosanne who deleted this senseless and useless mails rapidly. But isn't there a real solution for this problem? OK, to kill this guys maybe the best way, but than I will get seriously problems. :-) So please, isn't there a way to set up a filter - for user names or, with more effect, for IPs of this bad guys ISPs? I know, this will cause 'collateral damage' but if it helps to prevent the next wave of spam - I think it's OK. This maybe a task for AppDBs administrator, isn't it? -- Kindly regards Joerg Schiermeier Bielefeld/Germany

April 27, 2013

Re: netapi32: Add stub for NetGetAnyDCName

by Ruslan Kabatsayev

Hi, On Sat, Apr 27, 2013 at 6:21 PM, Christian Costa <titan.costa(a)gmail.com>wrote: > > Hi, > > + FIXME("(%s, %s, %p) stub!\n", debugstr_w(servername), > + debugstr_w(domainname), bufptr); > + return ERROR_NO_SUCH_DOMAIN; > +} > > Please use 4 spaces indentation as the rest of the file. > > Christian > > > If you look at NetGetDCName(), you'll see that I used 2 spaces as is used there. Should NetGetDCName() be fixed too then? > > Le 27/04/2013 14:05, Ruslan Kabatsayev a écrit : > > Hello, > > This patch adds a stub for netapi32!NetGetAnyDCName(), which is needed for > e.g. KDE's dolphin to launch first time. I've done it similarly to already > present NetGetDCName() stub, but with another error code return, which is > among valid ones listed in MSDN. > > Regards, > Ruslan > > > >

April 27, 2013

Re: netapi32: Add stub for NetGetAnyDCName

by Christian Costa

Hi, + FIXME("(%s, %s, %p) stub!\n", debugstr_w(servername), + debugstr_w(domainname), bufptr); + return ERROR_NO_SUCH_DOMAIN; +} Please use 4 spaces indentation as the rest of the file. Christian Le 27/04/2013 14:05, Ruslan Kabatsayev a écrit : > Hello, > > This patch adds a stub for netapi32!NetGetAnyDCName(), which is needed > for e.g. KDE's dolphin to launch first time. I've done it similarly to > already present NetGetDCName() stub, but with another error code > return, which is among valid ones listed in MSDN. > > Regards, > Ruslan > >

April 27, 2013