April 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] wined3d: Introduce a wined3d_vertex_pipe_ops structure.

by Rico Schüller

On 25.04.2013 09:59, Henri Verbeet wrote: > -static HRESULT shader_arb_alloc(struct wined3d_device *device, const struct fragment_pipeline *fragment_pipe) > +static HRESULT shader_arb_alloc(struct wined3d_device *device, const struct wined3d_vertex_pipe_ops *vertex_pipe, > + const struct fragment_pipeline *fragment_pipe) > { > struct shader_arb_priv *priv = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*priv)); > struct fragment_caps fragment_caps; > - void *fragment_priv; > + void *vertex_priv, *fragment_priv; > + > + if (!(vertex_priv = vertex_pipe->vp_alloc(&arb_program_shader_backend, priv))) > + { > + ERR("Failed to initialize vertex pipe.\n"); > + HeapFree(GetProcessHeap(), 0, priv); > + return E_FAIL; > + } > > if (!(fragment_priv = fragment_pipe->alloc_private(&arb_program_shader_backend, priv))) > { > ERR("Failed to initialize fragment pipe.\n"); > + fragment_pipe->free_private(device); Shouldn't that vertex_pipe->vp_free(device)? > HeapFree(GetProcessHeap(), 0, priv); > return E_FAIL; > }

April 25, 2013

Re: Clang static analyzer results / wine-1.5.28-66-g6899279

by Austin English

On Wed, Apr 24, 2013 at 10:39 AM, Austin English <austinenglish(a)gmail.com> wrote: > On Wed, Apr 24, 2013 at 3:28 AM, Ken Thomases <ken(a)codeweavers.com> wrote: >> On Apr 24, 2013, at 5:10 AM, Jacek Caban wrote: >> >>> On 04/24/13 11:35, Frédéric Delanoy wrote: >>> >>>> Although, one can sort/filter by file, or if it's really that >>>> annoying, a quick script removing <tr> elements containing "/tests" >>>> should be easy enough. >>> >>> Well... that's far from perfect, but could work. >> >> Would it work to do two runs and have two different result sets? >> >> I think that "make install" rather than "make" avoids building the tests without requiring --disable-tests. (You can set DESTDIR to some temp directory in your home or /tmp.) After that, a plain "make" will make just the tests. >> >> -Ken > > If people find results with the tests enabled useful, I can certainly > run it twice, yes. > > -- > -Austin [austin(a)localhost ~]$ sha1sum scan-build-2013-04-24-with-tests.tar.bz2 9dfd540f2ac2bd656ab326bc9c5fff7240f966b6 scan-build-2013-04-24-with-tests.tar.bz2 [austin(a)localhost ~]$ du -h scan-build-2013-04-24-with-tests.tar.bz2 54M scan-build-2013-04-24-with-tests.tar.bz2 http://www.mediafire.com/?jtiqxdq8fql2b9l These results are also against wine-1.5.28-66-g6899279. -- -Austin

April 25, 2013

Re: [0/4] Improve wineconsole and kernel32

by Frédéric Delanoy

On Wed, Apr 24, 2013 at 9:15 AM, Hugh McMaster < hugh.mcmaster(a)masterindexing.com> wrote: > This series of four patches will improve various three functions in > kernel32: > > * GetConsoleFontSize > * GetCurrentConsoleFont > * GetLargestConsoleWindowSize > > This is achieved by moving logical calculations to wineconsole itself. > kernel32.dll only receives the final values. > > The first and second patches should be applied to source before compiling > Wine. If this is not done, the compiler will exit with errors. (The first > is a patch for server/protocol.def and requires tools/make_requests to be > run). > After each patch, Wine should be able to compile correctly (e.g. for regression testing) If not, you should split your patches differently IMO. Frédéric

April 25, 2013

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)

by Sam Edwards

This series has been waiting in the queue for a few days now. Does this need further discussion, or can it be committed? Thanks, Sam On 04/20/2013 08:08 AM, Sam Edwards wrote: >

April 24, 2013

Re: [PATCH] kernel32: Actually return a PERFORMANCE_INFORMATION structure in K32GetPerformanceInfo (try 2)

by Christian Costa

Le 24/04/2013 23:35, Christian Costa a écrit : > Le 24/04/2013 20:10, James Eder a écrit : >> >> >> >> On Wed, Apr 24, 2013 at 6:58 AM, Christian Costa >> <titan.costa(a)gmail.com <mailto:titan.costa(a)gmail.com>> wrote: >> >> Hi James, >> >> That would be better to change the trace at the beginning by >> FIXME( "(%p, %d): semi-stub\n", info, size ); or FIXME( "(%p, >> %d): partial stub\n", info, size ); >> instead of adding another fixme (which is not really correct >> since it's not a stub). >> >> Christian >> >> >> Does this look better? http://source.winehq.org/patches/data/95866 >> > - TRACE( "(%p, %d)\n", info, size ); > + FIXME("semi-stub (%p, %d)\n", info, size ); > Wine sources used to put semi-stub mention after parameters. There is > also inconsistency with spaces near parenthesis. 0 before the format > string and 1 after size parameter. > Something like FIXME("(%p, %d): semi-stub\n", info, size); > Otherwise seems fine. :) > - if (status) + if(size < sizeof(PERFORMANCE_INFORMATION)) { + + mem_status.dwLength = sizeof(mem_status); + if (!GlobalMemoryStatusEx( &mem_status )) Oups. Forgot this one. Cosmetic again :|. Still space inconsitency. First if w/o and second w/ space. Christian

April 24, 2013

Re: [PATCH] kernel32: Actually return a PERFORMANCE_INFORMATION structure in K32GetPerformanceInfo (try 2)

by Christian Costa

Le 24/04/2013 20:10, James Eder a écrit : > > > > On Wed, Apr 24, 2013 at 6:58 AM, Christian Costa > <titan.costa(a)gmail.com <mailto:titan.costa(a)gmail.com>> wrote: > > Hi James, > > That would be better to change the trace at the beginning by > FIXME( "(%p, %d): semi-stub\n", info, size ); or FIXME( "(%p, %d): > partial stub\n", info, size ); > instead of adding another fixme (which is not really correct since > it's not a stub). > > Christian > > > Does this look better? http://source.winehq.org/patches/data/95866 > - TRACE( "(%p, %d)\n", info, size ); + FIXME("semi-stub (%p, %d)\n", info, size ); Wine sources used to put semi-stub mention after parameters. There is also inconsistency with spaces near parenthesis. 0 before the format string and 1 after size parameter. Something like FIXME("(%p, %d): semi-stub\n", info, size); Otherwise seems fine. :)

April 24, 2013

Re: msvcr110.dll: add a stub for crtGetShowWindowMode (try 2)

by Alexandre Julliard

Austin English <austinenglish(a)gmail.com> writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=33195 > > try 2: return SW_SHOWWINDOW instead of SW_HIDE It's not much harder to return the correct value. -- Alexandre Julliard julliard(a)winehq.org

April 24, 2013

Re: [PATCH] kernel32: Actually return a PERFORMANCE_INFORMATION structure in K32GetPerformanceInfo (try 2)

by James Eder

On Wed, Apr 24, 2013 at 6:58 AM, Christian Costa <titan.costa(a)gmail.com>wrote: > Hi James, > > That would be better to change the trace at the beginning by FIXME( "(%p, > %d): semi-stub\n", info, size ); or FIXME( "(%p, %d): partial stub\n", > info, size ); > instead of adding another fixme (which is not really correct since it's > not a stub). > > Christian > > Does this look better? http://source.winehq.org/patches/data/95866 -- Jim

April 24, 2013

Re: Clang static analyzer results / wine-1.5.28-66-g6899279

by Austin English

On Wed, Apr 24, 2013 at 3:28 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > On Apr 24, 2013, at 5:10 AM, Jacek Caban wrote: > >> On 04/24/13 11:35, Frédéric Delanoy wrote: >> >>> Although, one can sort/filter by file, or if it's really that >>> annoying, a quick script removing <tr> elements containing "/tests" >>> should be easy enough. >> >> Well... that's far from perfect, but could work. > > Would it work to do two runs and have two different result sets? > > I think that "make install" rather than "make" avoids building the tests without requiring --disable-tests. (You can set DESTDIR to some temp directory in your home or /tmp.) After that, a plain "make" will make just the tests. > > -Ken If people find results with the tests enabled useful, I can certainly run it twice, yes. -- -Austin

April 24, 2013

Re: [PATCH 1/2] shell32: Add a semi-stub for SHGetStockIconInfo

by Nikolay Sivov

On Wed, Apr 24, 2013 at 6:38 PM, Detlef Riekenberg <wine.dev(a)web.de> wrote: > -- > By by ... Detlef > --- > dlls/shell32/iconcache.c | 42 > ++++++++++++++++++++++++++++++++++++++++++ > dlls/shell32/shell32.spec | 1 + > 2 files changed, 43 insertions(+), 0 deletions(-) > > diff --git a/dlls/shell32/iconcache.c b/dlls/shell32/iconcache.c > index 637dbca..df6675d 100644 > --- a/dlls/shell32/iconcache.c > +++ b/dlls/shell32/iconcache.c > @@ -46,6 +46,8 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(shell); > > +static const WCHAR shell32dll[] = > {'\\','s','h','e','l','l','3','2','.','d','l','l',0}; > + > Please put this in function that needs it.

April 24, 2013