May 2013 - Wine-Devel - list.winehq.org

re: [PATCH (try 2)] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode

by Maarten Lankhorst

NAK. + HeapFree(GetProcessHeap(), 0, device->primary_pwfx); + device->primary_pwfx = DSOUND_CopyFormat(passed_fmt); Copy to a tmp buffer first and return E_OUTOFMEMORY instead of reassigning primary_pwfx to NULL? ~Maarten

May 29, 2013

Re: Christian Costa : d3dx9_36: Implement skin mesh loading.

by Christian Costa

Hi, You're right. This can be simplified. Will send a patch. Thanks. Christian 2013/5/29 gurketsky <gurketsky(a)googlemail.com> > Hi, > > just saw that a bit late. Is there a reason for the rewrite of hr? > > Could any call return anything other than D3D_OK and succeed (maybe > S_FALSE)? It may be possible to drop "if (FAILED(hr)) goto end;" (for both > cases) and "hr = D3D_OK"... Also the function (parse_mesh) seems to > overwrite the result anyway to D3D_OK on success, so I see no reason to > change the hr to D3D_OK in parse_skin_mesh_info. > > Cheers > Rico > > > On 28.05.2013 22:16, Alexandre Julliard wrote: > >> + if (SUCCEEDED(hr)) >> + hr = mesh_data->skin_info->lpVtbl->** >> SetBoneOffsetMatrix(mesh_data-**>skin_info, index, >> + (const D3DMATRIX*)(data + nb_influences * >> (sizeof(DWORD) + sizeof(FLOAT)))); >> + if (FAILED(hr)) >> + goto end; >> + } >> + >> + hr = D3D_OK; >> > >

May 29, 2013

Re: Increment, Decrement, and Assignment Operators

by Alexandre Julliard

Stephen Leibowitz <librestephen(a)gmail.com> writes: > Hello: > > This is my first patch. The changes are minor. If it works out, I may > attempt something more substantial. Doing cosmetic changes like this across the code base is not a good idea. -- Alexandre Julliard julliard(a)winehq.org

May 29, 2013

Re: [PATCH] gdi32: Ask for a newer FreeType version

by Alexandre Julliard

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -3686,7 +3686,8 @@ static BOOL init_freetype(void) > WINE_MESSAGE( > "Wine cannot find the FreeType font library. To enable Wine to\n" > "use TrueType fonts please install a version of FreeType greater than\n" > - "or equal to 2.0.5.\n" > + "or equal to 2.1.4.\n" > + "(Fonts with vertical metrics need at least version 2.4 of FreeType)\n" > "http://www.freetype.org\n"); > return FALSE; > } > @@ -3749,6 +3750,7 @@ sym_not_found: > "Wine cannot find certain functions that it needs inside the FreeType\n" > "font library. To enable Wine to use TrueType fonts please upgrade\n" > "FreeType to at least version 2.1.4.\n" > + "(Fonts with vertical metrics need at least version 2.4 of FreeType)\n" That's not useful. There are probably very few users who still have such an old Freetype, and even if they do, telling them about vertical metrics will only confuse them. -- Alexandre Julliard julliard(a)winehq.org

May 29, 2013

Re: Christian Costa : d3dx9_36: Implement skin mesh loading.

by gurketsky

Hi, just saw that a bit late. Is there a reason for the rewrite of hr? Could any call return anything other than D3D_OK and succeed (maybe S_FALSE)? It may be possible to drop "if (FAILED(hr)) goto end;" (for both cases) and "hr = D3D_OK"... Also the function (parse_mesh) seems to overwrite the result anyway to D3D_OK on success, so I see no reason to change the hr to D3D_OK in parse_skin_mesh_info. Cheers Rico On 28.05.2013 22:16, Alexandre Julliard wrote: > + if (SUCCEEDED(hr)) > + hr = mesh_data->skin_info->lpVtbl->SetBoneOffsetMatrix(mesh_data->skin_info, index, > + (const D3DMATRIX*)(data + nb_influences * (sizeof(DWORD) + sizeof(FLOAT)))); > + if (FAILED(hr)) > + goto end; > + } > + > + hr = D3D_OK;

May 29, 2013

re: Increment, Decrement, and Assignment Operators

by Dan Kegel

Watch http://source.winehq.org/patches/ for your patch's status (see legend at bottom). It might be rejected since it doesn't actually fix any behavioral problem in Wine. IIRC trivial cleanups in code are frowned upon, especially if they cross many modules. Better to pick some small real problem and fix it. How about http://bugs.winehq.org/show_bug.cgi?id=32922 ?

May 29, 2013

Re: gdi32/tests: Do not try to test OS/2 win metrics on non-windows fonts

by Dmitry Timoshkov

Aric Stewart <aric(a)codeweavers.com> wrote: > + ascent = GET_BE_WORD(tt_os2.usWinAscent); > + descent = GET_BE_WORD(tt_os2.usWinDescent); > + cell_height = ascent + descent; > + ok(ntm->ntmCellHeight == cell_height, "%s: ntmCellHeight %u != %u, os2.usWinAscent/os2.usWinDescent %u/%u\n", > + font_name, ntm->ntmCellHeight, cell_height, ascent, descent); > + > + SetLastError(0xdeadbeef); The SetLastError() call should be left at its previous position. -- Dmitry.

May 29, 2013

GSoC 2013 has begun!

by Austin English

Howdy, Wine has accepted 4 student proposals for Google Summer of Code 2013: George Stephanos, "Registry - implement merging between HKCR and HKCU\Software\Classes" mentored by Detlef Riekenberg Jactry Zeng, "Implement ITextDocument in Richedit" mentored by Huw Davies John Chadwick, "MSXML - Implement XPATH without libxml2" mentored by Nikolay Sivov Zhan Jianyu, "Improve and add missing feature of vbscript component" mentored by Jacek Caban Welcome to Wine and good luck on your projects! As a reminder, here are the next few big dates: May 27th - June 17: community bonding period. Students/mentors should use this time to iron out details of the project, learn the code base and get to know others on the project. June 17: coding officially begins July 29th - Aug 2nd: mid-term reviews are submitted. Mentors/students, please feel free to contact me or André Hentschel if you have any GSoC administrative/procedural questions. Otherwise use wine-devel or ask your mentor for help with learning the Wine development process/codebase/etc. -- -Austin

May 28, 2013

Re: [PATCH] winhttp: initialize schemes (Coverity) (resubmit)

by Hans Leidekker

On Tue, 2013-05-28 at 22:46 +0200, Marcus Meissner wrote: > 1020943 Uninitialized scalar variable > > schemes is |= in the called function, but not > initialized before. > > Was submitted 2 weeks ago already, I think it is good. It's good but query_auth_schemes is called from more places, so it would be better to fix it in that helper, without touching the parameter on error.

May 28, 2013

Re: [PATCH] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25741 Your paranoid android. === WXPPROSP2 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === WXPX64 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === W2K3R2SESP2 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === WXPX64 (64 bit dsound) === dsound.c:1433: Test failed: validbits: 0

May 28, 2013