June 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 3/5] wined3d: Pass a wined3d_resource_desc structure to wined3d_texture_create_cube().

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-06-05 11:06, schrieb Henri Verbeet: > + desc.width = edge_length; + desc.height = edge_length; + > desc.depth = 1; Wouldn't it make sense to either set desc.height = 1 or desc.depth = edge_length? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRrwNtAAoJEN0/YqbEcdMwLkoP/jN3ooH3ur4ZLMgSc96VT+WR b+EcwCmK1yigPrY04UPiHmSVSS/g9bgR/BsVoQB9d6Fa2UfFeDEGGgOYdVOE6/9P guRWs6RAMTv4AfuDCjmRC3h2fO0nigg3sLkmvqG5qZF8hmGbItijB5zREWHys3Bk kedPMQaWXWuq9wwHa7ZM1B3wcMiZsxqfcyitFa1FsB7LvbLHIYuMzNQrViObGvT5 75J1Ux/WmFu9ZKTvWjIyFzhWg9oqeHPpB1lXgj4w3ONkOa0Rw27EUsxHRTlGiYm+ 4qGyvclsE1Ep2A2NK/kCUU1SuxeSP/bW38P9Lc8J/xNb8Si8zNu2VApTYjOIOk9q 3wHKgU0MuRRnw5ophMM9xNhIT/lt+0FilNZYosvEul+A0tAhncthCege0ZBRIeSf ZKlRGrInBMSy59BJwxVvPxaF702M0xHdkpKEMnML1NYCRg9+gbm862y/KRczvBxL kRWs6AIBr0247voTHvhRBJTtEanCeKP+qGLoatNVimPFaEDnSj9xxHIA+4XaThPW 2A+WjSPc7ni0Z8IKGQB9hOku0ZKvX2BJIAXiFm1KQW23psqUHF5CTR3w48yG7Dmh pm8SETIud6SwakKTW5ikp5ObjLYdM1Z8M8hNIkU64O8k7+aSX3hAqKW2shC6d/xm REcwzCU6NhmbDWgC5epH =tH28 -----END PGP SIGNATURE-----

June 5, 2013

Re: ole32: Add a basic OLE client/server test suite. Take 2.

by Dmitry Timoshkov

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Alexandre Julliard <julliard(a)winehq.org> wrote: > > > It seems to be awfully complicated. In particular I don't think you need > > a shared mapping plus a pipe plus a mutex just to log tracing > > output. Redefining standard macros is also not a good idea. > > Launching the server in responce to say CoCreateInstance is out of our > control, happens behind the scene, and the server runs in its own console, > so it's impossible make a simple redirection by passing in/out handles to > CreateProcess. So using a pipe and a passing its write end via shared memory > seems like an obvious solution. Without a mutex client and server output is > messed up under Windows. Redefining trace allows to write to the pipe in > the server and synchronize server output on the client side. Did my explanation help with understanding the reasons behind the test implementation details? > If you have a suggestion how to simplify all of this please let me know. It's pretty hard to make any progress without a reponse. -- Dmitry.

June 5, 2013

Re: [PATCH] d3dx9_36: Implement ID3DXSkinInfoImpl_UpdateSkinnedMesh.

by Rico Schüller

On 05.06.2013 08:48, Christian Costa wrote: > bone = &This->bones[bone_num]; > + /* Decrement refcounts of vertices previously influenced */ > + for (i = 0; i < bone->num_influences; i++) > + if (bone->vertices[i] < This->num_vertices) /* Ignore out of range value */ > + This->vertices_refcounts[bone->vertices[i]]--; > bone->num_influences = num_influences; > HeapFree(GetProcessHeap(), 0, bone->vertices); > HeapFree(GetProcessHeap(), 0, bone->weights); > bone->vertices = new_vertices; > bone->weights = new_weights; > + /* Increment refcounts of vertices newly influenced */ > + for (i = 0; i < bone->num_influences; i++) > + { > + if (bone->vertices[i] < This->num_vertices) /* Ignore out of range value */ > + This->vertices_refcounts[bone->vertices[i]]--; > + } Please have a look at the code style (brackets {} at the for loops?). It should be a bit more consistent. Also I think an increment (as said in the comment) is something like "This->vertices_refcounts[bone->vertices[i]]++;". Maybe you could add a test to verify if the comment or the code is correct? Cheers Rico

June 5, 2013

Re: api-ms-win-core-localregistry-l1-1-0: add stub dll

by Austin English

On Tue, Jun 4, 2013 at 5:05 PM, Charles Davis <cdavis5x(a)gmail.com> wrote: > > On Jun 4, 2013, at 12:15 PM, Austin English wrote: >> diff --git a/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec b/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec >> new file mode 100644 >> index 0000000..cc15d4e >> --- /dev/null >> +++ b/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec >> @@ -0,0 +1,40 @@ >> +@ stub RegCloseKey > Why don't you just forward them to their implementations in advapi32? Is there something oddly different about these functions that I don't know about? > > Chip Michael pointed that out as well, fixed in try 2 sent earlier today. -- -Austin

June 5, 2013

Re: api-ms-win-core-localregistry-l1-1-0: add stub dll

by Charles Davis

On Jun 4, 2013, at 12:15 PM, Austin English wrote: > diff --git a/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec b/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec > new file mode 100644 > index 0000000..cc15d4e > --- /dev/null > +++ b/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec > @@ -0,0 +1,40 @@ > +@ stub RegCloseKey Why don't you just forward them to their implementations in advapi32? Is there something oddly different about these functions that I don't know about? Chip

June 5, 2013

Re: [PATCH 1/2] server: Don't create new handle when DUP_HANDLE_CLOSE_SOURCE is used if possible (try2)

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -890,6 +890,7 @@ struct rawinput_device > obj_handle_t handle; /* duplicated handle in dst process */ > int self; /* is the source the current process? */ > int closed; /* whether the source handle has been closed */ > + int reused; /* whether the source handle has been reused */ I don't think you need an extra flag, there's nothing the client has to do differently in that case (the warning is mostly cosmetic anyway). -- Alexandre Julliard julliard(a)winehq.org

June 4, 2013

Re: bugzilla: Change no bugs found message

by Christian Costa

2013/6/4 Bruno Jesus <00cpxxx(a)gmail.com> > On Tue, Jun 4, 2013 at 12:38 PM, Christian Costa <titan.costa(a)gmail.com> > wrote: > > > > Hi, > > > > Minor but shouldn't it be "bug" instead "bugs"? > > At least in portuguese zero is plural. Ta! Mas nao nehum? > In english according to [1] : > > Treatments differ in expressions of zero quantity: English often uses > the plural in such expressions as no injuries and zero points, > Yeah! Right! > although no (and zero in some contexts) may also take a singular. In > French, the singular form is used after zéro. > > Ah ben la je sais ! ;) > > Christian > > Regards, > Bruno > > [1] - http://en.wikipedia.org/wiki/Plural#Usage_of_the_plural > > > > > > > > -- > universe* god::bigbang (void); //and then it all began... >

June 4, 2013

Re: bugzilla: Change no bugs found message

by Bruno Jesus

On Tue, Jun 4, 2013 at 12:38 PM, Christian Costa <titan.costa(a)gmail.com> wrote: > > Hi, > > Minor but shouldn't it be "bug" instead "bugs"? At least in portuguese zero is plural. In english according to [1] : Treatments differ in expressions of zero quantity: English often uses the plural in such expressions as no injuries and zero points, although no (and zero in some contexts) may also take a singular. In French, the singular form is used after zéro. > Christian Regards, Bruno [1] - http://en.wikipedia.org/wiki/Plural#Usage_of_the_plural > > -- universe* god::bigbang (void); //and then it all began...

June 4, 2013

Re: bugzilla: Change no bugs found message

by Christian Costa

Hi, Minor but shouldn't it be "bug" instead "bugs"? Christian

June 4, 2013

Re: [PATCH 1/8] winemac: Don't unminimize a window on first activation during start-up.

by Ken Thomases

On Jun 4, 2013, at 5:15 AM, Dmitry Timoshkov wrote: > Ken Thomases <ken(a)codeweavers.com> wrote: > >> --- >> dlls/winemac.drv/cocoa_app.h | 2 ++ >> dlls/winemac.drv/cocoa_app.m | 3 ++- >> 2 files changed, 4 insertions(+), 1 deletions(-) > > I wonder, do you actually run 'make test' in dlls/user32/tests with > your changes? My guess is that you don't. In fact, I spent many hours today doing just that. And some of these patches were to fix specific test failures. -Ken

June 4, 2013