June 2013 - Wine-Devel - list.winehq.org

Re: widl: Do not generate C structure for empty interfaces.

by Michael Stefaniuc

On 06/26/2013 10:06 PM, Thomas Faber wrote: > On 2013-06-26 21:47, André Hentschel wrote: >> The whitespace changes are bad, please don't do that. > > Ok, I can take them out no problem. > Why's it bad though? I thought the rule was "fix it while you're > working on it anyway". Sure, fix the lines you modify and the block you're in. Avoid having whitespace only diff chunks. bye michael

June 26, 2013

Re: widl: Do not generate C structure for empty interfaces.

by André Hentschel

On 26.06.2013 22:06, Thomas Faber wrote: > On 2013-06-26 21:47, André Hentschel wrote: >> The whitespace changes are bad, please don't do that. > > Ok, I can take them out no problem. > Why's it bad though? I thought the rule was "fix it while you're > working on it anyway". > Mostly because you mess up "git blame" output. See also http://wiki.winehq.org/SubmittingPatches

June 26, 2013

Re: widl: Do not generate C structure for empty interfaces.

by Thomas Faber

On 2013-06-26 21:47, André Hentschel wrote: > The whitespace changes are bad, please don't do that. Ok, I can take them out no problem. Why's it bad though? I thought the rule was "fix it while you're working on it anyway".

June 26, 2013

Re: widl: Do not generate C structure for empty interfaces.

by André Hentschel

Hi, The whitespace changes are bad, please don't do that.

June 26, 2013

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

by Christian Costa

Le 26/06/2013 09:10, Henri Verbeet a écrit : > On 25 June 2013 18:26, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: >> While I agree with Henri's statement to some extend - patch reviewing >> is a terribly exhausting task - I think the statement was a bit harsh >> to say to someone who donates his personal time to the project. >> > Well, I could try to sugarcoat it a bit, and add in all the little > nuances, about how e.g. a patch that's otherwise great isn't going to > be rejected because of some minor formatting issue, or how someone > that's been with the project for a while would be expected to already > know these things, while a new contributor would perhaps be given some > more patience. But that's really the basic concept. And it's not a > particularly new concept either, or all that specific to Wine. > There are good reasons to have someone else do the review or developped tests. Anyway choking on a typo is a bit exaggerated. The main issue would have been enough. Someone else did it so that's fine.

June 26, 2013

Re: server: Update German translation of manpage.

by Julian Rüger

Am Dienstag, den 25.06.2013, 19:41 +0200 schrieb Alexandre Julliard: > Julian Rüger <jr98(a)gmx.net> writes: > > > I'm unsure about the second line. Is that supposed to be the "last > > modified" date of the manpage, the wineserver or what? The English > > version says October 2005. > > In general, it would be the last time there were changes to the program > that required a manpage update. Thanks for the answer. So I'll change it to October 2005. Best, Julian

June 26, 2013

Re: po: Update Ukrainian translation

by Nikolay Sivov

On 6/26/2013 13:10, Микола wrote: Hi, please resubmit this patch with your full name transliterated in English.

June 26, 2013

Re: riched20: ITextDocument implementation

by Qian Hong

Hi, Welcome again :) On Wed, Jun 26, 2013 at 3:11 PM, Tiger Soldier <tigersoldi(a)gmail.com> wrote: > This is my first time to develop WINE. Any comments/suggestions? > > [1] http://bugs.winehq.org/show_bug.cgi?id=17042 Improving Rich Edit is great appreciated! Interesting, one of GSoC2013 students Jactry Zeng is planning on implementing ITextDocument as well [1] [2]. Maybe it is a good idea to work with Jactry together, if that doesn't violate GSoC rules - actually I don't know, hopefully Austin English or other GSoC mentor/manager could comment on this. If you are interesting in Rich Edit, there are a lot of bugs to be fixed :) [3] Some of them may be good for beginner, for example this one with a test case [4], or maybe this one [5] which has a basic diagnosis. dlls/riched20/tests/ contains some example to show how Rich Edit api works, play with Wine's buitin wordpad maybe a good idea as well. Before you implementing something or debugging something, there is no harm to learn as more example as you can from website like msdn or codeproject. Be careful on copyright issues: never disassembling or tracing Windows binary. For those things without public document, the only way I know is guess and test :) (Since I know you personally, I believe you are good at this kind of fun :p ) Once you decided to debug on an app, WINEDEBUG=+tid,+richedit may be useful for you, also you can have a look at other debug channel [6]. I hope this helps, feel free to ask in wine-devel if you have further questions. My experience on Wine is limited, so my suggestions maybe not work, maybe not the best, hopefully other developers with more experience could help you when you get in trouble :) [1] http://www.google-melange.com/gsoc/project/google/gsoc2013/jactry/12001 [2] http://wine.1045685.n5.nabble.com/Application-for-GSoC-2013-improve-Richedi… [3] http://bugs.winehq.org/buglist.cgi?product=Wine&component=richedit&resoluti… [4] http://bugs.winehq.org/show_bug.cgi?id=33191#c2 [5] http://bugs.winehq.org/show_bug.cgi?id=29769#c11 [6] http://wiki.winehq.org/DebugChannels -- Regards, Qian Hong - http://www.winehq.org

June 26, 2013

riched20: ITextDocument implementation

by Tiger Soldier

As bug 17042 [1] reported, the IUnknown object returned by CreateTextServices() does not support ITextDocument. I believe that's the root cause of some apps crash. richole.c has a very limited implementation of ITextDocument for IRichEditOle, which is totally unreusable. I'm trying to implement ITextDocument for both ITextServices and IRichEditOle. ME_Editor type provides most of the editor functionalities, and both of ITextServices and IRichEditOle use it. So I'm going to use it to implement ITextDocument. The proposal is: struct tagReTxtDoc { IUnknown *parentObj; ME_Editor *editor; } ReTxtDoc; ReTxtDoc *CreateReTxtDoc(IUnknown *parentObj, ME_Editor *editor); void DestroyReTxtDoc(ReTxtDoc); ReTxtDoc_addRef/QueryInterface/Release -> delegate to parentObj Other ITextDocument methods: use ME_Editor to implement. This is my first time to develop WINE. Any comments/suggestions? [1] http://bugs.winehq.org/show_bug.cgi?id=17042

June 26, 2013

Re: wined3d: print the architecture when showing driver problems

by Henri Verbeet

On 26 June 2013 03:53, Austin English <austinenglish(a)gmail.com> wrote: > My understanding was that using the _WIN64 macro was preferred. I can > certainly do that instead. How's this? > I could probably live with that, though perhaps make it a helper function, and I'm not entirely sure this will print something meaningful on e.g. ARM. This is really a winex11 patch though, so it's more something for Alexandre.

June 26, 2013