June 2013 - Wine-Devel - list.winehq.org

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

by Henri Verbeet

On 25 June 2013 18:26, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > While I agree with Henri's statement to some extend - patch reviewing > is a terribly exhausting task - I think the statement was a bit harsh > to say to someone who donates his personal time to the project. > Well, I could try to sugarcoat it a bit, and add in all the little nuances, about how e.g. a patch that's otherwise great isn't going to be rejected because of some minor formatting issue, or how someone that's been with the project for a while would be expected to already know these things, while a new contributor would perhaps be given some more patience. But that's really the basic concept. And it's not a particularly new concept either, or all that specific to Wine.

June 26, 2013

Re: wined3d: print the architecture when showing driver problems

by Austin English

On Mon, Jun 24, 2013 at 12:20 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > On 23 June 2013 07:10, Austin English <austinenglish(a)gmail.com> wrote: >> Please consider applying before the release of 1.6. It has no >> functional changes, but would really help when diagnosing user >> problems. >> > This is not really a wined3d patch. That said, while I agree that > printing the architecture would be useful here, you can probably avoid > the #ifdef by using something along the lines of sizeof(void *) == 8 ? > "64-bit" : "32-bit", although ideally we'd probably get the actual > architecture from somewhere like ntdll. My understanding was that using the _WIN64 macro was preferred. I can certainly do that instead. How's this? -- -Austin

June 26, 2013

Re: widl: Do not generate empty Vtbl structure for empty interfaces.

by Thomas Faber

On 2013-06-25 21:11, Alexandre Julliard wrote: > Thomas Faber <thfabba(a)gmx.de> writes: > >> An alternative solution would be not to generate a vtable structure at all, >> and instead add a dummy member to the class directly. That would be in line >> with what the defined(__cplusplus) && !defined(CINTERFACE) case results in, >> but require a slightly larger change to widl. > > I'm not sure it makes sense to even define a C structure at all, since > there's nothing you can do with it. Hmm. The only thing I could think of would be someone making a pointer to such an object, to later cast to a derived class. Since there's a typedef generated earlier in the file, the struct should already be known (as an incomplete type), so that scenario would work even without the struct definition. So... I agree. I'll send an updated patch that won't generate the structure at all.

June 25, 2013

Re: widl: Do not generate empty Vtbl structure for empty interfaces.

by Alexandre Julliard

Thomas Faber <thfabba(a)gmx.de> writes: > An alternative solution would be not to generate a vtable structure at all, > and instead add a dummy member to the class directly. That would be in line > with what the defined(__cplusplus) && !defined(CINTERFACE) case results in, > but require a slightly larger change to widl. I'm not sure it makes sense to even define a C structure at all, since there's nothing you can do with it. -- Alexandre Julliard julliard(a)winehq.org

June 25, 2013

Bug 24018 which appears to be a showstopper for running Cygwin on Wine

by Alan W. Irwin

Andrey Turkin has stated at http://bugs.winehq.org/show_bug.cgi?id=24018 that this is really a Cygwin bug. I frankly don't understand the technical details but his current test (an infinite loop with Cygwin fork calls) may need some beefing up to convince the Cygwin developers they have introduced a regression. The reason why I mention a Cygwin regression is the winetricks script mentions bug 24018 and works around it by downloading an old version of the Cygwin installer. I haven't tried that myself yet, but if that workaround still works, then this is evidence that the issue is a Cygwin regression which is an important consideration when reporting this issue to the Cygwin developers. Andrey Turkin was asked at http://bugs.winehq.org/show_bug.cgi?id=24018 to report the issue to Cygwin, but my search of the Cygwin mailing list archive didn't find any post from him and only found one extremely casual (an aside to a completely different thread) mention (http://sourceware.org/ml/cygwin/2013-06/msg00471.html) from a different wine developer of bug 24018 with no response to that mention. I currently have no experience with Cygwin and my only real interest in Cygwin on Wine is it theoretically provides an alternative build platform to my present successful work with the combination of MinGW, MSYS, and Wine as a Windows build platform. But I haven't even been able to get started with Cygwin on Wine because of this showstopping bug. Therefore, I am mentioning the situation here in the hope that some wine developer on this list with some knowledge of Cygwin will take the responsibility of making a proper bug report to the Cygwin mailing list (which according to http://cygwin.com/problems.html is the correct place to report Cygwin bugs) including the evidence that the issue is a Cygwin regression (assuming investigation of older Cygwin versions with Turkin's test supports that conclusion). Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

June 25, 2013

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

by Christian Costa

Thanks Stefan! No problem with me. I don't take it personnally. :) I'm not statisfied with the submission/review with some criterias which are sometimes rules, sometimes tastes, with patches (not necessarily mine) that remain in the new state without any comments while another with a missing dot would have more attention. I live with that, I'm used to enough, but I'm wondering how newcomers that are not paid could contribute. Fortunately there are cool guys. Not necessary overskilled but who try to do their humble best. This is what gives some fun for me. :) BTW, "fonction" is the french word for "function". Probably a wrong locale. ;) 2013/6/25 Stefan Dösinger <stefandoesinger(a)gmail.com> > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Am 2013-06-25 18:08, schrieb Christian Costa: > > Are we really discussing about a typo in the subject line? > > "Implement" just comes naturally from the fixme when I create an > > empty patch. It turned out after coding that "Fix" is more > > appropriate. I forgot to updated it. This will be fix. > I think the typo Henri refers to is "fonction", which should be > "function". > > While I agree with Henri's statement to some extend - patch reviewing > is a terribly exhausting task - I think the statement was a bit harsh > to say to someone who donates his personal time to the project. > > I'll try to do a better job looking at patches myself to help weed out > the most obvious mistakes - right now he's doing all the d3d reviewing > work. > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.20 (GNU/Linux) > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJRycSuAAoJEN0/YqbEcdMwOHwP/R98Fs+ZunKuRIPnenvXFEat > hP3C1JCrGhxANiYIggkdcvfjPxCSbgz+LM4nfZC4qARSHnYzvxhcQxALN2je/lwb > 1iWx/xZ0Czy2yR3rHqJCEW0jXkV53O/Lkqbs/Nf2ue0I7vJWuhaA3Tl+P1esE3m8 > rdeRQY89SyXuvfZGtO1tPnGwsYMU/NuSoIffKkLjjWpBhScvJmcSUYOL9RuFk6Tj > +r7zGp9niSfVO9N8JY7BTAlXTcAK9p0gKaWzAuCXYFr8gcbOaGB3kDSsbIhtHe57 > 8oWEDA9pn3tO7l1fXGZdbyfamIPyjg5boh1yHireDze9eefGHrd/WQqEu1xqVd95 > BVlFUt2nMPZoR9A0MUT3/0kbq/sfJ05ytCTZ5AlbNAO8msA0fTX58gw6UA9QXrET > 1dpE+tjGHzN49qjcBtUmFUII6zc+m8B91Xlhplupda2v/TZv+tzQvrsMIuwRvLvP > hTzxaZo/kFr2Pnlx8Sgk0ImNUfi9AIXpLo/h7geLgMi0kMTzkHY4qW2LGf74GNhU > NtBgN+4Y1iFLeK6dbKIenD75MN/JGOp6eOHK53E2++RykLxJLyqCTPqplShE/Zz7 > hnt80SQTR0jYttA9KsHGE3GnqKPc8RndMnjGnMCyNhLj9Jm27te2VMGLbw4mK0yD > C+nOcltXE3Hu3AYpzEXd > =C1yJ > -----END PGP SIGNATURE----- >

June 25, 2013

Re: server: Update German translation of manpage.

by Alexandre Julliard

Julian Rüger <jr98(a)gmx.net> writes: > I'm unsure about the second line. Is that supposed to be the "last > modified" date of the manpage, the wineserver or what? The English > version says October 2005. In general, it would be the last time there were changes to the program that required a manpage update. -- Alexandre Julliard julliard(a)winehq.org

June 25, 2013

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-06-25 18:08, schrieb Christian Costa: > Are we really discussing about a typo in the subject line? > "Implement" just comes naturally from the fixme when I create an > empty patch. It turned out after coding that "Fix" is more > appropriate. I forgot to updated it. This will be fix. I think the typo Henri refers to is "fonction", which should be "function". While I agree with Henri's statement to some extend - patch reviewing is a terribly exhausting task - I think the statement was a bit harsh to say to someone who donates his personal time to the project. I'll try to do a better job looking at patches myself to help weed out the most obvious mistakes - right now he's doing all the d3d reviewing work. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRycSuAAoJEN0/YqbEcdMwOHwP/R98Fs+ZunKuRIPnenvXFEat hP3C1JCrGhxANiYIggkdcvfjPxCSbgz+LM4nfZC4qARSHnYzvxhcQxALN2je/lwb 1iWx/xZ0Czy2yR3rHqJCEW0jXkV53O/Lkqbs/Nf2ue0I7vJWuhaA3Tl+P1esE3m8 rdeRQY89SyXuvfZGtO1tPnGwsYMU/NuSoIffKkLjjWpBhScvJmcSUYOL9RuFk6Tj +r7zGp9niSfVO9N8JY7BTAlXTcAK9p0gKaWzAuCXYFr8gcbOaGB3kDSsbIhtHe57 8oWEDA9pn3tO7l1fXGZdbyfamIPyjg5boh1yHireDze9eefGHrd/WQqEu1xqVd95 BVlFUt2nMPZoR9A0MUT3/0kbq/sfJ05ytCTZ5AlbNAO8msA0fTX58gw6UA9QXrET 1dpE+tjGHzN49qjcBtUmFUII6zc+m8B91Xlhplupda2v/TZv+tzQvrsMIuwRvLvP hTzxaZo/kFr2Pnlx8Sgk0ImNUfi9AIXpLo/h7geLgMi0kMTzkHY4qW2LGf74GNhU NtBgN+4Y1iFLeK6dbKIenD75MN/JGOp6eOHK53E2++RykLxJLyqCTPqplShE/Zz7 hnt80SQTR0jYttA9KsHGE3GnqKPc8RndMnjGnMCyNhLj9Jm27te2VMGLbw4mK0yD C+nOcltXE3Hu3AYpzEXd =C1yJ -----END PGP SIGNATURE-----

June 25, 2013

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

by Christian Costa

2013/6/25 Henri Verbeet <hverbeet(a)gmail.com> > On 25 June 2013 11:05, Christian Costa <titan.costa(a)gmail.com> wrote: > > 2013/6/25 Henri Verbeet <hverbeet(a)gmail.com> > >> At least try to pretend you put > >> some effort into making sure the patch is as good as it can be before > >> submitting it. > > > > > > I could have send the patch to wine-devel first but would I get something > > longer that "several issues" as feedback? > No, you're missing the point. Why do you expect me to even look at a > patch if you clearly didn't even check for obvious typos yourself? > Bottom line, if you want me to spend time reviewing a patch and giving > feedback, make sure it's worth that time. > Are we really discussing about a typo in the subject line? "Implement" just comes naturally from the fixme when I create an empty patch. It turned out after coding that "Fix" is more appropriate. I forgot to updated it. This will be fix. According to the feedback I got, altough the patch is not correct, it doesn't seem it does not worth looking at. And now there is materials to make it better.

June 25, 2013

Re: Czech language for Wine

by Alexandre Julliard

Pavel VlÄek <paaajavlca(a)gmail.com> writes: > @@ -1415,19 +1400,19 @@ > > #: crypt32.rc:74 > msgid "Title" > -msgstr "Titul" > +msgstr "" > > #: crypt32.rc:75 > msgid "Given Name" > -msgstr "Jm©no" > +msgstr "" > > #: crypt32.rc:76 > msgid "Initials" > -msgstr "Inici¡ly" > +msgstr "" > > #: crypt32.rc:77 > msgid "Surname" > -msgstr "Pjmen" > +msgstr "" Why are you removing all these existing translations? -- Alexandre Julliard julliard(a)winehq.org

June 25, 2013