July 2013 - Wine-Devel - list.winehq.org

Re: Possibility of adding a new patch status

by Vincent Povirk

> Wouldn't these two points simply earn a 'Rejected' status and/or some kind of comment on the wine-devel list? Applying a "Rejected" status would require looking at the patch. But it could be nice to have a status that means "I will not even read a patch from this person to do this specific thing without substantial changes that are not being made." >> * He thinks there's a good chance you'll revise the patch without his intervention, and is waiting to see if that happens. > > This is good, but only if an error is obvious or more research yields a better means of doing the proposed action. But again, a 'Revision needed' status would help clarify the situation in this case. But maybe revision isn't needed. Determining that would require reviewing the patch. >> * The patch is difficult to review, and he's putting it off. > > There are some statuses (e.g. 'needs splitting) to counteract this. But patches are/can be difficult to review. Again, a status such as 'Not yet reviewed' would help. > >> * He's travelling and does not have access to a machine that can successfully run the Wine test suite, and he thinks the patch might break the >>tests. > A 'Not yet reviewed' status or similar would probably be best. But "Not yet reviewed" is what "New" is supposed to be. The problem is there are situations where patches are never reviewed and no one is told why.

July 31, 2013

Re: [PATCH] d3dx9_36: Filter out D3DCompile warning messages that are not present with D3DCompileShader.

by Christian Costa

Hi Stefan, 2013/7/31 Stefan Dösinger <stefandoesinger(a)gmail.com> > Hi, > > Am 31.07.2013 um 09:10 schrieb Christian Costa <titan.costa(a)gmail.com>: > > + if (!(strstr(line_out, "warning X3206:") && > strstr(line_out, "implicit truncation of vector type"))) > + line_out += line_size; > > msvc localizes compiler errors and warnings. Are you sure d3dcompiler.dll > doesn't do that? > AFAIK no. My localization is french and I get english messages. Any idea how I can check that? > > Wrt the parsing code, wouldn't it be nicer to use strtok_r to split the > buffer into separate lines? > The parsing code handles missing null byte as well as both unix/dos text formats but maybe I can just simplify it by using strtok_r and assume dos format with null byte. > I am not sure that parsing the errors and warnings like that is a good > thing, but I don't know d3dx9 and d3dcompiler well enough to give a final > judgement on that. > > I'm afraid this is the only solution. AFAIK there is no option that disable this warning. Cheers Christian

July 31, 2013

Re: ws2_32/tests: Test the precedence of parameters while creating a socket in WSASocket()

by Thomas Faber

On 2013-07-31 02:48, Bruno Jesus wrote: > + ok(!getsockopt(sock, SOL_SOCKET, SO_TYPE, (char *) &socktype, &size), "getsockopt failed with %d\n", > + WSAGetLastError()); It's not guaranteed that getsockopt is called before WSAGetLastError here. (in fact the latter will be evaluated first with most practically used calling conventions) So this needs a variable. Best, Thomas

July 31, 2013

Re: po: Add English (Canada) resource [Take 2]

by Ken Sharp

Please disregard this patch. I missed a couple of words and with those corrected en_CA.po becomes identical to en.po (except that "serialisation" is fuzzy) and Wine defaults to that anyway for Canadian English. Will re-submit if there are any changes (just noticed -able/-eable). Will keep an eye on the English translations. On 30/07/13 22:37, Ken Sharp wrote: > - Re-based to latest git > - Removed all the fuzzies thanks to http://www.etymonline.com/index.php > > Turns out all the -ise/-ize words used in Wine are of Latin origin anyway. > > > -------- Original Message -------- > Subject: po: Add English (Canada) resource > Date: Mon, 22 Jul 2013 19:28:51 +0100 > From: Ken Sharp <kennybobs(a)o2.co.uk> > To: wine-patches(a)winehq.org > > Canadian English follows some British/French rules but not others. > > I have left some of the -ise/-ize words fuzzy because: > > "the etymological convention that verbs derived from Greek roots are > spelled with -ize and those from Latin with -ise is preserved in that > practice." > http://en.wikipedia.org/wiki/Canadian_english#Spelling_and_dictionaries > > I tried looking for the origins of the words and I couldn't get any. The > non-fuzzies are correct. > > With British, US and Canadian I believe all the English variations (used > in Wine) are covered, except Philippines (follows US rules). > > >

July 31, 2013

Re: [PATCH] d3dx9_36: Filter out D3DCompile warning messages that are not present with D3DCompileShader.

by Stefan Dösinger

Hi, Am 31.07.2013 um 09:10 schrieb Christian Costa <titan.costa(a)gmail.com>: > + if (!(strstr(line_out, "warning X3206:") && strstr(line_out, "implicit truncation of vector type"))) > + line_out += line_size; msvc localizes compiler errors and warnings. Are you sure d3dcompiler.dll doesn't do that? Wrt the parsing code, wouldn't it be nicer to use strtok_r to split the buffer into separate lines? I am not sure that parsing the errors and warnings like that is a good thing, but I don't know d3dx9 and d3dcompiler well enough to give a final judgement on that.

July 31, 2013

RE: Possibility of adding a new patch status

by Hugh McMaster

Hi Vincent, You raise some very good points. On Wednesday, 31 July 2013 2:53 AM, Vincent Povirk wrote: >I think I've seen patches stay in the "New" state in the following cases: > * He's convinced you do not have the ability to write a patch he would accept. (There's a common pattern where people will take feedback and >attempt to revise their patch to account for it, but not really understand the feedback or how to apply it. The only way to get an acceptable >patch in this situation would be to do the work for the submitter.) > * He's convinced you're taking a completely wrong approach. (And generally someone has explained this in reply to a previous revision of that >patch.) Wouldn't these two points simply earn a 'Rejected' status and/or some kind of comment on the wine-devel list? > * He thinks there's a good chance you'll revise the patch without his intervention, and is waiting to see if that happens. This is good, but only if an error is obvious or more research yields a better means of doing the proposed action. But again, a 'Revision needed' status would help clarify the situation in this case. > * The patch is difficult to review, and he's putting it off. There are some statuses (e.g. 'needs splitting) to counteract this. But patches are/can be difficult to review. Again, a status such as 'Not yet reviewed' would help. > * He's travelling and does not have access to a machine that can successfully run the Wine test suite, and he thinks the patch might break the >tests. A 'Not yet reviewed' status or similar would probably be best.

July 31, 2013

RE: Possibility of adding a new patch status

by Hugh McMaster

On Tuesday, 30 July 2013 9:04 PM, Ken Sharp wrote: >There's also "Pending". Hi Ken, Yes, I know about the 'Pending' status. The patches page describes this status in two ways: 1. The patch is not obviously correct at first glance. Making a more convincing argument, preferably in the form of a test case, may help. 2. Waiting for feedback from the main developer in that area. Both are quite different. Perhaps these should be split with different labels as well - particularly as the first requires revisions, while the second implies that the patch may be accepted as is. Anyway, to come back to the point, leaving a patch as 'New' is problematic. 'Pending' is more informative, yet perhaps not descriptive enough to cover patches that stay as 'New' over a 24-hour patch cycle.

July 31, 2013

d3dx9: Replace M_PI by its D3DX equivalent

by Nozomi Kodama

Hello What is the problem with patch http://source.winehq.org/patches/data/97500 M_PI is never used in D3DX. Nozomi

July 31, 2013

d3dx9: Replace M_PI by its D3DX equivalent

by Nozomi Kodama

What is the problem with patch: http://source.winehq.org/patches/data/97500 M_PI is never used in D3DX (moreover it is deprecated in C99) Nozomi

July 31, 2013

Re: msxml3: Unescape '&' back to '&' in attribute value

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26523 Your paranoid android. === W2KPROSP4 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WXPPROSP2 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WXPX64 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W2K3R2SESP2 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WVISTAX64 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W2K8SE (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W7PROX64 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === TEST64_W7SP1 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WXPX64 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WVISTAX64 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W7PROX64 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === TEST64_W7SP1 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & )

July 31, 2013