July 2013 - Wine-Devel - list.winehq.org

Re: [PATCH] Ignore MotionNotify when XI2 is handling mouse motion

by Alexandre Julliard

Josef Schimke <sgtcapslock(a)lavabit.com> writes: > Hello, > > When XInput2 takes over the mouse, regular MotionNotify events continue to be > handled alongside it. This causes the cursor to erratically skip around when > the slower method (X11 input) tries to reposition the cursor while XInput2 is > already handling future events. We want to process MotionNotify to resync the cursor position, XInput events are not enough. -- Alexandre Julliard julliard(a)winehq.org

July 29, 2013

Re: [1/1] kernel32: Implemented basic NUMA functions to replace the stubs

by Matteo Bruni

2013/7/29 Chris Moeller <kode54(a)gmail.com>: > without looking very deeply into the CRT source code. You're talking about MS source code, right? That makes you tainted for contributing to Wine at the very least for C runtime-related code :( If you haven't looked into any other source code, this patch might be okay (barring other issues, I haven't read the patch at all). At least http://wiki.winehq.org/DeveloperFaq#head-fed5011434f62ae1a88baebfb8193a37ea… seems to suggest so.

July 29, 2013

Re: How to get involved in Windows Store API implement?

by Stefan Dösinger

Hi, Am 29.07.2013 um 15:33 schrieb 中川祥 <matyapiro31(a)gmail.com>: > I do not know much about the store apps development. > What is Windows.winmd? Do I need disassemble it and create wine version ?If I need C++,I wouldn't do. First of all, don't disassemble Windows DLLs. Wine will not accept your code if you do that. Use black-box tests to find out how APIs work. > Is there any planning to support them? What is your goal? Run applications from the Windows store? I don't know about the legal status of the Windows store. Is it possible from a legal and technical point of view to take an application from the Windows store and run it on a computer that doesn't have the Windows store installed? I'd expect copy protection schemes to prevent you from that, backed up by legal terms that prevent you from taking an app out of the Windows store and run it in a different environment.

July 29, 2013

Re: riched20: ITextDocument stubs for ITextServices (retry)

by Caibin Chen

Hi Jacek, Thanks for your review. I really appreciate it :) 2013/7/29 Jacek Caban <jacek(a)codeweavers.com>: > You sent the patch during code freeze, when it couldn't be committed, so > it probably didn't get enough attention. Now is the right time to resubmit. Does that means I should resend the patch to the mail list? > It doesn't really make sense to test COM aggregation on every interface > implemented by an object. The valuable part of the test is that > ITextDocument should be supported, but there is probably a better place > to put this test. Sure I can remove the aggregation tests. > +struct tagReTxtDoc { > + IUnknown *outerObj; > + ME_TextEditor *editor; > + ITextDocument iTextDocumentIface; > +}; > > Do you really need a separated structure for that? Wouldn't adding ITextDocument implementation to ITextServicesImpl be enough? This structure will be used in both ITexstServicesImpl and IRichEditOleImpl(richole.c). For now IRichEditOleImpl has its own implementation(stub) of ITextDocument and ITextSelection. A stub of ITextSelection is needed before removing IRichEditOleImpl's own implementation and use the separate one. There are already several patches that are ready for review once this patch get submitted. Thanks Caibin

July 29, 2013

Re: NtCreateFile fails

by Marcus Meissner

On Mon, Jul 29, 2013 at 04:02:03PM +0200, Mislav Blazevic wrote: > First of all, pardon my ignorance, I am new to wine and winapi. > > I am trying to implement apphelp.dll and I ran into issues with > NtCreateFile: It always returns 0xc0000103, STATUS_NOT_A_DIRECTORY, and I > am not sure what that means. Here is code: > > /* This function is not in API, but written for internal use */ > HANDLE WINAPI SdbOpenFile( LPCWSTR path, PATH_TYPE type ) > { > /* SNIP */ > if (type == DOS_PATH) > if (!RtlDosPathNameToNtPathName_U(path, &str, NULL, NULL)) > return NULL; > InitializeObjectAttributes(&attr, &str, OBJ_CASE_INSENSITIVE, NULL, NULL); > status = NtCreateFile(&file, GENERIC_READ | SYNCHRONIZE | > FILE_READ_ATTRIBUTES, > &attr, &io, NULL, FILE_ATTRIBUTE_NORMAL, FILE_SHARE_READ, > FILE_OPEN, FILE_DIRECTORY_FILE, NULL, 0); > /* SNIP */ > return file; > } > > Function is called like this: > > WCHAR szFileName[1024] = {0}; > ExpandEnvironmentStringsW(L"%SystemRoot%\\sample.sdb", szFileName, 1024); > // for testing purposes > SdbOpenFile(szFileName, DOS_PATH); > > Compiled with winegcc. > I am sure that C:\windows\sample.sdb exists. What am I doing wrong? Try printing out the expanded string. It will probably just print "C" L"string" does not work to specify WCHAR*, as the Linux L"" strings are differently sized than the Windows L"" strings. Ciao, Marcus

July 29, 2013

Re: NtCreateFile fails

by Nikolay Sivov

On 7/29/2013 18:02, Mislav Blazevic wrote: > First of all, pardon my ignorance, I am new to wine and winapi. > > I am trying to implement apphelp.dll and I ran into issues with > NtCreateFile: It always returns 0xc0000103, STATUS_NOT_A_DIRECTORY, > and I am not sure what that means. Here is code: > > /* This function is not in API, but written for internal use */ > HANDLE WINAPI SdbOpenFile( LPCWSTR path, PATH_TYPE type ) > { > /* SNIP */ > if (type == DOS_PATH) > if (!RtlDosPathNameToNtPathName_U(path, &str, NULL, NULL)) > return NULL; > InitializeObjectAttributes(&attr, &str, OBJ_CASE_INSENSITIVE, NULL, NULL); > status = NtCreateFile(&file, GENERIC_READ | SYNCHRONIZE | > FILE_READ_ATTRIBUTES, > &attr, &io, NULL, FILE_ATTRIBUTE_NORMAL, FILE_SHARE_READ, > FILE_OPEN, FILE_DIRECTORY_FILE, NULL, 0); > /* SNIP */ > return file; > } > > Function is called like this: > > WCHAR szFileName[1024] = {0}; > ExpandEnvironmentStringsW(L"%SystemRoot%\\sample.sdb", szFileName, > 1024); // for testing purposes > SdbOpenFile(szFileName, DOS_PATH); > > Compiled with winegcc. > I am sure that C:\windows\sample.sdb exists. What am I doing wrong? Probably you don't nee****d FILE_DIRECTORY_FILE if it's not a directory?

July 29, 2013

NtCreateFile fails

by Mislav Blazevic

First of all, pardon my ignorance, I am new to wine and winapi. I am trying to implement apphelp.dll and I ran into issues with NtCreateFile: It always returns 0xc0000103, STATUS_NOT_A_DIRECTORY, and I am not sure what that means. Here is code: /* This function is not in API, but written for internal use */ HANDLE WINAPI SdbOpenFile( LPCWSTR path, PATH_TYPE type ) { /* SNIP */ if (type == DOS_PATH) if (!RtlDosPathNameToNtPathName_U(path, &str, NULL, NULL)) return NULL; InitializeObjectAttributes(&attr, &str, OBJ_CASE_INSENSITIVE, NULL, NULL); status = NtCreateFile(&file, GENERIC_READ | SYNCHRONIZE | FILE_READ_ATTRIBUTES, &attr, &io, NULL, FILE_ATTRIBUTE_NORMAL, FILE_SHARE_READ, FILE_OPEN, FILE_DIRECTORY_FILE, NULL, 0); /* SNIP */ return file; } Function is called like this: WCHAR szFileName[1024] = {0}; ExpandEnvironmentStringsW(L"%SystemRoot%\\sample.sdb", szFileName, 1024); // for testing purposes SdbOpenFile(szFileName, DOS_PATH); Compiled with winegcc. I am sure that C:\windows\sample.sdb exists. What am I doing wrong?

July 29, 2013

How to get involved in Windows Store API implement?

by 中川祥

I do not know much about the store apps development. What is Windows.winmd? Do I need disassemble it and create wine version ?If I need C++,I wouldn't do. Is there any planning to support them?

July 29, 2013

Re: riched20: ITextDocument stubs for ITextServices (retry)

by Jacek Caban

Hi Caibin, On 07/29/13 01:52, Caibin Chen wrote: > Hi, > > It has been 2 weeks since I sent this patch[1]. It's still new status > in the patches list. I'm working on following patches based on it. I > appreciate your reviews and will work on the patch to get it > submitted. You sent the patch during code freeze, when it couldn't be committed, so it probably didn't get enough attention. Now is the right time to resubmit. + /* COM aggregation on ITextDocument */ + hr = IUnknown_QueryInterface(unk_obj.inner_unk, &IID_ITextDocument, (void**)&textdoc); + ok(hr == S_OK, "QueryInterface for IID_ITextDocument failed: %08x\n", hr); + refcount = ITextDocument_AddRef(textdoc); + ok(refcount == unk_obj.ref, "CreateTextServices just pretends to support COM aggregation\n"); + refcount = ITextDocument_Release(textdoc); + ok(refcount == unk_obj.ref, "CreateTextServices just pretends to support COM aggregation\n"); + refcount = ITextDocument_Release(textdoc); It doesn't really make sense to test COM aggregation on every interface implemented by an object. The valuable part of the test is that ITextDocument should be supported, but there is probably a better place to put this test. + +struct tagReTxtDoc { + IUnknown *outerObj; + ME_TextEditor *editor; + ITextDocument iTextDocumentIface; +}; Do you really need a separated structure for that? Wouldn't adding ITextDocument implementation to ITextServicesImpl be enough? Thanks, Jacek

July 29, 2013

Re: riched20: ITextDocument stubs for ITextServices (retry)

by Caibin Chen

Hi, It has been 2 weeks since I sent this patch[1]. It's still new status in the patches list. I'm working on following patches based on it. I appreciate your reviews and will work on the patch to get it submitted. Regards, Caibin [1] http://source.winehq.org/patches/data/97331 2013/7/18 Caibin Chen <tigersoldi(a)gmail.com>: > Anybody reviewing this patch? It's almost all stubs, so although it's > long, it shouldn't be hard to review > > 2013/7/15 Caibin Chen <tigersoldi(a)gmail.com>: >> (Retry with real name in mail. The name in the patch is already my real name) >> >> This patch implements a standalone stub of ITextDocument. The stub is >> currently used in txtsrv.c and will replace the stub in richole.c >> >> --- >> dlls/riched20/Makefile.in | 1 + >> dlls/riched20/tests/txtsrv.c | 16 ++- >> dlls/riched20/txtdoc.c | 282 +++++++++++++++++++++++++++++++++++++++++++ >> dlls/riched20/txtdoc.h | 46 +++++++ >> dlls/riched20/txtsrv.c | 6 + >> 5 files changed, 350 insertions(+), 1 deletion(-) >> create mode 100644 dlls/riched20/txtdoc.c >> create mode 100644 dlls/riched20/txtdoc.h

July 28, 2013